From nobody Sun Feb 8 05:23:15 2026 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32D7713C3F2; Tue, 16 Dec 2025 01:40:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765849255; cv=none; b=lpjAJvaLg4eNlgzL01wXXysMUfewOFWJ554HEKifhmVNIWksXFfQhnErTE1EoTOGz2q0rdNZr0S9CCqk97X9vS5vclNzIcI+rJDy+chu9xazr8j3dc0apZhqq1iSM8bhwhdxAaH7L7Q+IEW4kFg2Jzz5gvo/WTCpDH87X/uFRaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765849255; c=relaxed/simple; bh=OxyVMbdEVLlQ40GIPx+TvFzGx+KEK/557hc/XhzYmLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=D7RkXq5NmHo6cbOH+TdI82S0tft3ypBgh6JkCLN81vRE8o/E+Qy0ZWI8RH69Qy4FopYHYaciGAb0RnvxL4nExoyfH8alsxDdwiBnOZIegSRI3nPtsi1RZbFmsXSgbRxeEKUMHh/QByLP9pLiZISeDiyCR+kUJ/rk3ymzvfdkic4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-01 (Coremail) with SMTP id qwCowABX_mmduEBpzAfHAA--.7071S2; Tue, 16 Dec 2025 09:40:47 +0800 (CST) From: Haotian Zhang To: andersson@kernel.org, konradybcio@kernel.org, dmitry.baryshkov@oss.qualcomm.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH v2] soc: qcom: cmd-db: Use devm_memremap() to fix memory leak in cmd_db_dev_probe Date: Tue, 16 Dec 2025 09:39:32 +0800 Message-ID: <20251216013933.773-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 In-Reply-To: <20251215074125.2089-1-vulab@iscas.ac.cn> References: <20251215074125.2089-1-vulab@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABX_mmduEBpzAfHAA--.7071S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw13WrWxtr4ktFyDJr47Jwb_yoW8XFW8pa 4xJa4Ykryjyr4YyF17Zr48ZayrK3yftayDJa47u3s0vwn8JFWkt34rtFyjgayxXrykJr1a vF4kJayrCF18AFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkC14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v2 6r126r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_ Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUehL0UU UUU X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiBwwSA2lArlMplgAAsx Content-Type: text/plain; charset="utf-8" If cmd_db_magic_matches() fails after memremap() succeeds, the function returns -EINVAL without unmapping the memory region, causing a potential resource leak. Switch to devm_memremap to automatically manage the map resource. Fixes: 312416d9171a ("drivers: qcom: add command DB driver") Suggested-by: Dmitry Baryshkov Signed-off-by: Haotian Zhang --- Changes in v2: - Switch to devm_memremap instead of adding memunmap to also do the cleaning when cmd_db_dev_driver is unregistered, since there is no _remove() function. - Updated subject to reflect the usage of devm_memremap(). --- drivers/soc/qcom/cmd-db.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index ae66c2623d25..84a75d8c4b70 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -349,15 +349,16 @@ static int cmd_db_dev_probe(struct platform_device *p= dev) return -EINVAL; } =20 - cmd_db_header =3D memremap(rmem->base, rmem->size, MEMREMAP_WC); - if (!cmd_db_header) { - ret =3D -ENOMEM; + cmd_db_header =3D devm_memremap(&pdev->dev, rmem->base, rmem->size, MEMRE= MAP_WC); + if (IS_ERR(cmd_db_header)) { + ret =3D PTR_ERR(cmd_db_header); cmd_db_header =3D NULL; return ret; } =20 if (!cmd_db_magic_matches(cmd_db_header)) { dev_err(&pdev->dev, "Invalid Command DB Magic\n"); + cmd_db_header =3D NULL; return -EINVAL; } =20 --=20 2.50.1.windows.1