From nobody Sun Feb 8 12:57:40 2026 Received: from mail-yx1-f49.google.com (mail-yx1-f49.google.com [74.125.224.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC6523BCFD for ; Tue, 16 Dec 2025 00:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844937; cv=none; b=CZLvHJ+tGU1OLPJBHgwKs6x9TFc0B3O6EwzZCuHnqcuH0uZ86rdKszuMiZibi9EmLsjlXgw5+NOtpMDKcw3VjfguH4cmSRBzWB9w39CeGGHbwAXNPoIumE2fyG4XrQ0L4VDWrrd1baG/T+CjaZSf8aZLa4FYP9Xb9qyx958pLX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844937; c=relaxed/simple; bh=CaXeOu0A0skQCU0A5drQ+e25Y9LhKKOLHu4OGKU+HfI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EWG5p7usZtH9YkkeHqzdhT40NSLfvX4MYZuK5waPxhFn+/LT3oLZB7DuEhuNVFi+O2Md1OiBZSj2K/66dTXaQChKfBVF8zE7DKrtOwQFWsRL5ZcxtleXtK8mgVWqvb/zI3AZxNIB6sgXUmt1OaxJXddWMl5U44X/kJElboplVq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mmLdxQ9+; arc=none smtp.client-ip=74.125.224.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mmLdxQ9+" Received: by mail-yx1-f49.google.com with SMTP id 956f58d0204a3-644795bf5feso3710480d50.2 for ; Mon, 15 Dec 2025 16:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765844934; x=1766449734; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vS+iE22pE5yQk0ecXq1w/+qZcaWovgCEPqFWh4+wKk0=; b=mmLdxQ9+HNZRg7M75lQfWdeciKLciFnqoHpjql3rdPWtnzlGNd7X4A7QXhIgRu6QZj xZivoznSgI9I6aNzeJXRaNJCnNN8rYbDPAsggNIrwF7Z2blpUAGJtFIovoakqdv1yJu0 nBi8zyMl+6eDHPEzK73Uoew/hnbtvipy8T5x2I9IsXDCwEatmWAWXTIWswyOzKEvz5kn uDJThnUtr3WN07a9BBgLYwLPDwNPw4L4T3RN9z55AZSONY/eI6TbuLEu5J/cmkUtj6Dp QMIAcJzPoWqHv9wz2PevOhE1kqjJj6dBk/QJWbLsiNBz/J0F+vanOieSQgM+T45TZxWt vFSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765844934; x=1766449734; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vS+iE22pE5yQk0ecXq1w/+qZcaWovgCEPqFWh4+wKk0=; b=nC1cnUMOJ5kPWcI+mfLKd5I7SHsdpb8qiAT2fetKDQ1sVUNv6y147XR17+HlLmujJb FIAQ6EWuDVbLtTbSYwBHpMWx2OV9o0fbOC/Jcix1ZCwcQOvLjDN/X8oiODxCPtNPL2A5 vHtK9wgAKARAOW2D0ve9oaNtA1e93r59oOqrzrLI2yvcXkXVAzQzsCi08T7334qfErDq k1ray1lMchqrOm/vT2CmEOSITdX45Bzqi78F9sqyKu3X+Jad79fw78EoHUnZzR4wDwh2 VViRvei6P1ZFnxmVbwiZo0Tnn5iEU/eoXTBuDhHJJTMw5qeh/6cIANCYs4yPtGy++Kpl zCig== X-Forwarded-Encrypted: i=1; AJvYcCUxrj3TFetxDTYkyk6Av6LBWxy8yIRqYGXkxl4vw0re7szRDOSZIP6K6DZsydWJ5/+4mdhpM5Sx4pcfSlI=@vger.kernel.org X-Gm-Message-State: AOJu0YzKXZIesbI606+jFhwE4VEVr3PD3/ALYv6zFC+iKXqL51iDxQsB J/ZPnIu/k5gdDls3I8/eSAB0zlPTV1O/8Gk2QM08iKk4c7UM4RXDC7Le X-Gm-Gg: AY/fxX63LVUcV6KPomCaS7G2h0L0JkrCbf/8jl+JkF2Gm+L0L4D+zktIZJJZc1N4yxz ECNplOQee7+c/WsttGuGZ5Gx0ynXh2YC0bP43kcnBebY2pgE3RzpMRFh4p4Hunc6xQjxUo5+uOx es+mMqns59nKFtX2ixOvVgkN7Kzn3eYUAcUreDpGQtd6CWwtl0u0bEsqECzYx4MNyoC9eRsASQV EM5rtLtqyVeQDE4u/r5G3m09F3u5F0tS/Z/4qXiqv2Up3REA984Bbkt/lzpanv+cErbUybMYqwP ujINT93hrzzlRwFi1GkkfPyLWa8JSeW1EW8lj/GauzCcetdw9FOuyBm5jSogxb48BEcsAsIfwuk u5iJU60QTWOB+W4c5yObMzRFlXTk5B4emxEXgBkhseOV4+owPwllocR1w952SWUNMDut+DvmgW7 ZiFadKPA== X-Google-Smtp-Source: AGHT+IF6G9gSXRla2Tz5bO6Ji7opQVGOgE8yQgrLkp9/eG0gts1hC1CXc9Ec1S8HnYTPHfxxJ7DoYA== X-Received: by 2002:a05:690e:1a61:b0:644:6c45:4ee9 with SMTP id 956f58d0204a3-645555fa40fmr7908718d50.39.1765844934492; Mon, 15 Dec 2025 16:28:54 -0800 (PST) Received: from localhost ([2601:346:0:79bd:6b0:1f10:bc87:9bd7]) by smtp.gmail.com with ESMTPSA id 00721157ae682-78e74a42aeasm33437797b3.52.2025.12.15.16.28.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 16:28:54 -0800 (PST) From: "Yury Norov (NVIDIA)" To: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Yury Norov (NVIDIA)" Subject: [PATCH] i40e: drop useless bitmap_weight() call in i40e_set_rxfh_fields() Date: Mon, 15 Dec 2025 19:28:52 -0500 Message-ID: <20251216002852.334561-1-yury.norov@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" bitmap_weight() is O(N) and useless here, because the following for_each_set_bit() returns immediately in case of empty flow_pctypes. Signed-off-by: Yury Norov (NVIDIA) --- .../net/ethernet/intel/i40e/i40e_ethtool.c | 24 ++++++++----------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/e= thernet/intel/i40e/i40e_ethtool.c index f2c2646ea298..54b0348fdee3 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c @@ -3720,20 +3720,16 @@ static int i40e_set_rxfh_fields(struct net_device *= netdev, return -EINVAL; } =20 - if (bitmap_weight(flow_pctypes, FLOW_PCTYPES_SIZE)) { - u8 flow_id; - - for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) { - i_setc =3D (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) | - ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32); - i_set =3D i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc); - - i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id), - (u32)i_set); - i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id), - (u32)(i_set >> 32)); - hena |=3D BIT_ULL(flow_id); - } + for_each_set_bit(flow_id, flow_pctypes, FLOW_PCTYPES_SIZE) { + i_setc =3D (u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id)) | + ((u64)i40e_read_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id)) << 32); + i_set =3D i40e_get_rss_hash_bits(&pf->hw, nfc, i_setc); + + i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(0, flow_id), + (u32)i_set); + i40e_write_rx_ctl(hw, I40E_GLQF_HASH_INSET(1, flow_id), + (u32)(i_set >> 32)); + hena |=3D BIT_ULL(flow_id); } =20 i40e_write_rx_ctl(hw, I40E_PFQF_HENA(0), (u32)hena); --=20 2.43.0