From nobody Thu Dec 18 23:23:19 2025 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 480BA34FF75 for ; Tue, 16 Dec 2025 15:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765899751; cv=none; b=kSiqlz6kfR7TuhZoSkoWJgeJM/KGBd4cFWo8R6whtITSJnb4ypCWYFCUPHjWDgxIMWBpWdXB68QtJFNRbTZB3PYLyKVAdQwWc889j637JZIcHqNUNmjVCxX/JRKVzJypvUdysdBQtQNEh0/G6B63kjY50/1TTHVUa603yBMMm8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765899751; c=relaxed/simple; bh=4muiAjHuAD7dYIfr73MQ3yyzrOuuTQnuoe/uC/hHsIY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kOxvlxI9nQObuwC94uYnChCJ1L3Ml36JKO4BL/AqwBwuAfeQXr/oXgGYF/tfHtI6qA+jSpaGIaez77x2L1fHXjz+laokUqkLHYCf5MyZHAJl8T6T81m0Qtc4p1eXBP0cIfNPlhyDaxgjL6PnFevN4rGUQuK6Mt53aj+8qRKsFXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=B/HC9NIU; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="B/HC9NIU" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-5959187c5a9so4464112e87.1 for ; Tue, 16 Dec 2025 07:42:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1765899747; x=1766504547; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ibUqxEEeYAT14DRs/j/XBVBOJBPbCX2lWNH1mmAv5Jc=; b=B/HC9NIUdh1wRKaBzYMX2S5UMr7hU5Tgc69VRyDFxvEij9t3byELs0Hq0t2FdbION/ OCwgeSfN8UPajFlQGVnyFqQmJrAKv1QQNMOqrgYRg3LGG3EIKgapnYpkJ/5o0H/3PXp+ ilBH/xRthzqeMS4ZfHHQeHN/P52NwhDgmNr84= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765899747; x=1766504547; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ibUqxEEeYAT14DRs/j/XBVBOJBPbCX2lWNH1mmAv5Jc=; b=rbHMzBJdZQ+uwAJbTiUavcs1RCFSb3R4vOiPUEwT2OTq4a0cBkF+6Y8GI5e0OqKbj7 kXIkUcAHu1cKKhLnqo+GJjODORtk84juLwR3hiC+jb5JbDXBQe7SOTLLtjE6lKN0tMoK O9JI+i4JaN55tmpwM+PSfnDi9kTAKYXlecBBzNva/9IrJMmkFzdI+xxyM5qWkHqco+oF sbMk+TRwCK7vg7BLR/r4wFViguWVNjKZKK09ukpyGIBaXKeahyh0RmNYUdEStjKyGn1H BjWmJgN5m7vFpUHIqrED97KRk8+gn0GF5kZxNDtuorix1ad5vI7fYWgxbotqyZtGX5Og hgng== X-Forwarded-Encrypted: i=1; AJvYcCVVrLDobXMAaNWjkB8v3gjVsc68dNsKwakSjjtvNJrWsQQFFLCTCZv/vvPtUCtUFRDoqc4kVtv2N8LuKj4=@vger.kernel.org X-Gm-Message-State: AOJu0YwSvqlFV1yh74ceEAn5p2o69d9sU2NcVZFDZwVnzZQj+5+AncCt gl+tob0eh+nsmo5WggpDUj5Bpfk3e7kZGAUtjp/X0I0PBi4B5lZEkmeNUdCjc7p+wQ== X-Gm-Gg: AY/fxX44IoIyRfjydJgZfSGw7Y183vcfkTEqc9A/MIy6Bn0L2CVRQ70uWSYdHH+Hbq0 G2foVxfHehQarF/b2jduMnsQmT+tDJBn8DCscLA6j7jFb/3QfDk5Ni92gGgwazWjg8aUnpBk527 54fnSZqKI4PgrRzE8j7O5nOTD6frsig8gbixq7dJfcaElVp4Rgo5oFDLrPhdsR2r+AT5oHmz6J7 nu5NDjzVt4TpLz1LkAaXZtWAlH5DcqyOlRGo/GhfOuGrHyKcNX5wk2zDjPpgJIMomOVuDzI4lf9 JgpzZm00zwBGksVzetUHo8gtti+UOCdF87ipeQWXvYA2ONtQAN++8mJKYBXcr2ZdqBpRfiMw1CD n7QuloT6R9IMl+aY2u5anKrck7zqBfe5T0z84TKGICLP13eqP5r5FlknlYNE2k87NC2DEAErQ/c g0D6V5ATuJ1H4wGASLbwMcLBgXEHrxpJuyWlUST8IUJuJS/3lB+xCtkDrs0SMA3j2AxKLcLfJn+ PE1jAtE X-Google-Smtp-Source: AGHT+IEZ1MJ3LD/5MNrLllt28+1UFyOWGkybZY0pOHALDmg5lcghAE+VW/yCL7VugkHpkWECOWBwBA== X-Received: by 2002:a05:6512:1390:b0:594:490b:4493 with SMTP id 2adb3069b0e04-598faa83effmr5186905e87.41.1765899747397; Tue, 16 Dec 2025 07:42:27 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5990da1a4b8sm1003489e87.31.2025.12.16.07.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 07:42:27 -0800 (PST) From: Ricardo Ribalda Date: Tue, 16 Dec 2025 15:42:24 +0000 Subject: [PATCH v2 1/2] media: iris: Document difference in size during allocation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-warnings-6-19-v2-1-12075e3dece7@chromium.org> References: <20251216-warnings-6-19-v2-0-12075e3dece7@chromium.org> In-Reply-To: <20251216-warnings-6-19-v2-0-12075e3dece7@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 As we get ready for kzalloc checking for invalid sizes, let's add documentation for the cases where the size is different but valid. This patch fixes this cocci warning: ./platform/qcom/iris/iris_hfi_gen2_command.c:1215:9-25: WARNING: casting va= lue returned by memory allocation function to (struct iris_inst *) is usele= ss. Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index f9129553209922fda548ca320494ae6ae797854c..c120ea3594fb5d0f40d6b9a7c67= ffc28c42109f0 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -1212,5 +1212,10 @@ void iris_hfi_gen2_command_ops_init(struct iris_core= *core) =20 struct iris_inst *iris_hfi_gen2_get_instance(void) { - return (struct iris_inst *)kzalloc(sizeof(struct iris_inst_hfi_gen2), GFP= _KERNEL); + struct iris_inst_hfi_gen2 *out; + + /* The allocation is intentionally larger than struct iris_inst. */ + out =3D kzalloc(sizeof(*out), GFP_KERNEL); + + return &out->inst; } --=20 2.52.0.239.gd5f0c6e74e-goog From nobody Thu Dec 18 23:23:19 2025 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54A0236922D for ; Tue, 16 Dec 2025 15:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765899752; cv=none; b=GzAI1vPrT846H77ImjtxLN8KvAbI5gXn1QLaMeq5Jlfj6GlwaFNrGd/SByyWkZh/CrLGiQHPao7U+irpc6Dz25R3/ivLlGV41akC1HL+Lp15dZKB97JkeaCeeQKRZQ1PIfYTk2BllvrC+3txHykpqVnp+Jnsb6BIdA7HdIahXl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765899752; c=relaxed/simple; bh=M5jI5mFgh0sO9xG8ITV3eUOJCXfWDu7rg24QOLJv8T4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HGqKMGvnVmhw0oVURb2aMPUrAv6HHJeNN/7v+vWmDT4foyA5N6IfXc6izYA/Z3tzoJ2+WTRvg+pXcDLhqa0j5Wz/jXvToYqr8gzTqnb7p/GKHJOyolbhH+xn8Mp9783IGSbhF+KmhYa3LkR+0ULNpMX2XNKR8efacZG03IHbBhA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=cD5UOMm3; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cD5UOMm3" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-595825c8eb3so5530999e87.0 for ; Tue, 16 Dec 2025 07:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1765899748; x=1766504548; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ztlm7b+VM0LLd3VqoVbu/MTVuy9mYjOFBwoz/bGs1wo=; b=cD5UOMm3TvMdCtojq07eAg7hqxe5dbzv8mAdZ+hnTEA+yZdHhTK/Y3TNtoQeCIfNg2 9pPWwlOQrynQ+VBLIwL/mwPpwyFfXW2QppwtSs5XyB9IZ029MvCOMYnojxIIs6vgH8wZ r/pB5IRYWLYk2v8G89hJGkMX/x1Hot8lMEAQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765899748; x=1766504548; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ztlm7b+VM0LLd3VqoVbu/MTVuy9mYjOFBwoz/bGs1wo=; b=FCqMvS0Qy5NcJhEQIgEgwXd9j9gGqx3SPHJe/X3eTKMtP6XO6ptKSEpFp4kpzS5olT z+u8iMbUmxRfGl12xjYFIKIceME7AugvaFdjzWXy9kT5sY9zdWeDudZynjmzwZhu/KvP /v/QuyvAQl3Sc9qEmd0wCnjr7L+FpHdEJARpjWvj/8xkKwF9WWvqPj7Q+AhH+j53ItCY QzULKH3br13d/9e5u/IrK8HJbATbZFLJMIETV/FHVDtykTBaRxIUpHZc7Sw3WUrVU9tR utLf5G/vtIYD9HKHl/CJJhrlovnq/gdvGh+hNfeB25sG+pUkFbBKFG0vAiTUi52J8lpf e4Lw== X-Forwarded-Encrypted: i=1; AJvYcCUDDkQHfBTHEoBkNdHzqZh+3JRGjx3ozi5LZrkj7efnpj+InF68sXrr5Ndgd1y2ZDW2uaiWxdeqmslVYWA=@vger.kernel.org X-Gm-Message-State: AOJu0YxU0TzZlrsdD/s46+NF72EjWHi+syFl+nDa5vinKbLI0H3LaJfn sQbucKYDznUbpercV93CWIvwivyLqjetsXAa1bHL5smX+eC2GKKRE79+W7pCe5rs0+Jar8Chxa/ kUv2loA== X-Gm-Gg: AY/fxX6NxtJra2AJpXO5rHYFGnZyvwikfDkeGcx22I1/zZq/J6tU0TnQZwVxqvEjlhn HOiA0q1Nm7Toh4cC+doxc6V+rYaroPvLCwi02IIy1BRd+4RJ+nzl5OKu30r1yxM+986l1fL/5Fc AISnB8LcUlpWfGwEznEnRVzJk9c1PBC5EflUamBYzr13QVp9ZSUcQtQe+4bAC2O4CHXZtG+bXl4 12ZyycDBFOdh+juYjwp8Agrie8ROsKzq16iHi9ye6QUfpmEUg0bt5CR9SKY4m9ygupRSommsSDH jI/0rYWKeYIcpdoET5fjB3G1hpGbFzMXhysnej4KeYN2Bng/qdIn8qxO0eiHmUyZhtaii/5g4CA Cd3g+rMFXLVc8H81zfdJ+fnJgQJKTwK4dRYyUSA+nQnRgqq0PP4GV54qiEE+DArGV25IBqdAyvy IhZG6j2UpbJSUE2zCTofSmuDefmxoix0ngXJry2qCqIw3sp0tIYA8kYpmvMn36d2615s8eZg== X-Google-Smtp-Source: AGHT+IEX1A/Iv3xmmU4qq0eqYZmFq5GrjwGFzD+8NRTYO1Zb7ju+OO+Wo6JMepkOgf9/tyK+xCBEGg== X-Received: by 2002:a05:6512:618:20b0:598:faeb:2e2c with SMTP id 2adb3069b0e04-598faeb2e31mr3906303e87.34.1765899748347; Tue, 16 Dec 2025 07:42:28 -0800 (PST) Received: from ribalda.c.googlers.com (165.173.228.35.bc.googleusercontent.com. [35.228.173.165]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5990da1a4b8sm1003489e87.31.2025.12.16.07.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 07:42:27 -0800 (PST) From: Ricardo Ribalda Date: Tue, 16 Dec 2025 15:42:25 +0000 Subject: [PATCH v2 2/2] media: iris: Fix fps calculation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-warnings-6-19-v2-2-12075e3dece7@chromium.org> References: <20251216-warnings-6-19-v2-0-12075e3dece7@chromium.org> In-Reply-To: <20251216-warnings-6-19-v2-0-12075e3dece7@chromium.org> To: Keke Li , Jacopo Mondi , Daniel Scally , Hans Verkuil , Laurent Pinchart , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Sakari Ailus , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 iris_venc_s_param() uses do_div to divide two 64 bits operators, this is wrong. Luckily for us, both of the operators fit in 32 bits, so we can use a normal division. Now that we are at it, mark the fps smaller than 1 as invalid, the code does not seem to handle them properly. The following cocci warning is fixed with this patch: ./platform/qcom/iris/iris_venc.c:378:1-7: WARNING: do_div() does a 64-by-32= division, please consider using div64_u64 instead Fixes: 4ff586ff28e3 ("media: iris: Add support for G/S_PARM for encoder vid= eo device") Reviewed-by: Dikshita Agarwal Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/iris/iris_venc.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_venc.c b/drivers/media/p= latform/qcom/iris/iris_venc.c index 5830eba93c68b27fa9db87bac63a691eaca338d2..3b941aeb55a2f498898a27a5f8c= b58cdb26fdfed 100644 --- a/drivers/media/platform/qcom/iris/iris_venc.c +++ b/drivers/media/platform/qcom/iris/iris_venc.c @@ -382,8 +382,7 @@ int iris_venc_s_param(struct iris_inst *inst, struct v4= l2_streamparm *s_parm) struct v4l2_fract *timeperframe =3D NULL; u32 default_rate =3D DEFAULT_FPS; bool is_frame_rate =3D false; - u64 us_per_frame, fps; - u32 max_rate; + u32 fps, max_rate; =20 int ret =3D 0; =20 @@ -405,23 +404,19 @@ int iris_venc_s_param(struct iris_inst *inst, struct = v4l2_streamparm *s_parm) timeperframe->denominator =3D default_rate; } =20 - us_per_frame =3D timeperframe->numerator * (u64)USEC_PER_SEC; - do_div(us_per_frame, timeperframe->denominator); - - if (!us_per_frame) + fps =3D timeperframe->numerator / timeperframe->denominator; + if (!fps) return -EINVAL; =20 - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); if (fps > max_rate) { ret =3D -ENOMEM; goto reset_rate; } =20 if (is_frame_rate) - inst->frame_rate =3D (u32)fps; + inst->frame_rate =3D fps; else - inst->operating_rate =3D (u32)fps; + inst->operating_rate =3D fps; =20 if ((s_parm->type =3D=3D V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE && vb2_is_stre= aming(src_q)) || (s_parm->type =3D=3D V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE && vb2_is_str= eaming(dst_q))) { --=20 2.52.0.239.gd5f0c6e74e-goog