From nobody Thu Dec 18 23:26:02 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E41C430F95C for ; Tue, 16 Dec 2025 18:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765910322; cv=none; b=uwR9vMMoN5uxKalPa1iOXvE5K5ipCFSPhPQ4XpLD2EhzuVZxhE6TPrPVGT8yTeuvY2ZsxFEkLoapu+ualemJ5Rm7RIyC0qXFdxr8nhvAS0/T3K+VK7ehBoOMaRMvvYD2aVN04+x+xutxVHbBwH5dimqaZgxBtGTNVveMdjR1x0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765910322; c=relaxed/simple; bh=CZzKbhnTR8QMBDbIJ5b7gXs6lPvLCTOOrTggNIFNhgk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=uGYSoV5UdqTIYgwAMpNKhntzpT6G8maJKFkqnoOk+T1ZefKb3k2RVFoVsGzj7DOUWgnOgdXcjMnBsosky1BbUo9ngQ7D5DY2rOgSoiYk7jRs6uMsM25pAjcBnvYwvOXekiTaKEnKDN2CyM1QlOJOfQwvjQ4C0pmYR4N6K07xkqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jVhnoxoh; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jVhnoxoh" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so37018215e9.0 for ; Tue, 16 Dec 2025 10:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765910317; x=1766515117; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=h4kLxtqeeF1wE5hC2bTx+o584bKPJX+SdCXSIsBe5oo=; b=jVhnoxoht+hN+bzRF2krP7xLx365ZXvPmF27h87Y9UUytjZ+24ZsRwlDNwCegkUL4I 1yKmlTD0c2MeMjzSdDPOXtfkzuGubpBt0FrDAHOhYSHQkIXY5cEQswXhwyMsugH9GkY0 rqQmIMIY7ndP7jnMzPp01LE4PRwxM3kxs32H3HdA8a8hljkoBEoH0l9efd4ohe9EgmAD B4sYj5vOUlvdEZ7CCtOkMV5T/mbt37o3ueoeke0/3fcr/MMmH5h3+PntX8Zq7LyAo8wN r1+WU5ORHfIRx3iIN64Wkjs5uNtOIoOfZFyKzpbORfbELwoWPgp5cgRTwdXB+O2nIkSD 9w4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765910317; x=1766515117; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h4kLxtqeeF1wE5hC2bTx+o584bKPJX+SdCXSIsBe5oo=; b=otZ8A1DcJbgTTaDcYUUX03kZ+vGVONQDUzCVRKXFK4WNKXr6F+VRljU4Olskdn4oe0 kV48ZYS2rK88th807Dt4uTr989T3zM9O638hxJBghFu1bJLT8t8uGUAdMCDIF+oXXP1w f7Br+gLJHqvsdgPWUDY1O3FR+8CNpiVsNbTcBu+YxB3e+1bKsloy3hsEefXMkjxXTZMr 2apKTKcfi7uHzEqACYRPAsVmp5sXL6M1buks9KpOv0DrKq2nRQem4AyRNddLQv5iXTM6 aAMVhpVKVR+PsIyDLR8OFjP44Us8caKIq3owWDdoeiuU0sgSPnT2ujgccMkaVY87oeDe Z6nQ== X-Forwarded-Encrypted: i=1; AJvYcCXEaLw4VYlyNAJTucwve9aubADab8paUaRSF8HtZJoKAUIB4XPGJckCMvCmQWBTvqVhD+a/IIzF2NJ2Pos=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0+f/wcugleb30CP7BwJjDWixV6Y6etP9mYnB4G36tGVekhauo fctjHHr9leaI8OR89W/vlRmzOveLiHPcZcX93SlA55fkoZlToEBLHRIIypBwQg== X-Gm-Gg: AY/fxX5Xo2Sy1Mc6FavgG/ttfaLVDYJL7hWibVQUmEFFMdH+bQpm9yXwN3ZyuyoESis kLnspJomIg8hZZbxEPhyc7dynctqV4yaIu9kmQf+HpeBXklso4vOzMQbKlrFVrBjCf5NeAfBr2L p7BqGm5VEBtTGaUGjwEhnDSOherb15cidWy4nZ3LvASugezc7Ic8T7frb4bOqQ96JF6nqRZYZS9 EiH44FKR73R29h6Jznsxqk4PDtHs1q9G5lvCDsfXxmRJsgMqn8ZTorj2qTkeCu7oweSsjIxb7fM JGH8zlLmVVbptesyL4qWCP3ZW+9wZdny3jGRRLcE13/FsT8hfHfX7/Hhgjuo12CRlzUyM8aEDtn OX6iLMHqzJDjR3gIY4AuXGHngRR4k6tr2YqLmsXElLWUiB81Fy63aCfcHW2PnJ8n0h+Dio8EhMi Yn0UsDrtrPpLjB78VOil8ea3zVML7hcEhOe3rs3thb X-Google-Smtp-Source: AGHT+IHp0W50xaomreGJxxmmd88jtHxu/DuyG6bK1IIkwCYXxvWjTK/YO8x/knJ4/fkQxpsnMxCssg== X-Received: by 2002:a05:600c:530c:b0:477:7c7d:d9b2 with SMTP id 5b1f17b1804b1-47a8f91289emr195667175e9.32.1765910317025; Tue, 16 Dec 2025 10:38:37 -0800 (PST) Received: from [192.168.0.253] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-47bd932a3e5sm14498885e9.0.2025.12.16.10.38.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 10:38:36 -0800 (PST) From: Gabor Juhos Date: Tue, 16 Dec 2025 19:38:29 +0100 Subject: [PATCH] regulator: qcom_smd: change MP5496 supply names Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-qcom_smd-mp5496-supply-fix-v1-1-f9b5e70536de@gmail.com> X-B4-Tracking: v=1; b=H4sIACSnQWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDI1NDI0ND3cLk/Nz44twU3dwCUxNLM93i0oKCnErdtMwKXUsDC7OUxBTj5KR kUyWgAQVFqUBhsOHRsbW1ADMpPUNsAAAA X-Change-ID: 20251211-qcom_smd-mp5496-supply-fix-9086dad3cbc5 To: Liam Girdwood , Mark Brown , Varadarajan Narayanan , Devi Priya , Praveenkumar I , Konrad Dybcio , Kathiravan T Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Gabor Juhos X-Mailer: b4 0.14.2 In case of the MP5496 regulators, the driver uses the same name both for the regulator and for its supply. Due to this, in some cases the supply gets resolved to the regulator itself, and the regulator core code throwns an error message. For example, booting the kernel with the 'ipq9574-rdp433' device tree, results in the following message in the log: [ 1.710392] qcom_rpm_smd_regulator remoteproc:glink-edge:rpm-requests:= regulators: Supply for s1 (s1) resolved to itself Additionally, the driver uses different supply names for the 's2' and for the 'l2' regulators which is incorrect. Here is the supply map based on the datasheet of the MP5496: VIN1 -> Buck1 VIN2 -> Buck2, LDO2, LDO3 VIN3 -> Buck3 VIN4 -> Buck4 VIN5 -> LDO4, LDO5 This indicates that both 's2' (Buck2) and 'l2' (LDO2) are connected to the same supply internally within the PMIC, so those should use the same supply name. Change the supply names according to the naming schema used by the other regulators in the same driver to fix the above problems. Although this breaks backward compatibility, but the risk of causing issues is quite low because none of the in-kernel device tree sources are defining supplies with the removed names. Fixes: ad663ce67804 ("regulator: qcom_smd: Add LDO5 MP5496 regulator") Fixes: 60bbee7db43b ("regulator: qcom_smd: Add MP5496 S1 regulator") Fixes: 47894c859479 ("regulator: qcom_smd: Add MP5496 regulators") Signed-off-by: Gabor Juhos --- drivers/regulator/qcom_smd-regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/qcom_smd-regulator.c b/drivers/regulator/qco= m_smd-regulator.c index 25ed9f713974ba25058c9dbf38d36e88f70a940b..91bfea06b98682fca3c41f49ac1= 27884143d282f 100644 --- a/drivers/regulator/qcom_smd-regulator.c +++ b/drivers/regulator/qcom_smd-regulator.c @@ -792,10 +792,10 @@ struct rpm_regulator_data { }; =20 static const struct rpm_regulator_data rpm_mp5496_regulators[] =3D { - { "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "s1" }, - { "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "s2" }, - { "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "l2" }, - { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "l5" }, + { "s1", QCOM_SMD_RPM_SMPA, 1, &mp5496_smps, "vdd_s1" }, + { "s2", QCOM_SMD_RPM_SMPA, 2, &mp5496_smps, "vdd_s2_l2_l3" }, + { "l2", QCOM_SMD_RPM_LDOA, 2, &mp5496_ldoa2, "vdd_s2_l2_l3" }, + { "l5", QCOM_SMD_RPM_LDOA, 5, &mp5496_ldoa2, "vdd_l4_l5" }, {} }; =20 --- base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 change-id: 20251211-qcom_smd-mp5496-supply-fix-9086dad3cbc5 Best regards, --=20 Gabor Juhos