From nobody Sun Feb 8 06:04:16 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012041.outbound.protection.outlook.com [40.107.209.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CB6631ED65; Tue, 16 Dec 2025 05:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862041; cv=fail; b=KfFFGw8kX05YMKal31k/fXalyiBvMzREe1o+KvI9ECW8vvnbn5ioEkoCCsCaQF9hHE+L0YvJ44P9hMyGsBD3azyIL9H8ADn9X5pjXbI4B/lmSBOkshS0Iwk2kUhIIuxs7ZVO1sotDDu3+NtYyuEE4L1RkBFroqUu0fV2jzJw2s8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862041; c=relaxed/simple; bh=x0PYPJnCPHS7LOQRI5Yt4z0sn5dIWX1bsxf6Rtn46tc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Lsgu42/y0Zd0ZrBtUbCmFszemeUetvt0yim+nc1ui1PAmCtry6/aeW/BBPWdiZDT+GiCM06W/0zsZvZ2nC2xghNNsODRmLNF01ZkcZACofghXOT8xJ9RJ/EWempX+W0E96GYGnGfIXDRGoDT8sVhNG1eMIUubcYSU8d726VIGAY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=QzOm65vO; arc=fail smtp.client-ip=40.107.209.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="QzOm65vO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j02Q/OuRaq1gXOecK+XvJDREvXMDVLo01OR42MKTjI8XaaZtdT6JbORdFwf07oVnA04k2Qj12jBzLRG32u1hDMJVcOQ2314ZzeOeSMACb8n7cZtnPUaCl84jTfBaq29N+Mn+9sV9/qc5WnXItaP3KM/K/CDyYqa8S80q9+1nAfx/MGwRomITY42N5Uxw3FzUc8K/aDN6qVqtgAvU3fekY5sPaHLYH2SIwW5+fELp7fyxbDSSrnVNCfd39gjaX35i+6LFUcCUO1kkiO+0hUW8fLWHQFy6QLH8hbmqqkcgzgV0pVNGAIX+T9mB57ahJwHM9xuAne/oshGiYSvigxibNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njB3XbabS5wdP9ffYEU+rRaLSkvMYGkElAUc0uMcjYs=; b=eq06RfhPypfxYWSKwFh7E69Q/vPB3+GZXZ3bq8ooXAThRqaODx5KlfnIbmX97WXPs64sPSMf8G4W/TGYqjeVNYnKJ/5LdfQHD6L/7nH58DVu9rTSyVjmclFhovM6Il7yMNbpiWwke0I4fXVBhbfw5HLA8+HecseJ3wONsyUBRR7iYtHXFoNS8KSnZ1dF7Ipu9qsuLd+Nh6EEfsCde7d3GxIaWE4JO5FEpqN1iQHIMz4cW6AvPZWO/yYjYBensqMrpEp5fGHJo+5EExIf78F/jFiqX+DfBUJMvMhXaU6emt+TLDoxMUlXYxUGtFrke0kpXaFDHO4wob1ethL9SXHy+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njB3XbabS5wdP9ffYEU+rRaLSkvMYGkElAUc0uMcjYs=; b=QzOm65vOsLiXvccaOoA5gqoCqPCmGTwoxA73iqPsu3bZ01KNeunTAamOsbQC1IO7dKUHka5Rb8NrymCrvAV7B/rVeh7BpHNG0q5xC7LRxaCNPzl36noVq/QP5S6+E4uuoFl3ovmbY0G//nvVFM0jLBK+TP0u3tlPl4HIKiFdNA3YhQPPn19UD7oaCBB5zkUJVxe21sA+AWqvYCqW/ObOIeHOKxvWR18jbFCjAv8tDk16tCA0GmMioCreeJ8jk00A9JKXI8UBYt/H5FVmekBm48ioARGY37etP3BYo/be6ymLCor3u3KZtMUMQkj804KZ9lron5cMug9MMWlq5G+PJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:36 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:36 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:27 +0900 Subject: [PATCH 1/7] rust: pci: pass driver data by value to `unbind` Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-1-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0328.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3b7::17) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cc124f2-a999-42b0-cf16-08de3c61ddad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cmJsT3RXU0kxSkdwWE5nalh4MHlackpSMUFySERNSSswWU5VQ2ZqQVh0cTQv?= =?utf-8?B?RFh0Q3lxVXpVWXNKQ0tMZlBucTZmK0ZCUFRqQXRRWVlFMURJc3RtOFhZcTR3?= =?utf-8?B?ZjZiK3dra3FXeW8vbWhFN0pBdXNLd3NWNWVZbzhBTlVYakpuN3RlczF3T3V6?= =?utf-8?B?TE1UcTlycFBDcGZROWJ2TGIrZit2ZHhMeDBjbE9HTFowaENGVjBvdWNVUml1?= =?utf-8?B?RmgrMzFhMmxnVmt1SGsxVWhLUmkzZ3FDdjl2dWVsMmpodTZFMGQrelBoUDFJ?= =?utf-8?B?eVJjRW9DMFJYeC9kUkFSTitSRFpLZmhZS1hiUDIvL2VqTHRBcG02YTJMK1BR?= =?utf-8?B?V0JrNFE0U252KzVqUDVQVkhqamJtMVFQWTJva1hpUlBvTUNET1JrWjJqTkVF?= =?utf-8?B?dkVDZk13cDhCTG5xQlFMaHpRNmdtdjQ4dEVCWms0YTYvL0hxNmZ2eStVZXNn?= =?utf-8?B?MHlHR3RjVE5HaXFDSWw2WFhYVURrdmU1ek55R2FIU3Z6ZElMakpSL1lpWEhv?= =?utf-8?B?UDY5TmwwMHR0dVRNMWdhOW8yc0hQWkNFWHl0S1VIU2Q1eno5OUtHZlFpNHJ6?= =?utf-8?B?OHdtSmQrUUZrNXJXa05jS1crTFlrc2RHZ0NTdUxBWHlPRDIzTHBwWStObS9y?= =?utf-8?B?RGlsNTJpU3ZldDBtVXEyV0g3MkxQR2VJZ3lXV3VxWEZ6NUEyOG96S1ZYaTlY?= =?utf-8?B?V2RCWk9sbDNxVlBvdjFNSlNxejE3SHlLOHBjaGFScmVQc2FML1l6Q01mVEM0?= =?utf-8?B?R3dYWWNQMFhJNENIZUNpVmZwSGV3L1VWdHljSzFkek0xcWRaVndGdXJJLzFr?= =?utf-8?B?RExUSnhzZmVWOHFsVGlsR080ZkVCLzBzK1c4MmF0VlpIYWNKc0RzZHJCOXBi?= =?utf-8?B?VWpCcCthTFc1elMwZXJhUFJjRUZhbDdnZXBrMVNCdVllQkt5SnIxYUtWTmlW?= =?utf-8?B?MkpMNzZzNWJJZ1ZBalVwbEVZZGtOUGIyb09uZzNaYzc5alg0UXc3MjViR2FD?= =?utf-8?B?VUFPL3FQekNndXRUbDBGYzRmU1JGV3NpUXFoMFZraHhMZ0JHU3lnNkpvZWhX?= =?utf-8?B?ay9oQjNsakNEZ3UzQ0E2UVBqOFFWTzhlR2dQSzZXWDlUbWZTc1Zva1o1bkRw?= =?utf-8?B?WDlidHVERnh6WUJzQWszQml6OXoveDJ6L25ZNDF5S0JaK3gwR0pMUW1xWS82?= =?utf-8?B?bFJudHQ4bnVkajA1cWk0MVVUbVBDeDNkODJtTHBWTGZta3hMVEE0QUtGSzFq?= =?utf-8?B?dlhic0h3ZXBPTkd4Sjl1M3dibnJJUDFUOXlmSXlXQVRlbVp6VDJGM3J5ckta?= =?utf-8?B?OGhJaWlyeXFnWEpOY1Q4MWUveW8ydzJhdDFRek1DR3JjVFZMQ1daTzg2dlcv?= =?utf-8?B?WXdwMkhOTENoQnNKRXQ3ZGJxRDRNNWlQUkZBWTZHb0JSUkNHY0FJMEp6eVNX?= =?utf-8?B?cUUzVlJ0dTdFTjRESkN0VmRNV0wxSVpaZldoaG1tamJQTXZlcm5uTDZJR0xy?= =?utf-8?B?eG5Ca3lUZm85UStXZTI5dHA5ZmxiWDMzellodnhBaTlLWTd4S3Nnd0tmWlh1?= =?utf-8?B?d0g2ZkNqUmJPY0t5SkNPL1BuL1lqVC91MkE0WVpIOEtTM3NwYkJ1R0VyaXZP?= =?utf-8?B?eWRRNmdzRWxrMFl5c0g2MDBQeGkxSkhPcHByOW0wZTRXMEZvWGRXZkJkOEVO?= =?utf-8?B?T2k5K2ZvdTVJQkdJckZyWGQ1MHlLZW5ad3IwZGR0Z2JGOFY0Z0w4U3dESGJ3?= =?utf-8?B?UTM1dG5PdGFGeEhGdXNkbjd3ci93dEF0WFJPMFFzaHBQY252QmJzL0FOSXh3?= =?utf-8?B?Vk1qNDNKZW5PYmlDOGFRZlMrQktSWncrdWJDMUpZNHNwS21XaW1Ha2pocGpE?= =?utf-8?B?b09XY3ZvVTJ0akFOd1ZqUWE4aTd5N3NVb1Ftb1kxeXhDR2NmSkxtZ0RoeVYr?= =?utf-8?B?SDRlRXVDTXBSMHlSL1R1YmZXbERoSzhBVk9mWUZtbWdwWmZIaktNUGJLSjJN?= =?utf-8?Q?K7j5obgg3sTkVrTwYOaaSPupFf8tG8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MldGZ0RKSGpzYTNUUytacXIraVJCREg2MThtRFlyWnhBZUJrNE45UDBKR1BN?= =?utf-8?B?NDF1THh4LytsdXVSWVN5ZDNsdFA5M0RBV1FrUlpITkdlK0JndG1hM2crb0tC?= =?utf-8?B?Y1crVEoxMnpzbUMvaC8rak5JYVhxNXBKRUI0NFNNazNVWkozTWN1VXlKbHJT?= =?utf-8?B?dDB1MlZ0ZlZVeHRETlgxUW40SEc2bFhMREVpYmpwS1djckdvVTRvREZYYXJB?= =?utf-8?B?WWNOcE5iVkU2RGs3Q2QxOFNCNlArVlZBbjJpVDdQdEtnRXhPSDU5a1hoWS93?= =?utf-8?B?eTk1VzY4ZStQSTN1bE96N3BTSENUUVZMNU44S1ByVnA4MGhoWEx3TnRHdTFv?= =?utf-8?B?WXQyc21VTFdhQ2NUVFRGeFZEUzZqWG9lSFBwK2NmRHI5K3dwWGNFbEVIRE10?= =?utf-8?B?UHlPdE9tcDB6dmpvbTR5U0lMVDZLVnlEbXcrN1BGTXMxV05EeG5paU5WSmM4?= =?utf-8?B?MWZVT0VGT1UzSTE4NjVQYjZaSWtiV012d3BITm9MVVRnUkdTNU9USFRPQUZm?= =?utf-8?B?c0NSMkdIR05EMmovWDNPYlpuZk5aK29kK2hKZ2xORWlqd2xKazhOQUR0ekZj?= =?utf-8?B?UlV3SjJKTW9CcEhCM1pBYjZHRXpGYjlSNnhJMWRXWHJYUTlGd3UwL3Z1TFR6?= =?utf-8?B?SEY0a1dyQjk3Q2FER0NsV3ExTnRJZTV0Q2VKeHE4TVUybksyMGhzakJkNk13?= =?utf-8?B?VHJSajNmYU4wNEMybG5NTEtDY1JpZjEyQ3BMTmRjS2ZJVnRjTGg3TUViVjll?= =?utf-8?B?VTNTd2J4c2p2TzFIMmlrOWtESGpqREFtSFZ3MnI5R1VWQlhoM200RTVXRkE0?= =?utf-8?B?bFhmSVJKc3hYZzJLT3JNSnJ2VHg1eS8rODJLdktGNVdDMGtpaGdwZ3ZBWG53?= =?utf-8?B?RHRNeDVxZnBNdGpZck8vRWZKM3RKRW8xMGJGdndyNjBKdFNIVElJakR4QTN5?= =?utf-8?B?MEpEVEwySzNTZDhMVGYyNm9VVFNsRWRvRjZVcU9BdjBlN3dZbkpINEVrVlpn?= =?utf-8?B?dWFxMStoRjJudE5nSFFCZzVCbHBUaEpXZWZIZGVNNHh2QkV2NEZzN0NNVHVQ?= =?utf-8?B?NHBXOE42R0h5QkFxaXJYa0JyM3FuWU00cXhQUTY2a3hNUVNYWW0zemRxQ0s0?= =?utf-8?B?VlZvN2IxUHZZbkRMV05odjF0VEtybHdRSXZVcEt3TjB0Skdvd29EMEpnaWhR?= =?utf-8?B?V1VacDAvZk9YenYzSStDUVFQZ0pEUXQySHBoVkN5N25UNmpLT0p4M0lQdWpY?= =?utf-8?B?NUFLWkZoU1krSjRvRG1YS3pxVHk2WXZwY0wvNmpFeTZKR0NQUEpiQ2lVODFP?= =?utf-8?B?R1phc3ViR3RSaUxaZmtBOU5JRkNEdnJjM1pMUmpEWm8xVUs0dGUrZHNVK3dw?= =?utf-8?B?aU4xbmN6SXFPeUxjK0pWaGEvUnpSUWYrV3VuWmZDZEkxMGh6ZUV6UGNXTXhV?= =?utf-8?B?Yjg2Z0k3N0dLcjBkdnNXY3ZhS1dxbzFGWFFmUjFBN2s2eHRBOUtkNER0ZWRu?= =?utf-8?B?SWFwMlN0Q2NZRVpuT1BaWk16RzhrdmwvNTZyZHpoR2F6UGtvMUlGdUl5bGdl?= =?utf-8?B?UStpaVdQRVVSN1NaMUhlaFZxSGJrUFZuV1N4QVpTZDNFR1dJVURxM2ppdDd5?= =?utf-8?B?Wkl2V3pHRUIrRU9CenJyTEVSMlpNd0ZhMEVSNTNqM1NLYXY4TzE4bEN5QUZh?= =?utf-8?B?MW9xSnMvSndVSVBSbzZ5Y204QnQ4TkFzblhOeG1xMm9OS3FMNi92NHF0SDBR?= =?utf-8?B?QXgrUHBrTGhNR1FrTGlRL3MzRHE1OEZpQ0tKVG5DbDIvQnlxZEZTZEsvcjVj?= =?utf-8?B?anArTXdRZUdURnoremlLRGxwTTlhd1UyNkJQRnhBYVVNUVorbk1Oai9EUmJW?= =?utf-8?B?Z0F5SU1KWmQwZmZjL256YUhjL1k2MUZndER4dW9obytaV2RyZjVTWmZSbVRF?= =?utf-8?B?bUtMenFYSEdiNFhUVmsxLzR4NGhqc1hXcnB1cEZqQUFTYVZwMmJidHBNU0Jp?= =?utf-8?B?eFJjaGxqVFYwYjZUM0lSQS9obDJHR1hvdEMwM0xRMEl5N0d3N2wrTVJadlp3?= =?utf-8?B?UTVROTZFUzIrdmZJRVgvZE9FQVR1bHgyanJDTjd1SGM5KzhLNzNhU0F6RU1h?= =?utf-8?B?c1V6ZmRCaUtWNi9qVnJJNEdlSnltVkNBNTlpSnc3MWZJRy9LMjVGU1hzb2lG?= =?utf-8?Q?VR1skjEZ8soq1u5eJYYOrefJlTMuiJs8QNwc0mr8cqp2?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cc124f2-a999-42b0-cf16-08de3c61ddad X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:36.3005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6tsznlV7CfEoLES/xsuvMZ/RJtH2JRl+Fnojc5KkDp7uo4MA2ijJdetw4LKW9jBUGw9zwnkce3NNBumXIbYq0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 When unbinding a PCI driver, the `T::unbind` callback is invoked by the driver framework, passing the driver data as a `Pin<&T>`. This artificially restricts what the driver can do, as it cannot mutate any state on the data. This becomes a problem in e.g. Nova, which needs to invoke mutable methods when unbinding. `remove_callback` retrieves the driver data by value, and drops it right after the call to `T::unbind`, meaning it is the only reference to the driver data by the time `T::unbind` is called. There is thus no reason for not granting full ownership of the data to `T::unbind`, so do it. This allows the driver mutate the state of its data while unbinding, and also makes the API more symmetric as the framework grants back to the driver the data it created in the first place. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/driver.rs | 2 +- rust/kernel/pci.rs | 4 ++-- samples/rust/rust_driver_pci.rs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index b8b0cc0f2d93..b0e3e41ae9d8 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -98,7 +98,7 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo) = -> impl PinInit, this: Pin<&Self>) { + fn unbind(pdev: &pci::Device, this: Pin>) { this.gpu.unbind(pdev.as_ref()); } } diff --git a/rust/kernel/pci.rs b/rust/kernel/pci.rs index 82e128431f08..39e70adde484 100644 --- a/rust/kernel/pci.rs +++ b/rust/kernel/pci.rs @@ -116,7 +116,7 @@ extern "C" fn remove_callback(pdev: *mut bindings::pci_= dev) { // and stored a `Pin>`. let data =3D unsafe { pdev.as_ref().drvdata_obtain::() }; =20 - T::unbind(pdev, data.as_ref()); + T::unbind(pdev, data); } } =20 @@ -303,7 +303,7 @@ pub trait Driver: Send { /// operations to gracefully tear down the device. /// /// Otherwise, release operations for driver resources should be perfo= rmed in `Self::drop`. - fn unbind(dev: &Device, this: Pin<&Self>) { + fn unbind(dev: &Device, this: Pin>) { let _ =3D (dev, this); } } diff --git a/samples/rust/rust_driver_pci.rs b/samples/rust/rust_driver_pci= .rs index 5823787bea8e..ee8fc8d48ff3 100644 --- a/samples/rust/rust_driver_pci.rs +++ b/samples/rust/rust_driver_pci.rs @@ -95,7 +95,7 @@ fn probe(pdev: &pci::Device, info: &Self::IdInfo) -= > impl PinInit, this: Pin<&Self>) { + fn unbind(pdev: &pci::Device, this: Pin>) { if let Ok(bar) =3D this.bar.access(pdev.as_ref()) { // Reset pci-testdev by writing a new test index. bar.write8(this.index.0, Regs::TEST); --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012048.outbound.protection.outlook.com [52.101.53.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8651031A04D; Tue, 16 Dec 2025 05:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862054; cv=fail; b=ER4WQHqn3Q+bjPgkJvolIBz1utCldfoaq5QfFyrDN+bzln14hPCM6ZZ8Y5G3zvmULn+dEsH7PGqZ6hZVxMwpBrHC7Go8PIjQzt9sGa5GgA9A6OtcTErqfT5jXULsHO94sSJbNA9VMU0u7aYFK+XjcxN/yBGTdijLljLwS0uscbI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862054; c=relaxed/simple; bh=QCP6ZKGSBm+k+OP5LciU248qPSdHMSJY5w22IkfxJow=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=P7qt9Cl2zmbC/BRJnNB0a8S7mhlngpOcefO3cxLQKXgIyNctvwRUl5oT26yakVxEv58QkEkEnoSQ/QNPUU2pQ9Wji4Px9lpFgq+BSbuxfT5RO/WX288x1fA8kKMzNZKCR6GtO85KjeyzQ2RiqaqADrqyOZDkqshmBP3jX2Xj03U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Les5bBTs; arc=fail smtp.client-ip=52.101.53.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Les5bBTs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J8N5rntJ+/Wi+5cHo5zHUfWjL4qt4t8T46/cncwGH9jDC/e4U1N01RCxCyuv5EvowMG6Qwubj2OWr5CRM6mCsM71iEcCeuNwxUoU3SiEe0lom24zS2fj8oYh7BMAFZG3xHrez0exo1x5W/RjcPZjviCWslwE/i7YOZm/+TDdE4ilvGHegAtV0QaFre54ohqW8vGdY5BNY7thvK9M9Bs9KlHLu9rwm1L1UxNMoaOZEiJl3K3La1yyz34m3r8EMnh59svu7ei2LiBbxp1TZearXHV4LAi2VVZBQGgfVsl8xPsJMlkyDP8f8m3KSuOlcdawI/Zg7MtntUayjfTVzwLjOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iEG3TBh1YGF5iOf1CfYYbA1iDYden9DyvM9Dm1AH/Iw=; b=VE+LoSjWQl2Pxcs+4VUA2A8B89qKo4dxYgzh8geU5c5oMULcFP9qI44sSQSMZOjQjCpDj8Fja4tujAw5Tdm5Tr1EjAzRgtH7wpZ8O2mZo/A8cEVe4p+5tludm5NxyEpfrakXORxqnQgV1wrmif688eSBNH2eyfB1Y8CuQGJWhzpHHyeX07EkXq8pfsLJWC86oyIttHDvH8fCE5+360mNqP6Sa5sl8nc17jHf0X5elhciVRtVoiiRZg5evJ4utFYZ0vYP9PmUpLNTRszf7NVEHlWPSZaJEPo7cKK1V6opvcvX46FHnP0KU5baVeBSA+38te5MsdKMOi5IgvItEEfpMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iEG3TBh1YGF5iOf1CfYYbA1iDYden9DyvM9Dm1AH/Iw=; b=Les5bBTsAJGW+qtear/lnxkJIkEJKH2F95BDazpk6ClRruQwg4d9HeOPh99YsvFrRhgSYBZeRE6vkEgPs9Y8MnMXgf3aQolN9hbaeJ1Rw864EIon2dSYKW+0h6Vn37vH9p7gOaLidRL5SVI0FgXYhe+KYedzt1hM0jbR7loCJRGrNDuoNVSdgwIRqe6qL7upIBD6FcTn+OfCXBX82zbbb3l4iI6IBykS7b9/+MJrUPAUkgPdwIX7Sl6WA9Jq+KCmx4i+l7nnHVJbFKqa/QHEJ1y5QY/pRiJ77nvxueKo8XHd4fiGrat1ko/WE81vypd9WO3QPgyM4vDjTuccfN0mDw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:40 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:40 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:28 +0900 Subject: [PATCH 2/7] rust: add warn_on_err macro Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-2-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0060.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:36a::10) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: d9ef5000-6d45-4b7c-956a-08de3c61dff3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cFlaTkk4V1YwbEE3S2hiU0s0d0RLOFRLem5SbWcyWE9jSzlCZXZuZnF5L1Nw?= =?utf-8?B?Z0NycVllYzA3WXlOOGx3OUY5WUQxUnB4V1JRbUZBNUwrbDhEeGVqNG1Wdmw2?= =?utf-8?B?SkU5bDRtV2R0eXJNaE1hQVhKRzdRM1lWWTRuQmgyWUlvN0dWbjlNWUdPR0Fa?= =?utf-8?B?S1RaUGtUakNTVEJCQ1Y1UVVqdjNjSFlDaXl5SEtJbE9tNmlQL241dmZIMG1K?= =?utf-8?B?TUlzV0Rxam82dUpWMHFEWlZpM1lGY1NSSXZkcU1tOVlFUGJvRHliZFFrdDhs?= =?utf-8?B?dWprTDU2ZmtCVi9TZlhLTlVjNnBuQVZGdFIvOXljQWo0dTJpZ0c4MVdoTHEw?= =?utf-8?B?bSt2NEhWVDMyZk5OL0UvZVFNcmt4ekIwZm1QbUNSc3Z1YThuNVpuODV2UUxV?= =?utf-8?B?UXRMaysyQlMxWUlETzZzVjIxRmZFRHN3QStXY3JIOWpGbzhGWi9pSDhWbmx3?= =?utf-8?B?NXVueFB4aHBHOFZrQjN3bThGaDRyeld0TCtoM2xidkl6UTBNYW13NkJIaWFV?= =?utf-8?B?Z0NUMGJtSFV3Y2JXTjBXQlB3NVpBcjh3QzVRR00wMk1WOGNuTVRzZDNjUlZ2?= =?utf-8?B?ejR1YzF2SzQ0RUhPT0ZwVkwxTkVpRk5LMFZ6YkN6MThqTUhEdjJiVGFvLzBW?= =?utf-8?B?L3RRTHZJWVNkRm1RNzdNUXFmREJKQm5xUWZaY3JETmY4TUEyOGg2azM0Ym5X?= =?utf-8?B?WlZNWmEyanFlelhhV0U1M3Ntak4vSXh5S1FiVC8yM0tUdVRubVdGa0I0VlJl?= =?utf-8?B?bDRPQUxHQjdvSkdYVThRcDFETmQwQUNBOVlNWS91ZDFiU3VhZ0dxRGxEMkUr?= =?utf-8?B?SGNBNk1mdHhqS1loQnVCeEVCZzZVM1VEU3QrNGM0MmdGVUFibEdGS0V3U05N?= =?utf-8?B?QjhGdmxXVGhDdTZNSjhkZjZvblRpL3hITUZQWGhCWVlJVGE1bHNSeDRiVjZt?= =?utf-8?B?WGRRK3AzQ2lGV04vWEd3QSt0VlNoTW9md0pqak45dVkwZWU2SXd3c201U2FH?= =?utf-8?B?Z01sZThOR21jSDZyVUhOa0RsVzkzRk1qWXBSeSs5VEp2QkN6WEhtTU9HUTEy?= =?utf-8?B?WWR0OFRDaWNUOEtQOEJyUXN1cncyTmozaFd0RGFmbFR5b3loNkJtaFR5a1NM?= =?utf-8?B?MEo1K2thMDNVQkhGMHRrRWowWWxHa3dJck40UzJqRXVMajdzaTlCUUppaXlt?= =?utf-8?B?Tk9weFhoRzRmdHpuZ3UwR0NBTzRreEEraXFWek80ckpJYnJZYWVpZUdDTXJE?= =?utf-8?B?dmhRbHZKQm81NHBkNHBWSDkzTE9MTk04bVcxQXFqQlpOZnRsTkFyaWhCQ2x0?= =?utf-8?B?cnptYTJZOCtQODNrcFZkNmo2V25MQzBURVhidnFEK3I0c3RkdkZjazJ4WVBw?= =?utf-8?B?aXZueFFDeWRyK2M2eE5lelJNaDErd0hrSGhTM0NzeWIvNDk2bkFSNjlic2Rp?= =?utf-8?B?eVhrUW1FNzZiWXFHeVhHd1hXOEdtaTBocG11ZHlYZVFMUFdwdFQ4WnlNSE1t?= =?utf-8?B?L3lXMW5weXV6WElqTzl1d1lpUHdJQXM3VXdPZ3JIV2VucFlOMUZHcVd1NEps?= =?utf-8?B?UGR0WHpITjNVVHNtWGdNUG1JQmhtMHlyYnZ2STV1c21ZSE45bjZtWXlMelJE?= =?utf-8?B?UE4vMWw2b0lEcUgwc1Ayc1RzZFoyb2NJaGRBNE9Xeno2eFBtM2dRMlZ6anZj?= =?utf-8?B?SkxZd0tlNjhodGZweVBBVVlac2toYUpHOHRBbWdZYldnSEFabTNBbDNhaWcw?= =?utf-8?B?cm5mTDFRdWoremhYVC81S3NpYkx2SStGWmJFOXhKdnZhcEVvQnNTcVFEenFF?= =?utf-8?B?RXlic3NScjQ4bVdaWmhORCs1STJVWVcvRkxvalkramlrV2ZkL1FoeTlIWitG?= =?utf-8?B?SXlELzB3b09KUFd0dHU3UUlKTjV1WlhjRDNRZkxtVjZLaUhrSm5EUk12dzBy?= =?utf-8?B?M2xWTHQvaG9Td00vckowN25kbmtRV05OOVhueU5XU05OdTdmSWNuNWpRaGxC?= =?utf-8?Q?j6wtlm5bULhBDUoB7TdGvn4ntRU3ZA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MzRPeFlTZ2dEU3o1YlhMVFBuQWQweXFDelB0dTJONFQrVkpBczc2ay91OE5J?= =?utf-8?B?SURoT3oyRHhlVS96ait3VGZHeEw2RGVoSlJNMlU0L3g0Y1FSSVl2NW5CaGt0?= =?utf-8?B?bXZ5SGRQcE1SU3NkRGxyamQ1VFliY3hsVVRjU0ZIVENuZHZUVDJUbXFCQ3Fq?= =?utf-8?B?U1U2U3BhSUlCVHZQTWdLV3dCcUIrVk9YTGtMakF5NGRFWDVOVmMvaUx1YWVZ?= =?utf-8?B?eE1ERkpLR3h4SnV5MHozeklMQVVkN0VWY0ZNUzJZTWJSSFpWV0dpQm1BNmNq?= =?utf-8?B?MVZYM0hNL3E0SlpBMThtVnNjNFJRdVlyME84VjhYMUZjM0x5WWN5cXpRMEwx?= =?utf-8?B?dno0Rm43R01uTDhwY0h2RUUwSXV2NGdZY1MxUU14KzRLOXRWdVFkb045c3h5?= =?utf-8?B?NFUvekdFbnlHRUxmbTNYazM1cmNSVGhjSXlMVVk0SU8yTWc4UUplUnBaWURn?= =?utf-8?B?YnluUHoyT09ZZS9iakFtbkI4NC9QUUxUYUltYjhLY0NXNzErbFpWTEpFREJX?= =?utf-8?B?Vm45M1N3UW12RUJXZlYzOEM2bS85ekFRUS8xbUFsZS9tWUVqaVlBMW9BcjJK?= =?utf-8?B?NVFSQUVVTklYY0VNcE1HSXZHN3g2Q3dNTEQ0b0E2TnF6UWN2S09HZVhwVGRK?= =?utf-8?B?OU5JWXRTcUNXcU5MaHhsUjRvcTVxcWNmb3h5a3FEdHhsejBhVzJ0akUzYUlh?= =?utf-8?B?N0Y2REdmL2NmRVliK0YvU3ZxMnFoRWpjd1VZd1pUR01vd3J0QVlEYWlUVUJY?= =?utf-8?B?UHY1QW8zZFc2TkJpSGVmY1o3Z3NsajZNV0p3WEpEWjZ5MUZOR21FalcrdC9u?= =?utf-8?B?VHBLRjVyQStjRlhQbkJ4SmxQS1pMZWltRlB6N2Q3YlV3ZG84NkNuRXMweWc5?= =?utf-8?B?TnI5c2YvTEtkTnpSQ3RtYkJsajhwUUY0MjZIUEsrRWY2QzRFajVQVGNSaUNL?= =?utf-8?B?R3J1dCsxVE5pNDFsZTllOGkraHRFMkN0M1R0QXAwMmZtVmhDSFpJYmpJTE85?= =?utf-8?B?SjAxczRVbGZTZFpNK0VMVmNiMWd3ZlJjMGM2N1hyZitHdkMxNS9hUHp5Wlcv?= =?utf-8?B?S0kxR2ZCQ1V6Zm0wWHhqNWlmMStYK3dOQVBqK3YrM29sczRyLzVjNmdJU1Fl?= =?utf-8?B?SGx4Mlo2eGRQdUcwWngvakU1QUNJbnVlNDBHeFV2V3hYMEpveDlIeklhR014?= =?utf-8?B?VHYxQ0hGKzlxRWQwQjB5SSthWUlwN3dCRVhBaHJGcUdPYUVTb0EwbjdPNjNG?= =?utf-8?B?MzhibFRJREhIbVJUaXBtSkkrTFZuMjBTWFpOdDFUNEhkNWpGcUtLemt3bDly?= =?utf-8?B?V3M3R0tXZ0d0OXRkQm5lZElyNXUxTDVHeklMVjhpWUdWelB1WkE3cTRiMlkx?= =?utf-8?B?QTJPQWNoU0FOaGpmTGFxOEErT2dScGp0UENmelJUOHpQd0N4OVk5S3ptc1ln?= =?utf-8?B?WnRqOG9IUTIxbjdSWDc5bzd6cmZNa2F0T1dET3FHL1R4VWJ0UGh5VVV1NWEy?= =?utf-8?B?SnRlMm50R0FZYkg1aFFibE9QeE5sbzkwVktOeHdBT0FmQWRrMU9xTms4bkM1?= =?utf-8?B?V2RDMHdIZU9YemlhR1N0cDF1UnI3VDJBamJ6SWlFamxaRmhVNkg5ckJXajUx?= =?utf-8?B?UE90OGYxd01DVFNYNDBOelNrRHhlcnhpZUVrRXlKbTJYZEltZkxSRDN1UWdx?= =?utf-8?B?WEVvckNyNkNtNTB3RXBPSFR5NCs4UzZmOHlWSEtmYWR6RVdUQ2hYa1pLVVVJ?= =?utf-8?B?dWs0Qmd1Sm4wb09WOW80cTVIVWVhOUQ3T2F2bldhMFhJYjVJWG95cDUwVS9u?= =?utf-8?B?T0N0UGZVbmNmVm96VlFEZWl1MmpBbHQwZHlQZU9aT3UrM1FNcVNxaFFDY2wr?= =?utf-8?B?alE4dkxLQ09HNTlsQVJNcjJMOXRSVEtUZnlDM20yVVQydTg5VGNFVTJtSnpu?= =?utf-8?B?QkpmZlZBQWZZUG9iN0owdlY4OFZtd01XOWthQkEyUlZtcHZRVlRmUlhkMjNR?= =?utf-8?B?VUg3ZlBGeWVpRFNuWUdqeWQySlZxRHR2MCtNeEVHV3lwU2ZVNlVQZzl1Z0da?= =?utf-8?B?Tk9hQXZkaExDRnVXNVVBMVVQc3BpNkxLM3YxK1FrSU1oWmpVYnNJZHR4TXdz?= =?utf-8?B?M3l6ZkZPRU9paElUWGRJNnNSMlhMaGRuUnllWHdPZGlTbFpHdzZaeE1zY1Vy?= =?utf-8?Q?LMZVsGjGQ1ZAQa/UaMIyB47jhyTkNHV91GCPTZ85vkaf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9ef5000-6d45-4b7c-956a-08de3c61dff3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:40.1469 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eM2469chYOi7vZ7OQ5opoUgzso0Zfl5/40BJlmDSK5bMcH+xcsr9rY2d+jynkK5nyeHs2GGulASa8zzpv5P2lA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 While we already have the `warn_on` macro, a common usage patterns in Rust is to check whether a `Result` is an error. Add a helper macro that allows this. Signed-off-by: Alexandre Courbot --- rust/kernel/bug.rs | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/rust/kernel/bug.rs b/rust/kernel/bug.rs index 36aef43e5ebe..255c780bb4f7 100644 --- a/rust/kernel/bug.rs +++ b/rust/kernel/bug.rs @@ -124,3 +124,13 @@ macro_rules! warn_on { cond }}; } + +/// Report a warning if `res` is an error and return it unmodified. +#[macro_export] +macro_rules! warn_on_err { + ($res:expr) =3D> {{ + let res =3D $res; + let _ =3D $crate::warn_on!(res.is_err()); + res + }}; +} --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012041.outbound.protection.outlook.com [40.107.209.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0A131A06F; Tue, 16 Dec 2025 05:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862051; cv=fail; b=M83UOg2IqBKqG05GBffIoNm0y0ebUG7ZiIvXWsirHRUhMzT4Cp3S6Y/I9Her2422FvBJaFbVpH0Phf6TTN+ChpIEnZ7iS8bxBEgIDCeTsZu3Rzt7NXv3+NkkRnN6omQqEqQTVOLf9Q3dmxpaXgNxDNpBw5KOfUuIjjrNk0lmXuA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862051; c=relaxed/simple; bh=8rBxVzs9v9wJL4BVL5moZLOCuXLmYB2BiQwqtw2PnvU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=rdEyY6nQEnkkaCvGO2i7l+l5IRNzvbUh9gIXdcyEaGPBO1pUx9qapBRBRyxUcuwoJnIXTQoUlE4SElrUomGjcj8UHNfJ6C90n/CuXJ16TsYSDqnHILQHjshx8JzKz+Voq0SttdIki3Nsf2bk+B4IWYk8LfE6SDltVJe0fIOqs/E= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lfFnG3dA; arc=fail smtp.client-ip=40.107.209.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lfFnG3dA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z9UjrHGm33hJ2AKIN1FPkee5M89meBkA+S85E5Y+ZsOEo+J13C+VsohNznv39xeNZkkj83G5oTovnOu4RNARVuRL2mAkfUIitC/U4/FPa4a8rL+qUo2fM/nwwp/g7WiV7MdDZRXb4o1sqbGpJmLbkjshGks9ElyvL9Lllgcv0gaOKi8rdcQpfJrbtaVbTQAXU/WEcIGDfheARbyUuZHBkEoOy3gBHFNlPyjguzFc/CqsTc11285V7MlyRsDHzDP7T3rSX3tkOA70edgG6LKxhOyELrLlgWlKbZdz7ashbNhVTvEEeKXULsh6eBdCrcjotODw5apE/jSS1JKHGxKBqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUMDiv8CEGyszg9oMJQVl+4wdeGAm8ZFQgnYRA26OXM=; b=VzfRBN+11/hadqYr/D+Yz+a4FNSpRU6RsBrgy9b+KTaKDGWZ4tHM64T1l75RGBJ6b7UkUdKRH4Fa08uWPWxXKS385ZeKEMB+fJyQFQlnTHqBnUJuYr3GMCzE29PvdcxWFsndObzQOC4ZjRzNwhfoB+UPFFDhMkxh0v45jQOmmpo1JLtxJZu19UOxKdmafPGL+i+fh+EUm9N4fLp8nMjdjbT+QZrviFhx9D7HYKpcpg1WUHBBnlwmfKA7LQebNkiGLlxjtKfJW5AA3TjgE5utgHdJVITIJ3ky3vIRvvNCUEiw8JUJMeNA47wdMo7U0DJN3LoKDpmW0m8oukXBIfct3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUMDiv8CEGyszg9oMJQVl+4wdeGAm8ZFQgnYRA26OXM=; b=lfFnG3dAdJ9zpznFHyszGfCao6UqqJeiK7dnj7nZRESMYee2oQSjgjp/fADW4mXwhe0pPlPzVod+GJ0Ej3e+cSyoX7LUCZh4WzE6w0la4ltzmMeJBLRIA2TWlJ0rj4MoyQ+sC5EuCFxQ3TLzX+kE8UrNm6p+1lrSFy8WSJ2NrlOT058WCUl+4IfTDeieflDL5tHGAn76CpBjOGLkNTjwBuLv/4P57r8LgixAAygEYJzCgPtO5oc/psFaWKFfJbVZDZFGJgLPFd6ZjF8VGS4I8sjIsE0p9YPenxJT4CYb88U5KBgUfzKCquvfkIKfJjSW26txq6m2ptD807lyeWmiZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:43 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:43 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:29 +0900 Subject: [PATCH 3/7] gpu: nova-core: use warn_on_err macro Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-3-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0234.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c7::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: c664406e-1237-454d-615a-08de3c61e21c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QUFhSGt5Rk9uUzE3TDNtR2crTXZ5YTJTdEpRR3lNSExpZmc4R2RyTWRES3I3?= =?utf-8?B?Q1RyQ3M4SWRPbHpkWmVjbmh3NFlpdGRBK2NVeExhdGtjb3hRQmwxWktoUFdJ?= =?utf-8?B?OWNPN0VFbHZYYko4TkZLRE4zTUYxOU1KMkkzV2s5bDR2bzdDSzVLOWYzTGtP?= =?utf-8?B?SDZxVEJ3SFhTbjlleEJrZ2lwTlNDS3R6eUZyNzRqZXMvdklFbjNyMzM4djV5?= =?utf-8?B?bU5ZNCtIRlN2Y1kzTUEwNVArbm1PM25OUmZGUjBPbUZQeHZxNHBLV0txZnRu?= =?utf-8?B?Q0R0cis2ZC9wak1tZnBKbVZ0bkZOK0JDaXIzSUVocG9TbVNnRjFnZCthRkti?= =?utf-8?B?QzBMdGZjS3l1Y0FVTUZqV3NuK3RRdjdadzlvVUt1OVFZWjdsNlFxOWUwYjVX?= =?utf-8?B?TUkwY0NONnAxU3YyMmthVXdBdkQweFpvY1ZYTmdpZW1LaHBlaml1SFdpcWZm?= =?utf-8?B?d0xuMGQxNVlvb1N4amRzdm80b3Z6MnlnSk5Cc1BOT3VBNDBSek5sNmN4bUpt?= =?utf-8?B?em5BOTFQMWlmRTNSbHpJVTFtdHltSXpaOVQ5ZWRtN3JtaWU0dGRTUlliSmNn?= =?utf-8?B?MHBQUDhTd1RnZ2dtNUZtcG5jcTVsdWp4RUJBbEwrNDBOTmNWV1Uwa0tvM3ox?= =?utf-8?B?WHFCN3BNb1k2VlE4TEMxa3JCc3p1UStDdkpSNmtscmRLaVE3RFdhZjM5SE9w?= =?utf-8?B?eTdjTkF6VWhtTXFGOWFpZG5hK0FDRkEyK05IUS90S1lrYnkvTEgxK29nbU5l?= =?utf-8?B?TGt4b043WjNHbThuWFM0TTBLb2ZRZkZ3Rkg0dTVxUUZzY0k2enpoOWROci9x?= =?utf-8?B?TDhqNkN0bUs4UUp5NC8xaGRCMzFVMjBNaUg5TUNrZktUSFJHSld5WXg2QWMz?= =?utf-8?B?L3NaTjg1TUtxaXRueDdocjRtcUoxT2RacWlVQzVLZDczTmllMExlN2ZrWGFk?= =?utf-8?B?d3I0bmZ4eFN6MFdieTRQZS9zUHVxR1JiSDA0ditzTWhNQ1MrbFRVdzNyWEVF?= =?utf-8?B?SmJHT3U0TFNSKzBwbS81a0xqa25IMkFPYXkxNHlYdlpBbXQ1Uy8rVkVKV2hN?= =?utf-8?B?VnVzdGtaQlVvcUhkTG9LRnJEVlhuZG9JbytXc0xkWFdwcWVKbGg2ODdjNjFm?= =?utf-8?B?WHB4M05pRUhLNTBucmZUTkJXKzNlMmNxNXNzODkvRGp1K2dONE9mTTNhUHNO?= =?utf-8?B?bC96RFcwV21Fc0dMbktBUnZkK0hGSFFwQ3NzeFMwYUhRZUNQMlI4QVZ0SDBT?= =?utf-8?B?TUlrL1NjbklTY0RNZitJTmVDMVphb3VNcGlXak4xTERZUkZmd3AxUGd4cFpC?= =?utf-8?B?eFJoUVBVbjlZbXZSaVVQOExBVFR2c0NVaEVzTmlzZ1JKNW5zd1U2dkNET0lx?= =?utf-8?B?QXdIUXJoaGorN1JTNGVJWndMbTM2b0RGQ1Z3UFRydnIwTVVWcHUvbVJuMFpP?= =?utf-8?B?VTMwZjZxSjZ2bk5YblozZzFJVENIU08wL0E1R1BNN2VTT2pva25PNk1MbUhM?= =?utf-8?B?MGlrWFVNRkY3MHpvN3B6MG5pYjUvNEQvUGxUYXYwdWQ2RVc5VVAvZXNRaDJP?= =?utf-8?B?cTF2WC9wWjJENFh4ZlNNYjhGY3JBN0UxL09QYTNmS3huY21oM2tWWEJBSENs?= =?utf-8?B?UGNhbzZFd2RidFkrS1h5N0U4aFMzMnpPTGxEQ2Jwd2VNNW9nNnlOZGdSNC9V?= =?utf-8?B?QjIxcCs5OVh0Y09TNlFVUnU0STFVWm1TMjNDUFdpcGxUVFpLNmFBSCtsbWpI?= =?utf-8?B?UDM0eVBlMEVCZWc0aTBxcjA3Y3ZjU0VlR0ZYZGdoRy9hcGExR1c1S2RkUGox?= =?utf-8?B?L0xNMnpDRVJ3VVNBSVhZOThTZDdsUlEyQU1FcmNTRXdDQjZsVUdKQUZFbTZJ?= =?utf-8?B?bHl6a0FSZHhIZjdZcmw0WGtDQkZTYlFabWNkblpZZkZvZ2JlazJhZzdXcVFW?= =?utf-8?B?ZWZSaHcyd0JmYlVZbHBibER0WjYxT1JjZ01lSHE5Q3hpcXlTUnRaaDlMb0tF?= =?utf-8?Q?H0MXTXPPuMThCJs2VCMjqydkR+Sqbw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlpZWWk0cVkyL3VJQ0U2QnZZZ3FjZVJVdGo5cnlGbDE0aGRsbUhjM0ZSalNt?= =?utf-8?B?NzFPUGM0NTZYS1VoekhKS3A2ejk2ajJkcmJjSEdWY0pUdFNsRDIrT05FelNE?= =?utf-8?B?QnhlVlVaUjZEWUNOM3dObmVoL0grZXRmOGl2TlN4ZllpbFpzRE1TOExGdlov?= =?utf-8?B?cjN1NlZZOVdMSUdoUG0yN2RWY3RxSkhIUWxxdnJZMVRnZUhwZ3pxd0NNOXhI?= =?utf-8?B?Q01OYnNpMnFtNU5HcHRtcW9MSWlkZXQvR1FNS1VmQ1ZpZlBNS3IxaXBkNDR0?= =?utf-8?B?aVh2QTlSSXE5bDk2cVZlRlRycjFLUWJzd3ZScHo3NDFPcmg0dVFIaU93UVpo?= =?utf-8?B?a3pwV2ptallWVkcwVkRSZ0hmMTFiTTk2QklSMnY2UlpWS0d5c2JKUUR0TVc2?= =?utf-8?B?RSt1YmtNdDlFaFZabG1udTJXUDRSRFBFMkNwOVpKRVRZWVpTT2RYeWRwWDFR?= =?utf-8?B?Y0hYempmellwa0VMSWZYZWdkM3U1SzhLam9lWlVnRDA2NW96blJ6WXFQMkJz?= =?utf-8?B?NEJzeGdXbGJ2V3Yyckx0eHF4RlFLTTkzS1hnZEs0ZlYrS2tOYm9jSDNHd24v?= =?utf-8?B?V3VkQlE4S3ZkMS9ndFZlbXBaMm9xQUNJZHUvVUFtNG9MSGt5cTNweFBjNnAz?= =?utf-8?B?VUZIQzVnZ1c1amM0ZDV6S0lWbHFGWHIyTElyZE9CNWxZOXJGb2pSYVRlVy81?= =?utf-8?B?Qkh5TXdWamwzK1BMTkFsaTd3Y0F2bVIwVG1BNFpNd0lsM2pEdTlRZ0sxbXQr?= =?utf-8?B?TlJLeEF4c3QyVUF2ZVo4R3lRSjVpMG9OTnFTVk5mZVQ2d1J6L1VPcytIQjh4?= =?utf-8?B?UW9OckhPSFdxOFpmcUluVStTQ1NmRk00UlB5azFOb0ZhWlpyRVRESy93VHZr?= =?utf-8?B?emhtZ0tQak01SkExcXBvQzhaQ3c4WC9nN29hRVAwNXZyMktzOFByUXVGempx?= =?utf-8?B?NSt5bU9VcFB1MjFQamNmTHpaZUxTTkNmZVNyUThtQWxpbVlpMFBhbzFLbmdz?= =?utf-8?B?bWY2VE1VUnF5ak5JRUg2enRMZEVMdzNoSTdWcExEWGJ6bTFOMy9pNEEyb3Ni?= =?utf-8?B?WTdPbkY4eThMSlRYbmpQU01MdGNUNms0NzJyN0k4dk1Rd3FhRzd4YTdnQU95?= =?utf-8?B?Y0JmbVlOenhHekgzT2JOempNZVlzWFJJQUN1L1A1cHE3NTdtTGpxYVdCK3R5?= =?utf-8?B?enBZWGhKV01EaTAwRUFEU1dWYndWdUNyYTdaSFJEdWl2eEtNYTIveUxjQmJr?= =?utf-8?B?MU9jbzJNRTVUWHhlT3l5Nkd2T21PdkMzZ3pmSVhnRDFVT1QxOE0rL2NiM2Zw?= =?utf-8?B?amRGMEF3UDNQVWNGREtRQW9xSVZaYncrYTVZb3ZNRHNuWmNvOFd1N0tBbkxL?= =?utf-8?B?U05tV0VYTHNHODA4TTJJeGdoM0Vaa09Ram80WnlDV1gwVUc0b0hDdDZ4OXJB?= =?utf-8?B?RWdMdHRCU1lSYUp4VkNuMXVpcEpPcXA5a0NxT29EcWN5RW9Tb21sempFWGtJ?= =?utf-8?B?TlU1Z2pGY1pDeUhEd0hVdUhSblFyY084VW41VDBPL1UrRUdkU0pxTFpPVElt?= =?utf-8?B?eXBTZ1cwS1UrZVRPdFRhd2t6THc3RTBzMThkOVRMUEVWTXpmRUs3T0hiRVdO?= =?utf-8?B?UXltNmVuVjF0Z3Bzc2k3YTNsTXl0WU9NcWtZNzRLUEUzd0ZFRFIxb1huaEVH?= =?utf-8?B?cEpqYk4zQ0JiMDRqaTc4OFByaVE2c0J2clA0WDl4VHRYYmFDYnMxQXFqUTNB?= =?utf-8?B?WkRMSDBKdFpTWEk3aXdQdzhCOWdmR05OcE9iSjdlSlZ1eHg0UmNtdWdKNCtK?= =?utf-8?B?YXVDQ1lidWRYNGFRTnZzVk9SSU43S0sxVnVIYnlRZFlKandTeENtc216MWIx?= =?utf-8?B?RUNsdFRkbC80M3NMSVFBRnUyWm9nSEFCTWY1UFRlOVZvdzZvQTBzUFFaeG94?= =?utf-8?B?dXJPY2JlZkhtcHV1OXBaNjdUL2JtbHdwbnorWTB4ZURDclJ6Wkx0T2p6VXU3?= =?utf-8?B?NXBRT3kvRDhuQXdDLzNUeHJJMVVxQVBFN3NUMGUybWIyREloUVM3U1pnVEZV?= =?utf-8?B?MC9abFVuVFEzVlI2NVFkVURTdjF6Y2NhcEFuMlo4aS9mb2ZsMXBqWk02TzJS?= =?utf-8?B?Nk1EeG5DK2FIMitwZU1VUzFEbGMvcWFVZ2k5WmtJYk15MkFEeU9SNTB3cDl4?= =?utf-8?Q?u8j1kRUgk9t+A1lyHAjvVOuQBvV/sOEieofk0TeRJCwR?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c664406e-1237-454d-615a-08de3c61e21c X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:43.7498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VZxhKaeCTqA+5apXTk+MjmJ3wCSN2xAxYsNbxFdiosK8LBYhQMjLvZ3V2E4E1do74A/E8u260oNqdIAL+ajQWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 Use the warn_on_err macro in the unbind sequence, and refactor it to early-exit during the failure path as we will need to use the bar for other purposes. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gpu.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 629c9d2dc994..e16d3c2a6b38 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -293,10 +293,10 @@ pub(crate) fn new<'a>( /// /// Note: This method must only be called from `Driver::unbind`. pub(crate) fn unbind(&self, dev: &device::Device) { - kernel::warn_on!(self - .bar - .access(dev) - .inspect(|bar| self.sysmem_flush.unregister(bar)) - .is_err()); + let Ok(bar) =3D kernel::warn_on_err!(self.bar.access(dev)) else { + return; + }; + + self.sysmem_flush.unregister(bar); } } --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012041.outbound.protection.outlook.com [40.107.209.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1894F329C7D; Tue, 16 Dec 2025 05:14:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862062; cv=fail; b=qWR57YcHzAHthDnQtxv2pOuqeP94AqqpK/efIQ3rPNRJMiBLX3gcZEx9NRbXol95XnRXLJRYKNwguWz3eJB8plahFueqm/dl7yqrUd004SMsOHAeXD4gpgDe3Q3TEkWfmwBLLBNxMYEOpCmYI6tXDBPI8LUDZAyA3hZaiFps3sQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862062; c=relaxed/simple; bh=6Ac86YX0IhCD5U0hrj0KbNmckgWqSvpf20aH5TtV8Jo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=aMjBcECypjT09VtMeuvfsKJHNX3d8u2+ZDiBPU6g35luCXuPkRz6lcA9MqVfdiJxAfnjCSa0957ltdSMOE7w0CS+nOMhb1Tn8hs1iOs824+LFbRRulzA+68rzbIGBJW8/5J5sO+lJ563VffXUh5Mbux3/9kqzGJIPuHsCe9651o= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=HJiXOkiW; arc=fail smtp.client-ip=40.107.209.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="HJiXOkiW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ARwtJBJuePkdUbotYWgaf6zzcYXAAAjVb+bGUldzvPUxbePnPkTlE/RCI0+Tif+dzWRVp5jgPU1CBkis5pOoGJq4OPg4UsXW/k7Bz2M13miaMKfs2ElFNGzRq2q88v6u/rIOxi3oIW9wYAI9zF92mW8Po0G45TAWLX2Gf90PXN+N85aXQqCaOZwsZRyQR2f2eflP4NWVRB9sPbzpSSnz+JY8oR2c7AS4GfWP7QDqi2eKpdAmKjcfsYCJ7iZVhWI/JgJOrPzYdG1GadY+PAZuMzviHdU/J4alsKpOx3oQBGz6tP1Uphm7WJhhyC1DJ8MA3AYOLyE8/jiOo5IjmIRQag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6o0DvmZqVPrd8XbiBeZLiyHJr9BDy8ck1P5gyGqqrcI=; b=U5SaG3p5zIq12twKJCq/+pMI6SRDQOopjIEJBPTt6ZLd60vvoUG/j7fGixWkjGyXaGGjqueW4ZdAx7VzCnaf6SkDO6/O3OEy1EjpJJyGw+YP9XEpfFCGT+qABDqyaNWsAhCXy9pSbcKeNhu0MyOkn2i3yofy7hRbUqk1PH3ve0AIy0DGLTFm9pu+lYNmlgy/2Pe5VdIZolpPD3G48YYtSDAcDtqwFMhVb6VzbKBhA2JSF7uQu0/1THMUSJhTKHtbBRl0MoNRoc+5pFbhSXBWgb2RJiW1TYhcayJv3LOjYf6ZJK/n6LMcN5hHvOsGKNCRLrhbzb5O2Mv5Eau/OvY8NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6o0DvmZqVPrd8XbiBeZLiyHJr9BDy8ck1P5gyGqqrcI=; b=HJiXOkiWDRRg+GaHF0Vgmc8W3BXgpWiRum5fQKc159W8QTur4zmyWIJu+nIKjpUDdRvLfNZiR+vaocxQ3wlYDyW9NTbEK0Kfd+hhZg7me1bnkhRCgWpHrqBw77fpPKvt5ukqkLRns8t432+D+rTgkRhyWP1vsqoiV9GjMN5m8wZT93Gzv5hjTqZBbfJHBZlXm5OcdWUexEaLjn0SyxGI0+MSaZ6WwSXtkvkBV9dcGmuGJYAI3y7Fkf0rwnC7LXyifAYojf+FaBHmqVW1ZA/zTMM4cNmS3/ZWJ3JtVPenzpI9PcEw897KivCuYQ7BXlzot3fqlsIa7RduUkWHohU94w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:47 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:47 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:30 +0900 Subject: [PATCH RFC 4/7] rust: pin-init: allow `dead_code` on projection structure Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-4-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0049.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:36e::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: 196afa72-72d7-441c-15e9-08de3c61e442 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ajFYUEdXMkxPU2hiN1V4dnlPczErTDEwNnBWWEQzdFN6WEhsWks4ZG1WakVH?= =?utf-8?B?eHZpc3I5UzhsZnZrNDEwR3liM1RpL1ZVZVZLQVllUGpTcU1rM0pvN3lHaWVp?= =?utf-8?B?NTlRNjY5UVdIRUdCb1R3NkYvQ2E5MlNoU0VWZW8vRm9rVnBZYWhuT1ExeWVu?= =?utf-8?B?Zmljc1hlbHdFNDE0dVdONWhSSmdnWk92bXRYSkI5STdGMjhtd0ViWTg1K09P?= =?utf-8?B?enFXZC9CU0ZiTU1BSlFBRFNKNVJiK3VRajhmRGkxTWQwMDVaVjlSQ09EOFdo?= =?utf-8?B?NmdPUGt6TERuU2plVHdWY01hN0hjL1cwVlcrcGtsSHcrUUh5UDI2bWUySjVn?= =?utf-8?B?YldkaW54STJKdXZCR2tjcHh1K1JhQ24waHg5VkhUNVo1YUhhTGFWWWZOR3ZY?= =?utf-8?B?bVpHMlYwVzJpQjErTGFVSGh3eUJyeXFOODRkZHhrRjFRS0pmSERQUkJwbDZM?= =?utf-8?B?TFR6U0JCTXhJZlZjYXZ0ZHdHNXFBNTBzUHIvclZITUpDVDlQN0h2VlM0N0VF?= =?utf-8?B?ZUFVOGRkWEFZVy9OdFhwT1ZWd0p5ZXJKenNMRzQzckxLZFFpUktBNjZVMVc4?= =?utf-8?B?WVozOXFjMWUxbmJmM1NKbk1HVlNXcituZzJvTzRiY0dWTkJRMm1QWlhXU3dH?= =?utf-8?B?SjhydlFMeXE2YjBaQ1Z3YUYrbjUrMi9adTU2eFhMTzNBd3QzVUtoZ2JjVmpu?= =?utf-8?B?ajhtWnMwOWNYekI5ellVNDg0MUpJUVYvOC9qdldaRUJWNDRBc0ZqdlZYSmdY?= =?utf-8?B?UlJqRWhmL1FNcS9OVnVteXhxdzVUNHdoNHJmeTA1TlROamVoY3c4Z1FZSnph?= =?utf-8?B?dE5UZHJDcDlBV09MY294Rzk4K1Y0d0xUOWM4Y2dLMjI5Um4vWE9BMkRvRDha?= =?utf-8?B?TG5yY2VwcXRkS1JCTjZLVjJYNEJjNnM0cXNyaExrZC9QcnI3YnphcHNUUldE?= =?utf-8?B?blc5YkYvQThYbWJ2bUhkempiS1I0eGZzQXRCOXh2akJLeEpvQTd0ZElPUlFa?= =?utf-8?B?b0Y2UlVhQy8yY1lDeUhpZERlZ2xiSm5BOEloeUIwWThNYXRiTWdXNWFTQ2xB?= =?utf-8?B?V1dsWmF1bFN4dHVaYStoeit0WnNwekxZWXprQ2R4YWJUUGhXUjl2QmhLQ2tr?= =?utf-8?B?eXhpWWVuVFhiTzlOb0FUekt4aW9zTWliUmhnM2VKaHl6THhQVG9vd3h3VzBq?= =?utf-8?B?c3ZIdEkxeTdSUEQ0ZTFFRnhGQXByTzRnY3dFeUxqK3h4OTFoUHRiQXJaQlZV?= =?utf-8?B?K2dWL2pIMUFhN1lDYTM5SFJSKzQxcTVySFBlMjlXcEpkZmRIUWQwTDlOWWNZ?= =?utf-8?B?aFpkYkhpOWFkeUJZWWpncC9TUWdZWG9DSm5PdDBNVVBSV2FpQXBMdjh2dTlF?= =?utf-8?B?ODBlVUxhK1EwODFKdFZBVUk3cUcrTFJUa3hZVEhJaGZmOGNFZ1I4dTBWMGpN?= =?utf-8?B?THBnMGxtMUpNc3Z4V01nZ1BpU1orT2JwZjRTYWswSXVSWm9MZWppMElNaThz?= =?utf-8?B?cFBqVjlXRVRTc0RiZU5PWTZjU09oYzN6K3YwQW0wTUZZQ0JKVW11ZnR1SlZ2?= =?utf-8?B?WWJQL214aTVKQjVrM2prZXhDSzFnMEhpWmRHbTlKVUtHbFM5MEgyRDhMRXpS?= =?utf-8?B?STdnaFBlcTZZU05td1BSTTJMREt4QzNzZFV5NFlkOEdGbjY5UTZ2V1MwdjZD?= =?utf-8?B?OFZJaEcrTkpsc0trZEZkZVlON0Qxa2V4MUpJa3JsWHpFbndhaGQybndVNEdI?= =?utf-8?B?SE81K01qckpYU3JFWThXM3AvYnZWMzRpRlo1bUovTTBYK09NN0w2WVBEM3J3?= =?utf-8?B?N1ZhNVkySTY1aXdqVSt5d1B0clowc3ZKUnpoQnNoVUw0TWxVQlNZb3JJd3pU?= =?utf-8?B?WUh6M3diazV4aEcwcHFUZ0kzc05vbVlDdVhhemwzelZ3MXB5NEU4bzBmTURY?= =?utf-8?B?MytJa0o3SWZscTdqSWt2SjhHT0R0c1dqTGJNNUFodnMzZDI5UHNTME5zN0RX?= =?utf-8?Q?myb4xjevZjt96GdW/yseODTtt/IjKw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHBUb2lsRXJPdGI2RnZIQ0d1WVRsalMvWUZYRGdndEplWG9NaVN1RWRnUG5I?= =?utf-8?B?dVNocVg0dmRVbVo0Z0N0V1FuSlh0cDRiMFZ4WjZWSW1qeXFJMVREQjBjdU9x?= =?utf-8?B?SUdKTXhINDh2aXZiMlFSWXZoMGh1TklvcW1pL2hzR0JhcTRmOU5GZWpwUnNZ?= =?utf-8?B?aGdBYTJzYUZyS0JlUHpIaGFueXd3OGdzdHJrcDUzME9lM1ZydDM5dlJHOXdO?= =?utf-8?B?SkwvNkJmRHh6SVZwNWlJLzZFYk9OUlVyeXBxUXdKLzhhWlBCZC9UdjcyakN3?= =?utf-8?B?Z3lEUThLWk9tMVZhdFIwUUFUSEZ6MUZvNDJ0Rmt2T2NxcXpuVHlBQzAwNDI4?= =?utf-8?B?ZGw2dEdjN3VKTFhRaEVLWUFwWi90MU9EdU1RMlY4V0VFZ2ttYnlTWkhNUlp1?= =?utf-8?B?VjcydU11MGRmS2pCZDdlNnBla1E2SERNaVJvcnJzYnFDeDdyVkVuVWJIcDlP?= =?utf-8?B?cmhuNm4wanYxVHVYMkZoQS9Fa2tOQlZ3YXNiYUVIcDBwelRQcnBFOFdtMk9H?= =?utf-8?B?MUhHVm1kNUlyLytEU0szTEFMTGtPUHd6c2REN0I1cGtjU1NrcTBnNEhQUjkz?= =?utf-8?B?RXNEQyt0QUxZTi9FU2ZOdmZnN0NhdVVhTG00VUE0QWQ0SnZDa2thQnRLS3Zr?= =?utf-8?B?dk9DUG5iRDFsQlVQQVUySjNoWmhza3JsS3loWDljVys5SVJpZVlVZXYwc1p2?= =?utf-8?B?a1BTeGlPbmtFc3VRMXZjUDlKRVFoazBjcHgxbzFKY2dvTDluRW1oYTArL1Nn?= =?utf-8?B?MG1UTVBDQit1THgyOHgyb2FadXlJTnJlS2ZjdVdsTWM4V3NRcGRFMHNMNnNK?= =?utf-8?B?WnZqRk5mdy9LMWpzUVUxcE40VEM5RVVnU1hEK3lLT2hTdXFOdS9YU1dPMi82?= =?utf-8?B?SW43cHVvaWpxNzZzSCtmd3F1ZXFTYndkVnlnSFI0Ri9CY203R3BpYmJDOVUr?= =?utf-8?B?RkNYVlhpRzB2WG8yaGZQeDBRRnI2ZFZQV2NSc1RBWm8vY1RuLzNycWJEVzdm?= =?utf-8?B?ZkdMTnFLbDVPdUF1UHlsSnpvN0E4Q21PMUt3UVlUWTlCRkExNVo1OWl4MnJa?= =?utf-8?B?YWhIa1B1OTd2TVZPcUt1RHpiaDlaSXhZeVl6SU9hblA5QklWYmxtWUQ0QnZr?= =?utf-8?B?anNHNmV5Nkxsd01NL0V1ZWRTK3ZVRUtHc0o5eklMc3hOcWdGQ0ozcCs4Tk9M?= =?utf-8?B?QzZhYTlSS0ZPdzFVbkZ6dHRlL0tPQkM3eWxOaG1URDhQWFBjQmFZRlkxdGVr?= =?utf-8?B?YXdFYzlzdWdCRTRZUmNlSDYxTXo5VTgyRUEwTk9KdXNZcjVPSzFWczgrbG53?= =?utf-8?B?N0xSaEtUaDJVVkVVT09Ibkp2eElrNE5EQ0lDYkhuQ3RzMmRRaGVYQ0hYWi9s?= =?utf-8?B?bitGNzJhVWxSSXVITzVLYnhSVFBPTjM5bHdXWFptN0JrUFQ0VllLY1FOWC9i?= =?utf-8?B?T09XVnRhOGRMS3hKSi9jUjA1NVlON3BVWVgrVVprZWtEVW9OenB2NzBDUE1N?= =?utf-8?B?N004RG45ejJpeFVya0NiZXVjYUxxUVoyK1lkNTF2WEZ6Um50M1RXTkxUdkhn?= =?utf-8?B?azNRZkJDZmpoMmYzbHZnMkhQanlscldpelRBbm9zbmlvSm1scWVBNTYzVmVx?= =?utf-8?B?UERSNkg3QnI5aCthdVpNZnZrRzdLSmlwQ0dzN0l5QU9kWWFLd0pLY0lxYTlx?= =?utf-8?B?Y25EaVIzYnB4b0RnV1ZxQVhWYjVIaHRidzJ5djNUNHdXL0d3dmRRVDY0MDdr?= =?utf-8?B?SHM1OHBJUHBnMzROV0N3Qy9waGRBaXZpWGhaUlpUSXZVcmRINkZIYXFkV0hG?= =?utf-8?B?Q3ExNVpLbCtsQjBzeHNRemR5M2c4OW5nVWVFSUhQZFBYdG8rRzUyNmIrNVlO?= =?utf-8?B?UThRaWN0V0g0QnhwcE81bWdIV0ZXME83VXFMczNLMDRabUs3WUZlcW1iOFI0?= =?utf-8?B?b3YwbVJyMVF5YTZBQkdpcXFzUjBJa2orY1k5MlIxN2dsY2tOSTdZRlBZU05n?= =?utf-8?B?WjNqemVneW4rUkJiZ3lUOWluVFh5U0ZoSXRrM0lFenlseHcxZHVCSzlOa2kw?= =?utf-8?B?MnltTkVmN3U1alN0bmJMRzQ1Z2w3WnFnTzNKSUZWZnNtaSt5RHpRQWNYdTli?= =?utf-8?B?WEhReHNEQTYrWkJ3V3NIWGxNeHFkc1FSeHc4Z2NnWk1IaDVYL05ydjRLMWRr?= =?utf-8?Q?Lct58HSGv4PPoXSX1WPdTKw/I/fRBKoiD4VgLcVutpnf?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 196afa72-72d7-441c-15e9-08de3c61e442 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:47.3306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uvzyjYdZCHIMSy1bkQ0cTQuLcY/TKdZb1Q2l9HR0MNDIhywU+uo0LbMXXQSwb9PS6iwAf7pj97YpgoabIRBwUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 Projection structures are not necessarily (and often not) used in their entirety. At the moment partial uses result in warnings about the unused members. Discard them by allowing `dead_code` on the projection structure To: Benno Lossin Signed-off-by: Alexandre Courbot --- Benno, please let me know if this looks good to you and I will send you a Github PR for this. --- rust/pin-init/src/macros.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/pin-init/src/macros.rs b/rust/pin-init/src/macros.rs index 682c61a587a0..fe60e570c729 100644 --- a/rust/pin-init/src/macros.rs +++ b/rust/pin-init/src/macros.rs @@ -1004,6 +1004,7 @@ fn drop(&mut self) { @not_pinned($($(#[$($attr:tt)*])* $fvis:vis $field:ident : $type:t= y),* $(,)?), ) =3D> { $crate::macros::paste! { + #[allow(dead_code)] #[doc(hidden)] $vis struct [< $name Projection >] <'__pin, $($decl_generics)*= > { $($(#[$($p_attr)*])* $pvis $p_field : ::core::pin::Pin<&'_= _pin mut $p_type>,)* --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012048.outbound.protection.outlook.com [52.101.53.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FCFE31A54A; Tue, 16 Dec 2025 05:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862062; cv=fail; b=m9Tx1VFGDPBQrO+nkJKX7HYu7Yl72hrcEejYynjdhyxIvyZXNrDRSml0u2yX5Wu2tGJ63IIYraAm7dDra+aYY3UQP/5V59Yaef3vxALsHzH9++4D27tHd6Oj3/L5DNQD8bys6CEHIQd9schCBl2c//Xfl2cbmpWPGQCl2SFz8jc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862062; c=relaxed/simple; bh=K+kgq4oAtG2vymXTSK638pIp0Np8YnMGXOSghw2L6zA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Tt/7aTOXmqYjpZ4I0qt6HlNy0VqIVrOikq1bZGkDXzUnM3v8PWJj9Ftffir1aduRhboTgW6Ccf3zt65DnXUSUa0foFB7ScujU80gx5wlRr6QGV5PTQKaRvEz4ODuQhQh41I3BrW1as38bmmXl6k/SLFFiHpc1qj43QRKP9DsP1U= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=mhemXAPa; arc=fail smtp.client-ip=52.101.53.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="mhemXAPa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BfiGZl3qvsAxxvTz1yZRY6dg16++1mzZJ0TIVnjYN3zJFiXmZfRZ7UX3+qRwBg1ZhJ/jDiZz2Dk8rY+JmyPC3o5UOXlBmHabKQ63auVWRZwSGOrQG5JRe8NLhSQ4Z5DjKsLFLVKS9uYePAAp+L4j8PtII8bJQvdKhs2VRS2CmhPN2L9Z1fyjVTAUCgbZYWzu2McnQZwqUTBzg6RCoNFthiPr7Ywj6fVKsmvOB+rQaoBhd8ggmXope/jkw6eTwR+uMnwmFvhs8yzh9apoQM8hSK2cHwrq+YDWEgQMohqa2nS7oSpBODBXlAZ9od6lMwfWq+uO7wYcWSpPoMoWSRPS0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9fkVGuSGwC2afFu7iwk/DAQsxx8L7wJfObcQ3xOvu88=; b=mMqo4WDxzjx0PZEQY4SOQrJmOuWM+SdHWCzKtFiIMnMZEhZjg2buk+94yZjrwovcMigmttxUkO6c9Xd8aYfKBVAEGKNg4qnuuNzC0vzKyFPPwtJIG5fYAVsYDIfmximDnV0x0l9bf4MEvg7ZsiGyS+lQcNfC9wDjFNr/O0+RrCj9yIUSJHRdtQEj535mygpBzrFJUkK/hJ7Ey3+bGUqvsx96lghEjoQclFGVjV0vZyx7Mumh5WBiGNJq6W9D6sVbEWmR0P2tu76Fzw5+CdT5e6hryCZgExHGvZldAHyedD8r/OC80MojeULzrGkvLSjWBBW0v60hs6ythH5INMik/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9fkVGuSGwC2afFu7iwk/DAQsxx8L7wJfObcQ3xOvu88=; b=mhemXAPa9pqDQ8KAERlV5A/XnnwmVrFTPl5D0uV9rJfg7mnQglWJRCxVV6k5Yi7RxoICdeO9Xk7TyjcMgB4pYXwAUIEsQH3RBscsY2kpTJUo+ANwd5+oY/sYzT7GqdVz9Y2HP9KgnQRT35Y9zifq6EqDhFGwG0FvNGQOZvXoASadRxlMEConTeVKnP9S2Ig7NeEnr0LucdTmrvay7+jjeq9I1088MLWq/pvMi1isg/R5zNu56yc6Xd2RKy9wPHzUKJu5zrzR7wXjZ/m0ZtwTx9Qy2kp+epnOJNf2IQPXNxcGSFbfQ+VXcgjYJplxljLvqGPg7EcFdZ7pSx/DkTmHkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:50 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:50 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:31 +0900 Subject: [PATCH 5/7] gpu: nova-nova: use pin-init projections Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-5-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0228.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:3c7::7) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: bcc90c90-0584-4dba-ba23-08de3c61e656 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a0xOQmlaRTJoaDNITHJwM1JleXorcmlJRkd4bFpEWWNBaUl0c0RPNVBreVpG?= =?utf-8?B?ZTdNUk1GdjIySXJDbmdBd2I1RTNmdlpmSFdSd21TRWFKVG83Mi9NeVNqaUhJ?= =?utf-8?B?Uk0yQUsrM1JrcGpGSE14eTlPZVJuaVJIc2ZHNDBKSEtDZFU3bzFIa2xNakdY?= =?utf-8?B?cXhqR2Z3MVRBc0pEZlB3c2tKbVg5YmhSUHB2OHd6MXZDUkpIc2hLS2MyL0c1?= =?utf-8?B?dlp3N2ZSb3BwblBDOFExWTU3NEo0SDNzb2JBMzJhcXlXMkFlTGU2N29IR0R4?= =?utf-8?B?UnQyTm1oelhGaDVKdk0zN01DYWR3eE04SGNQSm96TVVHejZSVmlPVW5ucFUv?= =?utf-8?B?L3hReEsxam5HWGZiYjF2NUZtMUJwaHdLOTZXTktwS2ZuOVNhQnhGRkpubzFY?= =?utf-8?B?c2JEQVpNUHlYMXE2VDJ5ZlFheGN5RnBPWHN3Uk0yQzNSVmk5Z1lLT09pRHhQ?= =?utf-8?B?U2NyVXI3cFJWbHFIQS9DUkdxM0laYTQ5MnZQZnA1V3JDSTZRRmtoUGdPZElF?= =?utf-8?B?VjlJaElWdVY1dzU1cURTZlNIdDIrMkVHVVY4d05NNlZKS3ZZNHExWFJqZWtm?= =?utf-8?B?bldkR0MybVJzM0NiVVo5MEJVcTFBdmh0d0dROHBxSE5KeEtGdm8vNkEzK1VV?= =?utf-8?B?eGZ5eHIwN2tsUXcrLzNtUUM1ZG8vODN5dzR2bzBrWDFXR0NiNFNtZUFzdi9q?= =?utf-8?B?NjFLVjdOaVc3TmZQSktOWjNsZE5ROWliVXplV2JxOVhncG5tV3Qwd3RJbG92?= =?utf-8?B?a0Z6SE1OTERCQlRZNjFLOFUzUS9KU1hWR0VTbXcyQU1KUVYwMGxCRXZZdm1D?= =?utf-8?B?ZzZZZjhSb0w3TFA1SWtiYlFPcWxyUnB5bi9nTnA3a2JxRjVLQk5Qd0YvekxH?= =?utf-8?B?NTA0TzF3QjhUblBpMTBGNUhYRU5NeWxSR0Z5T2xnL1NZV0JCRWlxRTIvdE1X?= =?utf-8?B?dm1JQWsyUXFFNVlON1FPWFdNNjVaUHFZRWFvWXk1blJTdzNSek5wVXV6cmFR?= =?utf-8?B?VytGYTFubW0wZ1pvVC95a2k5STlqa2FHZlVVdG9ubHkrelFablJrTGo0eHRv?= =?utf-8?B?Q0hkcHhQQWtoeEdrMWNKOS93WkNSdDdzK3pNMXpOcG42bUdTWnZIZWt4Mm1S?= =?utf-8?B?dzkreDRLTFBKZ2NoWlY3ZTh1RTFuMnZWWVJKY1Axei90YVM0ZG13T2xEaGdh?= =?utf-8?B?SFNJa2NTcjZ2aVBrbjhFVU52UWF3YWJJV1c3QUs2cXd3RmplYjZyalIzUTMx?= =?utf-8?B?b2hCNWVQM1FVRmYrTDFiSHhDN1VZTEdUbnhlL01KazRRWmJmcGYreEtkc1hQ?= =?utf-8?B?dFBHdHhaMWZZNUVya3NtcTgwWW1QdDlvSHc5ZHIyOHdsZ1ltS2xhU3AzTTRj?= =?utf-8?B?a3czK0wvdkoxNHg4eFlqaVNONlZGamROS0RBdFdkaDhOZjM2OHZ1NlZFZVdw?= =?utf-8?B?Vjdna3A4aUZFR1I4QzNCZlp0TC9tVnE3QkNMVExON3JWaFZtQTRHOGdFbm13?= =?utf-8?B?VkNIRTVMdk1rOURpRDl4bWFpbWFueXo2WnR0YmdZWXJFRDlKc2ROMTlpWk5F?= =?utf-8?B?SDE4Q2xaVCs4UWZmRno2MEEwV0IrcEtYT2xwb29yMFRlTzhSZ2Z3dk53WFBq?= =?utf-8?B?VWJZQTJpVERHck91Tk1CclRsSVRhRE9OeXNrMmpicmgvQWNqV2VlRS9WOGFY?= =?utf-8?B?R2dCSmdwbnhhMTVnejMwMlArdzFZZXRUS2diVkhaNC9qZDBSTkxJVVBYdzJy?= =?utf-8?B?OXB5cnBnQTc4amMwYU5XR1RZb2FGMUh2THpsbGpvZDh4cmJwd0swTEFQQVFj?= =?utf-8?B?VFlUMkxqdnZJNWtwNWE1MUFBUno1Ny8wamlhd0lsQ3ZNTkNTWnp6c2FqVlk0?= =?utf-8?B?N09OMkhkMnBqaDR0TVAxd3hWR2NWZGlQNVVNcFBoN2N0eWVJOUVHUFppWTZZ?= =?utf-8?B?clI1YUlvMnRaTGdsc1A0TG03ZU94KzArQm03djQ5Rm80bi9TUndwRkhTKzBP?= =?utf-8?Q?zOJPGWegK0rqRG19oh8a6/60yRLvKs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnAvMjNJUWdaU3JGNXJFcDhQNFhqWmVPdXZiK211RmxkSUxRb0R3Z3NiV0Ju?= =?utf-8?B?VEg1eE5NNzMwVDZyMGN3NTc3WnJXSjdIbkZnUUcwckVBN1dTYWpuanljYXZs?= =?utf-8?B?U2JGOUxBSEIwbkJuZ3psdVZ5K1FjRHJsbXdwRCtRQ3pNS1BLSlh5KzRZOVlU?= =?utf-8?B?TnI0U2N0REFmY1hOYzlleHBpS2wza2h6RkRCR0k0ZmJrTmlYbDVoTTNzaFhF?= =?utf-8?B?ZmRzMVlsYjRIdWw4cThzNmp5ZVpHcVYvSzdBNkptYjlSZVRPOGxBUzRwZWxh?= =?utf-8?B?aVYzcllRU2NUV2RiaXhXdlMyK2oySk1jbEhsbFJyRzhZSFdZbzlaTnE3bEtl?= =?utf-8?B?MzNoN1BVcGVDZG1FVFVud2NhWElyem1hMkN3WFN5czNRWGRpMnhaNy8zZmVQ?= =?utf-8?B?ZktFTXdlOWxwNHI0Nm02RGVzUjBHNzllMjBCUGRVTXFWeDc5dy9DRFNiaUFu?= =?utf-8?B?QXZ6SDZ3ZTJYem5nUWZ3QUxRcUhFQ3hqWVdWK1MxbmZycndFcS9uRjVXaEZx?= =?utf-8?B?b1lRSW1RT2VkdWx1QmlpdEJuUUd1L0pveEdCMCtOZUVIN05YNWxSU1JkUytt?= =?utf-8?B?Qm1xWk83VXZiWTlKdFhrM1dPcnRTTldYbUk1Ukc0M1oyaUtHZC91bUJMb25w?= =?utf-8?B?WXF3ZW85RW15WlZaMlUreUhORmE0eC9wcHc2anJxZHMvaEdlM20wc3BCdnZO?= =?utf-8?B?cTlsTTE4cFVoZzBoZVZjS0htU3kwWHlnY3JFZDNTZzRhMDk4RjZYcmthcjdm?= =?utf-8?B?aG5VYUNVeHZRcHVCeG9nODUyWGRML0dIaVUrd0t2Vi9kS1pLUFpra0trbDV6?= =?utf-8?B?TWQwVXFLai8rQmp5TjJXSTBBNi8xaUdlMDQ2SVZjbVdYK0tZdEIyWkRoYnpl?= =?utf-8?B?SlF4OTdDMlpUaVkzSjc1QllkRUp2dysvTE9DbnJ2SnNkcGNNVVhlWVZRc3Uy?= =?utf-8?B?RDh0cm9XZWJMRkZoTFlkd1dSSXVRc3JMRmRWb2ZWcFRNSllkYkpCT1FaYWtT?= =?utf-8?B?YTVITGF4aGFyR1l6a2NYSU9qN1JaUE1ETjFta0hRN2xOL3M4ZmNDU1RJek1U?= =?utf-8?B?Y2dKOW1zWWp2ZmRHenBwSnFzQmZKdHlTbEhETWp5MFRiOERVeTFmanZ2ZVor?= =?utf-8?B?WCtndU5RQk94NkpnT2kxdmtiVDBlUFplY1Z2eThpbmxNaFFReW9wbi9TaGYy?= =?utf-8?B?SHRXN3VxUFo0K3JVVi9xL0FSN2NGMXZRb1V3b3dLZzk5ZDJCVVBibHczYytK?= =?utf-8?B?MHVhZ2tCREJlc0FQM2tLOWlXb1lhN0o4cHdYNEp1SlpJOTFFWVVUTEUyKzNa?= =?utf-8?B?elpUc29yUjJhYnRrT1pnblY5dHFjYkVUSFNKWitmV044L2gyQzE0MHBkZGZJ?= =?utf-8?B?dUhudFBJeGN5NlpESmtZSUlPWGVuQkM1eXFwWW1aRmsvTksvcmxtRzBZOG04?= =?utf-8?B?S3lQa3hIQkQ2UWxQQ2hjMktpd3JOK1hLSkNzMHJSOWJZV3NOU1l4UTZLRkNn?= =?utf-8?B?djl4Q2QvU2NpSmZMdHorZUhMcHJWRTBJZWpxVURmN1pnQVB2VENZWWxXeXlP?= =?utf-8?B?ZFBPVElEaUxVeG1RbE5vOUJpOUpQb2pNUGY3cUxsY1plOE5QVVpGb1JjMXBo?= =?utf-8?B?R1hud09tT1p5M2xZYmN6SmdRYWRDZUNWWU5BQ1VCUE9SdEhMazkrai85MUNs?= =?utf-8?B?VTdFck9rU0RhV1VmU25BR0RyRnhVQ296UTRtemsweDJNbE5LNnlXWDg5ZGZQ?= =?utf-8?B?T2lDT055NVFjYjNTZllIQ0Fsc0lJcUJzeVJTNm4vMjlYbWRCb2RuelNWU3ZT?= =?utf-8?B?U1IyWXRWVEl2d0Fpc3NtYzJpZ1RKYmpyOC9UNUtycGpUTG5ZRnA0eHRpdjdh?= =?utf-8?B?cHU0dG5QalpDeUpTYmpXaHBFa2FraGRrSldwTUZ6OWRHTWFrcjlnbnBuYXBs?= =?utf-8?B?QU53a0ttNi94R3M4NzY0NFprMTI2OVhEaitrMDNtcGpCRkY0R1lEcE1MSTNw?= =?utf-8?B?azk2aU1vOC9xaVFFQWp2dXdwajJzNlBSU3I1NWw5d1A0OVZPcmEvbDRNTE9m?= =?utf-8?B?SnFVWXRsajZIbXpVSFZNSnFLV1Y3akZPNzRZeGIwZDVGOWZFZnlpaXpUb0Nz?= =?utf-8?B?aXNaSDR5QlpKd3hCQmpqR3dTVVlOeFlpRzVIajUwMlpCZ280S1QwUFRLeTJT?= =?utf-8?Q?g+93b6Ccb4fmOU+FEZ8ZO3eAKCSBtdCsjzfqm3c45TGX?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcc90c90-0584-4dba-ba23-08de3c61e656 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:50.8387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVApp9x/ql+iQJl380NOsA9OMZgNKEfQZHmZllCSd+d/mnZGu+c0GNU6mo7NtiVzrMarE68UN73hNjGCip5b8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 Unbinding happens on pinned data, but some of our methods still take mutable references. Right now we can rely on the fact that `Gpu` is `Unpin` to get a mutable reference to its members, but this is going to change when e.g. mutexes are introduced. Take advantage of the `project` method of pin-init to obtain pin-projected data, and update our methods signature to work with pinned data when relevant. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/driver.rs | 4 ++-- drivers/gpu/nova-core/gpu.rs | 8 +++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver= .rs index b0e3e41ae9d8..c53e96173890 100644 --- a/drivers/gpu/nova-core/driver.rs +++ b/drivers/gpu/nova-core/driver.rs @@ -98,7 +98,7 @@ fn probe(pdev: &pci::Device, _info: &Self::IdInfo) = -> impl PinInit, this: Pin>) { - this.gpu.unbind(pdev.as_ref()); + fn unbind(pdev: &pci::Device, mut this: Pin>) { + this.as_mut().project().gpu.unbind(pdev.as_ref()); } } diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index e16d3c2a6b38..ef6ceced350e 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -292,11 +292,13 @@ pub(crate) fn new<'a>( /// Called when the corresponding [`Device`](device::Device) is unboun= d. /// /// Note: This method must only be called from `Driver::unbind`. - pub(crate) fn unbind(&self, dev: &device::Device) { - let Ok(bar) =3D kernel::warn_on_err!(self.bar.access(dev)) else { + pub(crate) fn unbind(self: Pin<&mut Self>, dev: &device::Device) { + let this =3D self.project(); + + let Ok(bar) =3D kernel::warn_on_err!(this.bar.access(dev)) else { return; }; =20 - self.sysmem_flush.unregister(bar); + this.sysmem_flush.unregister(bar); } } --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from PH8PR06CU001.outbound.protection.outlook.com (mail-westus3azon11012041.outbound.protection.outlook.com [40.107.209.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14A72334C22; Tue, 16 Dec 2025 05:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.209.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862075; cv=fail; b=Z9A+ZNtx3nY9iLrZEBlMarbXyCUMbSYSuCgmEWZ1rUMBVmkU/YtHEFxNFt7PMj7yr/5sVkyH6lwVm8Khyw1hi3I9O6ZB5lfygIIChPApk3tNlCaREir77UchsPwuK8wJ90k54/EL7+MODneyy9DRFRzpdCyFm2w/ASG6/n+AJMY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862075; c=relaxed/simple; bh=fqeL8OdSB94HaFpA08NNwhWrPA04Crx+49V4C/3YK3M=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=mSpvtoy4NMYC2430ufT6BKEb75NqXiIOQEZP/K97uniuH32crRzTW/Tlm9tAKf7qJeiXy9Aco01qqmoPP4w0W2uYIBq2ohWstPNDWiiYoeKbSx+sbBjzLBfOf1HlMSi3WB9gC+vykGp0t31172DyZGTvmKdUvJAaMFWg7x1GuwI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=lymxoruU; arc=fail smtp.client-ip=40.107.209.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="lymxoruU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=GznuBMt7HvJVTmut+7o4xi7uJ5enPeujjqIkAV5xmvb9jIxhiSivBsP/rQY7dQKWl972syKGN4amEJTYoQFzF9LalZ/usAHrR7D1eeLh70vfHjlC+DT+96sA9rvN98sss6JzZjCp/QrV1it+QC0kQFVBtVe48fgTe+zMAdyE8Cf9R6lgtEDqTZQEDBbAj3TcGiJK3z3iCTBVyJF2x984UZsw8h1pep/rnniOL05CvAmZTmP4wmprUjaYbdkSagKllgBOGL6goshR3zBZrskPM+dfIKh6anL40+uUiQca1Dfzws8hlMpDcAuUrqAeQ+RzpuXkkXKU9gV5JncNGBEvKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/vhbfZZwzZliNSdPtJ7DBOuGoM7eUMZTAzXKb28sPB0=; b=ekjS+35KPfrWk+jh4tAUrcXjxlEnHDmspJtvA/vgxlAFQMEg71KV+5yCJ5D8NGp94ot/HYCrSi0w0UXbnDzUrF/n5Gb6kdDilvEMWvK19pNYelow373J427IAS2x/oM6rMIt1UJUk5X4ct3QBluieMhncBaAEpVcqrUnAZZslAi98SAuGxilGek//wxkzJp8HWmbshZFHR+Xq/WyFKfJe8Z+YogKAh5qym0hdhxlZZ2LORYZytUojln2Xrj4Kh7xCIe5SP8eGqvSuNk9wNmldB/d/wE/xFNiLIrOtdkAlS7+OFeyf+qKjFa/DIcKJObmKDNqC46sNMRdloZqcvsccw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/vhbfZZwzZliNSdPtJ7DBOuGoM7eUMZTAzXKb28sPB0=; b=lymxoruUj0MXDijmFb+bKCtUcKQLwje8kfc8mfAWUfF8wF8tAjD1s9twU08QOXgq6coxcU8i2by+nB4QGw7W8UE436a9JuFvaqRjhlGF5YmVs2uWwGv+NnE6PjYH2kj9r30/SMWIOMLlOdOStRdUa6AXM5r/hc5HoaMl/WzNMVVmoBay16p1Zc7dEdMDWUmF6EFnFg9b40l8utU+Tv8UO9VcL0vadMhAiDiJpM0rdeM/cZ1UGox+cjiaA8DH5xzSTJNkfDbqSakUF1RHUrxRvXFb4kSbH8wscyPWoz5+C3R3TZhzF941ccdjPQsEW4lxBc+3pioZJ2/Fe7wyAg6Mwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:54 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:54 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:32 +0900 Subject: [PATCH 6/7] gpu: nova-core: send UNLOADING_GUEST_DRIVER GSP command GSP upon unloading Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-6-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0046.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b5::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f170b89-10ea-4a82-1931-08de3c61e892 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z0JIYlNKK2kxbEdjdTRidElvdHpLUkRXTk8rRWNEOWMvSkpPWXFJaU5QalpX?= =?utf-8?B?TzJ5a043MEVGRkZIdjhSTzVXc2FqR2JOQVNPazJkZ2lnS1kwYlFZY2FZR2lG?= =?utf-8?B?MXJtWkRUNEtxUmI1bGhLbFE4dXVGZDZydGRuRlJwRFJoNmxSTlVjeVFEM2E5?= =?utf-8?B?cS9jWlMyQUJnbk1IbXI5cE9ZNmFabVRwelVUTGdKb2Q1NVd5WWcxMVBFR29R?= =?utf-8?B?TWlMd3lidjhHbWlNUTUveU5XYzVGbVVZSHNMWkZwOURvelcyR1ZNSU16SjND?= =?utf-8?B?YTFMSEtyalJxWFcxd3k0dmo0cm9IUDFQUjEzSUkySjNpdlRieVFsNUhJWWNF?= =?utf-8?B?a2VDeDE1UEsvZVBudmRoUk9hNER1L2JBQ2MwSlZRL0Ewems1cXpoVkVKaHpV?= =?utf-8?B?dkpINUhvTDVFKzRVUDBMVGlLKzJOY0lERXVaY2NabVMyT0tJZEZ1VUxFSHVx?= =?utf-8?B?a0xXOEsveS95WFc4aVBwSU5GQkdJWkNuL25pQzF3UHRtVWJBMHdvQk4zczdq?= =?utf-8?B?ZTRsWS94UGhCRno3UDZ2d3dvVDk5bDlBbER4VGkwNnNIdENhRG1KY3dCZ0Ew?= =?utf-8?B?R1ZXdUIybnFMSmd5M25oRExFUWUwMEdEcmJVeEIrd1FkMFluNFZta1k0MVVE?= =?utf-8?B?c2NEQUpXanhhdjM0RFMzdVJhTnd1cDdRV3Foc3RGT21acGt1a2ZCcVFuWHl6?= =?utf-8?B?c1doY3NPUDdjV0RacmhWT2VXekNIekhRd25Wb0w3NFJ6cTFrWDhPSDh3MmEx?= =?utf-8?B?dEhpTzN4TXliTHZud2Job1p2QUNKVWV1SkpIRFJYQm9LOWNkZlk2VGJYa0JX?= =?utf-8?B?bGZ6TEZtd3A2Q01tMjBQajE3T1BPOUI3M3d0V1hJYzhCa2RDdUNNYm8wWUxs?= =?utf-8?B?dGRwQ3FLSUlFUWNDc2VDa05UZGwrM3BtTURvYTNZYnFBQ3FXbDZkNHovWnRt?= =?utf-8?B?TEVtMmcvKzd6Q2ZTcSs0QnJpT2lXMGVFcnI1V3N4NlQ1a1BYNmV2TUJuUWxn?= =?utf-8?B?cWtxaHhCZ2xuMEJXdko5RzRINlBhQllYb3BIOTZteXY4NkJiRVV0R2E5dXN0?= =?utf-8?B?b3FVUnFBQU51Z3NKNlhSNWsvNnJEdTR3dnRSZm0wYndJRkpSMU1WRytDN0Nz?= =?utf-8?B?alNSb3JXaTd1UUViUHMxUkwrNTEvb3RiUnBrUTZoWHo5ZjNIS2lKSnNCbm9E?= =?utf-8?B?QlZydHdnejk5SUE5T0Q5azhNRm5HR2N6UlluaDF2VXZQR0Z6UW9rQ3QwWXpr?= =?utf-8?B?K3p0SlRWaVBDWlVaTTdoUTZ4d3dwL0pYWFJEZElLbEI0bW16bTBSLzREck10?= =?utf-8?B?aXhHQkdyd2RjM3d2UDFmOEpQeVFUT0dsRVkxc2VlTURSclZhVUI2Q3VMV2ll?= =?utf-8?B?Sk1qZGZ6RTV0aGJFZDViUFA1eWlrQjU1bFpmOGs0Myt5L2xkR3dQYWJzKzVn?= =?utf-8?B?OXgyTnNsVjdaSzRqNGxlM0JHeTA4aktaRlJMS1pyWFpUYVpLNjhlU21Fa3Zh?= =?utf-8?B?YlBCY1FnRzdKYjJ1bzEzbE9xS3kxMGdkMHd3bDZJK2ZkS3lLYjhjanpBU25x?= =?utf-8?B?Y0VqMndyRmtQYXRvcGpxekFKLzM5ZFdjYUZ2Q2luODlvZmFXZGQ5L1NoaU5I?= =?utf-8?B?akRMMVFiQmtuOGpvSTFRZTlhcE1Ybis2T0ZFSnNZOUUyaVVCV294cHRMWVR6?= =?utf-8?B?dHh0RVRaWjJ3VHA3WHZmdEs0eVJsekZaaFNjci9QM0pYVXdIeEtBVFVXenc1?= =?utf-8?B?T2VzVkFmTVlOSHZKKytrRTdCaEsra283M2hiYnRHNlNYTk9IbFV1VFk4bXE0?= =?utf-8?B?VTcyQytkeU8rU01SemZ6NWdoWS9DWlFyOTJybXNTLzlNR2VXVlVBcXVVUkI4?= =?utf-8?B?ckdSVDNsSnloSy9NbkxzM056NE1jQUNSeE9jRkpuRFEyekhuY01WYnZsM294?= =?utf-8?B?QzNEK0MxdU0zS1A3ZElWOFJ2by9zZUt0TnlicDg3ZmlMMXU1MHFVU01yanFT?= =?utf-8?Q?mljaQqYteLnsf8gvfhWP4+p9hxAxjk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SStWaDgrZjZNZTNuSkFEaEpldE5CUXZDcnRZbkxkNml4ZkJiZ0JmenVFQ3Za?= =?utf-8?B?Q1pZaFp1d3ZYbE9XQUhLZmhKQXltelcvOVlrZ3NlNDFGVkV4QW5sYVVaT20y?= =?utf-8?B?RWI0MTFmcGM3MXpVUXNrSHl0K1NTYjJBaXdEdFdIRlVxRmtKSDY3Y1Bjbitu?= =?utf-8?B?TnEzejJsM205MTNmai96Q21IQ3pOaW5xRmwzVU1nSE5hZXRlR3ZzUnd6azRv?= =?utf-8?B?REtCTFVnK3Y1Wmh4bnNtYVBuL24xbmkxc0xQdFBYWkNFdmlYK0NjSUkvVjlY?= =?utf-8?B?WkxFL1I0UW5xMFhzT29tY3dwMTNWQkZYLzMvalJoTmFOaWNKSkdWK3VROEQz?= =?utf-8?B?Q3JSckp6cXFhSTNYVkFwejU5MkMwbSsyTWJrVHRTVGE3bW9GdDFMN3R1c0N4?= =?utf-8?B?R1BNTFFNRHBLNzZrK0R2cnA3VE5jdUFuS2ZqQ2pQaFQ5YlFLbzZSRnBCUlBU?= =?utf-8?B?eGZINU56d1lIcUVGRXNnZG9VckhCRlduUXIwa1Z4ZXRJLzFpVGpCb0JVY2NS?= =?utf-8?B?aHBpWlNSNWEzNEJWQjZYRTJwSzlBci9SNnZBQ3dOejBWRVZsL3hiTlY0TEdR?= =?utf-8?B?alAyUlVscEpmSmt6cW1PVWd4WTc2d1crRjdPcTR5S2huVVd3bHgwbjdxMUxP?= =?utf-8?B?Tjc5OWVWZERXMVNoV3JJRVZTQkxjNlp6dlBPeWFGdlZJYjJTNnJSODlxR2tj?= =?utf-8?B?Vm5KYW1TRGd4UldONWMzQ1p2bm5sRW1CWURZaUVYS1dnUWdQSzBHRHZ3QVhP?= =?utf-8?B?UWE4WnFUYTlCY29aTmdEK0prWWlYcExEcCs4WTJ2c3ZIUGV1elJqT2xKREJI?= =?utf-8?B?NXg3NXBFOUFqR0lQS09SWUxISGVLUWFQWEdSYVd0SUdKd2lwUkJrM2dTK2gx?= =?utf-8?B?Y2JFd0tZbzhWV0NNanlyTVRkZE5STDF1aXprMmMvcVd2QTFpU1NBZjUxcmFS?= =?utf-8?B?b3JpWnQ5QzVBOTBzRFZvYlFEdXVRNzhOcFRnWWZJcnpScnFwRjBuZUEvTmV6?= =?utf-8?B?dlI4VWpkLzk3YW4xZncrTXZHTjQvY1orWG1sUEFmaFc3b0czc05mcENRSXlX?= =?utf-8?B?Q2pVQ2lhWTFhR3RYNTBoYnNVa2FTZXVQd3ZNdm5OQ1RkVWhNNHdIOG9aWUIr?= =?utf-8?B?L2ZqUTdHNWFFTHZEWGl4cXlSdFNYa1lKaXJuRzdvSmpIYlp5ZUJ3enp0cDRq?= =?utf-8?B?TkdTa2VCL0Nwbm1keEdWWDhpa0w4cVBhTUlORmR1Q3Uza2xIMkRjVjFuYjVC?= =?utf-8?B?ay84OFdQYUY4LzR5TTc4Wk9ETEhPekVCWWpEWHR4RFNJTVpkb1ZVNmZvZXRv?= =?utf-8?B?MGY5OUUvWXJMRjJiL3Qxd0lzWGhjMWJpTDhKdjBTQTJoU2hTSkhESGZOOUMw?= =?utf-8?B?azNFdWVEdXVNU2psdCtVbDV1aExTWHVLNStkYVdKSHZENElLemZETVZrYlhK?= =?utf-8?B?NE5pWnpRQ3lVakZ6emhqd0lLVjVaTUlCMnBHc29qRG84WXphdVFrN0NOd1pL?= =?utf-8?B?U2FyVHRxcTROTjNsNTdzZlNycXFKU29LUzRXZ0RDSVVrNTFlUHVJTkcrNDQ3?= =?utf-8?B?czV2SFBpaUhhN1VIZEcvZW0wajNMdmlqRDdHZnBCSjJaYSsrODVzZ28vREJY?= =?utf-8?B?QWRBcHFxeDZZOHA1a25ZWEwwTStrK0tpRng0eG10bGRhcGJNRkVTYmpscDcx?= =?utf-8?B?NFVSTDdEMFJ3enJ4UXNkOWdqRlIrU2FTamR1UUs5d3NkWHYwNlVrT3N0c0Vi?= =?utf-8?B?OWdpQlpnTjR5bGpDQzEybUwyZE9FOTdJSTZ3aXFMSFFJbkhHM3hrd0UzK2Y4?= =?utf-8?B?dmRKOVZTVUd4R011cktrRDhRd1ZrOUd1b0o1ZnB6Q1ZWQVlERXJQTithd0x5?= =?utf-8?B?NXo1V0ZtRGx2aGVzR1A5REsxNFFTaWozYm5RaFgzTlpVSjJzaS96ZVM0YmNX?= =?utf-8?B?TU9KMlpqYUdiTjR3OHV2ZXUweXplUm1pbXlMRzFpbFhOMFptZzQrd2NkQ0Ez?= =?utf-8?B?eXEyQjhIellaVS91VUlmWFZxRFVqYzZiUkZKc3R2M1BuY292a003Znp0ckNM?= =?utf-8?B?UTdqNlg0UmZLQTMrRG02bzV5aFFSakFySW1NcXU3WjdibTZyK3pLSk1uL0o5?= =?utf-8?B?RTZaOG4rVWk1b2l2QXI2OGE5MUtUdmttbHlVTTJYdlFkelJhNHlZUDBhMlVj?= =?utf-8?Q?06XeCHoGmZWPhvAM2RLz9Ph3q1pV7d7KOtlBKqcJNVOp?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f170b89-10ea-4a82-1931-08de3c61e892 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:54.5706 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cbb1kqCh1kitOpCkZCyYZrJndn9J9Suiltercw+62v3mO9nLbuziX+PxjcP2QCNLdfdSQgiVPqGeU31KTZKscw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 Currently, the GSP is left running after the driver is unbound. This is not great for several reasons, notably that it can still access shared memory areas that the kernel will now reclaim (especially problematic on setups without an IOMMU). Fix this by sending the `UNLOADING_GUEST_DRIVER` GSP command when unbinding. This stops the GSP and let us proceed with the rest of the unbind sequence in the next patch. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gpu.rs | 5 +++ drivers/gpu/nova-core/gsp/boot.rs | 42 +++++++++++++++++++= ++++ drivers/gpu/nova-core/gsp/commands.rs | 42 +++++++++++++++++++= ++++ drivers/gpu/nova-core/gsp/fw.rs | 4 +++ drivers/gpu/nova-core/gsp/fw/commands.rs | 27 +++++++++++++++ drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs | 8 +++++ 6 files changed, 128 insertions(+) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index ef6ceced350e..b94784f57b36 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -291,6 +291,9 @@ pub(crate) fn new<'a>( =20 /// Called when the corresponding [`Device`](device::Device) is unboun= d. /// + /// Prepares the GPU for unbinding by shutting down the GSP and unregi= stering the sysmem flush + /// memory page. + /// /// Note: This method must only be called from `Driver::unbind`. pub(crate) fn unbind(self: Pin<&mut Self>, dev: &device::Device) { let this =3D self.project(); @@ -299,6 +302,8 @@ pub(crate) fn unbind(self: Pin<&mut Self>, dev: &device= ::Device) { return; }; =20 + let _ =3D kernel::warn_on_err!(this.gsp.unload(dev, bar, this.gsp_= falcon,)); + this.sysmem_flush.unregister(bar); } } diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index ca7efdaa753b..e12e1d3fd53f 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -32,6 +32,7 @@ }, gpu::Chipset, gsp::{ + cmdq::Cmdq, commands, sequencer::{ GspSequencer, @@ -231,4 +232,45 @@ pub(crate) fn boot( =20 Ok(()) } + + /// Shutdowns the GSP and wait until it is offline. + fn shutdown_gsp( + cmdq: &mut Cmdq, + bar: &Bar0, + gsp_falcon: &Falcon, + suspend: bool, + ) -> Result<()> { + // Send command to shutdown GSP and wait for response. + commands::unload_guest_driver(cmdq, bar, suspend)?; + + // Wait until GSP signals it is suspended. + const LIBOS_INTERRUPT_PROCESSOR_SUSPENDED: u32 =3D 0x8000_0000; + read_poll_timeout( + || Ok(gsp_falcon.read_mailbox0(bar)), + |&mb0| mb0 =3D=3D LIBOS_INTERRUPT_PROCESSOR_SUSPENDED, + Delta::ZERO, + Delta::from_secs(5), + ) + .map(|_| ()) + } + + /// Attempts to unload the GSP firmware. + /// + /// This stops all activity on the GSP. + pub(crate) fn unload( + self: Pin<&mut Self>, + dev: &device::Device, + bar: &Bar0, + gsp_falcon: &Falcon, + ) -> Result { + let this =3D self.project(); + + /* Shutdown the GSP */ + + Self::shutdown_gsp(this.cmdq, bar, gsp_falcon, false) + .inspect_err(|e| dev_err!(dev, "unload guest driver failed: {:= ?}", e))?; + dev_dbg!(dev, "GSP shut down\n"); + + Ok(()) + } } diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 2050771f9b53..0bcfca8c7e42 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -225,3 +225,45 @@ pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar0= ) -> Result impl Init { + *self + } +} + +pub(crate) struct UnloadingGuestDriverReply; + +impl MessageFromGsp for UnloadingGuestDriverReply { + const FUNCTION: MsgFunction =3D MsgFunction::UnloadingGuestDriver; + type InitError =3D Infallible; + type Message =3D (); + + fn read( + _msg: &Self::Message, + _sbuffer: &mut SBufferIter>, + ) -> Result { + Ok(UnloadingGuestDriverReply) + } +} + +/// Send the [`UnloadingGuestDriver`] command to the GSP and await the rep= ly. +pub(crate) fn unload_guest_driver( + cmdq: &mut Cmdq, + bar: &Bar0, + suspend: bool, +) -> Result { + cmdq.send_command(bar, UnloadingGuestDriver::new(suspend))?; + + loop { + match cmdq.receive_msg::(Delta::from_se= cs(5)) { + Ok(resp) =3D> return Ok(resp), + Err(ERANGE) =3D> continue, + Err(e) =3D> return Err(e), + } + } +} diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 09549f7db52d..228464fd47a0 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -209,6 +209,7 @@ pub(crate) enum MsgFunction { GspInitPostObjGpu =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJ= GPU, GspRmControl =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL, GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, + UnloadingGuestDriver =3D bindings::NV_VGPU_MSG_FUNCTION_UNLOADING_GUES= T_DRIVER, =20 // Event codes GspInitDone =3D bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE, @@ -249,6 +250,9 @@ fn try_from(value: u32) -> Result { } bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL =3D> Ok(MsgFunct= ion::GspRmControl), bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), + bindings::NV_VGPU_MSG_FUNCTION_UNLOADING_GUEST_DRIVER =3D> { + Ok(MsgFunction::UnloadingGuestDriver) + } bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE =3D> Ok(MsgFunction:= :GspInitDone), bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENCER =3D> { Ok(MsgFunction::GspRunCpuSequencer) diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-co= re/gsp/fw/commands.rs index 85465521de32..c7df4783ad21 100644 --- a/drivers/gpu/nova-core/gsp/fw/commands.rs +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs @@ -125,3 +125,30 @@ unsafe impl AsBytes for GspStaticConfigInfo {} // SAFETY: This struct only contains integer types for which all bit patte= rns // are valid. unsafe impl FromBytes for GspStaticConfigInfo {} + +/// Payload of the `UnloadingGuestDriver` command and message. +#[repr(transparent)] +#[derive(Clone, Copy, Debug, Zeroable)] +pub(crate) struct UnloadingGuestDriver { + inner: bindings::rpc_unloading_guest_driver_v1F_07, +} + +impl UnloadingGuestDriver { + pub(crate) fn new(suspend: bool) -> Self { + Self { + inner: bindings::rpc_unloading_guest_driver_v1F_07 { + bInPMTransition: if suspend { 1 } else { 0 }, + bGc6Entering: 0, + newLevel: if suspend { 3 } else { 0 }, + ..Zeroable::zeroed() + }, + } + } +} + +// SAFETY: Padding is explicit and will not contain uninitialized data. +unsafe impl AsBytes for UnloadingGuestDriver {} + +// SAFETY: This struct only contains integer types for which all bit patte= rns +// are valid. +unsafe impl FromBytes for UnloadingGuestDriver {} diff --git a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs b/drivers/gp= u/nova-core/gsp/fw/r570_144/bindings.rs index 6d25fe0bffa9..212ccc13c0cc 100644 --- a/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs +++ b/drivers/gpu/nova-core/gsp/fw/r570_144/bindings.rs @@ -879,6 +879,14 @@ fn default() -> Self { } } #[repr(C)] +#[derive(Debug, Default, Copy, Clone, MaybeZeroable)] +pub struct rpc_unloading_guest_driver_v1F_07 { + pub bInPMTransition: u8_, + pub bGc6Entering: u8_, + pub __bindgen_padding_0: [u8; 2usize], + pub newLevel: u32_, +} +#[repr(C)] #[derive(Debug, Default, MaybeZeroable)] pub struct rpc_run_cpu_sequencer_v17_00 { pub bufferSizeDWord: u32_, --=20 2.52.0 From nobody Sun Feb 8 06:04:16 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012048.outbound.protection.outlook.com [52.101.53.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1F2D32E69A; Tue, 16 Dec 2025 05:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862072; cv=fail; b=emojL0N8AOW4x+E9c2XQ4ZF4i1x8YkCxbMq/VhzTINqjw0TgJva+gmwj+GjahS79OQ1vVPYhDWJajqAIIbLht7ZWjdNWi6AzV9sA5OG1xwEGe5qZljHEZwqgLVhISuPkGl36e8aF2jDO1OmBskm0dNfSaMmcLiZexbfHaah7Kmw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765862072; c=relaxed/simple; bh=qk8r1GsPY0gqIVxuTnEJzyXHQuNx+WqftV5isQDySZE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=l83qkybyS7WHPLE/PJU7aIITNBROXlHU+i3wXxXkkpHDn5MOjZn4AJi+WQZYLs6BSCbQjxEcPS6d9C96MdrrHO1JYW5ir5CVq0jwK3Iq0K/tUi/9hneYSnOkd2GWX1DCXpHoPi59CW2FLCJJKrOzqvTL6n5a02AP5GHzbmGpIrI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=bu1QoUHN; arc=fail smtp.client-ip=52.101.53.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="bu1QoUHN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G2UepbbRLBrYJY4hv8miczvfexgsbYOUtnma43Za6IN5LeljmvsYbcL1rGe6PpLnRb9HZ5GHPcylQJ+0iP1fyAuhl1YZ6uaQkFBOx39Dm4To0LNlidf2v9/r6+qxpAKUdY3/23d0rTcAPNBOfRO+e6cMW+lbxM+F/a7bpVBBk1wZbnawbvSBlfHQZf44K1Cl82oFPp7KJCOwhH4DQXI1aiMg4uY0HEUcLcpQa1rAsJ48/OLFH5y/PU18bIy7S+7V9aSw5/L7BpCEUEY0gU923JTTwYcb0srgco2UB9SjE51EVj/oFZghBUhvMScXk9uq71F+maMKc+D0Cy7j4bowoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vxj1Mip/fytbwHtIh5o5HAwA041KqTKLu336u7neCAo=; b=heF1GZFbJznEiT/qRato/7+d3B6ypltp2GQXOILQ9VLRa89gg+oG9BMzCBA9uud7q3z6886Yv5KFGzulLbQua1lq1OagsCWXXidpWKRS0Eh3eyZIyyjD+2ioH6QBWi3R+42E8SQlw6+lhngLDp0MIGezkxFrKJWT7jgtTRugwgWC5l1m+a1vtiuLNeWwYjHJpZ0nxgRmIpGVBMG//60L76qLKGoQ4cF0sVX7lUdY1ggEqJ2RiYSDwori7n+syHMo146ruqgPjIB9WsQoCw3+1YPHeANfhgAwHZ+divqblDIX5OGeDF+Pd3Iuc/HC3Gk2X+wZKJYX1ZWPlrwyYoAyGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vxj1Mip/fytbwHtIh5o5HAwA041KqTKLu336u7neCAo=; b=bu1QoUHNsoNV3Fob2XGJ/H3n5ePn5Ou+/nI9/+zcCI9nC67FG3uYo4knGQKmosAtr1fj0ezrgdFj223hEsuC8vnPtj0Fph+9so0e4L/f5U3bRaRZSrINXeb19k4XnJjE7AAcdWbHReuzT/+2rq7Out/Vek+lgyoL07G5AswlznYaoQEqogpqxHKuop0IWjfqBnRJb2bZ/Cjpx8WesMcLcrJao8WSU+btkiHD+t/ajVb1yg6QdI9ffDY2Tuwgw2PhaYQilXLuplYxxPeHjkgrdxDwqog/wbEf3m3cMJb3fHk3fHuj3NvRxDiCTp7nfTdllxIjBudd9eV6JzA1beKBCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by DS0PR12MB8816.namprd12.prod.outlook.com (2603:10b6:8:14f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 05:13:59 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 05:13:59 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 14:13:33 +0900 Subject: [PATCH 7/7] gpu: nova-core: run Booter Unloader and FWSEC-SB upon unbinding Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-unload-v1-7-6a5d823be19d@nvidia.com> References: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> In-Reply-To: <20251216-nova-unload-v1-0-6a5d823be19d@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Bjorn Helgaas , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4PR01CA0082.jpnprd01.prod.outlook.com (2603:1096:405:36c::10) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|DS0PR12MB8816:EE_ X-MS-Office365-Filtering-Correlation-Id: b30ddcf0-6945-46fa-5b8b-08de3c61eb33 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|1800799024|7416014|376014|366016|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?R2R0aGlrUXJVY3N0cXM2eURJeHVhRStsY2s1SEhPc1NGWi9Qa1RyNjA0cHNT?= =?utf-8?B?SDQ5bWxDSGlJRm9Rdy9oVnlrSVBpY0hTaSs0eGFpRENBK2ZrcCtFRXZySXlh?= =?utf-8?B?MklKWVhWNnh1WjBYY05kUkpuU0ZoQXZiWEpCNHZ5M3hYQWlvazFpeXY5bW5o?= =?utf-8?B?K1RHMXNUcjZyUzZSVHV1WW84akZTSmlWUmxueStpSVJwZTNoeEZBeUxpckEw?= =?utf-8?B?dHZaU1RLdmRyYTcrcnNRbmt0eVdxUko1b2hFKzZaM1VhMGFYV3liQy9HbzVC?= =?utf-8?B?ekIyL0s0ZmVndE8wNXFWWmtuRXJVb2xkczk1MFExOUhHdkNHVUFTaFF1Smdz?= =?utf-8?B?bURPanp4U0JhY3hjeGhpR3VCdVBVNWxScnFJY3NyRG1IWVVpSVd2R2J3bXNh?= =?utf-8?B?Z3ViaWo2eU9JUXM0TkZFa0o3eWZlanEzc0tKSnR4L2lJMWpxc0t3eFVncjli?= =?utf-8?B?R0F6UEkzN04wUmJBWWFnV3RCTWFvSEhNRS85MVUzUGRSb0s5a29qWlE1dW9Y?= =?utf-8?B?VXdNbjZGVllkTmU0dFVIODNMejc3aFRYNVhlcjVWazMzc2ZKcjNGVmgwWGor?= =?utf-8?B?TGg0bXNmaExyM2xEMUNoZ2tmdHNWV3EyODduTEFuNDJuaDdNaVVkZDdqMGJQ?= =?utf-8?B?amI3SysvVlE4UlNZOWxMZTJZckJGVkZjK2ZHYWJHelZ4dmpjM1p0YXBnSDV3?= =?utf-8?B?ZksycERlcmxjT3lYWTdXdjhocEZXT3BxbmY2cTlwTmM2bk9zRkhnSkpleVFF?= =?utf-8?B?ZHR3cjl5MGxWNVhYWklpMmRRemlpMDFHd1dad0RScURHQ1RhSGdHNDNGTENH?= =?utf-8?B?Rmg5VW5PWlBsYTN5TFFKZlNDSC9zcFBFSTBQSTR4S0xSUWlBQURzSGljT0Rh?= =?utf-8?B?NGxoSzIwYkNTVi85TmduQnRZdGE1VkRYZ3NzUkVjMEhmSkFuMk42dzJxN2sw?= =?utf-8?B?VTdwdVA0SC8veHZDT0xJQzVFZTRFbHAweUoxV1JweWo5QjV2ZEM3YVBRY1FP?= =?utf-8?B?WVpXVmJLcmg2OGViakh4aWhuWTg5TjRNak0rTm8ram1CT2hZS1MxcFFFemtP?= =?utf-8?B?YUZtT0tzZUh2VEZBcVJpbENoclVoaEVxRzk3Y1ZIako5RXQzSGdTeG1BV0Vh?= =?utf-8?B?VlVZUmkzNk9zK053bUZXNmRFczZkWGJ6MHhDeUR5L0pMdXR1NU9zQm85Q2dH?= =?utf-8?B?RGEvSlZMdVFpZXY1SWlqU21qK2prbk04SEIwTEg0ZGFlWUo0Z1VlbW8wQ05i?= =?utf-8?B?NzlOTVZML291SElRNHYwVnlJenNHRGwyVExjN3BaMW0zZkZMbkZ5RmpZbjNE?= =?utf-8?B?eDVpUlFRblV1ZmUzdGQwRWVqbVppU3VTb0dMVHBORlFTRUpqSnNHQzNHcTRS?= =?utf-8?B?S2gramp5dkowbUJHV2Y2MVNvTnExbGFQVlFvM2ZhM1haTUc4b0pLY2hJRi9N?= =?utf-8?B?SVNuNHBxSnpGYlRXVGVvWDQ0d0IxRjExVUJmYWVhSktva215YTlwYmwzdjBO?= =?utf-8?B?SFEzQ2FxNFJQd042Q1Y1TTM3Y25iK2R3TEwzalBaNzMxalIyVTAxeVFPdGdt?= =?utf-8?B?aDhnYmFrN2lmbGU4NGhIS0w2azg4eldxWXhTZ1pqdDNrdFh3UlZDNWZ3THUr?= =?utf-8?B?T3NCUE9FR2I0ZnRwTThUOHhDd3FNUUR5dUwxUFgxc2owamg0NTc2Y3dNRkVZ?= =?utf-8?B?V3dxQVVPREswQmwvYUY0ZXJmZTZTU3liRGxMdStadFdmckxVTEp0VnlOTmFj?= =?utf-8?B?S2ZpV05JcVlMNXFNQ2o5R0ZPN21lZmZtNnNnQ3ZIRnhBL1BnaXFycnB2NElF?= =?utf-8?B?cmZLVnV2d3ZubWZnbTRwVGpkSHpnTVpEWHdzK0lxKzJjUU13Rk0yWGVSRDBu?= =?utf-8?B?S21zYmVQRGlrMkViVXFLS1FxSWQ1eXphNGtqZXltZjZvVDY3Yk9sMlMrYTM4?= =?utf-8?B?L2prMVRTdnVvOGpEa1FJYU83ZmNWS0JlRDA3OGlvc3pyQnpoa1ZPZjF6YjBa?= =?utf-8?Q?5SYsWeh9Dge25hjkv9yL0xrlQwU71E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(1800799024)(7416014)(376014)(366016)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmdpcWNDWUtOOXhQMHRKY2w0d2t0bTJ4QkhkRWpOYlFiaERCZER5MWN2c0VV?= =?utf-8?B?cFNqNW1xVldLZXUxcURVWVZZTDg1MkRpMng2NjNtNitIR2VXU1dIRG1Xd1Q5?= =?utf-8?B?OXd0ODhOTldMc1hiMHU2T1JZbTJUVWRsbmttR0pndW1nczZRNlAxaENsN3ZD?= =?utf-8?B?YVV4aE5hVG1oekV1UERUUnFsL0RxS2Nra21GTHE1WUYxN2ZnaS8wL3hoaUUx?= =?utf-8?B?ZkJSQWd3SE9MdW1kVnlQTkpaMGxyNVlkWGZZY2ZGTmw2UzVnNjc0ZGhaaHBT?= =?utf-8?B?bUg1akF0Y2JiZVZJeHNoZUFxSDRHUVprcHFIZzRQTDFtcGJoWnRtQkt0aHVW?= =?utf-8?B?SXYzSU8yblF1MmlvbGh3NlJoYnd1YTJvdUM1cSsxU2UzUVVndkQwakcyZWkr?= =?utf-8?B?V002L2RMNUFnY1pTZ28zZW9jai9JQnBqc241Z2tvZUQ5QStmUjU0RmNRZjNY?= =?utf-8?B?MWRHVk1WVUFYNEQrZkJRcHBaM1pZMnhEa2lHYzlNd3h5SFpENVBCaHRUSEVy?= =?utf-8?B?dm0waXh2RHRSSGV2RHpJYVBhRHVNbmJQMzJ1VTE4VzJoUUkxTUttdnpFRXp5?= =?utf-8?B?ZFZRKzZOeG0xL3pIZlNUSm1XSEdTRDAvRWt0RTNBYUZyd083RTYzd1J2djcr?= =?utf-8?B?dERqU09mdjJNR09SUHQ3Z1k2anMrWGxvcTUwT0k2VEpCa0NDMlFEaWI2Y3cr?= =?utf-8?B?SmNHQ1ZzOENFUDNGTG5ldUFobHZ4MjJLVy8zeENsaG0wYVV4RDNGWXRjdHNn?= =?utf-8?B?dkxER3ZNTTNxeTFtR3FLNzhDdjhIb2NEcGJTWjZTblVGekJ2YlNja2RUYzN6?= =?utf-8?B?aWtVdGJKN2xZQy9zM0liVldObnRHZEMzek04MWxTWTdGMGliR293ZWEvMHlW?= =?utf-8?B?Q0lUcWRrN3BuTCtSYUE2RDE0TFJhT1lwcmtUcE9mdWtjNVA3RWZhQ2RCN0xU?= =?utf-8?B?ZGhLVkVDdE5TdWxaQm1CTERPeG0vVFJXNHhuOEtZczZkaWxHOWtRcFZadUpC?= =?utf-8?B?d3h2NU9FdVRod2lkVkkyTDB4MnlrcUNhRDlvWDRuN05mU1daazlrWCsyMU5V?= =?utf-8?B?MlpXUFVnVkQxQldrMkdYTmhBZnZWMllvbmhLcmtrQW9Dd2F6amRiSzF0SVpz?= =?utf-8?B?OWdmRS9mTWpiWlJjTkF3aCtZOUk4ZVZ1eUZHWEg0Y3U3aHdha0JqRlQzWndx?= =?utf-8?B?bHdhek5neWcyZ2FmWGI0WmRXYW9BV1k1cWpKUFQ3UzlRcERidEN5b1lva0lR?= =?utf-8?B?cFE3Qi9QejFqZng0QnhYd0FsRHdyUEtMejRhSm5CajBVczV2ODgxKzRTWjRl?= =?utf-8?B?YXN0QmpjY0dYcmhXUlMvUkxXMUo5UmRaT2cxdmNkQ2FleXFJVWxBcnRqVFJa?= =?utf-8?B?QlVjZWtIcUF6dDRnZnpzNXdqT2hyMkcxUU05dVkxQ0Vaem9lYTRWZ1ZPOXE4?= =?utf-8?B?VlBoaURjNUtZRDQ1d0VVWHFnQUhpS1F5eHo4Mk1pQk5YZXQ3TTZRU0xkbmtL?= =?utf-8?B?bzBCeUZzdXFhQ2ZWRnZpeVZjejE2S240MmdvY1VIc0VSbzlreVlBTWlwT043?= =?utf-8?B?L0VGek1CT0w1Uk0rY3B5K2VzMUVNdU5SbFNpUytvcndYZzlBUEwzRzFna1pi?= =?utf-8?B?THgvN1ZvbUo5TS9mTkFlQnpwenhaZHZPcUNzeW1HcERjQjFPVjhTZHZ2Y3o2?= =?utf-8?B?TDJkY3ozT0VGUWNjSzNJMlIzWmVZd0QvUjdJbndlOFQ5VHU1Q1lMMFBFYW1w?= =?utf-8?B?d3FvejQyZk5vSzZpVDg2aDdQd08vZkxwTjNEMU5ieDRHL1pZakdOWjRXUXpw?= =?utf-8?B?SGlpa1VlM2JCSlVta1pNYVQxOUpLTVJ0K1dMY3dvdS9RcUxzeUpYcjYrb1FI?= =?utf-8?B?ZHJtZjExZTZtanVnaVlFVGdMUnBodWVJNXJ2UG1GRWpkVjBiZXZaNzB6b3c0?= =?utf-8?B?UUxScDVjRFFpY2hIODZrczFNdk1XNTV3TnUwam5mek5yUkYxc21Zc2F6ZUVF?= =?utf-8?B?bUpTUEhPaHBkWjdOc3VQSFpKRHhoQ2JQL3hHZTRMeVJ1bXA1dndDdTUxdTJF?= =?utf-8?B?YlFjSXo3K09ZUjNsb2RFWWcyU3hLWGVvV0ZZWFQ0ZlNkVXJORjdvMTNsSXNZ?= =?utf-8?B?UUZVZTNubTVZeGJFenVLTHZ5OW1WZkczT1V5bE03YWRRelZ6S1V5U3ZBN0pW?= =?utf-8?Q?NY2pTxuMV3DDyCUo61vRkG//kBEgvt/dmiJ6EJWHmidj?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: b30ddcf0-6945-46fa-5b8b-08de3c61eb33 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 05:13:58.9807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YOAksCWw5kcB690a7sm31KlUY/ktYJn1EsX+ER6akL9lwyvpdVsEEneEBlfSRmQRUtwyNqu3z8N4DNP/cO/Z7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8816 When probing the driver, the FWSEC-FRTS firmware created a WPR2 secure memory region to store the GSP firmware, and the booter loader loaded and started that firmware into the GSP, making it run in RISC-V mode. These operations need to be reverted upon unloading, particularly the WPR2 secure region creation, as its presence will prevent the driver from subsequently probing. Thus, load and run the Booter Unloader and FWSEC-SB firmwares at unbind time to put the GPU into a state where it can be probed again. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/firmware/booter.rs | 1 - drivers/gpu/nova-core/firmware/fwsec.rs | 1 - drivers/gpu/nova-core/gpu.rs | 8 +++++++- drivers/gpu/nova-core/gsp/boot.rs | 35 ++++++++++++++++++++++++++++= ++++ drivers/gpu/nova-core/regs.rs | 5 +++++ 5 files changed, 47 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/firmware/booter.rs b/drivers/gpu/nova-co= re/firmware/booter.rs index f107f753214a..d435ff11c5ec 100644 --- a/drivers/gpu/nova-core/firmware/booter.rs +++ b/drivers/gpu/nova-core/firmware/booter.rs @@ -270,7 +270,6 @@ fn new_booter(dev: &device::Device, data= : &[u8]) -> Result #[derive(Copy, Clone, Debug, PartialEq)] pub(crate) enum BooterKind { Loader, - #[expect(unused)] Unloader, } =20 diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs b/drivers/gpu/nova-cor= e/firmware/fwsec.rs index b98b1286dc94..0758867a57a6 100644 --- a/drivers/gpu/nova-core/firmware/fwsec.rs +++ b/drivers/gpu/nova-core/firmware/fwsec.rs @@ -150,7 +150,6 @@ pub(crate) enum FwsecCommand { /// image into it. Frts { frts_addr: u64, frts_size: u64 }, /// Asks [`FwsecFirmware`] to load pre-OS apps on the PMU. - #[expect(dead_code)] Sb, } =20 diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index b94784f57b36..f98b195994ce 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -302,7 +302,13 @@ pub(crate) fn unbind(self: Pin<&mut Self>, dev: &devic= e::Device) { return; }; =20 - let _ =3D kernel::warn_on_err!(this.gsp.unload(dev, bar, this.gsp_= falcon,)); + let _ =3D kernel::warn_on_err!(this.gsp.unload( + dev, + bar, + this.spec.chipset, + this.gsp_falcon, + this.sec2_falcon, + )); =20 this.sysmem_flush.unregister(bar); } diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index e12e1d3fd53f..9525ac912ee9 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -261,7 +261,9 @@ pub(crate) fn unload( self: Pin<&mut Self>, dev: &device::Device, bar: &Bar0, + chipset: Chipset, gsp_falcon: &Falcon, + sec2_falcon: &Falcon, ) -> Result { let this =3D self.project(); =20 @@ -271,6 +273,39 @@ pub(crate) fn unload( .inspect_err(|e| dev_err!(dev, "unload guest driver failed: {:= ?}", e))?; dev_dbg!(dev, "GSP shut down\n"); =20 + /* Run FWSEC-SB to reset the GSP falcon to its pre-libos state. */ + + let bios =3D Vbios::new(dev, bar)?; + let fwsec_sb =3D FwsecFirmware::new(dev, gsp_falcon, bar, &bios, F= wsecCommand::Sb)?; + fwsec_sb.run(dev, gsp_falcon, bar)?; + dev_dbg!(dev, "FWSEC SB completed\n"); + + /* Remove WPR2 region if set. */ + + let wpr2_hi =3D regs::NV_PFB_PRI_MMU_WPR2_ADDR_HI::read(bar); + dev_dbg!(dev, "WPR2 HI: {:?}\n", wpr2_hi); + if wpr2_hi.is_wpr2_set() { + let booter_unloader =3D BooterFirmware::new( + dev, + BooterKind::Unloader, + chipset, + FIRMWARE_VERSION, + sec2_falcon, + bar, + )?; + + dev_dbg!(dev, "Booter unloader created\n"); + + sec2_falcon.reset(bar)?; + sec2_falcon.dma_load(bar, &booter_unloader)?; + let _ =3D sec2_falcon.boot(bar, Some(0xff), Some(0xff))?; + dev_dbg!( + dev, + "WPR2 HI: {:?}\n", + regs::NV_PFB_PRI_MMU_WPR2_ADDR_HI::read(bar) + ); + } + Ok(()) } } diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs index 82cc6c0790e5..6f53ac096e1e 100644 --- a/drivers/gpu/nova-core/regs.rs +++ b/drivers/gpu/nova-core/regs.rs @@ -156,6 +156,11 @@ impl NV_PFB_PRI_MMU_WPR2_ADDR_HI { pub(crate) fn higher_bound(self) -> u64 { u64::from(self.hi_val()) << 12 } + + /// Returns whether the WPR2 regions is currently set. + pub(crate) fn is_wpr2_set(self) -> bool { + self.hi_val() !=3D 0 + } } =20 // PGC6 register space. --=20 2.52.0