From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0AB8329C7D; Tue, 16 Dec 2025 04:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859276; cv=fail; b=R4Bh5z1ysk0kRLGYXoV0aM+P3Af8owfjE8AFYnXGNFHH4sbwCNaWiJHemaCvkbIBPdNmcwzt5c6DlWePWYuWz6/0I2zXxhesjqMXELJcgjof73B9xQKA8kgMKp8X3RFa+tKzMZXwnAsGdphsDYVLI6cbNitByWrIo8fKapSei9Y= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859276; c=relaxed/simple; bh=KUmtxz3/4jRkDjCYHq8tX3cOma3cykntyz3O3R2cPlU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=XiSLXEQq9v2VyTU8fBiiFyh68m4hP1xI3sgw1x4ZqpXNFwqbDBfIiCilRigwx2nnsWOo42pUDjXL2XOHtN9cRQo7eT1Yz44+4LMWiVdqGX5bS7p7xsHquPUQq1z0DcfnTthRrxqxWqr4pdtB5YuRMEDseP2TDzN3jtnD/ODKznw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=b2vDaO89; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="b2vDaO89" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hPBoQgELGximoe01qFSsvS6KBd1IW1s+D6dppD2oDi46KX/AdyYKDCNwCPIZ6/eHY7THBmekh7eEPbEjmQmQeU+jPoisk5aH5Qy9n3ohoPawycpfcGbQ2DhY2xtXHv1GROvx+88J1OTPXiXjkkWj0yIafJCqROIXn522TwlHI2vjxADnLAH0slM/WotHo+juozjBEYALDq4taqOZ7N/lIFKz7MsOec+2aL072ByL7EIxkVC9Xd+gpQHYOBVhkQVN6CS+63A6qWs7YZIHGaBGcc9mNsQ2MexNeo4Btu7sY/axGxwQEu31qoRZZCIa6qvzVDpi/G+KR/emV2Y/ibvwIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udhNcsqgzt3RqGKMHk58pJEPFIodrlH0V2zfYOFwIxM=; b=ABmZ0deM+3nspaTNaiQqNVqNz6vESTjbgpkYfbImcm1C1nhe+ka2WPO050sJfgXjWzEJkuH4ZtLFqy3ON4P6VI11uMF2KyiqOPITPsWs2UkHupxtAXq3c36lTIG9zwcOS9b2x3BPBNMND7kbr2uEiFUVljydOyPMpnek9M0VmYENbJXlb3yG1e0v6CqcMaG5cI+wa4wfF4J2OYcE7wN7IcLCvFVyQEq0LqEDhiKHp/VsEYPkOlawmaH5UAIW1KRvPa/Hl0Cn0J3paVXRRpM6dERVg0hAYZKw7v/UY1MYEL9+bmxWx5Wbjw2ILE/jSefCcDAiy2bSl5S73Gwn4sf2Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=udhNcsqgzt3RqGKMHk58pJEPFIodrlH0V2zfYOFwIxM=; b=b2vDaO89QsZjby8j19HmgmIb4XShn/Zdo5xo0YlyipJcE0bXsQtddU/BJk+aD1JzSVYAERX61mpUEmJLtIqO+soZ1KIQ13JhR7bQadW05N0JNyUuVw9sL1LmYeBoI0obPMckRZKraSX4Y48jva+XMgQHQP0sZbN6u+Ek4qQ56eKmyrU0xo4B6orfCIYvH8RW983yAvJnxPlW3RajHc8ICaPqpHwbaS3nGCa5gZQUC5h+/4DkMO4yDwYAQkXy6m/sH0PO+K1nvwADqQnPb9X1J1KUTyuNZ9/3vEtXvsEW3Tci4Ihg7znsgFhuC8nfNlXVOqXnjujp/nuOqsnNjKxWGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:30 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:30 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:21 +0900 Subject: [PATCH v2 01/10] gpu: nova-core: gsp: warn if data remains after processing a message Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-1-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0182.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:382::9) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bda0bfc-a3d6-4ecb-6560-08de3c5b6d01 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b0JtQ05hSEw5SWZYNTUyaFJDdStheDQxaEZIRS8zYUFWS2NSbFlPQWJyNFZl?= =?utf-8?B?ajN3VFI3UGNlK0IzdmNXK1JLaGFaUmlrY1pDSEpGemZoOGpXOE1XN1ZDZ1FB?= =?utf-8?B?K1kvaUhFMkhTOWw0b3hhcTJya2FOTlFNV1lQMzI1eVlkbWZ3Szk1Rm1yZFFh?= =?utf-8?B?ZUd4N2tMa0dVc2xJRnNZL2ovZkJBS1E1dHNRdDRZTjlXeEpGUWhSZFR3WXY4?= =?utf-8?B?TU1iejBzbU5vNXpFcXloODhCQzVzRk1CcVZZVVl2YXI3ZTlsZlYxQkt2NFQx?= =?utf-8?B?cDJFNEVDZFF1SU5BWUcrM1dUakpFYS9wOEFXakIvenIwRXI5eERiOVFqeitV?= =?utf-8?B?OWk2OVFPRUp6NWtTYUNEbVhCR2tIcGNXQnB0dUFXYUF4YTVFWjdZY3Mwamh3?= =?utf-8?B?ZXg3K2FFd0RtMTVKUXRnYTBJdXZjd3BJa3Era2F6clBJeXN5U1gvMEIxWWhX?= =?utf-8?B?VTMwc3lldVVyejUvbkVYTE5ha1Z0UTdOVTVmMTF5anJqMEJUdEJWL3B5MlEv?= =?utf-8?B?R0trTCt6ekcvVzhLemV4SjF0TmNsUzRGM0poR0dBUzdvSkwvYWppcFpFa1pZ?= =?utf-8?B?cDRsWk8xUUNyK0xTdUNvTVlMdFN2eS9sdldvdlhaa3ROczZObjhKTitYd0ow?= =?utf-8?B?dUMzbExGTTAxRGtYMC9EMjJ4VlVNdG1mV0dnYXk2UDlKV2N0aGhsUWdZRjRz?= =?utf-8?B?UDZiQ0p6NTRBNjJFNm9PS0k4aFFvM0cwNytJSWdOZk9ObHY3NTNkdWEyOUUv?= =?utf-8?B?Y1g1RU5neUJPdk00ZDB6eHl0Z0g0Q2wrelhUUlo1bGFDYjdyRFVHRXJxaTla?= =?utf-8?B?RHl4cFdjVnVqR3l0dTk4MnMvaGl1V0hnSlgreDVQVmdNSStHVUtqakdzd3ZS?= =?utf-8?B?TS8rM0pBVGdNKzE4SlhsZjJWT0xzRTRvb1JsYkFiWEFRSTU5UjNQZk1SbFNQ?= =?utf-8?B?MnRNd2grYTlmYmp0ci9TTHZnN0FzbHd5T0xveC9YeDQrZFB6VkphWjZkbmxo?= =?utf-8?B?WExXdGdJVWR0TkI4aUcyZHoyMEU1YzNlaHRNVTN2a2ZyU2F4ckZlNUt3Q255?= =?utf-8?B?QkhPOUNoczV5UjlMcGlObXpiajBKWmVZcUFlR2Z1ZTFXUGgwZlZiZkZaV2dk?= =?utf-8?B?alBaeVppK0RNWEZ0NzNkajFlYUtVdHIrT0RvVDZ1UFNmeElFT0svMDQxL1Jy?= =?utf-8?B?bVdUTmxtWE9PdDVyUk5abEtRRVhPTDJtOERXQkNsTDJCN2hid0lHK3FYZlNT?= =?utf-8?B?UEg5ZWhHak96ckREbFNkcHFrcnE4OUhYSVRDNXNWTnY0MXFOL1NIbEVjQ0VX?= =?utf-8?B?WlBmYUMyNDBydFlGb29qY3JXMURNSXdLTFJlczZ2QkUxQ0lZYlJuTU9xdzNC?= =?utf-8?B?VWQ3SUxNR2xUNWZGTzFwQ0tObm9UNnZKUk5yTXNaUm1LbEdFOElPN0ZiQkJK?= =?utf-8?B?VmhoK291VVJoanVMdHRuNlpTd2l5NDFqcmZGZ2hDUUlEMG1UVERES2h6eWdN?= =?utf-8?B?Q25qcGY0YkFOQWNwVlpTMTNIeWNjQWtubU5KZWVvZXJmRXNBRjc1cVV3Q3JP?= =?utf-8?B?OEtwaU1jY2ZIQ2duVStlM1dPNUtwYURkUFdIbThyNno5Y2dTa0FpRkdHR1Rm?= =?utf-8?B?N1BvdnY5Rm9heVZ1dTJmYVUyNE1WeGZxZEYyMjBxQkVxbGZjSUVyTjZpQWxu?= =?utf-8?B?M1ZDZzA2L0dJc0ZHWDNyOHFoSWlkLzZ0a1lmR2lwK3lqZnBUQzF3a0Fkd1RG?= =?utf-8?B?QzZvNHBJQmVKTjdWU3YxZ21iVnE1Vit0WWVMc2ZKOXVLVVp4UWNUS2JxQzRn?= =?utf-8?B?WDhKb0VaUXN3VHViTEx0SEF1UUpZd1o4cytpKzFOd3Y5OEhMWHM3YThCNjNM?= =?utf-8?B?a2c1S3owc1lPZy9VRzVzV0Zldk9lWmFxNlFsUTBvSmZ5RTdkY2VVU0V2aCtF?= =?utf-8?Q?1BJweqQTAN5X4pED6Cq6t+ECyx5rVUOL?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlM0eFdLaWw2OERHTUpDNVBtbGFDcmpPN042a2lQcHczVlhIckhCVDZIS2Q3?= =?utf-8?B?RkRoemJqTUJnSFB6Mm8vcG1YdnFZYmJjajFxMlNIdTk2UEFjVlBYbkpFd29s?= =?utf-8?B?YkhLVkRUZjZoV2xiZ2lZYmJ0RVVJNUdvSFZBUU5WelppK3Jpb0thOSs0SG1R?= =?utf-8?B?N204eVdwWTVMSXZjMzNubUtoRXg5MmpOMlpma3dRbWhBckdoUlh2eWluR25w?= =?utf-8?B?MHNqV1BuNUlTcEpYZTd0dVJrQTFEeW0zdjY0NHR0WlB3Zi8xMGRmYWFFZ29N?= =?utf-8?B?elh0WWt3NmZxdHYya2wyWmRDSGp4SmsyZXl6Q3h5Nk9CRk5LbTRVVlhkNjVW?= =?utf-8?B?TEE2eWVTRnlWVEFWeGxuNFk5dkt4QWJKNUhrdlZDL2JjYTBkZ2xkZHdUQXpq?= =?utf-8?B?MnVJV0dUWVBRNHp1eGppaTFMVjdlNlFxV002TlRDaVJ4cWNFN0FIdVhmRVFO?= =?utf-8?B?aUtzN294YXE0cHJFcERvOWJZRmJZZjc1TmFvNUNzRDBueXJMYzk0cWZNa042?= =?utf-8?B?RGp0eU85eXZYRUFZZEtuN0V5TGIvaUVKOWc5YlRSTVJLcjREY2xubXlWdFZx?= =?utf-8?B?c1VZeWNJVUNLenY1RzRSMlc0enlueWg4OWtNQ3FtZFhkaXJYdWxubXZKMjRT?= =?utf-8?B?Q3BlVWNlYWFzS1k1dk9CeVZaQlNXV0hsTldVT21IK3FaRThESitQSC8veUpS?= =?utf-8?B?OGYwL2puZ2lqT01mNGdTdE1UdGpiazQveWFDSThtcHdZaml3Yjc2RHVDS2Ix?= =?utf-8?B?akRXa2kvbGtYVU4vM2xwVUlXNWloSVkyRmRDbzZQc0pvdzBWRW5WbjlLR0Iz?= =?utf-8?B?UkQvQ0MxMWZoMEJJS3hJeFA1cElZZnNaenh5UWxjT0hQTHhuOW5uRGZEM0tt?= =?utf-8?B?U3FlemJLZ1UvU2lvYlNxUXdUNzBEaUtEY25PNzF5SWdhaTkxaTAzbm56WVRZ?= =?utf-8?B?TG5veFpXM09sMjUyekpqNnBWSnFIM3FMTFk4eG1jZ1pTL2pVTmU2SmFMWnlq?= =?utf-8?B?bkdjdmRKVUVKZWorWmRlcVVhb2pSOWcyNUlYL1ViZWh0TmVweWdlK3F5OStF?= =?utf-8?B?U0ZzQ1hadEgycTNoTEhZTzRramdWQmpHazA0Vi9tb3V2YzZYL0x0VFNuVDNs?= =?utf-8?B?c1ZFTE9Ia3JzbThJLy84SFkybUpJSVZCWERzdkgrT3FmbjBpVHVQTmhacmtz?= =?utf-8?B?VmxMMy81TDZMNFg4RERiSDFjYkJoZDVmZ3NsajJJVUpkZmpTSEFsM3FzT1VZ?= =?utf-8?B?OERuMklTRDFtS1hCUWdpUHJvc2hNM2g0STQ0dDJmbHJodHREQU52QU4vZzdl?= =?utf-8?B?eUZUeE9tbTFLbUpJNE0veVlwWmlLV3lGT1FGZ2dsVXdRK3lrU2hLNXlDVXFw?= =?utf-8?B?aDQvTDlxTzRIdTBIUkY0ajM1bmQ1dHhHU2NHSERvOTFXSmtseXFweFhzaHNM?= =?utf-8?B?OEYrbEZZaytJYk5SRFprayt1VllocmhFd0NZSjRMdnM5R0diNzNEZlRpQXBU?= =?utf-8?B?bi8vdUt4VEpNMXU3LzE3eFFjRzJlU2R0ZDQ3b1hGaklVNDJ0SCtJcGRUSFZN?= =?utf-8?B?K1RvZHlFWURncUdvZjFKQUs3RFdNMUJlWnl2RjhFL1ZTRnp1Zy90OWdUSFJS?= =?utf-8?B?UXI2RHJXR0U4cWI1dk1uREdhdzNnbThqYWFEdXF1akZXQ0xJL1N3VkpEWSt2?= =?utf-8?B?bzhVQzV6b3VVdkRoeHN3MXhMMEpWQkZ0VFE3SksxRmRqTUhyQW1TWWZWSy9q?= =?utf-8?B?Mjd1VHVobUIzd2JRWDd6Z2lWbE9HT3RWQnVVTXV1UkZReUpUN0drZ0lKbm1E?= =?utf-8?B?TUpiNUllYUlab1BoNXB2WHFndjl5YjJVZlBCbjA4b3psZmJZMXhlZDZjVkdE?= =?utf-8?B?cFdKc2ZTOEg2dXM2Q1F1RjVkMkZ4Nlk2eFpxMEFVdTNxa1puMjUrNjBMNTJu?= =?utf-8?B?clpRdENXVkw2YjdNZlVxUWhJZmlFeG1DLzJicXAzVnpKZEduSzJEa05jcmpJ?= =?utf-8?B?UDQrcjdhTE5vL0x5ckU0d2hYM0pkenNIOGtaNmdjdUZ0ajMvSVVrUWkzbDFl?= =?utf-8?B?QVN4MStrTmg4QUJFNDJ3Tmswa3dKa2tacjVJUEVoUFdUbjJGeEk3aHA3ZnNG?= =?utf-8?B?cXNQcUtoQjRDVFFvaXI0dG8rc3psZWtETW91ZjhTNmI2c29vdEJ3RkdkY0M1?= =?utf-8?Q?s6BsKRKw770P6gKSI+1DnsutkoeiKvF9GsV6iSYuIrL1?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bda0bfc-a3d6-4ecb-6560-08de3c5b6d01 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:30.2898 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uCP/P/tNyzV+2E9VVIkDLDyi4rdB7NuNLCbBGTsejgd+wt77rBWc4qVu4gwv3b1XJy8GavCYj1rZi66UXcJ3xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 Not processing the whole data from a received message is a strong indicator of a bug - emit a warning when such cases are detected. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/cmdq.rs | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 7985a0b3f769..f0b7ac1ee759 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -661,7 +661,17 @@ pub(crate) fn receive_msg(&mut self= , timeout: Delta) -> Resul let (cmd, contents_1) =3D M::Message::from_bytes_prefix(messag= e.contents.0).ok_or(EIO)?; let mut sbuffer =3D SBufferIter::new_reader([contents_1, messa= ge.contents.1]); =20 - M::read(cmd, &mut sbuffer).map_err(|e| e.into()) + let res =3D M::read(cmd, &mut sbuffer).map_err(|e| e.into()); + + if res.is_ok() && !sbuffer.is_empty() { + dev_warn!( + &self.dev, + "GSP message {:?} has unprocessed data\n", + function + ); + } + + res } else { Err(ERANGE) }; --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013029.outbound.protection.outlook.com [40.107.201.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F10C0319864; Tue, 16 Dec 2025 04:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859284; cv=fail; b=H/fRobm3+KrRHwy/aZK1q78YywJRnEK9Cv3nk0BP1f+3DVpZNZgtxykPAsshnuu4SpBf51QETHbJ7OtjvC+rnbN3acbIdQi4H9UpboNSBgDDhdLuNN70A2yM60+fIbrTAiAMqlI3sigoHyhe0ujhbFPPEe63fRpK5ZIh12tZcDk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859284; c=relaxed/simple; bh=QpKlTLnuGa4mPt+29XM0uFcqzqhnDXc/jcbCOldGGpY=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=C1HwJOC3XWBD2EOTVxGhFDP/pMBaB/EtLuLc7g4a65rJCaar2ff/PyTpx0LE8S0QosC7fb0WY1sHBscmp/b93UbBsoIZiLqmWfUEHpQ5A+FiXhhdQxjqPNBAnduJi72qX3qBgiwh/ESqa4hMan0WGvtQD9yzQ06zijux54Us/z8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=RBRdKHCJ; arc=fail smtp.client-ip=40.107.201.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="RBRdKHCJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ns6OyK6YvO+V4Uzell9/PAyO9378awsD4IRRouH8w5L+eR8yJigwANEFETDf6+593LVUj3DoNipfCYQQWkj2lxSXnupRWd1EVDkt3W+O9Jzjsd9KJjv4d35yE6Rv6b+93SqReg88LI0MHUwj6ZCI9hz1gHXtqa7uu9r1b/NQR3/KhRqprDTx4j7r5zDIc684s5kyLOdQSxsDRChNAlctPriCDC28HLee5PKHYU1Y89XGBtZ3OVp9aqEcieAQQ43rQKeiyZZ8sSa+aZZY0qBObYcYlD7Yy/4L1+h8RMMdP9R6QDJhIzOpS562HU8TgBNCGVIgpHrXwNIfcCgGKlaFAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qzsuFQhtEOW6f1y3Fl3hN8wxTko3CfD0LNP5zMvMCkE=; b=t0P8J73Dh6o5oC5v+Z6fxyJUnwl9DN4FzNC7oxURjcNWnxAi49ZOQnmXBeLVbDlEMF/TCxv1T0sNzHDLzfCocbJB8JOrPK6/1qoqKbI8jpHU+Rcg3F133OiIPI7K5zSkwO4z6VBl03EmRj6jW7h68ybUu3OCTDY5kPb6KQKBrNOycPHw48PZJmfjc4AN9ZnmnEigDaIN5MzC4es3Vz/YdbaQ5l7JmNDbqZfnrhTOBPED/ubkm6cPF00ILen9CwUXVI/Or4grZtd/V2PJPf3UVajOHsrKfusEKWyQeRKLzffMXPkydScJqpqygAkyKfuufYFur5iCFU36Y1ibRWA7pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qzsuFQhtEOW6f1y3Fl3hN8wxTko3CfD0LNP5zMvMCkE=; b=RBRdKHCJd5+7/oW/i4VHw/+VwhP7KhwsaTeU+yadH37duP+zKDomw9MD352HX5UeLevQmTE956JGcDkwNY/6Ob2+XnXaAYT0Y9DNOm/uipbtdKRblGv7Fq3aruyzzlk5hSCxaoLkqnpjw66vo8zF8tWUbrTd4WMaen9Glac5RcJrF5UvWugpttjxCSFeM7/qvPWlcJ+PQjhdLoX/HzgvlcsIIR5X1ff2lD3LL+iwlBNigxj5g/BTw/HhFhHmY9c/SloSIp8/p/kLBDrnVS+Mj7ckAVh+9NgaFFK+VEYeZh57Dy7KR1amg2o455FjqBoOkNAwG8r971AI1apxzPqaSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:34 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:34 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:22 +0900 Subject: [PATCH v2 02/10] gpu: nova-core: gsp: remove unnecessary Display impls Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-2-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY1PR01CA0197.jpnprd01.prod.outlook.com (2603:1096:403::27) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: e51332b6-fdfe-4254-b181-08de3c5b6f29 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ek5qU1A5MWlBb1N2b1BVemN1Y0JKU0dWOWZmaGp0SUZZNzFxMWZscVMxUjEv?= =?utf-8?B?TDcxSjVvaTB2VEVOdDVyUTdHeWc1Z0tMbHN4UDBZVjUzSjBRRFFPcWdJdGtO?= =?utf-8?B?dEtabGpzMDFWNmdSNzVYL1IrOGtSdlpLMjlLNTYxSkZSVGczK29Xa0NOc3Bk?= =?utf-8?B?cDlSbkRBaFFJYVRFaGE1T21idUZmdGNVeHkyTUJ2aGRBMnB6SlFyUmFlbTRY?= =?utf-8?B?cmNDa0NSVWp5bjJrMjBnaHUwSERHM1YvSU85TXFTcEdFd1MzbkZiWUFvVlpZ?= =?utf-8?B?ZWZaY2FaQm5GcXFHdDY2RXJZMFoyWlpkaUtiQTlKS3hDelZxT0JSbW5LTGIw?= =?utf-8?B?bHJKZHlKYXdTTEVlWDZoNlorcDdtZVVVODhha0Nsdno5SW02dTZsNk9XaG1B?= =?utf-8?B?Y3luNldCV3Axb2gwdkREbzRrMTZGT2QvM3hzOTF5aGF6UEgvdW5ZUUd6NmRR?= =?utf-8?B?TnZzVWttcDRXRUVoNjNVSGtxayt3bCtqQ0paQ1VQRExoeWVKMGdtMWVjMFdC?= =?utf-8?B?SXYzaHd5WklOd29zU0JhcGVCbXdYeHF2dEkvQ0phaGxZaFpNMlFrZnFNU1hV?= =?utf-8?B?YitpSzVDL3lKTlRob0ZReWRKK01IVVJ4QU9EYXBYd3VzM1Q2STVPdWRtdVhv?= =?utf-8?B?Rm1OT1N2dVZ2REVNc0JGYzd5cjdNTVQ2Q2NRSE4yY3hmcTEvNGNXcUY2S0Fa?= =?utf-8?B?c3RyMkltUHphL2E1b3ltRGliLzVRSHJndlpQQ3FCN0xrVnp4U3VoOERIaTJQ?= =?utf-8?B?bmRhSXJ2Qno4VWhjbkhjN01IZTJDVTJiazBuMDgreVBFeHVmMHlWVGZnMVRP?= =?utf-8?B?M0h0YnpJV25MVmFzM2ViQWZqVFVJa3VaQVJLbXZmZVI2R1QyM1RWYXFxYnhM?= =?utf-8?B?T0VSMkpVYWVnTDFZNXJlNmEzaUtGM3Y2NVZjZGxKUERDVUFjdU9hTjJjcGxU?= =?utf-8?B?TWc1ZDJoL0xrVTdQam5XNEgrZE5aQUl1OVVJQlBHZ2xjZU1JR3VPZXQyK0Zv?= =?utf-8?B?cHowTVJ5ZEJsRzlLeWhuclAyMlZQb1R3Ynd1amdzUFF0WmRmUk5ybEU0aHA3?= =?utf-8?B?dzlIOHNiR1JrNFpHaHFqVG5tSFB5alFLK1RSVklZZVIyYiszcTIxNklCcEFl?= =?utf-8?B?Szd3dWZSL1J3cHAwQ2pKcW5KdnNhTWllSTA3eDBzY2ttVVBFbitMcVp5ejZn?= =?utf-8?B?R29peDd2Q0d5SE1nYTM5djFQNVlndUY4K1owL3YyNTJEN3V2cHpXamhsWGMy?= =?utf-8?B?T2VEY3h0T3FCeDF4K3Mra0VGY281MkdDWGtyalZiNlY5dmhPampwOVFSeHEr?= =?utf-8?B?elVYMWZuMXBkNUl1S29PRWlwazA2UUJmREZ3MkdVTDBxenNDK1U1NFpGczJT?= =?utf-8?B?WjVzR0doMzZhM2krb2FnejE3YytQamlGeWVxdmZNT2U2K2R0V0Vwc1RiMVQ1?= =?utf-8?B?bW5vN2xXNC9wQ2Z4ZFdDeCtBYXNwRTVHdWgwS1RPUnREWWhscFFiaTdJaFdz?= =?utf-8?B?MWh3TVNnaTZ1RGwzTkYwQ1VySW8xaUxLNzVReWQrM1E4VlJDbEU1SWlYNTlN?= =?utf-8?B?K1R3OUFUbGh1WWhyRkFDTmJGVlU3N3hteHpDZ2creDZybllmb1F3NEFuS0lv?= =?utf-8?B?TjRNdWl0VzloYlFOU0Z0RFNFdmlGQlRKc1J5bTdGRXN4SE4xMHBzaFhmOVRT?= =?utf-8?B?cXh6d3l2MWNUbC9ha1cyN1J3ZlBNV21JT01ES3BJWVRaRWc4eDJ3ZG9hWWZo?= =?utf-8?B?azJ0bFFFZ1o5OGFzdjVUNklLUVJxUEpaMlZ5M2IrQ0RHc3ZnVFk2QjA0NzRR?= =?utf-8?B?Nmg5OWt6UmQ3RmhVQTRCS3Y1TDlUalRMWmJpaU5MclpsQWU1SktWK3BBL3ZO?= =?utf-8?B?YkFWdVNZczZrNGMxQTRFV3JQZWZzeGx4bnFEWmxQTUw4UFhEdXBCYlpZYWVB?= =?utf-8?Q?FqS58D+QynS0hRgtnG4IcapcManCoVCn?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWp0cGo4ZmZwTWJxOVVoT09ISUZIWmN0eFMyWXBoZXdidFp3cVJMTC9WcXJE?= =?utf-8?B?VUd6ZVdqellEU1hxelBJWlh4UHBpVzJGTUpicXpQODYrYmQ2TXhFa05sVWYy?= =?utf-8?B?MXljcjdtM3R4V0NWTkdmYms0SmRhbEQxdy9FLzJTdGpFeGZFcXh1dUNUWEl3?= =?utf-8?B?QmhqTGJMQWg3M2NuZ2JnNWdXVkQ5eXo2ckkrbFpKQ1ZheDgxQ2NGc1k3em9s?= =?utf-8?B?a0czVVEyQXhLamhKRVdHQmZ0OG9qQmhvQlVyR3RlWHpxYk9ya0hlWTdNQmZZ?= =?utf-8?B?bmtwL09lOTNjUWlFUWVUSTFKRGxVb3BLa0pjejFqN29nelk5dENyaGVNUnpW?= =?utf-8?B?eXJPY1R6R1RsL2d4NTZFbDhvQ3dvNkwzTkJtR1crQUtrakNKVks3cEU2d3g2?= =?utf-8?B?eUJCVWFGYTVQZEpsSjdEOW8rZ2lIUnlMb201SnlYNWJkOVg2cUJNNjIveUh5?= =?utf-8?B?YlhkeHlFTmxzZzJaNmhSMk1vOW5hcmp3Z1lIbDM4UlBIUy9LYlJRL3RTSkNh?= =?utf-8?B?MEZFRXJSY25kc0JmcTV5NkJGdnRFdE91Wk9Ub1NtV0dUZ2QwLzNMdEw4T1Ey?= =?utf-8?B?Um5RTmZZMit2WndteDFnbDlRSEpuejVoWkV1dFlRTC8vMHNLT1JmQVd0eThi?= =?utf-8?B?ZFdDUUY0VDBjQmNlcm9pY3pjVU1JY3RwdlgrTnZhRUxXSU1aYm0yT09mVld0?= =?utf-8?B?QjhLdHJYU242T3Y0aDU4SFl1S3FHL0dOZTZNWDlDK3hIOWVBV092MnZ0TFVF?= =?utf-8?B?bzEvNkNHSkluTmlJUUEwWEdqV24rR0pIZURBc0I1cXF1VUFVNnBsK0V4bGRQ?= =?utf-8?B?V1ZqYTJmNXhhdDc4eklMYk9rNGNsTnIvOSt5UXdiTVRBVUg0Yk11WU9vZ2ZD?= =?utf-8?B?QzVTV3VVZGE5c3NNNVQxa0tHNE8zSzY4ejRPL25yZ3d3RGJQcFVrczlDTzRs?= =?utf-8?B?M2FRSmlyK2VPMXJoVitreHFZUCtiN0NjaXNwSmw0VjJBUWVLc0NGNjZRQXVq?= =?utf-8?B?Y2FZenFrcnRZSVBndHZwRGxSbE9JWU53RVFZNFlDQmRhZTY4bnlpTlArOXps?= =?utf-8?B?SUVKSGFmbHMzNUxNb0U0c1BUQWZ3K2RpR2hubDhDWEhSN1VubFdMNVhxMHNR?= =?utf-8?B?U2Y5d0FLZUNGeTBWUDRkdm9xaTRBQmMrcHRsMjFTZWM2bWs1WW5TVys1K2Zu?= =?utf-8?B?bSt4cXRxYWJ5TWRNMFdpVlQycko5NUpwbVBqbVN1MEFxSmJJTzJiMWFlMjhv?= =?utf-8?B?VStNV2NQcWluV2hRa01OVTlPV2paZU1IOHIvNW9QMlloVE9wQzBxQ0RzNDB2?= =?utf-8?B?eWowZXZubkd1RGJFRkZKV2tUNkVwSlorMGIzUS9CSWdCQWlIczhlU0FhS1pw?= =?utf-8?B?dWFkQ2F6SWluNmlYWHBORDhsTTVmbDZHNDFZTjZtY1d4cGZPT2s1WDZlem5G?= =?utf-8?B?dHRDV3VGSnlpUUZSeGZ5MnhQM0szNS8vakpCZEk2djRHT0NJVTVhZ1lVOFYy?= =?utf-8?B?U0FmbjFKUTlScmZwSmIzM2FoajI2eFZqWE1WVTZaNXlJUXdVL1UrZ3hkQWFW?= =?utf-8?B?eGdpOWREWXdUcDlUOFF0b2hRbEE0QzQ1ZC85dmppUDVta1ZBNFR4OWo3QWxD?= =?utf-8?B?S3VZb0tlVi8vUVU0dVc0bzczNkt4WFNUSk81TG1pRTlEZXYyeTdSS2kyaXM3?= =?utf-8?B?QjRVOGFhYTJYZGhFNTlDSGY2c0FjcUNCOWZnLzlxTUdoUnptdllVbnNGK1Nm?= =?utf-8?B?bWE5MFBtMll2Y1RJOGJzUWNXQkUyS094YUNlQUpLMjlUcGN5cFVDOW9ILzBu?= =?utf-8?B?UTNhMUN1YzA5WkFTRmVkNHRwYjNtMkpjK29rUE5MVi82NFlBcnc2SDFLSTk4?= =?utf-8?B?SkloUzgxREwvbUs4SGo5bnE1N3Y2UjZ6OENLbnhUejcya3JTSjVlTjRMQklw?= =?utf-8?B?d3VYMlQ0bDZ4SE1zYnlmU0tNV0o5WDhYTk4rRk8rdzdJM21XMUF4UE96YlZN?= =?utf-8?B?MkpKVUl1dWF5SU9rQlZnU0lpMTRId3I3bTJ3VTU5OU13RWtPRE81alloOHYz?= =?utf-8?B?ZUNwUHpFSExCQ2hBZjVDNFJ1TzlrU2pQK2x1MmNzYldmU0NQamVoamhRQ0Z1?= =?utf-8?B?TVVjZnlEUENsaFB6bmtWeGRVSkZKaFNoY2lDSTVvb3RQNndIWlNhVkk1UDlM?= =?utf-8?Q?vJUQLhZ/fZIuHPcLfrgL6KrgRfG1TVdmp7tRbnfLx00c?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e51332b6-fdfe-4254-b181-08de3c5b6f29 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:33.9352 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0lLLdhPEV/8VOx4HPxqJbkyZe0paSn9H8zjyTd+rdDcd4/P0y5FECRC/XpSO7/cCID5G3H2Yiie6aFLIrlBLpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 We only ever display these in debug context, for which the automatically derived `Debug` impls work just fine - so use them and remove these boilerplate-looking implementations. Reviewed-by: Lyude Paul Reviewed-by: Alistair Popple Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/cmdq.rs | 2 +- drivers/gpu/nova-core/gsp/fw.rs | 54 -----------------------------------= ---- 2 files changed, 1 insertion(+), 55 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index f0b7ac1ee759..4dde9cc4e3c7 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -531,7 +531,7 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result =20 dev_dbg!( &self.dev, - "GSP RPC: send: seq# {}, function=3D{}, length=3D0x{:x}\n", + "GSP RPC: send: seq# {}, function=3D{:?}, length=3D0x{:x}\n", self.seq, M::FUNCTION, dst.header.length(), diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index caeb0d251fe5..de251a143f7b 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -10,7 +10,6 @@ =20 use kernel::{ dma::CoherentAllocation, - fmt, prelude::*, ptr::{ Alignable, @@ -223,43 +222,6 @@ pub(crate) enum MsgFunction { UcodeLibOsPrint =3D bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT, } =20 -impl fmt::Display for MsgFunction { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - match self { - // Common function codes - MsgFunction::Nop =3D> write!(f, "NOP"), - MsgFunction::SetGuestSystemInfo =3D> write!(f, "SET_GUEST_SYST= EM_INFO"), - MsgFunction::AllocRoot =3D> write!(f, "ALLOC_ROOT"), - MsgFunction::AllocDevice =3D> write!(f, "ALLOC_DEVICE"), - MsgFunction::AllocMemory =3D> write!(f, "ALLOC_MEMORY"), - MsgFunction::AllocCtxDma =3D> write!(f, "ALLOC_CTX_DMA"), - MsgFunction::AllocChannelDma =3D> write!(f, "ALLOC_CHANNEL_DMA= "), - MsgFunction::MapMemory =3D> write!(f, "MAP_MEMORY"), - MsgFunction::BindCtxDma =3D> write!(f, "BIND_CTX_DMA"), - MsgFunction::AllocObject =3D> write!(f, "ALLOC_OBJECT"), - MsgFunction::Free =3D> write!(f, "FREE"), - MsgFunction::Log =3D> write!(f, "LOG"), - MsgFunction::GetGspStaticInfo =3D> write!(f, "GET_GSP_STATIC_I= NFO"), - MsgFunction::SetRegistry =3D> write!(f, "SET_REGISTRY"), - MsgFunction::GspSetSystemInfo =3D> write!(f, "GSP_SET_SYSTEM_I= NFO"), - MsgFunction::GspInitPostObjGpu =3D> write!(f, "GSP_INIT_POST_O= BJGPU"), - MsgFunction::GspRmControl =3D> write!(f, "GSP_RM_CONTROL"), - MsgFunction::GetStaticInfo =3D> write!(f, "GET_STATIC_INFO"), - - // Event codes - MsgFunction::GspInitDone =3D> write!(f, "INIT_DONE"), - MsgFunction::GspRunCpuSequencer =3D> write!(f, "RUN_CPU_SEQUEN= CER"), - MsgFunction::PostEvent =3D> write!(f, "POST_EVENT"), - MsgFunction::RcTriggered =3D> write!(f, "RC_TRIGGERED"), - MsgFunction::MmuFaultQueued =3D> write!(f, "MMU_FAULT_QUEUED"), - MsgFunction::OsErrorLog =3D> write!(f, "OS_ERROR_LOG"), - MsgFunction::GspPostNoCat =3D> write!(f, "NOCAT"), - MsgFunction::GspLockdownNotice =3D> write!(f, "LOCKDOWN_NOTICE= "), - MsgFunction::UcodeLibOsPrint =3D> write!(f, "LIBOS_PRINT"), - } - } -} - impl TryFrom for MsgFunction { type Error =3D kernel::error::Error; =20 @@ -330,22 +292,6 @@ pub(crate) enum SeqBufOpcode { RegWrite =3D bindings::GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_WRITE, } =20 -impl fmt::Display for SeqBufOpcode { - fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - match self { - SeqBufOpcode::CoreReset =3D> write!(f, "CORE_RESET"), - SeqBufOpcode::CoreResume =3D> write!(f, "CORE_RESUME"), - SeqBufOpcode::CoreStart =3D> write!(f, "CORE_START"), - SeqBufOpcode::CoreWaitForHalt =3D> write!(f, "CORE_WAIT_FOR_HA= LT"), - SeqBufOpcode::DelayUs =3D> write!(f, "DELAY_US"), - SeqBufOpcode::RegModify =3D> write!(f, "REG_MODIFY"), - SeqBufOpcode::RegPoll =3D> write!(f, "REG_POLL"), - SeqBufOpcode::RegStore =3D> write!(f, "REG_STORE"), - SeqBufOpcode::RegWrite =3D> write!(f, "REG_WRITE"), - } - } -} - impl TryFrom for SeqBufOpcode { type Error =3D kernel::error::Error; =20 --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B47C320CCC; Tue, 16 Dec 2025 04:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859287; cv=fail; b=WYql3YoKCBqxDh4Ja5Q0zGfGnbnwSuA5mCjWEXIuUMx2VO2wZKsWeguurfWgAe9HWH6/RbCck3LR0+PjcHR98ElTz7m15b/s6i6TgD0JSvnvGJTa32Gf8LL5Av0mHOKcj5OFaYyzq36gDXB8COEekBFGiJ8kBGPWPxUf8ExUPuM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859287; c=relaxed/simple; bh=CnnPR45p4A1tdchK2USm3wslzKSkNb2Io5AJRBpLPqg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NekvIhfNH/LiEOLmPAH0XRDK6a3NPhZj4MwykjJP+pqvDsvFF16yrUDZj3PIm1SEfJDcAjy5jFL9IF5oH60L7vUCja61/AxvBL6QNs8yi6qoAxTGuCoWQ01Tz41wsMl5DzEHR3VfNlZMs/jHUUZ++flcdWfjHmJdb0DE3AVYc0A= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=TMJO5uPe; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="TMJO5uPe" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jWMuMfvR/kyWQdg2ejLxfblFQPvHR2cYwfcbdrbkinvSQD1VkQZW37CNwhWKAXrB/NM5RjjAnboI0JIVqlSyrIkYZDt3jqwyMISqp1h1KblprO4A+FRqudxWHB2gXh+weW3GEjBZRomcV0i1IEsJoTyEg6ast9OrjkUwmJ28myl4JSKOx9smMsz1J/2+5W+XhkK/hgw5HfGxXPtYhtIrpZZDz/mHRah4KqiAmCbOUaH9CqenkZYiVsA/nIquo0wcGsE/0JJL5FMO2e06ZLg6JWF00V+JnxzM4VgLEtXWAxdBQqOOW+xyhreygQoNpIZVMiVhSTHtAn5uw04ipZhS4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cbPS1qOWsNVkwKaXmGpWkNEovpETxVLB51+i6hKnS3s=; b=KrHnPDfPCKsBD70rNkfyX+7CJxhNR0kBhdjGRy2t+fiKHd6zD6JuVcHXqfWGOrVcUex883N5Stq4WGUlTQJvt5seSd/QA98pYHb5lR5wshiOk3DBh0snrGN49k+qtyFBxODeHnqLZCez6bjsDEhaXy7dP4JFmQu/SoRvs81mYR9JdGwfsmvRpT+tvM9SwMuc1ylxZzjdFR4YqLKUAI/3PEpc2O3rHlYb5/o94PEJ92+g0tVYFd3YaRdy4O1gV6KHnQ9RCE5n9oDQYxVF1XfXDAIcFLokFhb98j6ZRrZ6ByQQKJKO7+OcenjwPZV1yiQ7Tufg8f5w3rFVcwNBesLWSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cbPS1qOWsNVkwKaXmGpWkNEovpETxVLB51+i6hKnS3s=; b=TMJO5uPeS75YMICs9/pAmOZxQO/iQ/e4t5m3I8bdpyJwtFzBUKXdpvl9uaclcuHyrC+Tyhdd1Wq62QmPnnf0IXdMyKCNWCNQlQeT3SXaV1gp24RKyaAiIuHuGzohuZ3UmIJtrw6zNI0jYfC3hL7XIxD1cwVEAUnS9Kllz6C/4hbZccNqwAMNN6uZKEgTcFzMgNz5WI25eHyyrp7mgNkZi8qwPIMgQAFAuRM5HcWJzLFRD4yUk/Eo/cEatJguqqOMTEfqPkkhCmj6fWr14W3tYMS/sEEBG/RauG14a16AuW23oWmjtdYiql8IPpU5GcZM8M0WOepozYdrtHKBOXV4pA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:37 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:37 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:23 +0900 Subject: [PATCH v2 03/10] gpu: nova-core: gsp: simplify sequencer opcode parsing Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-3-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0343.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38e::11) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e746080-2f98-45d8-0a4d-08de3c5b7135 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OUF1QTNEMFFWUDBZYkdBSnp1UjNQaFhYeExhS2pKeTFQcUdWS3B3YW0vNGh6?= =?utf-8?B?YUxFbUwwVXRwYU1SYWhVR1VSWVhaQ3ZCVHFjb3B0S0ltcFVQVGczUGl5czds?= =?utf-8?B?eHM0OHFacUpwci95VlphZmZpMURVRVdvV3lVTkZqU1NBdHRrbHlLR2ZBVkRQ?= =?utf-8?B?aTZWREZhRHE2RXFBYU5mY1EyS3hKd1hrOENtNysxZ3NCMGkwWTNKZlpSZWgv?= =?utf-8?B?VUxGZWxxOFp4bkFkNXZaZUdNcS9HQVg1b2NwT2NEclJDVm8xeXFicGp3WWI2?= =?utf-8?B?ZDFYeUk0WWttcFN0OFRjYUNkdFBRUW9CWWladElpdldsS25yYkZCS2sxY0dp?= =?utf-8?B?M2tUbFNhS0tnSk5oSVJFRWtDTHNZRGVYMFhWdDg5N3NNYWl6Q2xuT0p1YVpL?= =?utf-8?B?U21Lai9nUHZPWGZnekVHZVUxRS9nOXN3ZzBDTEJkNFdsSTAzL1ZZem5Lbm5p?= =?utf-8?B?TWtIYzBHQ2RhcEJRSS9YZUZtRktLY09BT3V0UC9FR0JPSUlGb3k1Q3hyKytW?= =?utf-8?B?dDRTcGtCYWhpcW8xK1BYd21oRnpiYkZxd1VmSEZoZVZaT3NIZ012S1VtUXlM?= =?utf-8?B?ODl6WnliTmRCcGFGdzBaalQ2NUZpa09QRU1ZRUJtNVdGakZuazBiT0FiRnJY?= =?utf-8?B?ckwxOUF5dEdkZElSMm1aNnljUjB0SGdBWjhXa2hva21aVjhHT2tRMHlIVDlY?= =?utf-8?B?VUREcWJkNndtZ3RUUm82RWZuakgwZkhpVlpmU0l3ckhGN0NMM2pjNG5MdllR?= =?utf-8?B?WXErUU1rZm9WM1NWYlZQZUlwUjN0RjJ3ZDZsYUkyMTJUMmtCM3grZ0pHOVIx?= =?utf-8?B?YW5GWUFYb1BsMjhJYXRTbkJPdFZaRDJGMlNuT3p3ck1jNGh1TUhDRXYyNVlr?= =?utf-8?B?eC90a0E3UnRTYUpVTStXTXdsMWh4Y3dIaXVnaVcxNjFjeGRsa1dieTB6UUxj?= =?utf-8?B?d0ZNd1E5NVZEWmVrWGw2Tkc5VHZZMWlzUnQwSzZSb0xBYmtVRjBKT0hRMHQw?= =?utf-8?B?ZklPY2lCcS9mZHUrN1RuZWJaeU5lTTRUdnpkeFUyRVFnLysvQVBBZWc2Rmx2?= =?utf-8?B?ejVkYkhCcnFGMzREcmtEZVV5V0FDZXk2cU1EZzVzYVVWTHZRQ0VSM0Nwb1VG?= =?utf-8?B?cEtIaFN4Tnhaa2ZISUwzcXNWU3ZIQXFFUFVZYzZNd1lSVk5iZjh2dzJFNlFj?= =?utf-8?B?K3AxTzhiOUd1WGxISTJFei8wM0FNQTJ5dVJPblRyODYwNWdoOGZ4ZUhMZEtU?= =?utf-8?B?NWl5U2xEZ1psNG5SZExzdjROcmxCRTlEdDNaRmU0b3p6L1RLalBNTlM1S3JL?= =?utf-8?B?SHZDTUVERVoyeElRdm5KbERhUG0vOWJ6MnBPZGVhQ1hsUWhiY3IrMnp5WjNr?= =?utf-8?B?bVdSVFhTeUtOdGszRlZPeFJCVnBsUjFFa2ptWU82dXlIcjBEUnhkSmJ4Zmg0?= =?utf-8?B?blpmUlFoZzlQWXgrYXpHYWtkQVFDd0R3Q2puRWR1aUhIbFBsdmhMV2dieGdx?= =?utf-8?B?L1BJTVE3eGc4S2hqbGYxK3pwTk1VT1Avb3d1QXdHKzB6ejVKNkhTdmRvRlJT?= =?utf-8?B?K3ZJbDlqZDVCUTVldUdpM0FzcUE4ZmF4dENKQWtCN1E3SHljdFljR1dySXds?= =?utf-8?B?WFBiS29TMXl1N1R0eE5nRllsSW1UWWwxTXFEY1c2NFhJdTJvNkZjclpHZnRL?= =?utf-8?B?Sm1lNHRQM2EvSmExSzlCT2tUMmNFdUIxeG5qY1o3MnA3c1B6SUdoelZHTVlN?= =?utf-8?B?QVVnSlY5azJpU0RJa0JTaFZtUVNaeXg0dmRYcHcrK0FRRDl1cE92YjViRFdz?= =?utf-8?B?RUN5UVU3eEJSdlp4RlN6ZDcyUFRkTFJTc2JjUkVFa00zV2RRYVlLSDFNQ0lE?= =?utf-8?B?Q05JbzFsWFJvUkYvWENiQmlBVXlCc2pOYzdPREpxKzREblZoYVowK1dnM29t?= =?utf-8?Q?NF1LIg+zuMURKzN5Vr5L/ctIfCOBgfLs?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RStwTk0wc1hIMkFabThDZVcxLzlIZG9yaWpnM1NSVERiZWdQN2RHVGhOenJC?= =?utf-8?B?ZndnR25wbGVEVGhzZVZMdU1JV2I2K0h2Y1c1d28wSnJ0blpTcUlDMUJXaGJG?= =?utf-8?B?LzQzdnd5aFVTU3FVeWdKZXpUc0FuUVVqaFRjcERweHJuY1UzamRxMnhHMGtL?= =?utf-8?B?N2czSkpSZyt2VkZ4amV3NXhLQ1AwTmwweUkzZ2RwUHQ3cEFQcXVaeWl3ckFJ?= =?utf-8?B?MzNlWm8zVDFzTXNZb0hRT3N6R056T01oNXBuSDZzUkU1MXFBUElzTnJPMFVK?= =?utf-8?B?NWVrRWtEcXlUUnZ2VW00Z0ZKTkhrOHg0Q24rWUJMQUQ3cUxGZnpQREVabnZ5?= =?utf-8?B?SHZiUlVKVkVZK015MUdzWW9xMjFMNmh2OEFlYUkwWmVmSG9VL3pQMW5MRWZR?= =?utf-8?B?OFcyNklPTVJoL1VNM0V1RUV0Ly9XVWdnOGpYUFJ4QlNwYnR5blB4dmdjMkMw?= =?utf-8?B?VElBdDBzN0prbGxTamRTWWdVR2wrWWN4UTZUMmEzRE1kZERHbEkvQXRQeVlo?= =?utf-8?B?QTBUTHJJTFBLL0pDWTNSM0p1WjJaZkxCOGlGNkVRV01qSFZmRmxSZi9WTHNK?= =?utf-8?B?MTZEeHdMdjFyOHlENWpKU0JGcktvNWd4RW92NXkwWS9zV2JZNmdpN1FHUVM2?= =?utf-8?B?NzQ5ZGF5ZlJzMkxaRitJQUpEUVV1Wm04WFJ6OTJ6WUI0NmU2SzZKQXpnZGNP?= =?utf-8?B?OXpLc2tRejJIKzZnOFJhR09ERk1kSEtoSDB2elV2ZmVaWG9VYTJvYXhWQXNQ?= =?utf-8?B?Wms3WWNRaW52UzBaYnF2TDFLa3pzaXdNT1BRRTVYd2MwK3hBTnlmNEgxbjZU?= =?utf-8?B?QjNUME5NeG1LK20wNzZrRFBkancrZkloRVVESndoNmNMWVVLRm4zK2hMMVJF?= =?utf-8?B?WjlRSzQyTUlzSVl3ZzEyTFNSdXJOZ2VZMVpueFhZSmUwWGtLaDBTUHViRW1k?= =?utf-8?B?YnhNNUdUVnArTGlqM0pkellkMU5QVW9vaVpFbW9qTTVpUlNEYnVrUWE1dVFS?= =?utf-8?B?SHpSS2NZRTkycWtEMXVrSmE2Wi82anV6c1ByaU5TSnJ1bkcvZ3VrbjhCcnhn?= =?utf-8?B?elNJTjJiRDhkVXI4WnAyTzIvM3V5MlFGN0RtQ0pKamNVRC83b3VuUDZKNWts?= =?utf-8?B?WWtuVFJ3Y1BqcmRFbFlpY1FLTnZYdDFhWjNUbzNJYkUyRW1GWjFFdHFzbDdt?= =?utf-8?B?OVM4MVRZb1d5QVowMS8vMkVnU2pLWEV5TDBsRzhPd1pFWDZ1MUgwZkQzbWd1?= =?utf-8?B?SXAzWXlSSnFvSWdDSTFWV2tURTZDS2pLblBiTnMxUEpaaXpZRm9HUjZFR1Ri?= =?utf-8?B?WCtWM3V6b1l2M0IwTFpuaVpyYWlROWRuYXRRVGlMZTFQVlhUSW1SOVRiaUly?= =?utf-8?B?V0ZaaFJ4SktFRkxkL3V4bUpBbkxJS095RGJKUlRKVEM0R0pxTXlzVkxXTkF4?= =?utf-8?B?eHlYbmhPbDBhZGJzTzJUc1UzeDdyMDZZQ09OK2QrZC9aK1pQcVRzb21aNzJ5?= =?utf-8?B?ZHRNbFlzRmNOdVZiL3dKcjJJMURsQ2E1S2pTUTNlVlpUU0JVbG5SZzV4Z3Ja?= =?utf-8?B?bnNUb0xqbGVHSlh2cjdrL3RGMTA1dWJTR0xpSk5TcVNWSVFaUk0wcC9vNGIv?= =?utf-8?B?aldycDYzVDFIOXRzbHRhazIvTTJWcHB5eko3emg3T1ArNStQb1Y3cFRlWVFq?= =?utf-8?B?ZUo4WEJ3RnVXN0FtbmJRRWIrOGlUTTZQbW9qWGRCK3BiMjlkWGJBbjlITkhP?= =?utf-8?B?cWNpSHlIMk1sWjMvcSttZXJ0V3F1M1lUYk1WK1F5QlFvSFBwalJYMERyR1N1?= =?utf-8?B?VjhNcjdLZjgvaXFwRDFwbHR4ZDBrcXR5TTVBTXZoYnl6VHV6NkRLd1lpRngz?= =?utf-8?B?ejUzdmFzSWpaK2FXSUdmVS9VMXUyVDR5bkVBM1o4ajhEYWd0eXo5QTF4ZlE5?= =?utf-8?B?MThhZU41TUdVRzlvUkM5a2RzUUZHZ0hxU3FNRlJCd3pLWDN1V0JOck5LcCtt?= =?utf-8?B?Wit1enRZWlFLMC9veHlrR1BUV2l6SERtNXR5L2c1VG9mRW5vSUQ5V0wvMHA3?= =?utf-8?B?dFducHo2RGpoQWRWQzhRTzN1b3ROZHR2S291RE93S3g4dHE0MWs0LzVTRGh0?= =?utf-8?B?VVh3ekxyNU1lbUVPeWU3V1pMaVNkT3ljZWpvQXdHbzFZQjJIaXJrdnJaaWxq?= =?utf-8?Q?FX+SYI+Ks45xl3nK9Ug/nf53PmT+fpUOFHGizLNbrEf9?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e746080-2f98-45d8-0a4d-08de3c5b7135 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:37.3284 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lh6WlZdW1OCSdu2eNZw5kIdiNaLP3PHY36osBgEzwqngK/5xxLVW7UbYnrFo/XdM/InZ8zoOgjbDfKIW/up1lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 The opcodes are already the right type in the C union, so we can use them directly instead of converting them to a byte stream and back again using `FromBytes`. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/fw.rs | 40 +++++--------------------------------= --- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index de251a143f7b..1b0fcbdc77ba 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -472,13 +472,7 @@ pub(crate) fn reg_write_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegWrite`, so union contains = valid `RegWritePayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regWrite).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegWritePayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegWritePayload(unsafe { self.0.payload.regWrite })) } =20 /// Returns the register modify payload by value. @@ -489,13 +483,7 @@ pub(crate) fn reg_modify_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegModify`, so union contains= valid `RegModifyPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regModify).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegModifyPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegModifyPayload(unsafe { self.0.payload.regModify })) } =20 /// Returns the register poll payload by value. @@ -506,13 +494,7 @@ pub(crate) fn reg_poll_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegPoll`, so union contains v= alid `RegPollPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regPoll).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegPollPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegPollPayload(unsafe { self.0.payload.regPoll })) } =20 /// Returns the delay payload by value. @@ -523,13 +505,7 @@ pub(crate) fn delay_us_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `DelayUs`, so union contains v= alid `DelayUsPayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.delayUs).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*DelayUsPayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(DelayUsPayload(unsafe { self.0.payload.delayUs })) } =20 /// Returns the register store payload by value. @@ -540,13 +516,7 @@ pub(crate) fn reg_store_payload(&self) -> Result { return Err(EINVAL); } // SAFETY: Opcode is verified to be `RegStore`, so union contains = valid `RegStorePayload`. - let payload_bytes =3D unsafe { - core::slice::from_raw_parts( - core::ptr::addr_of!(self.0.payload.regStore).cast::(), - core::mem::size_of::(), - ) - }; - Ok(*RegStorePayload::from_bytes(payload_bytes).ok_or(EINVAL)?) + Ok(RegStorePayload(unsafe { self.0.payload.regStore })) } } =20 --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013029.outbound.protection.outlook.com [40.107.201.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C881327BE4; Tue, 16 Dec 2025 04:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859297; cv=fail; b=Kfj9parY8AAHnMg3/nn13U31Q7n+yPxNVYhihO5rNonKoddDTpAeZQc0IBFq172lOLy1XqgXKe9rB7LQD3/ZD10Cc4ll467/snpapBGuYG5k+JtO6KdF6VMqURL5xoX2xeQhzYeD1BbAW5IqnWhi/L/loGBJK4Nzvb1sA/AIQNg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859297; c=relaxed/simple; bh=tU39N9ZTYQwK43ShEaxhyX3Zpe4bKrmUJhV+fZgzuoI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=fQEq9fKwBeD8Jt87fxfJ/Frh4M6dkMhIYLlgMmakKZiw5lPAIy5iOy39s0zfwewpZHotv96/Mgl+sjcvIoFYJbY6axB3byBSl7gbVCqIlY1ldhYDuG7usWqXMDB4Z4wf2Kh1t5gwFkWmsH6I8QUaTnP3YFM02QUd9ZIA8Ugre5c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=uJZiuvcq; arc=fail smtp.client-ip=40.107.201.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="uJZiuvcq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yC/I0CyfK6uqrQXfkIgZSAhn/VjJfPphxU0Sv17E/bqeOxWf4Gpj7DJflMQoyRYhPLspRs+XV90+BpL25xjbqSScrgGDzFOciEPw/6uKGMn0wTIVeNkwh7bcSm1fnOS9m6MdMZ8mETMRmOCozRCg1M9A2Smj+V+Mz2m/2S9rZouFP/OH3xfSNkGTYBv1ZMTHkw3s5Bgci7L4lU5nlY2C6ia2FDIjzVq+lWoGUtKA8kwwUKNS/HKKz/2axPD/ASkUE3ByKR8gQ0+M6RLmDx5Dj4/RYD76uchK773K9d8h7IcvgPCXhv15bxh1SwUeSKOLHEqdV0fZQqLGyvvoq3avmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cwqcrBzvc69hPzsM9kMseTTGXumYvZiqJyMn7FE3Gac=; b=F0kuByUAU71BYS7Bc8YCUWuEIdkZ68l7LS5gNQe/aieQoBqfr2TbhGt6EDnpilNwUj2VYZ1dJ8Gij7/KfcKy2JNrjvMWgBQbXcWsKzYdYnhshvDEusaJ+vkB1mlUdX9GhBK0ZZS1IyYqmTO6JOSe3xqsz+AEDh7WDdL23fiC3KcqkPaUWZC0z4srmU5yGSlkAWvOdATcyqJRSNDPPCoY9faQWJkJQMaNiuF2ROOqquB+zmo1bVfWJ5k17KNjLJYo4lKNMYPCVhcILUowxLwofM+7yWfXPPNddCTRkspVacar/PLcnd79fAF5r5YcRMr/iPHmw6WCWvvoxNumcm8+yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cwqcrBzvc69hPzsM9kMseTTGXumYvZiqJyMn7FE3Gac=; b=uJZiuvcqFgpTRmN3uWuv+c+c4Zm4eOCWxfjWqKVzcExlqVuFh3tQSsTe9kU4DBM2EKW+xKs8DZxpG3pSLEZS+aNh9X4EDOmGKbLVSCQe/2x+waUm7wrJJ55QleAPADydr7TH4u/PfvBMIIRFGi0Sy1n6YosIxptHUInCeWjGmCcqiDYajBydESllW91rAZgvBlxRqbrvJGx5mPSdxIgIIMA9ch8HPlqEkc+DjmJt/ixEs7yGfzQAQ0HCGib0T5hZ84wTyBQbqLMw1o0C2sDGieWlZr8HzZHbnZdxCvQPuyZtwoQJn2mFtDzb6woz1eHOMuFWgwRsSwlqOYMHHQyTvA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:40 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:40 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:24 +0900 Subject: [PATCH v2 04/10] gpu: nova-core: gsp: remove unneeded sequencer trait Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-4-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY1PR01CA0200.jpnprd01.prod.outlook.com (2603:1096:403::30) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: 617ac1cf-415c-4b87-5b16-08de3c5b7334 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cFJ4eDNyaG5nWm1rTmF0NUZJOXp3N0UvT2FJak8xeFBRR2pYS1BHVkJWWVlL?= =?utf-8?B?cU0xQy9ORENjek0yQXZhdnE2UHF2cGxkSEFNU0U5clEzV3lHR0J6T3htc0NL?= =?utf-8?B?YXNFdWx3NVdjcGhjYXJiUDhmanNMWWVLUzI4aWFpSGE4bkl4RHZ2NmhNalY5?= =?utf-8?B?Tmx1dUhHNTdYNU1IVjVlTXgvU28zL0loRnNPVlVXWU43c1pscTM0cHVFTU96?= =?utf-8?B?ZnprL21nNmRnSFBDTlhHQnhrV3hSOERNRXhQOHZwM0g5NHRQVUlCTm9DZ1FU?= =?utf-8?B?ZEllVVdONVZvb29zQUdwUjRCOVM5RVI0MzBOYnhpRUovbkIwTnljNmQxaUEz?= =?utf-8?B?YnFHdlhWeDUrQ2NMNmM4ZFlqbmNONU9EYXNFWWFiK2hQRjdxYkx4aXk2aG83?= =?utf-8?B?dVJyTHBPd1pYRW5vK0ZmNG5iOTRlN0UwL3RxVHNyQlBOWk9RVk9KQjNzWWM2?= =?utf-8?B?QjJhUi9OK25xanBSMGxCdnc2dmdHdkVqdEhLMVdWL3NQdjJUOVlydWFTS09L?= =?utf-8?B?RkJCRHZKQW93M2xWWHdZK0RqUExoRUJ2REhGa0ZSV2IxQ0lMc3paZncrakox?= =?utf-8?B?UkFhRmhjb1hFdjdQVGlkd0MwVVo1Vm9ZRk96eHBHZ28xaUtTRlg5bkJPOXU1?= =?utf-8?B?Vy9lWWJibVpyZm82cGU0bWNkSG1XZW5Na0RGeFJEQ2hHcjdrZkVZR1JFQW1M?= =?utf-8?B?bkNhMkllQWg0ZElZci9QbmtxRG0yd2ovZmRpdkM5T2ZVcjFLeVVXSnZZcmVL?= =?utf-8?B?MXBvS0k0NGZmT3JZRHpkTnZ2NCt3NW14M0pmNnE0a2pYYnhZT3pCNUY2QlNr?= =?utf-8?B?WjB5ekxsb0NqRlZvN2dqNnFzUmg5ZXl5U3hvSUQ1dFB2em9ubE5jZEZRcXlF?= =?utf-8?B?OWQ1bm9WVWZzM0FUVXdWeFUxSXU3V3E5ZVRaTkMzbTlOakgvQ0lrTjVZeWp2?= =?utf-8?B?aXBRemJpZlhpYnpZcmJHN1drYXdrZ1l5WmtQV0xsc2xoREdoczd5K1N0R20w?= =?utf-8?B?ZkZvMFE2SkQrVHhGTDkxR3g5cWtXcE5vODVPeS92cW1YVVh3T3dmVlowdDNC?= =?utf-8?B?RGVoR05GUlJIMjcyRWZSNUoxbUpjcjlZN3FuK0hjZ2R6QnVZSjg0TEhJaWI0?= =?utf-8?B?SUQ3YURYazFuZG9maUNnc21VYmlraVN4T2IvaFFjblR5TW50YUhkMDF5YlV1?= =?utf-8?B?Y0p0UG14ZjhNb2NSWjBJM0Y5cURpbHNTWUtYU1RqNFRjTGdxZHArd2dIcHNH?= =?utf-8?B?Tnlsd3IwREpUR1hiWFBsMkcxU1dCTlBOdUNjSnE1RUZlOUgwNTZmSHpmTzd4?= =?utf-8?B?VTBOS3RubCtINHQvS2ptdXhkY3lvSEg2RjJLUFZKZTNSb0NCM093OFlBdnlZ?= =?utf-8?B?Tk9Ub3lrdG5qZUg2YUE1NzVhVmZmTXZrWUxIN0xCTmxKRXVtWGZGcDdRT1BQ?= =?utf-8?B?NTFJZHY4dEtXQ3YxWitTcmVPQlA2L2VUdWVpUEtIWWdyb0lOSlZVQkdiZTVk?= =?utf-8?B?dXdkQmJtM3VXcE1BbnJwWmdTTVVxbWZCSmRQWENMZXprREZiWWpPd0dycjNh?= =?utf-8?B?WTVKc3lBV1lKdEJCWUh5a1dXQnpIbC95RHM5SlVoR01kWTR4VFFzM3lNOXVI?= =?utf-8?B?aTR1MGp0V1NsODNDdWVjNzNIRU1QSGFDZEZLQy8yc1BzZlBSd2F6dis5V1E2?= =?utf-8?B?djBSM1dLbENGU2t1QlUyZjBib1JOeE90RVZPM0RMbXFyYWo0SWdTRGY4QmRh?= =?utf-8?B?ZE5CbzR4ampsU3NUeTZYTW4wdHd5QUVhY2RqM0JRRFdwM29QbENYMVcrbXpn?= =?utf-8?B?N0lBNlk3cnVkOVUzNWFZSHNhZjkzMTBJcFdobkxFRUFiczhBMXpiS3VhWW1x?= =?utf-8?B?eGZUQmRQU0JCNUd5WVYwb1RrRUpSSFplcnhlcGdlNTl3MW4wL0JreGEwY3E2?= =?utf-8?Q?2sKmRJop9BIpbcShSpYodCZsrqzP88ne?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzZLa3U0K3RnSWJMaDlHRlFMdDJQN2ppS0FvSTVndXphb01XYm0vUnR0Zyt4?= =?utf-8?B?SC9LdE1JUEhUUm1CZ0FsdHNpVERJSUZ1UVd0d3VzQzlkUThGY0RXMzBZclY4?= =?utf-8?B?cGQ0cHZ4ZFJ5TjVPOW9NL1hyN2V5ZkpyMldzMHkrZkEzR3lkUGRscmtTTGs2?= =?utf-8?B?THE2aFp4cUR3amI2bE1uamE5Rm1FYisyc0plZVA4czQ1TFVBL1hWTFhQeEVy?= =?utf-8?B?bktyM3lJL1Y3RittcG44M2xYUHB6ejF4RzN5Z2hoTWRUeENSOVBvWTFUT0JT?= =?utf-8?B?ZU96SjVtVG9ETDl6M2U3K2JSOTVDWmdNRXdTTVhuS1ptRzg5SXdaUU1qUjU3?= =?utf-8?B?NGdxYUh0OEhsVzllU1E2SjBMUUVHUjJmcHNpTS9ITlppeDVIUmVMeHJGdHdx?= =?utf-8?B?eXpLMnZicys2UzVLaTA1RTFHTTBjMWhzN2taOGRkTnAwZGRpTkhFWlIrdXhl?= =?utf-8?B?UVNDNXVzUW82TFlZWlJFOXN3MHB6OVBsKzR4UGdaY2VVVmZtZnliNERNTksw?= =?utf-8?B?ZUpHNGlZS3dzak84dmtSdHpkTVI4OFlUazJhL1Z4MFJSS3pZM242WXE3RDFV?= =?utf-8?B?U1pKRlFTaDBHSjkrUnhQeTFrd1dnUTlxNW5adFFOZWtEZFNrdG5VRnlEdDcx?= =?utf-8?B?eTY0NDdPUFJrL3NnREZmbkVFamZtV3FWQnljcE5ibTNzZ0hpL0RkZk5TVFpo?= =?utf-8?B?a0RwUWZ5MlpKZmRKNjlGNzFtK2NJWGM5c1FjdjRVWHlDR1doYnlZOXg4aXNN?= =?utf-8?B?dkRlZkg2ZEFQWjN1VmU0b1RYQ1ZERThPV2lITzNrd1BzWnh6cEFDTnB1TVRR?= =?utf-8?B?Mjh5NzVTUDNvcUl6N1BycTZ3d25UZDQrRDRXRG01ZU9CYjduSktNZlFpV3V6?= =?utf-8?B?K0VuZjNiQVMwTTVNVno3NlRSalc5V2xKU1FySjcvenVRZC9oSmVuK3U5ZEQ5?= =?utf-8?B?TmJVOVFRclZOTTNSU29JU1NFa084aE1oN1FuVnhtZUJHZW14ZlVQZ0NoOHFZ?= =?utf-8?B?NGZ6ZlVWa1RxMHFHYWJMNVE0YkIvNFZVTXVudk1zWDhrekhwTHoxWG9xRUE5?= =?utf-8?B?eENZNk1qR2cyMEdIV1VUQm1XZDZzSHlUaExPdS9ZWXNrTzRGMDVadjU2YWhD?= =?utf-8?B?dnFaMjZQWGdJRkNrTVJyMm8wSkhHdkswZXhqNnBiOTlJcUlmOXBZaUFjQllV?= =?utf-8?B?UGJ0eDlFM0FSZFdBbUdnQ05NS1A5TjYzT3VKQmwvcEo2TmkwV2JUY0dpOFFp?= =?utf-8?B?bFdpSDNqU2MvVkVIaUx1elhjN1VhTkRSNHc0QTViejVaS1BtNG1DaVFZMEI2?= =?utf-8?B?OFpIL3cwbGRoQ0xETTZWb1IzVnZ6cExhYlpDUFYvNmRnNzRDQW15UkFsZWZq?= =?utf-8?B?UXR4eWlRSmpBMStvQ3hrL3VoaDRZVVdnOG5uVnZLZ0I5bXVzU3RpYTloSzNy?= =?utf-8?B?Z1Z2UFNYejVBZVhHcE41U1pFTVBRUDhYL24zdlhmb0U5bXVBQlpTdkViMWFK?= =?utf-8?B?bVV5Y0N5Y1FUb2ZibDQzN0xkeG1vRFlkNkVKZXk3Nk8xcVhXUzVXM0RSZEFM?= =?utf-8?B?ejJ3RW5SZnI2K0o0Y2dQZGZ1TXdhV0NQazhqWU5mcUM1WTJ6NFRHS2FJb05C?= =?utf-8?B?WjkvdUwrWW0wUDE0WTJSNmdLSHp4d21LR0VGbXVrVkt4VTRWZTlaTytqWTYr?= =?utf-8?B?dzd5QUZ3eHExZWZLM2w4MzVsTUIwVG5UTGppcERQTzh0RE9aUHlua2pFOFlG?= =?utf-8?B?c1dHeVZnaENuY0Y5QWVpMHBaWkl3NnltWG8yKys4YnpyaEtnOVhXbEtLalBF?= =?utf-8?B?R1V1ZU1ITWh2WkZlR3FTbTRJWWRCSk1FK1o5RVZITWNNTG81OC9YS3I4S3gy?= =?utf-8?B?NCtKcjNrRUJBNUJVeG4rdW9VZFNZZ2k5QU50THcrUHNTUWVwR01XY0NzR2V6?= =?utf-8?B?TWovdWpkWmIydURIZjMyeXNhRHE4Rzc5T1Z0RTlMaVhMcm45NmNJVE8rV3Y2?= =?utf-8?B?R281c0txd3VpQ1dUSXZMQTd2WnlYRm1qRkpaWG42K2JkUUR2bGtjNjRlemNU?= =?utf-8?B?aUI0bFU2RmFXT0pwdlFQM3pIWG55ZFJjY1laNTZzdlIvUmlNOVo2MmRhV2Zt?= =?utf-8?B?WHkrcG8xY2J2YkZTeEZ3OFdzR1FrMHhpL1U5WHI5aDRDUzFGTHJENCtCa3BR?= =?utf-8?Q?OluJvmBJ5isCHwPZXiqnMNHeL+COxFLGqx0weKL9AQlJ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 617ac1cf-415c-4b87-5b16-08de3c5b7334 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:40.7084 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WGNbzfZZ2upROry0E4yidZFEpURJ93kDI3hlu/mfWDtuKCLkv1JAyeGWjTJPjCzFbXD3/EoHr5ZOFTfQSS8KaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 The `GspSeqCmdRunner` trait is never used as we never call the `run` methods from generic code. Remove it. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/sequencer.rs | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core= /gsp/sequencer.rs index 2d0369c49092..4efa048b9d93 100644 --- a/drivers/gpu/nova-core/gsp/sequencer.rs +++ b/drivers/gpu/nova-core/gsp/sequencer.rs @@ -147,12 +147,7 @@ pub(crate) struct GspSequencer<'a> { dev: ARef, } =20 -/// Trait for running sequencer commands. -pub(crate) trait GspSeqCmdRunner { - fn run(&self, sequencer: &GspSequencer<'_>) -> Result; -} - -impl GspSeqCmdRunner for fw::RegWritePayload { +impl fw::RegWritePayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -160,7 +155,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for fw::RegModifyPayload { +impl fw::RegModifyPayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -172,7 +167,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for fw::RegPollPayload { +impl fw::RegPollPayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -197,14 +192,14 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result= { } } =20 -impl GspSeqCmdRunner for fw::DelayUsPayload { +impl fw::DelayUsPayload { fn run(&self, _sequencer: &GspSequencer<'_>) -> Result { fsleep(Delta::from_micros(i64::from(self.val()))); Ok(()) } } =20 -impl GspSeqCmdRunner for fw::RegStorePayload { +impl fw::RegStorePayload { fn run(&self, sequencer: &GspSequencer<'_>) -> Result { let addr =3D usize::from_safe_cast(self.addr()); =20 @@ -212,7 +207,7 @@ fn run(&self, sequencer: &GspSequencer<'_>) -> Result { } } =20 -impl GspSeqCmdRunner for GspSeqCmd { +impl GspSeqCmd { fn run(&self, seq: &GspSequencer<'_>) -> Result { match self { GspSeqCmd::RegWrite(cmd) =3D> cmd.run(seq), --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829473128A1; Tue, 16 Dec 2025 04:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859291; cv=fail; b=b1jA9SO64EIrYDCW7Xdk9CWniJH1529ph6yO602BvBtYKJXecQTlk/j2gbuqQuTTy3n/kJpvKTwZOWR1b2Rt1G5aAxwEZkNpnCtfoZjdVQbNZhvphnKezPeuq+DxIUDMxq12UjvqotELDcTpkt0AqDAOvbixaYqowxWtNWHlZYg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859291; c=relaxed/simple; bh=EAB3zGjZ+63oT1QEMp74giPxXsqXot9t/gueefEeW6A=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gDRQugzwYDDAehQNb39Qy9C81o+sJydFfRFp6bFpj6dOReP9d/aeQJRirKqoAs7YlZE3VCUGo04aEbo7jQoLUx+Ud9ZabEeQqH3zTSeY5ONsxLXngpaSGhOtQU6KE0E56Z4HA0rBLu16o/QIIglIyLnDLZj8KQreQsyTYv0qvIk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=jm7u+6tz; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="jm7u+6tz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BYABl1Ih1ruuNiXA2KUdH4jZnVDoZckcP3NhKoGHFHD+I7PwU9BHxYBtobW51Ryd9wqyhNdQlYv/UHVzT3e/q34uWkiNw4mH7dUxfPVGZQHE6+tfXcxrg6wFhZwXDWVYxsm9BqziELzDWIbyvo24eoIYOEqgvvQB9e6ULej2/9Q65oEzGQJDRGG0Av2GwKH5SFndeEFVrF2KCXQOZ+au4/I+xqKIo10wUEUvk0tTgB+rPlwzQl26v/O9WYw6TtqUBZJdN7kJD+5jn0y3hsrwXp239FqvEBpK59VHI5ZBOIYQxEDyanMgNoNyZmFPLEIAuoDVkFkA3UoIh6/7nOAnJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TMxhFkxnluw2ekassvaNazMRqI9wmV8k2FcZ7a4rdmw=; b=aJPtmNd1Lgpk+2jmZ2i/vLu17atKlb2XLO+sK3htb9WANmQVAhXBIs9XqM9yOAMCa9V6YhlB07YgE3RfxENRD6LgjByBbRjuSi6SNrxg3bOIWw0S0NN0RIrykrkcTecHoKICEhSHS90oDid9xZftsGQ9uQeSEglpOWap7V2+abqb20Z/bqMJN7FEtC67ztVC7ly3fY0Tb91rcwSfj9ye9wVQIZu2MmSbQiekx2m2LXKE77rC2dP9EHhXmv2x2dhsBugysaUD7hRFZ3VnHstQFVjcv+35F3RB687daSfTOSmvtQxJ5lOQ+zMir0YiIZOdxZlS4I1FnbUAur6jbn5Kag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TMxhFkxnluw2ekassvaNazMRqI9wmV8k2FcZ7a4rdmw=; b=jm7u+6tzA+sX5cVQXJRTeVCZOj8/uwsn1Di9jzZgVDJZ120lqALzPAWkrSZCy5m3ba/oiNJsoOwyz8/R8pKmYh19siqONrq+7TwMioAam/n5Qnqsnn8Uhv+yOI/jvDIiJws2wHVCQTTjon9wsnIGz8JiJ0HD3s7z2XhT7zZoViUfgKrezySt8TuOnbt5rodGPqXuzg9hLmZBpwfgdN1Ui+mj63515xNsk1OgkBOzYIDVNlrP1E4JU9Vp4esG28xS+SHEKKTMzpvGdRX1ZXdnT/BQQGXcJR2tuifoIlHFmG8ZeMSCWS5uksfOXAKXziXTLLOWatzbT6eXyPL6ElHX8g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:44 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:44 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:25 +0900 Subject: [PATCH v2 05/10] gpu: nova-core: gsp: derive `Debug` on more sequencer types Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-5-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0111.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:380::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: bbbc6e90-f931-445b-8c07-08de3c5b756b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VS9WSC9CTmhPQnM2SE1YeTJET3lZVXNPdnVwOW93dHlueHlpd2J3dDhRSjJT?= =?utf-8?B?bjRnNitleUtWdFVyUUFhZjF5Y2xZLzE2ejc5TUZqMG83bUNLOFdPVXluc05y?= =?utf-8?B?RS9xVXFudHBiREhpeHoxemdpSG5zVGpTNDZVNmdtQ2tzOWwya2xrQms5TUtj?= =?utf-8?B?ZFFTejRtczhmQlhDcmI1cjZBNmhTWXU0VExiNkVyYkIxNjJkWjVtUThTWkpr?= =?utf-8?B?RFBEQjVFS1lTRnJxb2dvbFBBSC9PNmx2TDE3OHZyNStTeVJLR0Y5ckw3SFpu?= =?utf-8?B?UVo4MXV5S1BIbmYyOVlscHk3WDJDVUtKaVJ5RHFKSlVWZTBLdC9kdkVieGxz?= =?utf-8?B?QjBNeGQ5cVB5N3Q2SFlrTUswTGZQV2RsMHJjZHJCc3JROURXUW85cVRlVVk2?= =?utf-8?B?MjBORUgzL2dhaENlSE1NM2M5dUZTOVNKSzQ4cTFnOHgxcWZSM2xNQVBTQnRE?= =?utf-8?B?UFJqRkZ1aHRTeE1SQlBBcWI5ZlZKR0R4MnVQa3YzOWZ3akh2ZHdsenA2c044?= =?utf-8?B?bFA4UWR6WnhtODBML1d0aDBtOFl0dGpBVElQaEV1NmpCNTRCblM1eWZuc0Rm?= =?utf-8?B?MlZIdXB2enZaZmtTeEFKYVZHcC9oL3BGRDM0MHNicTArdmRnK0xRR0dLeGc2?= =?utf-8?B?cHZEcCtnUHBtQ3c2SkhIQ1V6K0E1TUhVR2NqMHpaUGZSWnFML05JU1R3WUpK?= =?utf-8?B?SG1jMTFFOEtTUEI0UC90cFNmWElCaUZkZ1UwTE0rYkhPUFFVRWVqZm1zelJ6?= =?utf-8?B?ZXFVTncvY1BMakRiZ1Y5Yy9wdlBtMTlaaGt3NEN6SWIzTkhoMWlGSHJDUmRw?= =?utf-8?B?Zi9TZ0FRcU8vb0lHM1pPbUhYWWdGa29EZ2J6MGVzL3ZOSXRBTXlkWnNka3F2?= =?utf-8?B?YlNKejZEaC9yMEdTNWRUOXJLNExmeVQ0RTFPcllqNnRQUHB6NzBCYUF0a1hz?= =?utf-8?B?STBYMTNJVjRNUUE3N3IzTkhNQUROVENwaGZYejJLb0k2cGdFNklNbldiK0xh?= =?utf-8?B?RlBWUGR1TmRFam9jMDNNQkQ5d1lsbWYxWnF5UFVZd3ptbWZIUFlqais0eVZW?= =?utf-8?B?Q2lORy8xNEdzdFc5enFyVVp2WVY1UzdpQUtlVktQYWhTN3dHYzFZcUlseVhl?= =?utf-8?B?NXJydCswaExSS29rKzBpb1R0NXFCdjJPWHRtT2xGZGcwYXdYTzJ3MEI0b1lO?= =?utf-8?B?QjhHVVZUUnozRHYxUUs4bElCS0Y2eDJWYUdvZXlKNlhIMlAzRDJEZ2dnYk9V?= =?utf-8?B?SmhaSGNMZnFZOGFONjV0TXBOdWRZOUFoUXNRZjl5Wk5uWHBxZ2E1VXR6RXE4?= =?utf-8?B?OXBUNU94ak54MExYbDdpMGN6b0tSbVFGdVVoUURveU5VRkFHZFBpNnFyY2Ji?= =?utf-8?B?V2hBNXZpY1IxUlVQeUFPNXQxZ3JHaURPdlc1MytCdTlnbThKVWpoc3BDUFN3?= =?utf-8?B?OXJ3a0Q0TVRDaHpTaldQSUNlaHRyekRWazZWUGl4RkpuMWlVOW1QMEdybW05?= =?utf-8?B?S1RHbTNpb0MyUzVKaC9haW5uV2sxRm5CLzIxcnhRS2x3QXRKY0FxVjdrMVR2?= =?utf-8?B?M3doNkRlbVJSMWpob3dsR0MvdGduSjhoYlJxWll1Z3YyWFBtUUNyWnc0NW1h?= =?utf-8?B?T01GbFNTRC9PN3ZlcmozU3E5eXM4YXNKREc0SmVCa3krN1kwS3JVQ2NwQU83?= =?utf-8?B?QmlFR21nTzdZVTNTdzFxL0dGRlQwNHRHdmw4NzA3MlJGczZMWHRyQ1doSmo5?= =?utf-8?B?M3pycVZ0L2pGS1RxVGxTVUc1OGFuakFNNGk0ZnU5Z3AwNGJKZFNtUE95Q24r?= =?utf-8?B?MHZjU0xhM0NFQWcrdVVlWlNNOVhsYVBmY2w2cGpkTUlBZ01YeXNreUNkamFh?= =?utf-8?B?Z0xxUE5SeTJ4cjlCWW5xNklObm9aaEl2MkxKbzdoSzYzbHVCeEt3Qm5PbDNZ?= =?utf-8?Q?kK8j11qhbDf71Gr7iU9ia9dXxg6gtXcl?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0I4bGdZRXRuNEIrdFdIMjMxd25kdTduSUFQMy9TSDNEa3ZuZ25EbTlld0py?= =?utf-8?B?TVJJczZUNGpDS3ZuN3lTQ3krbitHSUwrNFNLVTJ5SjQ3ZzB0ZGJNZDU3UlJ0?= =?utf-8?B?UEJuenE0R05DbW1VK0ltdGxVb1Y0RC9keXRxVEpqQTZoTFV6TU5UdVAzS2VM?= =?utf-8?B?aFByU1lsclIyOTcyVk01SEw0VUdoVzVVQ0R1UXdOQ2tNcUhIaWt5MEZ3VzFN?= =?utf-8?B?TTlKRWlSU1VzMmloajVFdGJqWlpsNlE5ekJvU010bHlSVG80WWdmaWRiMVRZ?= =?utf-8?B?ekhLR2tXZXpzbFBaLzZsc1dDQzNEbDg3MnRCZFBZeUE4T05HblhiWjV4T2o5?= =?utf-8?B?ZURQZTl6eldMalRTTUJmdmdmdFdzc2xrYjlYeDdNNHFGR2dXOTc5WXBxRWpn?= =?utf-8?B?WkZkWjgxc2VtSHRUVTk3NWxwQ1VYL0k4RzYvUHNQQ0RZZGtpZlJiMWk1VFZW?= =?utf-8?B?TkFqKzdmSFZPUFQ4SUlRdTBSQitSOGJ3NXh3Rm5KMGQzRUFvdXVGRlR5djFl?= =?utf-8?B?aTY3enZxeTZueklLZHoydmQ1a0c1VjhYQXpwYlNReUx3Q3VtR201RGhBTTFP?= =?utf-8?B?Mkc1eW5OejZEVkZyUVVXZDZTa0dsQmY3NkRsVjdBeC9ZRVZBd2wvVlZ4SnBz?= =?utf-8?B?SnRVdC9JQ1BNZWwxbDZGSTJEZXRjZVE3ZEl5bFdqc0FLenJreWtCc0NxTkww?= =?utf-8?B?OThqNXBVNmMrT1pnNzYvUlI5Z1pEY1VDVzFyWDJjdU9hN2NMdXk4cU9FMlgx?= =?utf-8?B?NWlwa2dRa292WDFLT0I5Y1hlTG1VRTQ0dHk2WWpTRm1CTDBwRjA2QmpBWUI5?= =?utf-8?B?WjAzVVJvM1pZZ1gxNnlGV0lESE1CSDFLY1VoeE5NOEFISTFGVVhmNFZVd3Yw?= =?utf-8?B?ZWg2Y1d6QTVlMFZNWU91TFRqQnVYREdsVVlKRm1SOWlNMFBKTDE3bFhVRVI2?= =?utf-8?B?bnlwWU15cE9LRHdNUzZ2cFQ1RUwxalJkdWdYT0RUVnJQalI1bDlKK0hTR1JH?= =?utf-8?B?Qm90M0pmWE44YVA5SmJoZVdpdGE2RGNXY3NnR25DUzRBb1o1a3RaSDZHRkhE?= =?utf-8?B?cGdhUkZJM3N5SmxEblg0eGVkQ2RsdHhKMHliUW9TNHlwOTZ0ckdaUHREN2RE?= =?utf-8?B?SlJvZzVPL3lnWStkbGF4QTlNK0k4U3Q3YzhtbDVlYWVYVnB0QTdRR1NLRzJE?= =?utf-8?B?WVJTa0JEV2c4L3hkMkZtNVU1MGdqWVBqWWhVRDlORGphTWZ6OHRBNGRydnd2?= =?utf-8?B?Y1BJNlV1bFlJaUlYZHdMaFhTK1JqRUFrWjgxQ2ZnZTBjWVR0VmRhcngxcEll?= =?utf-8?B?R0Q3L0NrQUtrSkxQbEdpRkYyYmwyRTVtQzhaYm5qcGJlODUvVGlWMWRJZDhw?= =?utf-8?B?eU5FNy94em9hNjRsYm9WL29tWG1ScXFhMFJQbjlaeUsxdGtEVnluOE5NYUJC?= =?utf-8?B?SFBwTFowUXk4MEpSVCsxSUdrVlBtY2sxK1cvb0Mrc29BU0xkaEZZcTM5OUVu?= =?utf-8?B?WDFqTDZOKzhqMDh4bEIyczM0alJndHJNT3FGcC85SC9SMVUyRlcrd0lCVnph?= =?utf-8?B?WXllaU9oZWlaemZWWWNyVFM3RmdtVTZFQVlMdlRhY0RSZExFN0EzYmYvZEFC?= =?utf-8?B?MWkvSU9WZHVQTXA3V3R3dTlLQmdOYjFIN2l3NzFxeStGQ2JrRDVYRlQ5NVZI?= =?utf-8?B?MmJTVjQ5cEJGZ2hCWHdSeFluK1ljMkRxM0plNkdVZi90eE9YU3IwY3c5NEVE?= =?utf-8?B?Q3czc3RBcTIzQ2FoSkthQTlmMXFZWHkyd05IYjZIaUYzOXpiMmpYaFBqS1Q5?= =?utf-8?B?Yk1xbmlRYjRsQVI5aTg4QnI5aE9vTVZqRjhBK09IK1BNbzBUUngrNnhKUklH?= =?utf-8?B?MGl1RmNKV1NhRi9pcHRtSC96WGhKMWdHODMzamVHM0RSVlNoVzBQVFJjVDFw?= =?utf-8?B?cWZxa01JMEZzWUJBeFdYUnhOMVVhTW5jQTB4dFhhVlc5aEJTM1ZZTXU0ZGd0?= =?utf-8?B?dXZpd1FBS09WcUsvN3hqTEJsMzZXbmpQeTgwamtBUEVLRHNrNHdrOE1yMkJI?= =?utf-8?B?SnZLZkY5SEVHNnFXMS9oOWFzREFPaTdsYjNDZ3dsa0FpbUhSOVhHcjUzYks5?= =?utf-8?B?aHpJSlpxZUs0Y3Ruem1GY0FIS1pYT2h3Zmdwb2Q3bHR1aldVQ05ESmMxekZZ?= =?utf-8?Q?3b4u3vhaKwSd20tTo9QdqsfuHwUH2BvPd86ZRCURLa6f?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: bbbc6e90-f931-445b-8c07-08de3c5b756b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:44.4082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IgdidOrwMj62YXjZXnH8hGmuHSW3biOckrm5YSSSxIx2ePWhYC92HPBr/S7TgghLyldm61AUh9I/9V/MlagK6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 Being able to print these is useful when debugging the sequencer. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/fw.rs | 10 +++++----- drivers/gpu/nova-core/gsp/sequencer.rs | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 1b0fcbdc77ba..09549f7db52d 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -330,7 +330,7 @@ fn from(value: SeqBufOpcode) -> Self { =20 /// Wrapper for GSP sequencer register write payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegWritePayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_WRITE); =20 impl RegWritePayload { @@ -353,7 +353,7 @@ unsafe impl AsBytes for RegWritePayload {} =20 /// Wrapper for GSP sequencer register modify payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegModifyPayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_MODIF= Y); =20 impl RegModifyPayload { @@ -381,7 +381,7 @@ unsafe impl AsBytes for RegModifyPayload {} =20 /// Wrapper for GSP sequencer register poll payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegPollPayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_POLL); =20 impl RegPollPayload { @@ -414,7 +414,7 @@ unsafe impl AsBytes for RegPollPayload {} =20 /// Wrapper for GSP sequencer delay payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct DelayUsPayload(bindings::GSP_SEQ_BUF_PAYLOAD_DELAY_US); =20 impl DelayUsPayload { @@ -432,7 +432,7 @@ unsafe impl AsBytes for DelayUsPayload {} =20 /// Wrapper for GSP sequencer register store payload. #[repr(transparent)] -#[derive(Copy, Clone)] +#[derive(Copy, Clone, Debug)] pub(crate) struct RegStorePayload(bindings::GSP_SEQ_BUF_PAYLOAD_REG_STORE); =20 impl RegStorePayload { diff --git a/drivers/gpu/nova-core/gsp/sequencer.rs b/drivers/gpu/nova-core= /gsp/sequencer.rs index 4efa048b9d93..5eead7ad4cbd 100644 --- a/drivers/gpu/nova-core/gsp/sequencer.rs +++ b/drivers/gpu/nova-core/gsp/sequencer.rs @@ -70,6 +70,7 @@ fn read( /// GSP Sequencer Command types with payload data. /// Commands have an opcode and an opcode-dependent struct. #[allow(clippy::enum_variant_names)] +#[derive(Debug)] pub(crate) enum GspSeqCmd { RegWrite(fw::RegWritePayload), RegModify(fw::RegModifyPayload), --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5DE232D7E6; Tue, 16 Dec 2025 04:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859296; cv=fail; b=KJqXPsIFywqD5HfOngFkSslgX69dtT+fHb7vlVNfDjB3eq+e8Cf1b/FYOIMPvINBbHKOHdSjkwKDurOkosOQNlCI6ktc4mwQcTkt8EI7F2MEvoU5UCyVqpuKi7nMZ/6L2FPcxWDQjj+A4a18bS5T61FfldYzeOhd8V/lHIZLhbI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859296; c=relaxed/simple; bh=SPCyY1P+OSzVOfloEfkAEZiPnJNo4JGkAzlRRt3qerM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=eMF2cMnN68dcfZLDAcwUYtQEJEdhYYRz2e0Lj8yqYXKUxOrZzE08IMdO6hmohhRHGP1z1AE2Mo1TP4VIb0z//AYqNVmIb9FQUwQOqRHCOeDOEFPiRCngeQR8E0W/GR39k/LtpZ0Yp+lz9kWMH5tNMvj+M5ctdbfk26lGg9RfA/8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Q3WUF7gQ; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Q3WUF7gQ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K1p7ZXMLe8Z/2HeINL6JP7U1eMhqXrb2wVErpyG9ztO6icvsH/PuY8FXikjNRo79LLXuQsjSGN6ysT4nOsSEfZrBkiE4tp3UsBIQOmShfLtjD/njz1xHFg/4zgUrm/f6/M9qvmwwRCkcaMixhMJ0M9oA/PuR5PdaIZDqsJHW5Ly+5c9rrGK2wprj9U9t6tMydQ6QbvkejleomcxPeBZUGA4GqmVgt1t8+VaZjpX5g9X3eFqy1pfn6MyKgSPHdxVhmcw2bVBLb+yFTESlLqNZo9YMZ+nvRBdeupg9kH9SGlwzrH4eyd4kMya8JkJf0j/RfECHOB+XqFcUgzPWdARIlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ic7EptXahZDuq2u/O+ZWlj1Se7HgP3UjssUUpL3y35I=; b=x+uRfBKpOQukvTo8+TlgAK+PsqakWhm8jJ2e3oNwvVm4ySiWCNWXH8ZCrblZLJhHentTgsCzGtIYZHMqhNOz8jJf8d7FZr4Rk8/CwlBmRt+/YGWjYuNnb3B0k6HySyilueNq86fzfYDhfXNUc6vAIMk/3DSBT2K0qMZ5SiA/JDudNXF9AvU7HbPuMY1/t8q9LPwdsExeMMyNtCNaoHscs9XbQ6jMwzjlx486XsRFIveFmQLN0S3WlzZzv8y/b1zgqRmfaPbo4SP9EwUXApcZ8WvTBRE3mDSzDo+BMAe91bZhCoucWiaCRrM74uD020lQZ3nozhesCAknIXzWuFUdRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ic7EptXahZDuq2u/O+ZWlj1Se7HgP3UjssUUpL3y35I=; b=Q3WUF7gQivwfSihehC7McaSxUJF1d+0RgKRep93oo+4eijfLCBchIAQwAqzBH2hHeu1ogha3FmahnQFTvvAQywmcmmbJZPGIp2KH+XqFYavSHVPMuWmu47Wwyp6h2TbMcxxTZXfMgvvN+HnhsfCyZ5S2sjSFxGUZGxb5iygqcNQ6qu0OvWiEvbtoqCEuvXSOK7d/QqgX+3JLfncwJHXPLcVs3KssTUCzjUxvXns/wuDb9HkTn2LB1Tcv0ol9U+xJQBUJCSVDMVi2fq47aTWFI6iElCevlrZNEYPBhq2E1UKMAAeCLAGk82oDNZ6sgE0XNKrHfUZMNTzSqCs+aVoPpg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:48 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:48 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:26 +0900 Subject: [PATCH v2 06/10] gpu: nova-core: gsp: derive Zeroable for GspStaticConfigInfo Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-6-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0137.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:37f::11) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: a370dbca-266f-4c49-d85c-08de3c5b77ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RnBPQWFyVkpGREpwVUxWMit5aW8wbU92eUVuN0dTRStiZUVVMDlWL0tzY2J4?= =?utf-8?B?aUw4UUNxTi9XQnVlazYvQ2JKbG1uSEh0TWdueHJwcmRRR2xoZ2hudkJrMGZN?= =?utf-8?B?MXVUdzdYMG1rOUV5QnUwdHozbGlvRWFYazU1UlFIQnlDYXBjRHZwZ0hocU81?= =?utf-8?B?bHBKOUo3Tld0MjJlbFFRTmQ2clU2aFUzbUs2NmFhMWJpNGRRTTlUYWVSV0Fv?= =?utf-8?B?bnVLTHVQNzVFYXlna3VUTEMvb0pwUTJLZHlHcCtzYWdVdDFFakJIUnlUOG05?= =?utf-8?B?TDM5dkRiUm5iMndoaFBXUXFQSmsyRURtVVloaUJURk5FRElITEFYM2JYb3Zx?= =?utf-8?B?Uk9rWjhnZWhyTGIxQlVXREJwU1RPa1p2L0YramhoRlAzQmFVWUhXVFBJR1h3?= =?utf-8?B?RVJpYW8reU5ra0p5Ym9FMGxNMjlUYXNyR3NjQ3pJUnQ4dFZzUnBQaUZpVlAy?= =?utf-8?B?NE9vQ1E1SFZZWk9uODdFRC9qcXh3MitZeTh1bGRLMnZCbFpEZDB3ZUE5U3V0?= =?utf-8?B?c2VIVVlFcUtsak16cFpsYmNnV3BFSFlYNm52bGM1QmtyTnNxb3B6aGQvWExY?= =?utf-8?B?MEFQeXZ0S2dEamFqTms1b2RiSGNRTUFERTZQdDdpZzBkMDlJVS9KOFFGNElM?= =?utf-8?B?Vmw4VHQ0elhST3RBOE14OHBZVG5uSnJhWk1hYjAwNlFjNVNXU2JkMFlRZ1lC?= =?utf-8?B?YkRLUzZIb2lKbUx3RHZiZVY2MmxSeEVGV0I4cGJaczYzZjlmNTZDeVZNbzE1?= =?utf-8?B?VE91L0ovYkdHVDUreGJhU3RUNEVrMmhLc1JuWm5VSGxzOXU5em5KTGkzN3hW?= =?utf-8?B?MmtvZkc2T3V0cnJ2aU9BTVdMNi92NTYzcDJwUm1ockREcDYwV1JKSHhORzB1?= =?utf-8?B?cVUrV3RHaStGT253SC83dzdzYURyYVdOK2JrMm5Pc2pXb01heXpWN0ErTmxn?= =?utf-8?B?OTRsZUh4dW5MS1FwbHIxSXo5NE41eER6L1g4Ui81dk01Q1BvZlowc1ppL2cv?= =?utf-8?B?ZEVPQ0FwZVpKekh6emZpN1NOT1plaXRrTEVzZlFOUVpkaWVZcHNPS2hPK2FS?= =?utf-8?B?Y1NOcFE4Z1UxSlAydDI5aWhlYU5VU2d6REt5RllIYUNCSEpmR3hNOHFheFMr?= =?utf-8?B?Mm15cUNjS0lod3JMbE9OcTUvRitORXVpRk4zcnlGQkRDMkZMVWllY1A5RHp0?= =?utf-8?B?MnJnTUVheEcyV1FnK0Jma3NEcTZFVS85MDRPSG5CMXo2TjRTK202NWFEVjBD?= =?utf-8?B?RzdOcHFEREZYWGxQNVdwWnY2VnpkUEhrcEFYOVgrd0J5bDBURzI1K29OSzB2?= =?utf-8?B?b0FiR3g4dEcxNFd0ellFTWV4d3pQbEEzb0NYZnUveG02THFQelhvUjJZVmJw?= =?utf-8?B?R1h5YnZNd3BxM0hTa2xKc1RMNE5GVUJnRGhPS0REVkJqaFBLWVdzS0FUdU5B?= =?utf-8?B?Vlo5UFFQdHhjUkxHL3lFMldJQW1naGluQXozTEtZYXNJT250cXgxam8zMkEr?= =?utf-8?B?N2o0TzRVbDFjTVNKZit6NGNzOVlYanZSZzMwTGh4RmVNV0phU29qdWNJMzFW?= =?utf-8?B?bG90a1pWWEM1YllhNmQyTVAxSlorRWcvVzlXbEhtU05FOC8rdnpiLzVCbnl3?= =?utf-8?B?ZFFqNlo4VjZ5LzZJNUxTNmNBeWVwczYxYVBBYmoxSmlBOEVhN0NaMVVVNXRX?= =?utf-8?B?ZEwvU2xJSDkvaW1YRGpzWVIydXNEQnVkRWdGOGU4bkpHWURTR2hpWUw1WHU5?= =?utf-8?B?SThXa3FxaUY5NnJSQ1hMb2R6TzRmSU94UzFIOGJlbjRvemdUUC9ucnBtS2FM?= =?utf-8?B?TnNsZTIzOUJQbEtYaEhWUWIzdUdZVXMvbjlyc2NDK0theDNQQmplODJLL2tV?= =?utf-8?B?dmYvT2xObFVzRnlnQ01KVEpYY3VId205blhFTHh3aVJ1RllvZDFObkR0OFdM?= =?utf-8?Q?Eh7PFQSyY2jOkaJVy5V7IeUJUxCrb2dn?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VFROQWVMclFBWjgvSFBneDNlOXNrSCtBY056b0x1andqaU45UjZ2SjJBWm9v?= =?utf-8?B?TExzK1JGOXRPT2lxeEJHZzB4V1pPZE5PWDJzNFFtazNaTU9DZ0ZYa1FDMWhM?= =?utf-8?B?U3RJRXdhMGZxcW9pcS9WemxmTjlJMFkxMjZaeE9CSFJ3aGFMTkxhRSt5Q2lh?= =?utf-8?B?cE9mUS9QUk0vZmFiOUxpVFQvNGxFNUcvUTZtMzhyTVVnT1FyVXRsSWhIR3NN?= =?utf-8?B?ejJPTkp0N2wxSEtlbVN2S0VNbVJzYWprYmsxV2FuNU40bEtDeTRkb3o1TkZT?= =?utf-8?B?cDd1ampzVEU0aHlWdXQ2MEo3UGRCOVNyY1pvQ2V1Umg2WE9JSUNSc0U2RnNu?= =?utf-8?B?Y0duMDZPQU10QnVRVW9xRFhscDFnbVF6RnlSVjBiNVF2ZnhZTGNtcEpud3NS?= =?utf-8?B?T3A1MndwMXNLY0JSNkZKYVVZVFJLanBGL0ZhMnVsQXRKTGxsVVVTTCtZbGFw?= =?utf-8?B?N3VZU3BjZWgveXo4NDhLcGQza3ZIRFQrdDhUTS9ZUDl0OHdXaG10S3JiV1gz?= =?utf-8?B?aFJ3Y2k2TktxaWt5UjNHcW8zMmZVMjV6VlhsTFpkcHlnSW81eld1YzYvanJ2?= =?utf-8?B?QXg2QWxIWkZMbFRrSm5PeEdpdEF3ODNxZTAra21YOTY3dXY5enR1RDRhSjFL?= =?utf-8?B?cjB1TjF1MGJFbHFxcXFWTnBPUWRhcGlNZGJHaDF2Yk9jbWUxbGxoQ2dmQUZZ?= =?utf-8?B?Sk9KaFFtLzdvZllKdmdlV05wdzhLK2w2a3lweFk5bzRsK2pYcjFSR1ZsVzg4?= =?utf-8?B?NWVwVG9ENFA4ZE4zV0xLZVd5RnYyMDAyUzJXSEJrQkIzaXk3UFhvT2oyNlJa?= =?utf-8?B?T1g5aWNZbjBwdTgwK3cxRityL0gxRUVLM1NPa2t4SHoxMnVEMUZjY3pUbDd3?= =?utf-8?B?djgySkN6N0NDS0ZVNDdhN0dURzNtZlZCakVrbVc4QkFaWlc5bmlrQlVWb09J?= =?utf-8?B?TTdMTldnRWJJRTFIT3lsb2dlR1JuNmNGZm9xTDlRQXg5aEl5dzgra1h4SFdz?= =?utf-8?B?b09XcGNkZ1NoS3RtTFN2S2lxeU9BOE9iVnpiWkZhalFoREZUa2lGMjl0Q0RI?= =?utf-8?B?S05wclJxMW5hZFFKRnJXQ0ZoWWk2Qkx2Z09ZMHhSL3BpWGtlMFFzd2U5MVZK?= =?utf-8?B?OEZRV29xRFUxL1V2TkFLZ0IzOUxpMDBJVGtYaFhmVVNKRy90YkcyWDBnZGtx?= =?utf-8?B?VWNjSnBsYzdYUzVLTjB6ekJldFd3cjhnRzBzdEh2c3JEVTZhVUZZYis4akRO?= =?utf-8?B?bU1aSXYyVG54Vmsybm9NTWVCU2t4NVdmaUhwSlkwTkpaandtTW5zejVvTG9M?= =?utf-8?B?ekZNQVhjS0hiZ01sOGpJd1N0eVVqcThsTTAxeHgycjAzSDZ2OE96QU04eDRl?= =?utf-8?B?VENpL1hEQkpaNGU1b0F6S1dDa20rd3N4YlZ2c2hZOWhKZ0l6Z3VhWHNOZW1r?= =?utf-8?B?Y3VoK29iTkpsaytZQ1Z1NlJMWTJqQkxVTUdUR09wczMxQm1KNmdMT1ZpSTcr?= =?utf-8?B?ZXdURzlhVnY3c1E1eHlWNGdLNHF6bG5KVCt4VlBNK3RYMUkxaTV0SzYxTE1R?= =?utf-8?B?bnNGUVpYKzB4OXZqSFl5NGFsdUY0YjFoY2Q5UjYxd3ZKODcrMmk4YURVcUFs?= =?utf-8?B?S0l2OEhWbTRSb000Q1FUTy9XK1dHSmx4MklrajFpK3NDd3ByaDBpR3c3aUtS?= =?utf-8?B?NlVEV3lwaENISHdjSm0xbGZNeFNXbHBDVCtnQVE4c1dDNzliVEhvTCt4clZJ?= =?utf-8?B?N1J6N1NQY1UwNnRkYmtHVVFyQU5mT1VHckd4djVkcjY2L2s3cW9ZSE1rOGJ4?= =?utf-8?B?c0ZmOVdPN1ZBbVk5bjVqTCtER3d6dThpWEFGMk5ocUV5ZXY0VlBGdG4zQk9R?= =?utf-8?B?d016eVNVVXNOMEpYMkdEN2RvWlBqVUlNK3dkbEV4WkJNS1p4SlA2VVZ1WUIr?= =?utf-8?B?Vkh4bjEzR2FwcWtrcGszd2g1Z054QUI0TjJjODNXNndTYVBveGJIZU90T25r?= =?utf-8?B?ZXV5TGl2M2VuakorRnlBTWxtWWNWNkw2R1IwSXJBMWZubGZveUtmQUJ1bnAz?= =?utf-8?B?YnBUQ3oyclJ0OEUycWZXMm1XVDZheW9SaFJiUGs4WUxITTdQVWZqMDdJd3lr?= =?utf-8?B?V00rTG4zQ29jMlNZd2tJTXlmSjY1Tnl6cldrZjhmRWlIcWl2WkM5UFVRazNU?= =?utf-8?Q?yixTfpjmKQ9lKkLXrlr+hypN9jf9q8A0XL+YZO+Zw8em?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a370dbca-266f-4c49-d85c-08de3c5b77ad X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:48.1822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kb9FjB8AvZuz4rXO1qHTg4vTuwqeySsgqjTJBLWKsQDwe/BLs5ObLM56F5vbfF2p7fkaM9n/P06y/gooXgp0IA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 We can derive `Zeroable` automatically instead of implementing it ourselves if we convert it from a tuple struct into a regular one. This removes an `unsafe` statement. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/fw/commands.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-co= re/gsp/fw/commands.rs index 21be44199693..85465521de32 100644 --- a/drivers/gpu/nova-core/gsp/fw/commands.rs +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs @@ -107,12 +107,15 @@ unsafe impl FromBytes for PackedRegistryTable {} =20 /// Payload of the `GetGspStaticInfo` command and message. #[repr(transparent)] -pub(crate) struct GspStaticConfigInfo(bindings::GspStaticConfigInfo_t); +#[derive(Zeroable)] +pub(crate) struct GspStaticConfigInfo { + inner: bindings::GspStaticConfigInfo_t, +} =20 impl GspStaticConfigInfo { /// Returns a bytes array containing the (hopefully) zero-terminated n= ame of this GPU. pub(crate) fn gpu_name_str(&self) -> [u8; 64] { - self.0.gpuNameString + self.inner.gpuNameString } } =20 @@ -122,7 +125,3 @@ unsafe impl AsBytes for GspStaticConfigInfo {} // SAFETY: This struct only contains integer types for which all bit patte= rns // are valid. unsafe impl FromBytes for GspStaticConfigInfo {} - -// SAFETY: This struct only contains integer types and fixed-size arrays f= or which -// all bit patterns are valid. -unsafe impl Zeroable for GspStaticConfigInfo {} --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 872E1318149; Tue, 16 Dec 2025 04:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859309; cv=fail; b=ErF9/TKRo3vD00bzAlFRbwJq2k11g0CkszbRvQu9st6hKvBcxlMrhVtPuZaOW6SswoZRV3sqG/sOrsU3rIlE6LufFCkhUn47NswnwQfdO55ZORwha/s8h7ZGsxgN78FWgM8fdYIqjgpnxZVq0tS0worrz6PaKTPpnqaXa6y+Mz8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859309; c=relaxed/simple; bh=jNTPyqvg5M0XYW0P2NIJerinaI/M+UFINHpypJTTXZc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=FVwe/sMcIhMzPU4y6Z40HV1lf3FSlr3/imAYwtaRVCtNKkRQIdIHPfsrJ/MLX9wHYakehbbmch9u8kV341c5og/bVQKChDMabGxMtDK/MaWMXMVqvgeU6/O8MWUu+t0WmL692cR+m01JXIAnfBeV5vKb8m8wGGSFdCpVqmKQkfo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=apaHIvkU; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="apaHIvkU" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CTGYYFs64Hj+CSOdkjPTSBtcGRGfOK4UcgK8bro0cTDb3QTGIqBR0wlfDxPIm+4YwMyJ9mgWWjOThB9+OE+yU7oQexxy1DvVtfe0bo8vrLRmzEPfjn0IVrDmaa0PtnSphT1bWwQXdeLjwbfTap/RvPq2xqoJ/hfSQRpIGVOXMjsNOm1HaCbEEkV0hZJVt1FSMPx79nMz1+dphzN7NIU3sNtaEu37hXL99nPMwe8Mr93yz3WEjMbnSW06NU8ibdH54b1siGcZlygi04yj+LCkgHhhsUtC1YOJBv0OKPNJ1H00tVBVGnGBBoDrOC1k9/154YQqImSREl+QMvKSPFjTvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hEG9Z2KFVCudmGeiwE8Z+yULenmuh88vme7oWWDmawI=; b=qtVv83Sv4pR7Whf3LlniTvffKZwwdqfLKkYAv1bZqH/DVzmiLjM3Av7IwCzoXN4RHGf1no5/EnWdDBXJCLUHKRdSkCQSHFfX6GqRhgzyQdx+eDkKd81K0GfXpEwsybjGyK/pbSw3lpYeUklv7EnrXXcCSW0kxdQbVt3NVetrihRN+yWjLmuCASJndzcLZ1taGLTwk6ZdjAuTa/5EiDpbJ+uCVXBp/znDJYm3oyUc8KyV9zaKeOAUhpDCOP2En+yxMOUFk2Fp0Qf/QwP/GaUneuAAGfFKNKGmln7LUJAMbmeKuE/cWz9BicxtMF02M9IvqGM5qxvyWZHIJALu7mfvnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hEG9Z2KFVCudmGeiwE8Z+yULenmuh88vme7oWWDmawI=; b=apaHIvkUGkPDvFGNuQzsDFq9V46Wr7lTqQXxhx4kmL+tlweDxWI6zc6wqHTDm0KWJO1Wn2Jcs27T7UWZt5V3j5U81iQUZl+ATpintbqHXMXEfpVOfzc2vsZi3CyPAxIO+S7j0KQAHShzrtuoIY3u8LZVawSBTkuof2dWwDPKjZv7nqvgesS/4k7LBJO8pKjiC3Q6wZvxqm1eCc9ClEfQo2sSR96TM8iFMshqaQSSKpodipPHHTRCNz+Fm1BYMQ0qHAET7dyzF0McgliwS2vXJ9mvO1NiS1Z5g87h0UCZ09E9GCUQUfrMEsXAQDfnMzZXXKp1PjgnbEawpuz8i6W2qg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:51 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:51 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:27 +0900 Subject: [PATCH v2 07/10] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P286CA0111.JPNP286.PROD.OUTLOOK.COM (2603:1096:405:380::6) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: dd76eaf0-dbe3-492e-765f-08de3c5b795f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RjRSd1J1Q2pLUzNVeFQ2akxxa3AvOGFNZ0ozbSt2WW8vL3dXcEk1cVI1cldx?= =?utf-8?B?N04xZGF6TW5rTGxIMjkzcFV5QXZqS2orYXI2T1FqYit6czlKeDAyVXltNWt1?= =?utf-8?B?NDNDYXlzUEx4K0NDbzNsK3A0c09TR0ZvY00waHJIam9NVVBEWDE4RTlJWk1k?= =?utf-8?B?dVBwSkZJU2h5WVd6T3VwUXRHUXVGLzJMOGM3eXljRk9CaXBvMzBqaktCM2Z0?= =?utf-8?B?N3ZkSGRtWGo2MWN4YXk1T29kWWlnaEFoYXRrYTBPZ3Q3ZE8wdVhBOU94b0tG?= =?utf-8?B?WGI0N29CU1BkU1cvZUY0RkpCT0JyUHB1dUZvajNGcDhiZFNORFQ3NXdoZkgz?= =?utf-8?B?NVhxeXRQRmxIelRNSnRWbjlQMlZQc1RmQncrSGd6ZFA2dHFyeWhaRkw2c21Z?= =?utf-8?B?RWNrSDZ0N2VDSVp2SVN2aC9kQko4bUkxRG94bGxaRkNmYjByVXhST2N4OHo2?= =?utf-8?B?UmNKYXR3c3VjUVRhMzNFb0dPYWlNTWJNRzJoZ3k5cVB3clgrUTQ1NFBld3JF?= =?utf-8?B?TTM1d291cnBDL0ZtdnNCNnNDZnd5cUhBSXRQNm52ZWx2eUJPN0pTeCt3K3hG?= =?utf-8?B?T2h3S0NrT3F2Z2dzdkNUMFJnK0JZNWdIMjJvaHc3LzFoYXJXcDBJbVZySi9m?= =?utf-8?B?bkpxcFhpUitpUWV3aFpuQzNFK2o2U3NpbWEyUnNONGJ5MElEc05JZ1FPa3VE?= =?utf-8?B?MW0xMERmYkVwb2RvR052cmhpNEZCRXRPS1hDajQ2TTAxVnBPTjRiRmZCUk5R?= =?utf-8?B?Z2JKL2RJbXlSWDFSdWEyWFJ3ODB4dVJWK0lWSU9Id0lUOVppUlNZOERpYmNX?= =?utf-8?B?emYxVHJBL3krTDFSOWFtbkM2SVFEdGVVdGFrQnZXc2dzQjZXdG92Q1JtVmpH?= =?utf-8?B?TGRVYW1sTGs3Q2tSQ01FYkc0QnZ1NWZWNFYzb1FvV0FsVHJrZWJoR1VkaDJL?= =?utf-8?B?UkdGMkFtZS9sbHhvT3lxekdobVVid1dkS2FEWU9PN3ZZWk15aDFHMnVobU1v?= =?utf-8?B?bDA0d1ByVXdPYXRBUFZNK3BiVFB6TzI3TG5ldTdRUlNnTzQrdXM0RnEyN0Vu?= =?utf-8?B?cjl0N0JjYzVjTVlqYzRNMXVLbFNhZ1NkSG9HQ2N5bG9iV3I2R3NoTXRaYk1D?= =?utf-8?B?ZkRZdCtyMWNNZ2RjTDhEVE5WS0hwSmxWYXUxLzdES05BNmRFUFJXUkRnZzB5?= =?utf-8?B?b0xLQUhvMWFHN24zWVZRdUkrUkI3S3FtZXVJL0ZmNlBEUkQrT0JycytGbjdv?= =?utf-8?B?MG5mQS9Rck5Nd0JlVFRWckZocnAxSDBtR1VRMk9Fc0l4RVZ6ZGxMemkvRDc3?= =?utf-8?B?Z01QVENPT2ZuLzZoc3UyM1F6U24vZUg3MHBDNnM2OGtFMWpJc2IwS2ZhQVRG?= =?utf-8?B?SVhzTmladFkrdjBWdS8weXljWWJ5QjU2TFVnNmM0Y1VVc0xrZ2paUlVtcUw1?= =?utf-8?B?dml2TUtIbmIrZnNFVGpCMS95K3FQQzlFK1krNGErSGI5djhUeXlFWTdtUnRO?= =?utf-8?B?R0VudUowZ3BPVFRzMExBQnFTbzE1OFp1NG5QeUozdTlKSWMwQU0wSXJrbzI3?= =?utf-8?B?eHo0cGNYa0t0L0NOcnp3SDVQeFpRQ3grVmh2SGlhMkdyR3Y5Z0hBSWI5cDd4?= =?utf-8?B?L2JuWFEybEJDWGkzb2dhTnNlN2RCVlNNb2RodWN4bGFHZE9DN0VEeHRPUzVM?= =?utf-8?B?RWJ3NWNDaElKbVVwOHhTcERnZjhCcFVqNWRuTXF3czVrZ3hXNkhVZDJ4MFBG?= =?utf-8?B?UC8xME5oYUlJWlF5YWE0RDNvSHZoK2NHeENTeWtJTW5qWCtOWkFPMXpLVm5E?= =?utf-8?B?L29ycFBmbnlmMzY4dml4V21wK0RvOEdlOGQ2Kzc1UC9Cc09Wa0F3K0d4NVNt?= =?utf-8?B?TkZMYnY3N0NZSlE3OUJIU3lWWTlNWkpSWkNaVmVwV2FtMGp1TTVvUExVVllz?= =?utf-8?Q?bCEiFSUshbvrTrcgOypNXqcaxAA7MqG+?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZkVPZzlPNFdFdTB5NWUvSWExYTZvZy9BNHRkTy94NVZWQ0FhMXBNL2cva1dh?= =?utf-8?B?akZ5aTJTQS9oRDh5WVNwS0ZITTdFRXZDSnVCQkpvcm9GdFJaTVVMMHFJbFRz?= =?utf-8?B?WjJYL1JzWHlYSkJvamtJUThtWi9PQzlMekYwZGN6VzRsVnYrQjdjZW1vc3hV?= =?utf-8?B?UC9XZGRrNTNFTzN2MWQ4SS9ZdTFwZHpIeGxlVnFnVUVXTFpnQnBET1NLc3h1?= =?utf-8?B?RmFuZHYwRGlVVkFEdExSWkNnVUZtY09ZZmNoRHYxSU1CbW9ndFpXVlFiQk5k?= =?utf-8?B?NFdIV1pUN1o1UTIyZ2Uzbk10NXR5Vjhmd2ZhMzg3blJ6Y2NldmN3V1RXb0xj?= =?utf-8?B?U0hLT082VnJGLzdaODZGTkFiNmNISkhDT21LT29ob1RFUGxRNWZWYjFkRVlN?= =?utf-8?B?bEF3ZUZnRmk3NHdIY1I4a0dVU3dQbC9FZE9XNFFvaXJlRWI4RWs1dVFtdWsw?= =?utf-8?B?SGVLc1NyWjJCOU1kT1lpODdGZEJqWC9JWU4zdWVtYk1pOGxCcHlGK2RrVGpE?= =?utf-8?B?VkhkcWNtSktIVnI4MHpNenprWFV4d0diSGlONE96S1FSWHhxVmJSYWI2OHBB?= =?utf-8?B?OXRBSFNQbG9LK1RYSG8rYUtZVGJkcFpyQm9mUkQxYmlEN1k0UHAwQmNmL3dn?= =?utf-8?B?TDUva2pESjNZWVM5U21vRGZZZWRCYU9iVDJsWGlSYklpNElYWmhvKytISU1W?= =?utf-8?B?RjdMTTdtV0FBU3NYOGFsOHoxaVpYcW52aTE1NGdnc3BBeU9WbDJyb0lQcWlL?= =?utf-8?B?cjJ3SGN2VXE3U1NjUjVMZnQvdGtRQmV6anJ1TUV0TGxrZHRIb2UrY1dFL1Ju?= =?utf-8?B?dGR0L1JDYzByU0FKN2VxTGhqdEx4TE5xb29aSXhTWnhXaXBkcGcreVhyUGZm?= =?utf-8?B?d1R6SVB6M0kvNEZkYzhnRElOWHo2cmliWkQ1MEdObG5XQXpQMDErQ1lXMG5B?= =?utf-8?B?OFQ1MWg4T3E1cGdGb3dnZVIxZkhhZHJiM0tSbHFEWTVjRUpQdExodVlRSlZr?= =?utf-8?B?b2wvMzRYU0w2VnJweHpHbGNMQitXUE5QajN5ZksyVzUweVJHcEoxUXZCaVJH?= =?utf-8?B?a3JaS0k2TVcxUGhsVnF1VVVwd2ptTFhBd010UVRWQkYyZ1duY3RjOTF6bWh6?= =?utf-8?B?SWFRZFpOTXdFeXFoaU1ET0hIeUgvY1N3Uld0TmJ5WE45SEhzYVRNeWJRM2ZB?= =?utf-8?B?Qm5zYlNaRW5LMTFxNFdUZHhENkFEV014T1RMNlVTK1E1eW9XUFgzMm5yRUtT?= =?utf-8?B?VldvVUVjeHJ3WWlTOGdpYjZkZmFGQmcycEp0elRxNzFHdDU3VTBNQ3FzS2FO?= =?utf-8?B?QzRLWFdmTXhXUHlLNDVySFVLVGJRdHZGRzhIdWZCYU5jRklQMVJjbThqUkl2?= =?utf-8?B?MzF4TUhGNHNjVmRWYVZCazQyc0lHUmJmdUJXSzZvMEFOZWNpUlExTEZsM094?= =?utf-8?B?Y3dMUjYzUnpQTTE5RmFWaUxTNDY2Q2IrbHp6S0Z4bGVYZEgvbXluRTZramhF?= =?utf-8?B?WU1oMklYOFpDMEFRN0xUeXJqMkxuZzQ3eXN2Q0VEMU1KMVA5TnVIZWgrM2Rv?= =?utf-8?B?dFEwQ0xsUi9WbUdhRWZnaTk2WUU3WjZXRFMrVUlmbjJSeExsRmtzYksvaGFu?= =?utf-8?B?TW5UZEpMTDdXTkprRWg3ZW53U1Z4eHlaaksxSGdaN3FJOW41TjFLZUdSeFVa?= =?utf-8?B?dzdsZFVGZXIvWkp6K2F0L0FqSHNhd3JSWk13VkEzR2Raem9kMlhvZ2FrMGdj?= =?utf-8?B?WnZBdnhXTEk2K0tGSHl1SlVNQnNLamxWK0ZMNGJoTkRINm9Bd1VLbEJNaUNJ?= =?utf-8?B?UWcwb3gwcVJWcCtNYkJ2amplTnQyWEk3WnVLSWc1cjJVRTBNWVZXeEVRMDRz?= =?utf-8?B?ZUJPZ2NIK1p2V20wYkRSWGJtdDB5SXF5VjlxcVdvMjdzTStwNzkrZStzSmpK?= =?utf-8?B?T0t0dktwU1ZzajQvYlprSXVjMk5QTHl1THpZWCtta3RJTW1SMHA1YUk4UVNV?= =?utf-8?B?S2hXRnFXbW1ZYkRtV1ZkUG14VWZ0TlEyRDlZWUhrd20zajVJM3lhV3Evc21R?= =?utf-8?B?LytiVWhUSzRuZ2d1VjgrcWxSWDBPQjN3eUJEeWlXYzdXQVZyRC9CR010blJp?= =?utf-8?B?cGJPa1VBTHJlQ1lIQ1ltM1BTQjhNQk1CL25hdzhDaEhUVDRoa0pWTEFZcy8v?= =?utf-8?Q?Rhuy0NHEX9H+7LJKBPFZW7+NybcBnU3KVYHxdSK5lIQ/?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd76eaf0-dbe3-492e-765f-08de3c5b795f X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:51.0610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Wr758vOu9byajSnzObIDvtE1/bFfeNUpYZSkTOGv9a16lMZl6v6pLpo0xzXTpLFv1a8yLf+tZgfFUtZkgM8nmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 `run` doesn't require a bound device as its argument. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/firmware/fwsec.rs | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/nova-core/firmware/fwsec.rs b/drivers/gpu/nova-cor= e/firmware/fwsec.rs index b28e34d279f4..b98b1286dc94 100644 --- a/drivers/gpu/nova-core/firmware/fwsec.rs +++ b/drivers/gpu/nova-core/firmware/fwsec.rs @@ -412,12 +412,7 @@ pub(crate) fn new( } =20 /// Loads the FWSEC firmware into `falcon` and execute it. - pub(crate) fn run( - &self, - dev: &Device, - falcon: &Falcon, - bar: &Bar0, - ) -> Result<()> { + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon, bar: &Bar= 0) -> Result<()> { // Reset falcon, load the firmware, and run it. falcon .reset(bar) --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013029.outbound.protection.outlook.com [40.107.201.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8715730FF04; Tue, 16 Dec 2025 04:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859309; cv=fail; b=QQcf7AqwcCpbt92wm07/459TXdiIdhqvrHY9RbGISaaj0Hm6g0f3okcQj5TL/mBAUPnYOqME6NnLpnJO9OQTRvUKdR7fMPr8WpxUWToq27GSdUhOqvnR4jPG/JCwcIMyvi2rCQz0clDcgvHk9iLuBWelG6sgkNmSMNe8Sn46/gA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859309; c=relaxed/simple; bh=YO2GRf905xsh2EHGbg+EGOs/m3/muSCReKKOXFj53IA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=UN1ztPmZSzgB5UKX9RHUBshpR6/rbjho2B8p3BqOH9z3fHv9iijlOMy32LksVvMLyrwQNlO9vjBPWQcvL8wxZVbW3G7sP9YShReR6kNDy2uw/jJbeZ4aN3finmDnkgV+fR8NfTq0l/tXIhqZRYO77mE4Jyi33O07yiTrvwlOyC0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=FKB6JPh7; arc=fail smtp.client-ip=40.107.201.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="FKB6JPh7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wt9HTxWNiS10K4T3C23ULafmOM8FN0ECBhvQ/WyAkvcWMzoWxE5Uxla6/+xvX/IagzTJOIsO4pjyO1X8+jbaO7Y5amATgNWqnQ1H0h1NqKfzGrj8jx6dZXqwYctNTdweMcX3NS43EPg0lD4FYomJQZuvjY1LH6dfF5lpVyy8bOvI1fvH+4kRbuQ5FCDDo1NaELQ9Pf5E+SSm2nnnIc0BzaWBbT9YNvZZyST+RGeTDGUsNjR4XHA/U8qlseBpA+PI3htBPtb72XpXk1FbcDeQNWim0TeMT3ce4DMVlagZSDDXw+/LP79SpJZJ0D/5YAZJlNhyPLAWIcx9FtNuLmHQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gtwREWFtnUaWtfxP+f1uXK0T4RBnxMQvCEmt5X247bE=; b=LHx7Nl7dhaPJzIbSV/y3bUCSyQ3Y5X8EcuQJafaQOj3/eDluhQLz0CPOMI9yaqGQUPgyu3qBK9deTzwxG9/7cup8tTI0P/KILnBJpX8LUVdLs7AF0lH4aiYjNsW8ecN0ypzpS/BnqkttgTq9Bk1QZcUM0Ydujm1wId5jkopqnCK7ASTG90tpZSdxPYiQEhse9k5mL+pYzzT4iP/fAZ7Xb6TYXsY80cSY0/rg9OA6w+noiZaC0IUZU0/p9muLcDyeKkeaDeR1qdnf+Ls3cC1TZZtCpG/UMYzueyOPtkbCu3Y6c6vXVMToKM39bf5DhkMjtoR3f0fvcf56aCgzrnPmOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gtwREWFtnUaWtfxP+f1uXK0T4RBnxMQvCEmt5X247bE=; b=FKB6JPh7Da0sSDi6xlmVhE+4SbhkakacahKfvg+gPmCLJnMpSf+lUEByPTzuRdj8wbK6mZUsz6be9b7/MkxL/rVOL1SAer9uaU0kLLwPRoA9o5uZAbLMkOyedm1kAh4vqDhOwB/mpGBcjESg/uH1JheF2TlYnrpHFz2643XslzMcRvxUQ04wPEPwtaMJUNufcU3mCIRF4B18omHu3Et2alA3f6du8FRqKslr7Zj92QrzHoQl6JZG4XYSkASj/k3JVw3IeEc+Er1CqEOMU7rwwLqw4hUWh8/TxUn8dZBhPNLNCWOgZ+784OsSI+FCbkhkgO4W6cA3EZ5Unt0to85oBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:54 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:54 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:28 +0900 Subject: [PATCH v2 08/10] gpu: nova-core: use core library's CStr instead of kernel one Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-8-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0023.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::15) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: c22e1764-1078-4ee2-4e3c-08de3c5b7b62 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?QWU4Yi93c05MeFNlUFJRQTVBd01OaDQrZER5VVM5SC9ybjNWUkdQZEtwNTlB?= =?utf-8?B?VnJBNU5uQ3o1NmhtVjRhSGNjU1RXQVZGUk1pdjU4bHFYek9KNFVSS3I3RmZo?= =?utf-8?B?QVl4U0dVRDVDRklEOVJadmQ3Nzl6VDB1b1gzWlBFdmRIOERjL3NhVHJKcTZo?= =?utf-8?B?dTlZRW0wWmYyTW1TSGpjU1k0Zll4b2E4MkZsUjNwZWdBUytyK1liVFE0SElw?= =?utf-8?B?QUplM2doMm9YNkFRMVZnOHRSQjE5MlBXanExMVpIV2pIMkh4T2JKZ09XcG0r?= =?utf-8?B?dDROWlZQU2diYnlHRGxQeUFiQmRxZUI1UkxrRlNvTWdKK2RaWCtINkZoVGx3?= =?utf-8?B?eHF6b0ZMT3dpaFNOTDExZGJ6WGhMRGpNQ1N2WjFrWU5MNHA5WTZUbU9oN1FK?= =?utf-8?B?TWVJVjlBNEN3TEM0aWFyWS9Oak1YeXN0RlhsNWxPSVNiUk0yMVZsaVRjVGFF?= =?utf-8?B?bHllaG4xeE40L3FBb0s3QVVmbVFLYm4rcjA4Wkh5K0pDR09sZ083SnhBZjE3?= =?utf-8?B?cVFuaHU4alJWYldVdnFRSGJoeWxuY0Y1L3JLWnhzVEVURXNvcHdmb1E5bVUv?= =?utf-8?B?Sll0ZGM1UmdqeFVnL080UHBCNUIvWVJnanp4T2Z0dC8wQkwzdVhBZmNCRC9i?= =?utf-8?B?QkkrTTgzTm85TFJEVXF5Um1mcTJIcEFEUU1mL0tGTnZORTI1Yk1XMGdrRGJQ?= =?utf-8?B?cDNXWTVnZHYzSEVkNnI1OHVkSGc4ZTJpUjYyam5tVmYrWmM5REYxR3F1WjVu?= =?utf-8?B?aW9sQ3pjUjF5NjdicmoxMWdER3VHODhqYnJGUEJRVExoWDVyN1hvcmNEaGFv?= =?utf-8?B?T0RjY1IrUm9tc0JBUW9leEtKakU1ZjdtREJXbWVxWUVzSURGZjFlR0FnM2Ru?= =?utf-8?B?Z2p3MnhDZjlSd3NjempmTFlOQnBrb1lmdU5Ud3FsTWluSklVaVRDdmN6L3VR?= =?utf-8?B?ZEhacVpmRW5kY3ZJUWxiMC8xUDBNbXc4Q0Q4T0N1OTUweWV4cEhSQ2FQR3Vr?= =?utf-8?B?OHJXVGJDdlZmd0RBaGk5VmNiaW9xcFRsWEUwN01ZdDFxRjZnbjRsQXRtSXlF?= =?utf-8?B?L0dqZ0pxNHJISkRVMGIzd0lXcUNuOWhwZG5wTm96Zm45MVoxeGxLanVmQnh0?= =?utf-8?B?elBYd2V4L1VMRUxtSDhUUGZqbExuZlRCSlJwREZCdlRoa2gzcUhvVE8xaTha?= =?utf-8?B?REp4QXZvVFRCY3V1QkY2dGxvU1N4RUZneUYvQ2picjJ4OEZqbzBkdnlBRzVx?= =?utf-8?B?MzlVTmRFdndUei83V09rSmw0UTZrWm9JSzZYdDVBRmRwdmt4Vk1xOGVXUElC?= =?utf-8?B?VkxtQitmNGN3Y3RHSU9HWUZCaGltWGJEN2RRQXZRaUp5WCtNVWNjWTFudDhq?= =?utf-8?B?TmttTHhBUmZNZnRxZHJLak5NbzlOaXZjYTg0N212S0VZZldwOFY3TzhBWGto?= =?utf-8?B?d0FCZTlweDRDcU1tSnBHdEZEWXJvWnMya0lCNE92UkpKeWFsTHd5RXA2YmJs?= =?utf-8?B?a2ZaNDlBT3Y1Tkpjd2drSGd6WHlMNEdtQXB3L1hvZHJJUGNVZWsvRWZ6TC85?= =?utf-8?B?QVZ1cmdLb3JEUWlLTGNsa1NmQ0ZwZG10K3NXWFdyUXgxQUFIN1FvRkVrREN1?= =?utf-8?B?NEhNQWRjcENNUEs2RjVnUFRZZmNVQVlPQm1rbGRaNUNETjZEZlBWM3Uxamp3?= =?utf-8?B?S3NQZUxCc1dDTGRmTzg1d3R2M2ZQZk1sOUJvQzRQaWMwdVJ3cXRIMWxyMnNP?= =?utf-8?B?d1BIQzRpSXU3N0pSN3REa08xYldZMFFlYnRiS2FTcVA3MDErSm05WTlPMWhP?= =?utf-8?B?N1F0QnUvTWJQR3NDVnZ1TW92MDg1NXB2WlVQR3lSbWZwOG9ieFdHREVjU0wr?= =?utf-8?B?ZlFsZVQrZnJ1VzBpdnZFemNtb3NXQ0w0MWVZckp3ZFJRU3Z1SUhMc29wWWJE?= =?utf-8?Q?gk7OAuNFM4qmV57tTwPMM8tL8vZMJupm?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0w2UnJoeHVTYkY1a2VITjh4YUhuNG9YTk9ObG1BZlpvZWFqZUdRL2N4UWts?= =?utf-8?B?cVNybHFCOHlKamgxUWQ0YVd5TXE4VjgzV0oxS1JNeE9rZ21ZZnRWaVgwYWw4?= =?utf-8?B?bVg3WmF1RjZvczQ0eTZtbEg3RTdpczZYaWhxNHpjRmh6VGF4SGtEMkVEWHls?= =?utf-8?B?dlNwMjdhZjZhcGd2VVdiUnZlUXJHbExQS25zaHRYQ21TdzJOTFJickF4NWpl?= =?utf-8?B?d1lIUDQ1TGQxY3ROR0Zyc3ZrYTZqNmR0SVlFblI3QzNwRjJZQ3QzOHpMSkI3?= =?utf-8?B?UjBPUTdGSjJEaW5QQkRWTFRMVnZpRDVBaWpIM0ZXVGdsWDc2SEdaZUhCa0I2?= =?utf-8?B?d01ia3JLNGEvTGIxOTljaUJ3VEV4R2dSdlZvR2ZzS1ZVMEQza2FkRXJDdU1F?= =?utf-8?B?Wk85K1hLajFDa0N5MHZIYkdHMUlyV3liVlU1Y0U1dE5iR21OdDR4NEExK1NJ?= =?utf-8?B?YjkrK3lqM003c2VEOHB1RHVQYnR2VGRUbGhFRGt4WElkS1o3NDB3Mm1CMytn?= =?utf-8?B?QzZHR1h5UzBhTit5Y3Npc2crWEVGVTQ0MGdlTGNyWGNHS3hKSzJDU2h6KzNU?= =?utf-8?B?aTQxT24yQlF1NzBuTkVoN0QvUE5ZcHRYdm5WQlJrZ1YreUxJZDJqNmJDSXV5?= =?utf-8?B?eERSUDdseDFyU1lQbzViMDU3a1hydHcxa2lPMXQxSC92T21JVk9UOGFRZXYr?= =?utf-8?B?bktLeG9tcFpFNzdSazU5UEh1dTloTExBZm5LRVU2cHF6dG9XcktSOUx3VmNF?= =?utf-8?B?aUcxU21KeC9vT1VuRTlOaG42eUtqa05NK0lkS0RTUlZFZ2s5RzV6UXdiRDMr?= =?utf-8?B?MWVqbDdueDFpSUZQZzJGbnU1anZiOXFnVk9ZbEhhYVMyL000cTFEUkpYMmlV?= =?utf-8?B?NGNoelgyRkllTTBCbnVWU1lGL2hQSDgwK3JEOTBGNWxUcUNuQ3ZJUE10ejZE?= =?utf-8?B?VjRYZ3EyUnlNVWJxcXdyRjBEN3Z3ZWVFL1h4Y2EvbVFia1M4aFRPaFdkWDdW?= =?utf-8?B?NktGdk1hUmh2dUQzYzV5OTRmaUhGSHJ3STRZZzJHNDVCdmFXTTN1S1NDL2tQ?= =?utf-8?B?STNPWDFLaUY0aVVTUnVZVjA2UkRsUEpOZjB5YTkyYlVhMmpzNHNQUlBCdGM4?= =?utf-8?B?NGNZdjM4QUNadzBkY0F0bmk0d3dhc0VDUEtFbVJXRFpiVnk1THl3R1B0ZlNZ?= =?utf-8?B?NW5YODdidU5kMk11bDFRUElITURFcVdWY3owaU9NdmFvbWcyQStKYlZGTjlI?= =?utf-8?B?OHVNWWpkckIwZG5BNVhMaFBEWXF0SEhDMXA1OHM2UjJxRG93UXMxWGhlMzc2?= =?utf-8?B?SHV4UzdNdSttOEd5elUxby9nWFlFKytkRUNyL2tIMUVBcWE3M0ZaM1JjaElR?= =?utf-8?B?anptRFJXZU1rM3NjbENyWTcxKy9RbVRFUmlCR0FHSGJZRmhFaVIwS0VXeGw3?= =?utf-8?B?S2cxb0xLY0FOcStRcGI4QWpON3EzdmJleDBPMFlMV3ZIREt3MmhDa21lVG11?= =?utf-8?B?ZHI1K0FFN2hmekNYdGEyQ1V2LytwaVNHMlFHVnBQVm1XQjQwWGswTmltTG5h?= =?utf-8?B?a1dXeHdUTGNaQzVNZ0JGOEh5RWZMdVBrV1ZyTDRmaU1VK051OTdRdVZPbWJU?= =?utf-8?B?QlNVNmtJZHJpdjNXNFFmSkJSWnRPS3VnOFN3TW5tZHlrSUNEN2ZvTGlLV08y?= =?utf-8?B?SlFLSmtFUSsvSTRPdlp6NXlZNzJOaUduRHJjVEEvbldDM29mRHpHNUVreW5Q?= =?utf-8?B?QmI0SHlKWlhMYXJwampuUC82UFlIWXByTTJhcmNVRisrSEtlVzh2U2NjbkdW?= =?utf-8?B?VGZxV1pPaDNHSXVlVllOdjV0UlhEbmNGekIvbGVhL080SHdXUXkvblpnMC9u?= =?utf-8?B?TGVCUUx1QlhCNDBKZXFnREdvKy9QdWxpTUVmMU5LTEliVmZsQUt2eG1jc2Rs?= =?utf-8?B?ZUFSaHRrVTQ5L2dOWDVKekJjL2lrODdCUW4zVkpJK0xYQ0dLNXdwazZFb1du?= =?utf-8?B?eHdJY0psZUN4R01kTjFQRVZqTGI0VEJCQkxnRTE4M0ZTbTZSdzFUMSsvNG9M?= =?utf-8?B?K1RBbjFQTXFSd1Q5VjVZSXYrMWMrWU1Ka3NVeXZUTXRxNUljWHFkNXEybFB2?= =?utf-8?B?QkRjRTc2c0U3QndKb0VMUTRBOUU4QnBpeW8zd3F5dEFWS0dELzVHdW93UlU2?= =?utf-8?Q?CTQCgIMbn9fbtsYLhpJgqC2s6KxAeuaZjhqohb7kC2hV?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c22e1764-1078-4ee2-4e3c-08de3c5b7b62 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:54.5566 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wTUfERx1onCP0aM+ey4bw+sTW9Mtg0VjBPXD1LG5IMbRQZ/xrZM9Iom7gvzDKTmM2kJR/8/it6tEjAroXWWMeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 The kernel's own CStr type has been replaced by the one in the core library, and is now an alias to the latter. Change our imports to directly reference the actual type. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/firmware.rs | 2 +- drivers/gpu/nova-core/firmware/gsp.rs | 6 ++++-- drivers/gpu/nova-core/nova_core.rs | 2 +- drivers/gpu/nova-core/util.rs | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/nova-core/firmware.rs b/drivers/gpu/nova-core/firm= ware.rs index 2d2008b33fb4..672f6cd24d4b 100644 --- a/drivers/gpu/nova-core/firmware.rs +++ b/drivers/gpu/nova-core/firmware.rs @@ -229,7 +229,7 @@ const fn make_entry_chipset(self, chipset: &str) -> Sel= f { } =20 pub(crate) const fn create( - module_name: &'static kernel::str::CStr, + module_name: &'static core::ffi::CStr, ) -> firmware::ModInfoBuilder { let mut this =3D Self(firmware::ModInfoBuilder::new(module_name)); let mut i =3D 0; diff --git a/drivers/gpu/nova-core/firmware/gsp.rs b/drivers/gpu/nova-core/= firmware/gsp.rs index 0549805282ab..53fdbf1de27e 100644 --- a/drivers/gpu/nova-core/firmware/gsp.rs +++ b/drivers/gpu/nova-core/firmware/gsp.rs @@ -34,10 +34,12 @@ /// that scheme before nova-core becomes stable, which means this module w= ill eventually be /// removed. mod elf { - use core::mem::size_of; + use core::{ + ffi::CStr, + mem::size_of, // + }; =20 use kernel::bindings; - use kernel::str::CStr; use kernel::transmute::FromBytes; =20 /// Newtype to provide a [`FromBytes`] implementation. diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nov= a_core.rs index b98a1c03f13d..3c26cf0b7c6e 100644 --- a/drivers/gpu/nova-core/nova_core.rs +++ b/drivers/gpu/nova-core/nova_core.rs @@ -19,7 +19,7 @@ mod util; mod vbios; =20 -pub(crate) const MODULE_NAME: &kernel::str::CStr =3D ::NAME; +pub(crate) const MODULE_NAME: &core::ffi::CStr =3D ::NAME; =20 kernel::module_pci_driver! { type: driver::NovaCore, diff --git a/drivers/gpu/nova-core/util.rs b/drivers/gpu/nova-core/util.rs index 4b503249a3ef..8b2a4b99c55b 100644 --- a/drivers/gpu/nova-core/util.rs +++ b/drivers/gpu/nova-core/util.rs @@ -3,10 +3,10 @@ /// Converts a null-terminated byte slice to a string, or `None` if the ar= ray does not /// contains any null byte or contains invalid characters. /// -/// Contrary to [`kernel::str::CStr::from_bytes_with_nul`], the null byte = can be anywhere in the +/// Contrary to [`core::ffi::CStr::from_bytes_with_nul`], the null byte ca= n be anywhere in the /// slice, and not only in the last position. pub(crate) fn str_from_null_terminated(bytes: &[u8]) -> Option<&str> { - use kernel::str::CStr; + use core::ffi::CStr; =20 bytes .iter() --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013012.outbound.protection.outlook.com [40.93.201.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5F1632E69A; Tue, 16 Dec 2025 04:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.12 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859318; cv=fail; b=BcWZxrTWPF6LMJyPbcLPekntwTrWY1PNqFYA7dfKGdYcseNcbIqx3nSk8cYg1WrQQYh2u+2Tkx6I3AAo4wuKMiXYEgUpwV/z0GVt4ZRViGOagtOpMhRnIF+E4BpJTYchFS0DA7vZrR8505p3osNH+czDgQ4Wf+l1FPD8rZzjjbw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859318; c=relaxed/simple; bh=us1XfvPAdrG7FOhfgwit8iyuJcGFkATVyJL1AsM7DRc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=VV3rqoFNUR/By5kJJeexvcpw/J0SmEgy5b+Z+BlCW+J5aWNEca09zQyOh9s7RqpUlQW6pZZBXEQGdRi0Gmai+tRmWwrlh8c76HA8qllkV0ReFZTrapnULxmu+HwfZt/D/QwZgA22gPIyKq0zna+HusyJzulkPMGzY7eyBzAR+bc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qDmyJU+2; arc=fail smtp.client-ip=40.93.201.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qDmyJU+2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MrAyNdAaSp5uAolHpe3y5g2C4/QqtAeiF3NUlaZlEmhqkeTYo+OFbqrR5+d2zW2b6qkYd9kqsFyD+WMvcZ3HvuophFqk2dnc9T6Z81JKZfFKxAGNG+MtiijfgCDALfWRs61UXCXZkeJCAUI07nP79vzxpqCzWgFopKR12MFqZKtJWewFc7XU2soaiMWiam409qYhmKMW9Alx3OvIcaHb3bVeORVAaeygJZXMEn+0FXk43w9MTdSRYP12vPKo1Cu5TJA0LqSqy4nMrL6DaG48clZZ+WAqVag4Uhq8lioPE+qYN+D7plrs81TmU1TahG4nB2AH85RF6fILcep0DarKOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1zeO7s72kBYHeKFwjlt1UCOec7OUIWIRIKIzf8JPvTc=; b=Wku67Y0WFTeljt9sajwJ9B2hrb3jqQL7391SemPJIeAA2jhAF78XTdV5RHvWVWj51a1ckQT1zKzA/iuqx+/OAmuVuxRQNluYC1i3cxUsEqIte6pV0nsS9C9vfwUXXNc7aMJfgim9A1FHz+3P6s9qh813CVIWyt5VnrJWFolloCFY9fezSNACKgU9HyiI1ytgQgn5xL73a/xtLvC8icUKHHKDwcMC3ybdYIu6hNSDa9+owd8qVoJV2w6iDHSdG1tv9shtrttwJxoLxRY7UFY0nSgetOUGpFXOAQ7eaqdW/A+CHJ+T+dI/q1iTq+BqHoVBJZa5RPlB22bSeCCx9Pncbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1zeO7s72kBYHeKFwjlt1UCOec7OUIWIRIKIzf8JPvTc=; b=qDmyJU+27KfvdTiZlzLpqUtyc4WLG7YGFy7ch9jzDb6KdM3/fjm0XpSUCLFbAjt1LxQFgfieZbiLc4PIYn8PMJLshrcmZPtRUE6qAshT+mbUezxzoKvwF+OlfQXWSRCYpnRo31nV4/WWGoSXDgIqcmY62lF38JFhGMSFj7Z5n1KEBKrViRLF+nISC9w0x9BowW49ys8wtXofFaFBkF0hIFkmAAVBVGV5cth2+GkW1xbq0cj41zAIgkLc6bsqVCHDGcQ4a9xa8FI+7wBMf1SSTpyaKX9FhrMb8lloKKTS5++Adr2Y6e3JqDK6sw0JQYH6kxvUFQSZVqr64mQHsGZtrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:27:58 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:27:58 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:29 +0900 Subject: [PATCH v2 09/10] gpu: nova-core: simplify str_from_null_terminated Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-9-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot , Lyude Paul X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCPR01CA0020.jpnprd01.prod.outlook.com (2603:1096:405::32) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: 0ff75295-50da-4534-4337-08de3c5b7d9e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q0YrQWFZNFRsY0tWd3F3NHF6MVpqRTVvNUFQQ21FVFltYXR4MkZtTnBWTXVl?= =?utf-8?B?dUlmZGROVTZXVHRDVmhKMzQ5VjBKMVFNUTNySkxydmpENGJEMUJSMVlML1dY?= =?utf-8?B?a0pTeWhxdU1LSWI3elF2M21kSUVDNzY5Q1EvRUUweTNPRkM0TU5DbHI1dzU0?= =?utf-8?B?TTFiL1FxODVNZjFicG1ZQ0JvQU55Smh0dHFJRXRSWmxOK1d5ZXIyQ1VhN0pO?= =?utf-8?B?SWJLNW1meVR4Wk1XRjc2WkJrOTQ0Qm1DNWZiU1NoYTRPMDhIZkc1MjVHVGFj?= =?utf-8?B?R2lMcnlRSTdTMHRwd2oyaHVQWTBVbEZCdVZSK3o2aXhoa0RsR0NwQWxhMUNq?= =?utf-8?B?bGl0blk4SmVBbDkzcVdraDhTT1VWTWpWSkROUWZhWVhVL3RDbjR3Yi82cmxJ?= =?utf-8?B?OW8vczFsT1RsYzNhY2RCWWEyMzd6eGdOU2tCYkN3aTBDV0ZXUEk0M1JZYnI1?= =?utf-8?B?Vk5qVWRhQ3ZoaTBTZjB0RXlHTDBjcko4NEJiYnE1NUVWNnpma1ZPZEVROFZM?= =?utf-8?B?Q212NWRGR2lIbFh6S2FIMmorclJpKzEyVG8rYnQzV1YxK3g5RUFpUXdqTEhW?= =?utf-8?B?Nlc5aGRwNGkyOVVhRXhtOFkrNmJoN2hqSHd6RG5JcFo1cEdKaXNjaXFZRnVT?= =?utf-8?B?akNoTFpvU2YvRjBOSzVNd3ltdHJhR2wwNG1hUWJhTkw3dVVwZVJ5K3ErSlVV?= =?utf-8?B?WEJDTmM2Rlk2OXRNR1JFRThSQmNpMGphamtlL2lhU1JHMHhRc2ZxTitBQlE4?= =?utf-8?B?ay9Fak5iUGlnM2pSbEt6VER4czlkSXRhSWkxSm1IWWxzVlZBc21iOFFIZXdB?= =?utf-8?B?RmR4Mzc2THVodEI2dHIxb05ITWl1OUs3Q3pKZ1crNkgrNVdEa3hobkd6UEdn?= =?utf-8?B?OTZTOVIyQk5FNG05dkVEQzJEbVVGOFJTb0loV2NTMnZzY0lia2ZNaUV0bkh3?= =?utf-8?B?aldhN0F1TzNvR0ZXQzJrYUU1ZzRYUXduU0FSQ3dMQmVyYlJBS0tUNDN1SzNm?= =?utf-8?B?d05wcXlnVjVubld0d0ZTYUIzczZoVXFOeEtKQU53cU52VkpzaHhKN3M1K2l1?= =?utf-8?B?OGpaWkZqUFJNaG1QUVRWTzRVZ2ZidnBDdDdhQUNud3BFNmVzU2RJUmtEMU5i?= =?utf-8?B?alRhUS8vWXFjd0Erc3Y4Z1ZWRGxQOUhNZmw3eEZLSndHNlVhUGdWVjZRWDlq?= =?utf-8?B?NUkxdFVCR1E3MS9SbDcvL29UWC9laUR1aFJkcGZ4akN3S1NWUkdjWERORFly?= =?utf-8?B?SEpMd3FSNlZkeXRkaEM5R1dBZnkzQTIyYkpENjcxOXpIWDdQdkpFak9VNG1C?= =?utf-8?B?bE5CM1ZESWdZdm9jN0pLNXVKS2E2cVVHQVdTLzhjWnFJQ0FGTmU5VDIxWjRZ?= =?utf-8?B?dXZ3Q01VSkYyT1kyTy9Vb1NUNGNnbXBvcjZyQWxkM3RuSWR4aU9WcEp6Vjdz?= =?utf-8?B?WUlJemdFbEFML01jMHZhYnU0ZXBvOFBXNHlJYVpKUnZUZVZsSGIzOXdpRVpB?= =?utf-8?B?SW9rVmcreHdtZGF2TjJFc3pzc1RiYXlhMHVlM3Iwc1ZTQ0NqeXkzK01LcnFH?= =?utf-8?B?eEtSRUExWU9uNzJXRTJ3aHNOejdicGRPcUxPWkZRT01wMEFxbmt2SWpHaHhm?= =?utf-8?B?UlRwNGl2VTd2ZXhVbVBlREpNUlVIUnVWWjM1Qkl5K2thckMvMmtqdmYzUkg4?= =?utf-8?B?SGVnNG15NVd4WjBqWTl3cnJFaDJjVjc4RTlhTDFMbVFLcGRCcElteVZVQzVJ?= =?utf-8?B?QTJmNERhdUJqOEtlekQ4V1hHcmtjdEVXamZtSjg2QU0ycXVPYVBHSUdmNnUz?= =?utf-8?B?b2xDcDNtNWN5SEhOUUlDdWpmSHYwUktFaXlSY0UvQ3RMN1ZuVVFZQ2E5VXhZ?= =?utf-8?B?bUlzd2dhUXAxWDk2MUp1cWdpcU5sODFrVU9iTWFWd0NYdHc2YVJlUTB2NUh6?= =?utf-8?Q?CE7ewjLxq6DT9Ns9FKIvcIjOxXvY1u3l?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WENiV3pxUDh3N0J0SHc5S0M1Wm1Bd09xSEowdXhGRTR2UWxFNk15bnZmR0Va?= =?utf-8?B?dFpTcDBxQi9wYkNUZmdLdmdMOVdkM3VTK2t0QVdiRDdPc0tabmRDeERKYlVt?= =?utf-8?B?OWo0Y0huZ3pXNGN2UzNBRHpTRmkxM0lScFB3Sm0yeUdVWGV6cGlHbzdCUGFL?= =?utf-8?B?cnNJc1RWRy9HUUl2czg1OUlHNk1IQ0UrTlVRcDBQZHFrRG16eDZIdytjU3Av?= =?utf-8?B?UHFpaDRXQ2s0cTNQM1FOem9KOExCMHduZlk4U1hrUzcySTJsZ05xQ3ozanlv?= =?utf-8?B?YnNFdHZkeUFMOEtNS1pWSzBJWkZmQnhCU08yY2JZZjZmR1Rqb2Y4QVNvZDhi?= =?utf-8?B?WW1xMVVid2NuVmlBc0J3R202d0Rub25yRlhzTXFMN3ZvdjZGcStoaEgxZk5u?= =?utf-8?B?NUJRaGZQNGljMlcrMWp5bmNyUDVzQWhrKzVMWTVnUVJvMmdoZXRqSlRpQ080?= =?utf-8?B?dFY1ZDA2aU45THhvR1BBdGpLbE9pZTlqSy9YT0RsWWZIR2t0STlhVFh1RUJP?= =?utf-8?B?Z0Z3eXF1ZnUxR3A0VnJFa2FqR0VyeGRaZUpwazgva0dHVFNqOTJIK0ZWM3Yw?= =?utf-8?B?RnNQbmowOXFvUzBoWlE3NVpmRVRabE5WOEJkT09vNFJuV0NGQ2RRWHVVcEY2?= =?utf-8?B?MXhoTFRxamtncHB3OGdEWEJ3MjNWb00vcGJwd1NHNHN5cFhvYmNsNndnQVZO?= =?utf-8?B?SXJFbW9oQUZGUlMxSVJWek16RDNzQmpVc3NuMWpxNnlDbVRETmVRZGRIb0lZ?= =?utf-8?B?aXNOUTQxVE5SdERIdnJpNnBwNkcrWHN3aUVid0dQZmJQNEQrV05VenZZdmVU?= =?utf-8?B?RFNkWXEwWDFXRGpzYjBnbHRVNVRMMGFabDlOT0RTcjArd2NjaU1ObkNqZ0ZB?= =?utf-8?B?VmZNQXZzOWhlK1kvaUE2SEY3Mzg4MHdQakRYandoanNXQVIyWjdrMWF6dzRl?= =?utf-8?B?bnZBNmJnelp2WG9HR2IvTmVUMnBkTTlabzNjT3FNNVRLbENNOFJRVnFOMnZr?= =?utf-8?B?cTAwZ0tacFgwSGpoV2FmUWJxbGpmeFh4Y3dnSE1hU2NUSE5jWlYwbFhVZmpM?= =?utf-8?B?YWlKbnJHMStWaUQvZmR5MmVXa3ZyNlFPTjFQdHdxOGJUaDNVQXFvMForQUNS?= =?utf-8?B?RVcyTjBFNG1hekdzbmZCeVZwQlEzbk1nWFJSR3FZWWFiZ2hkVks0dWNUSXIy?= =?utf-8?B?QWhHbUoweWpvUDE1bW1QaUxqblRxRDJJOTdJZUVHdUFZUTFsdys2d1JiMGRo?= =?utf-8?B?Qkp6ejlaZU1lZ1ZjZTVGNWZjbGdiWmlBcFNHNm1uamhXejlQa1V4S0RLTmF2?= =?utf-8?B?Z2xXSGV2dEtRSDNhaUU1YjR0Ump2REo5THJFdlRoclNBbld2MUdLc3JMTzVo?= =?utf-8?B?Tm9nV3pRZmNtRlhRZENhMkpYTHI0RkZZVTg1cWxNcDd3ekw1QlhUUTBVQUFx?= =?utf-8?B?ck04azF4Nmt2RUJOcXNPOE9kTHBuaXVzT2lpUXRhSHlSWWNybHpoUjM4alc2?= =?utf-8?B?a2I1blNqc0VUZUovVFEyQ0RTNHFQR1JTb0xyc0JKMWVLekFnclVFUWt5aHdZ?= =?utf-8?B?ZGd5cXBWYjFDN3Q0ZXpWMm8wRFZ5MHJ2bDUzRmZrczZSSkljMlFxODdZQmRq?= =?utf-8?B?emo5dmhTWUtjTm1Fd2xMSUJvaUp6OGt1TWpySWlCV2t3cktjMS9GZm9rVkJG?= =?utf-8?B?L24yMEY3MnkyS3BoelBmdjFUMXV4a3lZdjR6OTh1emdDVDdYMSt2RXdrdUZZ?= =?utf-8?B?a2dsZjZJbG5LZzFVL3hGZkdzVkMwMG0wRDJTMEVwakNmRHlaT3JFS3dqeCt1?= =?utf-8?B?Q2Zta0NydDV0ZGRGekg2Vzl3RExMTWswbitTS3RrNWZHR1FzYVBKMWtLQnRK?= =?utf-8?B?akw2bittQU1HS3ZKMGo0R0FlQU1kMzJ1MjRBdDZvVmdlcDdoVndHMDVYeUUr?= =?utf-8?B?cXRIb0dHQjhHYnA1UzhEYlU5WExhVXZNZ3FGNEdVZmZ6V2JkMEljL1ZTaDVT?= =?utf-8?B?WG10V1QvdGNGRjZKNlpWWDJWbndtcWJuaStWdEIzY0o3QVNKb2VOMVVoV1hP?= =?utf-8?B?VmxReHpvNTUrdElQZmp6bkJJZnBXS2J5UVhheHhJdXQ1SSsrNTMzdUViSGR1?= =?utf-8?B?ZldoZVNGQzVDM1BBSThnYWtDNWFadkZGMWZjUENVL0JFb2tPa25HdU9yTTIv?= =?utf-8?Q?vvMyMYp7dv+I4TusH+LZRsztybVmeLPY01uEVqh9UHXF?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ff75295-50da-4534-4337-08de3c5b7d9e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:27:58.1392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 61qgtmpMRCmPRlOgXXoEF1XFZUEo29FXD2p4PdYIyd1oJUrWsvu/a3cjk/V1eoeZxxh0EzINrVAHfxiA+x61gg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 The core library's `CStr` has a `from_bytes_until_nul` method that we can leverage to simplify this function. Reviewed-by: Lyude Paul Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/util.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/nova-core/util.rs b/drivers/gpu/nova-core/util.rs index 8b2a4b99c55b..2cccbce78c14 100644 --- a/drivers/gpu/nova-core/util.rs +++ b/drivers/gpu/nova-core/util.rs @@ -2,15 +2,10 @@ =20 /// Converts a null-terminated byte slice to a string, or `None` if the ar= ray does not /// contains any null byte or contains invalid characters. -/// -/// Contrary to [`core::ffi::CStr::from_bytes_with_nul`], the null byte ca= n be anywhere in the -/// slice, and not only in the last position. pub(crate) fn str_from_null_terminated(bytes: &[u8]) -> Option<&str> { use core::ffi::CStr; =20 - bytes - .iter() - .position(|&b| b =3D=3D 0) - .and_then(|null_pos| CStr::from_bytes_with_nul(&bytes[..=3Dnull_po= s]).ok()) + CStr::from_bytes_until_nul(bytes) + .ok() .and_then(|cstr| cstr.to_str().ok()) } --=20 2.52.0 From nobody Fri Dec 19 11:14:18 2025 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013029.outbound.protection.outlook.com [40.107.201.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1F1632E14C; Tue, 16 Dec 2025 04:28:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.29 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859330; cv=fail; b=j8yPnODMFpAB+IvtF2Yk/3TLWgBn+2xfmb2C6hQb5D0CZNaZYMRDmA5CAC6FnBxdyv/m9N9/+c+zHlE0yb4EPJpxwb2kmcpOAqU6qt7UMl89E8nW0ZssYDo2cVZsxlLIXzTo0USNzBS22LQ1tAQ7Ddziih153yLDPRtFTiv0up0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765859330; c=relaxed/simple; bh=L6PIgpsdTyQJkAbzdgZ9mOafDILUP2gxAfnqQie4Bvk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bmYJvblRHooMUJD2HpU1QIL0EH2uPw+4bBwj7s+A9NgYdXwSeeDEBeqeC0ZBIULTJmQYPVOaHcvOs6/vqjFRga4ZJCuFW0fYa7AR6FrbhI4llTFpYo0yN86tLolYwMZCSJZagJ673UtZ3b23rsS0eBeXxg2zwETUC0vmLpGVqfA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=mdDJCiC0; arc=fail smtp.client-ip=40.107.201.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="mdDJCiC0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sVy/Rh13FT/HEaEU20PLrvnYiFP8lUeNTDpzcU/4eacIxN2KDM9qg4RyRvIKvtgy0q9hsxhRp6ZrKRGWwFo2vVWVzfQx6CfUJxLf+kW1YrULzc0RJj4a5huhIHUeb8wS7hxO8vQYOM4AUKSYayOLLhBj5k8D8X+jxFpYQmTDk/T4YYAs6JpwCH10QF5NvW2UOnzgkx49P8r4ufAWEoiADi6KTY2IZplP5qpMJ5AbT4OJsw7bcGQs8c3UFFSkuZAXn1Fuqa4c8DCT14StKq5zLp2PUukfnJWaTYibd3w8vvOVw3fRgDAostWrJh8iGqcW/TmvTCAlEWOa/UXTXl44uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZUxRLlYcfDjKh25Gsggu6pSq6ECY7gT/seDuYBKPSHE=; b=bzUTcmgTG5EPCttvsnxxi17B8vGYwusGAwJWM2uvQgjtKWRe9+X9l3yO7hiryxCkuVDQUtzkGzpNtYI094Q3gGJmYY9jFpYIl7QYRJpp/IHKVWjoPqeWdU3/do2Cpy5fz8ryDsq781U4cw3MXO12cYniPkMp8X0MYUWQHxOELzYI/s+CWdsjFwcGPoOelqdq1MzkbvwNAMkysK5TDVJWld/OaCvT1WCxUH0NTJvzOe/O31B9fS9fsxM8t4/nBoYwagqW5EWzEQzSwrsEVn2o9xHX0V7cs2EdamQUfwliWjYNa20wPpMleLxRzNhTnJDd2RrSAhFbUX2MolmluJBiLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZUxRLlYcfDjKh25Gsggu6pSq6ECY7gT/seDuYBKPSHE=; b=mdDJCiC0GJPHE2ZlIYhpMsRfad4b1k+Yew3vltOaUVz+p55EdgA9c352ttjWdEVDJ7FOocdWsITe9En+JPM7u+fTV+MdDe/n6Lr1VRid3m4C94AU3eMHtfBggTnggO1GTrTfw7hIiqNq2N0FvMkmPeqm7GQ6x8f/29uwb+sqrhJPt/KOPyXY5gtjqcTl14EjQY0oHlaRIgSghFnNrmq8xrs7ohOYWPQScCOnPpmUP0zrxGWocvXvwC5P9/hHIFMdfp14mnyvCFUtfpV2qOtYIAggIbTtolv3NHDHBMzyjWAn2RULG2F3fQjcgMSF9ZS7t5GrIKEC3rMpHUipi3qCQA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) by CH3PR12MB8754.namprd12.prod.outlook.com (2603:10b6:610:170::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 04:28:01 +0000 Received: from CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com ([fe80::7de1:4fe5:8ead:5989%6]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 04:28:01 +0000 From: Alexandre Courbot Date: Tue, 16 Dec 2025 13:27:30 +0900 Subject: [PATCH v2 10/10] gpu: nova-core: gsp: use available device reference Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-nova-misc-v2-10-dc7b42586c04@nvidia.com> References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> To: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter Cc: John Hubbard , Alistair Popple , Joel Fernandes , Timur Tabi , Edwin Peer , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Alexandre Courbot X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0023.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:2b1::15) To CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB3990:EE_|CH3PR12MB8754:EE_ X-MS-Office365-Filtering-Correlation-Id: 61846ba8-56e1-4caa-8e1c-08de3c5b7f47 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|10070799003|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b0p1amN2c042VEsyZDlLZ1RIeEYwYXgwcHgyL2UvTmFzWDJlNlhQWVQrYy9y?= =?utf-8?B?bkZKekgvRDZ1bzNXNE50dUZaZlVlajd3dms1b0x4RHYrSFpYUVNTellsVWk5?= =?utf-8?B?SnRkNUUvcHlDV055U1pzNkRpRVBSbVFXUVJhaTlUTSt5WWNCRnVsZmduZVR6?= =?utf-8?B?NXVQdFcxN1FLb1puaDBraWRvSWJoaDBrRmIrSGljS3NoNEtzcHdTTXdzNmtX?= =?utf-8?B?dFE0TFpQcXVsaXVrTFJVcGh2YVdYK09YVnlhakFIR0VKcEpBSlJnUFE0TzdZ?= =?utf-8?B?RmlCVENLeFFXcjg0UVh2UTlnYUk4a0k2dG4rakVrZGtidEt1ejNpRW0wbUNG?= =?utf-8?B?Y3Z3TVE2OHArTUhwdVovbmFWcmN1UVZuMXd1RWpyVlhmN1ZqSkxuaUpOV3Vl?= =?utf-8?B?VVVqTmhhMVFTL1hNSm9pdSt6dkRuT3B6Ryt0YlZpMnhldHZGM3JSdUp2dTh1?= =?utf-8?B?QmNMbWRqLys2KzM1ZXliVlptaFUzK1RoTndLTU1TOHJUSWRhZFgxWXU1WHVN?= =?utf-8?B?TzVCeVVBQTc5WW9meWdDdTVUb3I3Z3NESjhpZEFXcGw5OHVudDkwQkVzODNh?= =?utf-8?B?K3ArOVFlTXk1QkRVcVlDMFdBZndIQXB3Umh5UDQya1UrbGhHVlNhY09zWmdM?= =?utf-8?B?eFJBZ2o3OFNyZFRTVkNialRxUjhlelZWWVJTYU1mYmk5UEJVU0xiWE1kSzgy?= =?utf-8?B?akFta25RdUpmNEUwa3A0WjdDQXBrbmJLcGxvNmxGRis3N094aHM4TThCeXFG?= =?utf-8?B?NnVRNjBiQlM1NVl4akxtcndXanV1VHNOc0tQSkNybGhSWHV3ZThtWk5URGxP?= =?utf-8?B?TGQ4NW93dnhTZzluQ1YzYmFxSkdWVGZiMFVvdy83b2hXbFNpZDZ0MUt5eWNr?= =?utf-8?B?Q3QwbnFXYUZveEFHUGNCelVKM1hpeUhveVEzRDBqL0JsTVhMNkNZQ3ZzNXBo?= =?utf-8?B?SXl1NmhteGdmZDF3OU93T3Q2S2R2a0Q2V1lTaXlLbkhpRHg0NUpldEN2bUQr?= =?utf-8?B?cGVGaHJLdmVYVUljU1B6djJOM3BaSVdKdk52V0tZYzMxL2NGQmVvV0xXSDgw?= =?utf-8?B?dXlxUFV3T2N0cEVMOWdxa1IwbWJjdW1LY2NEYzZJSUFlQXZHTS9ZcVA2Zlgx?= =?utf-8?B?VDZkSWE0em4yRXlHczZ2c3RielNsWlgxUEFtWUlvWTJMVDZSTStWL3dnMU5K?= =?utf-8?B?d1pPY1FldU9FdVR6Y0FxYXZXOTRoTkxnUVJvVDdoSXpPWGtBeEJDL1daUzRG?= =?utf-8?B?VUNHUlpzNUFuQmg1ZzdPRHR3TXdCVlcwbzZOSkd3RkdkTlZjZ1cxNEV1WGNX?= =?utf-8?B?RU83ZlYvcXIzdUgyZzVVZ3E1YU1MVU5tZUtnUk1BL1U2L0xpcTFxWmt5NTZi?= =?utf-8?B?aDBLMVR6T2RZUUZsMW9XUSs2WUNvZU9sd3RUUWtLdzFpNDFOMElGd0xRN3A2?= =?utf-8?B?MytjSHFSUmRlUVozdFRoWldid3JIbHo4ZXJab2s1SVpNc2c3eWRXQURUa1Bu?= =?utf-8?B?L1ZHWjAvRGdoQzBsNkJOYmtueGV5N2JqUjhsbXJ4bDg2RzNZRzhIem5Lc3lI?= =?utf-8?B?RW1QOE5Md2hJdm40T1RQM0t3dFdick5KRk9qRzluZ2VhYUtxc0sxTTVpNG5D?= =?utf-8?B?OXh4Y1ZxbGo1MlVzN0s0NnJhRE1CU1N5Y0RYVVJrMytseHREVy9ZZlZrSE5a?= =?utf-8?B?ejc1WGJJN2NNNy9SZVVEU2JWREF0aG1lMmg3Wi8rekhseXBaVHA3ajcrb1or?= =?utf-8?B?R1JibWdwVm9lSmVpOWhERXptakYzWk9Qcm1BcVY2bmxDR3V3YjlOeFZ2eTlP?= =?utf-8?B?VWh3Q3ZTVm5LZTZXVVE4b3F2bzJaSnQvZ2IweGFRam9BNTlEUGNJd043azlB?= =?utf-8?B?c0ZzeWtVK1lVeWZiQUNvdjRkNHA2bFJSSFJhSmliOE83Z2htRkw5MW1zUjFX?= =?utf-8?Q?siXh1Ht+AZxsSdvWIIaRVhJDR4N5bfjR?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(10070799003)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aklnZU1UeGZ3QzExcCs1WS9QOXBreXdNYkxzRUErNWhYQVRLVUhTZ29FSG9l?= =?utf-8?B?cllpNDZZVFM0S0dIN1NaUjc5Y3FXZjA1VlJpak9hek5LT3pHVldSVVlrdXN0?= =?utf-8?B?anVDNjJibDFDb3k3ZSszRnh6TlZzbDdlL0p6YzZtOWNpY2QwS0F4aWNsekls?= =?utf-8?B?Z3R3WXo0Vnk4TzltZEJIbldzOEZPT283SkFjUm9vL0ZnTGV6Qzh6cWJtV3d5?= =?utf-8?B?bjZVRkF4aXFxakEzZjdhKzIyVzNHVGVyZ0wwR2JQOTNiRGU3UFpTKytyR2NN?= =?utf-8?B?azJRUWpwVlpwRTJNQnV5cThkRjBNSnZSc3J6SmltNGlEeTlvd1ZpdllETlFS?= =?utf-8?B?R0VGSUY2bkZReGpadGpOclZGZ0J2UFpSNHh1WUZJT2FKcHJ6YWRWazdGUmUv?= =?utf-8?B?TXJEeSs0azY2UkZIYVBCVGJqY1lBelNicnZOTS9zY3NZemV2S09VZmhpVUNm?= =?utf-8?B?UG9IRHFSNjBRVm56TFA5TDFUODErTk5PNy9aakxXU3JEdUVQbGkzdGZYVjhX?= =?utf-8?B?STEyOVFPTnBYS0kwaDVCdFlyUzBwZEg1aHhOdFZHdERzTWQzMStWWWh4M1Rm?= =?utf-8?B?OXUwQjJqc3pOSnAxVVBZUktYWEJsVk5CVDVKbWJtUytEeG9JTUFNMzZmY2pM?= =?utf-8?B?Snh5NHBMTXF0am1QSThxMnVNWERacStuQzlxQzQ3YWE2eXRiUHpVR3UrS1E3?= =?utf-8?B?M3dsdHlZUld4bzIxYnhWdFFrTXU4T2c2U1N4a3ZScDZDSGJyN3FaRm00bk9V?= =?utf-8?B?djNPdGhFUEtIRTdLL1N5eWwrY3hVNlBwSjJWYzFsaVlDd3lIbkk2OVhpNHBu?= =?utf-8?B?QkJtL0lUOXh3Z0NTQUgrUVhKV3JZSlFBa3hISmdEVWNCeTNZMllMM1MvRCtN?= =?utf-8?B?NEsvUzdXZVpUWFU4bTdLSmVTUHhNN2g0MFBJSi9EZktMaFl1VEpjTGROaGF1?= =?utf-8?B?bGk1ZFZ3bkplN1UvY1BjVyszWVZwVTR0dExubTFkTmpOdWdIYUh1dHlqZkts?= =?utf-8?B?SHBSQThUdjVKakJKM0Y2YXRvb3RZdG1SYzYyZ2NkbStoUzFMQjhDOHpIWHpQ?= =?utf-8?B?cVMrVTV5MzJhbGhHWHlHV2RQQmhjYTgvVU1meUxHSGxqem9FVHh0MGIzL0Ry?= =?utf-8?B?V0pYOURJQ0NZRkROOEs1U3I4NWhuVGVYM2NmUU41T0ZHTVovaDMydmxsU2d2?= =?utf-8?B?MG1aNlhOSk1oLzRZdmFzdU5LbkN6S3V2RG9xai9mU1V2K0dnVVFqcTk0UkVD?= =?utf-8?B?bEo5OXlMQUdHNFNXVlFiMkk4YzBmUUw0WGFXMHlJdXdQUEcwQ1hKc2ZYaFNw?= =?utf-8?B?YzZtTHR5SmpNNm03UUF2ZXZUVnRsV1VleEFPN3ZlQURNZU40Z3JJV0RhUjBu?= =?utf-8?B?S0JmVVFDSDlpc1d6ZEpFQ21WdUxVeU5yaU1nK2l5RUdmOVkxSHZHK0NYd1Rl?= =?utf-8?B?cU1hYmVzb2NLQzdBWDNGWmpLaTZUajMxZXdWbWlGN2tiZTJmMmR1aXdVYTE3?= =?utf-8?B?c3o5TUlzRGZRd05ob0tzdW5taXgvbjcwRTlIVVRBbVFzUzR0aGRNanV3Nzhy?= =?utf-8?B?MjFKcEJZdFgrbk9HTUxBdWQ4SHBiNFpRWG9vWWpkWFNoUmpJcGd1YWkrLzZC?= =?utf-8?B?VzJQZjd5NGlyZ0lmUnNRei8yWVZnM1FJSm5nLzBGNW1raXd2emRFbnRhcnVL?= =?utf-8?B?MkFseDBPRUhXSlViSzdxN0VFbDJZUENhYU1xRzMxbGFyKzdyWU5NVXRQVU5L?= =?utf-8?B?cGhqWUFQVjRrdFVkUmJOSzZnK2JTTVlqcXUzNTNnYjcySlEwNU9MOXdKc1J0?= =?utf-8?B?Um9xamxYRkh2SXErdmVXQlVFL083N080SElyeVU0T0lqVXQzWTJ6dlY5b3Js?= =?utf-8?B?a3BweTVpUGhYblZDSEtPdlFDZXgra1MwMkpoNVVaVEZRZG9oMVlzQ3o0M0M0?= =?utf-8?B?Qnh1UEJBRkxPb1YxNHBZOVNYblM1Mk52a0o3M3lObUZ3RWxOZDRRc1ZMZTBh?= =?utf-8?B?SXJPSTNIVkpxQ0dpcXl4OUpKL3VoMndnb3FVT3l5czBWK0QzRHNlL1l2TFdY?= =?utf-8?B?djJNUTYvWlczZmdqOFR6K1BvTDg2anpCOGp4OEZ0N2FrdXExRExReUlUejBU?= =?utf-8?B?Y3VDYnE1OUN5bTF6bHlqK0ZocFQ0aGR3M3B6RGpYWGxNUC8zaVZaeXJPb1Rz?= =?utf-8?Q?sAd+lDEKlmLBqewJnWyMqss2BgxxJM+F2pfkbZLF69wi?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61846ba8-56e1-4caa-8e1c-08de3c5b7f47 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB3990.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 04:28:00.9615 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YEVaXEX+qOAd+Ji345SdavzOmuOT9YCrwdnkMePtUvosV37vQJz4FRFovGb83cztOE0//xAFQrIpG75Yckfe2w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8754 We already have a regular reference to the `Device`, so we don't need to repeatedly acquire one in this method. Signed-off-by: Alexandre Courbot --- drivers/gpu/nova-core/gsp/boot.rs | 32 +++++++------------------------- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/boot.rs b/drivers/gpu/nova-core/gsp/= boot.rs index 54937606b5b0..ca7efdaa753b 100644 --- a/drivers/gpu/nova-core/gsp/boot.rs +++ b/drivers/gpu/nova-core/gsp/boot.rs @@ -173,15 +173,10 @@ pub(crate) fn boot( Some(libos_handle as u32), Some((libos_handle >> 32) as u32), )?; - dev_dbg!( - pdev.as_ref(), - "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", - mbox0, - mbox1 - ); + dev_dbg!(dev, "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1); =20 dev_dbg!( - pdev.as_ref(), + dev, "Using SEC2 to load and run the booter_load firmware...\n" ); =20 @@ -193,19 +188,10 @@ pub(crate) fn boot( Some(wpr_handle as u32), Some((wpr_handle >> 32) as u32), )?; - dev_dbg!( - pdev.as_ref(), - "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", - mbox0, - mbox1 - ); + dev_dbg!(dev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1); =20 if mbox0 !=3D 0 { - dev_err!( - pdev.as_ref(), - "Booter-load failed with error {:#x}\n", - mbox0 - ); + dev_err!(dev, "Booter-load failed with error {:#x}\n", mbox0); return Err(ENODEV); } =20 @@ -219,11 +205,7 @@ pub(crate) fn boot( Delta::from_secs(5), )?; =20 - dev_dbg!( - pdev.as_ref(), - "RISC-V active? {}\n", - gsp_falcon.is_riscv_active(bar), - ); + dev_dbg!(dev, "RISC-V active? {}\n", gsp_falcon.is_riscv_active(ba= r),); =20 // Create and run the GSP sequencer. let seq_params =3D GspSequencerParams { @@ -231,7 +213,7 @@ pub(crate) fn boot( libos_dma_handle: libos_handle, gsp_falcon, sec2_falcon, - dev: pdev.as_ref().into(), + dev: dev.into(), bar, }; GspSequencer::run(&mut self.cmdq, seq_params)?; @@ -242,7 +224,7 @@ pub(crate) fn boot( // Obtain and display basic GPU information. let info =3D commands::get_gsp_info(&mut self.cmdq, bar)?; dev_info!( - pdev.as_ref(), + dev, "GPU name: {}\n", info.gpu_name().unwrap_or("invalid GPU name") ); --=20 2.52.0