From nobody Fri Dec 19 07:23:42 2025 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACB3F33DEF4 for ; Tue, 16 Dec 2025 18:00:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765908052; cv=none; b=aQVDgyomKls/NRfLODNp0GuoFFnWNGXGZ+/2oTDZPOCymX5pa/54YYx2Fa2IpvkGvHn7xpG8/ViVFZ43CSrxjbEbfvZdFnRfR9SBxx6X5zQVqnaXX60TeP6ypjTCYwalrrhLeSljPlO++kP2WvCwWYizecfaFD2/IN3xZvd2N8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765908052; c=relaxed/simple; bh=CXytcq9vi6icARbfFGq3HvY1gBQE7sMGyO4tH+F0YDI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BZzjhoBHstdhzPpm27f+eNhSFf+9aqldh11F3zIxoE8VimKrRvBP4IwDJ3KvQ/bmgxsDH8AXlhJxORofJ3ROOt83IemoAEZotecGHbNppD4uRDMkDLGUixat3cEbNykOP/XzkFko7SOxYyuYhpl5G0qTRFu7FG5Ci7tLLrPDVOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=yR5sfELE; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="yR5sfELE" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 40BD64E419EA; Tue, 16 Dec 2025 18:00:49 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 10E286071C; Tue, 16 Dec 2025 18:00:49 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7FECC119A97F1; Tue, 16 Dec 2025 19:00:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1765908044; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=E3venDDom+DGFVL2bgaoBeY8hl48k7Az+c/QW6Kq99o=; b=yR5sfELEKiDsl6homJx8wSE/k1REIQEFf5NXXHzizUBK3BAAa2Y0fcoFe6RQ7WxKJSXkDg 0Cy/3b46ZAqF6OmFmbHfe4CGoK7+ni1KnwlWwKmer5zc15o5unWt58yBwkhmgDyRVwxMMf F+Tp/d/qlCVqWAwJqziid9YCm+rVJh07PMgZzGgJmFh0CnEGbc4Brp8POrKw6ZKuKH7XDT gcYMAWBTcCtA7ZJFa1lgkMyOf2VI19Bv/w1bQHAf2jQqieWKxr6WNV4LPkd+xU6Zz4tPY9 zTb2K5wpbZ6He0CLEhK5/IXHbpoJhn3O4wTzbHurzwg+Xmz/1jyARlwuLNQTdQ== From: Luca Ceresoli Date: Tue, 16 Dec 2025 18:58:50 +0100 Subject: [PATCH v3 17/22] drm/bridge: imx8qxp-pxl2dpi: get/put the companion bridge Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-17-b5165fab8058@bootlin.com> References: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-0-b5165fab8058@bootlin.com> In-Reply-To: <20251216-drm-bridge-alloc-getput-drm_of_find_bridge-v3-0-b5165fab8058@bootlin.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Alexey Brodkin , Phong LE , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: Hui Pu , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, Luca Ceresoli X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 This driver obtains a bridge pointer from of_drm_find_bridge() in the probe function and stores it until driver removal. of_drm_find_bridge() is deprecated. Move to of_drm_find_and_get_bridge() for the bridge to be refcounted and use the destroy hook to put the reference on deallocation. Signed-off-by: Luca Ceresoli Reviewed-by: Maxime Ripard --- drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c b/drivers/gpu/drm= /bridge/imx/imx8qxp-pxl2dpi.c index 556aec3b3734..2c40ca86e319 100644 --- a/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-pxl2dpi.c @@ -63,6 +63,13 @@ static int imx8qxp_pxl2dpi_bridge_attach(struct drm_brid= ge *bridge, DRM_BRIDGE_ATTACH_NO_CONNECTOR); } =20 +static void imx8qxp_pxl2dpi_bridge_destroy(struct drm_bridge *bridge) +{ + struct imx8qxp_pxl2dpi *p2d =3D bridge->driver_private; + + drm_bridge_put(p2d->companion); +} + static int imx8qxp_pxl2dpi_bridge_atomic_check(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, @@ -205,6 +212,7 @@ static const struct drm_bridge_funcs imx8qxp_pxl2dpi_br= idge_funcs =3D { .atomic_destroy_state =3D drm_atomic_helper_bridge_destroy_state, .atomic_reset =3D drm_atomic_helper_bridge_reset, .attach =3D imx8qxp_pxl2dpi_bridge_attach, + .destroy =3D imx8qxp_pxl2dpi_bridge_destroy, .atomic_check =3D imx8qxp_pxl2dpi_bridge_atomic_check, .mode_set =3D imx8qxp_pxl2dpi_bridge_mode_set, .atomic_disable =3D imx8qxp_pxl2dpi_bridge_atomic_disable, @@ -333,7 +341,7 @@ static int imx8qxp_pxl2dpi_parse_dt_companion(struct im= x8qxp_pxl2dpi *p2d) goto out; } =20 - p2d->companion =3D of_drm_find_bridge(companion); + p2d->companion =3D of_drm_find_and_get_bridge(companion); if (!p2d->companion) { ret =3D -EPROBE_DEFER; DRM_DEV_DEBUG_DRIVER(p2d->dev, --=20 2.52.0