From nobody Sun Feb 8 00:26:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 782AE347FED; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872201; cv=none; b=NxCycUKTBGGPy90TUkHVys2cIqBLn0q2Fm+bBCQe5LyNSXVKmVqsroGmDs8jLJs2QL8/Vd9TBxXmU/iGpUH10r1Tm97ab199LLfneBUoAWeXmOugiIuiCoLk7fd4ZuQFA80AQLRS3icxvo7lgVoEMm+DD8KCwNNEwqP+o8XeM7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872201; c=relaxed/simple; bh=SWV/NfL3tLtgdR0M1+5VAcbUWkx942kwzpVWDE2itE0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TubFHaT6fGsB/pK9F8D4B/Hs/TKbiYjhtuppbw0B6pBvBRc0kCUDtn6WLCfOofs70HCYH24BjmB/6JCFh16Ert29q/oeRjLgcCUTbdfAUmIohqW162Xvrcy5Rd23uL167LR0znhsAQuBCqo6OnW61De9SvumFeY7SUpBVDYJjw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=szghvzKL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="szghvzKL" Received: by smtp.kernel.org (Postfix) with ESMTPS id ED877C19424; Tue, 16 Dec 2025 08:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765872201; bh=SWV/NfL3tLtgdR0M1+5VAcbUWkx942kwzpVWDE2itE0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=szghvzKLsJXowPIL3zohB0bKAioASP/yfFzcC89jI6asBK9WKb9ccFqt8vP017QQ1 sbMVNshut3lEw6TZqLnJMyWeHRO3rxZyikVpdo/Qy3e6ukaWO4ce5Ms3CZdTdXd3KV KDbhjZP4wj5lrnChsVq8PXBODHl/d8ntgemBxacHWUq2IJDeFe07KZBMQz/keeAD8Y CZxFKXweZi3Jsmsj8iPQdlC60vdtdm/FkQ8k3oGzYWHlaSnI2q4DVIV/8jK0SGOy0Z xoObIDlyGe9Ct2yIKPrNBaxRWDqhJW6uZXlU+a3x8fO0a9qBJzf5xVxrBZMlLIsaTP hO0w5WFvfLw6g== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4960D5C0D0; Tue, 16 Dec 2025 08:03:20 +0000 (UTC) From: Xianwei Zhao via B4 Relay Date: Tue, 16 Dec 2025 08:03:17 +0000 Subject: [PATCH 1/3] dt-bindings: dma: Add Amlogic general DMA Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-amlogic-dma-v1-1-e289e57e96a7@amlogic.com> References: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> In-Reply-To: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , "Gustavo A. R. Silva" Cc: linux-amlogic@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Xianwei Zhao X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765872198; l=2309; i=xianwei.zhao@amlogic.com; s=20251216; h=from:subject:message-id; bh=YtNRhQ7yOxGHI4OflJLoTQNj1t3FJEpqV/TcNs/qfSA=; b=XpNQNJ5Pk6DQgEgq8PAeCMnzEndlKbIEJtJ9zf+fGqwPN8DH/boK5LsAvSrASIYm4jjkWFm+d sQSF4mpzF76Af5+idnocEoqsSblm27jw0/CW4/tWBOsIciDiUmgfmBQ X-Developer-Key: i=xianwei.zhao@amlogic.com; a=ed25519; pk=dWwxtWCxC6FHRurOmxEtr34SuBYU+WJowV/ZmRJ7H+k= X-Endpoint-Received: by B4 Relay for xianwei.zhao@amlogic.com/20251216 with auth_id=578 X-Original-From: Xianwei Zhao Reply-To: xianwei.zhao@amlogic.com From: Xianwei Zhao Add documentation describing the Amlogic general DMA. Signed-off-by: Xianwei Zhao --- .../bindings/dma/amlogic,general-dma.yaml | 70 ++++++++++++++++++= ++++ 1 file changed, 70 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/amlogic,general-dma.yaml= b/Documentation/devicetree/bindings/dma/amlogic,general-dma.yaml new file mode 100644 index 000000000000..8b9cec9b8da0 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/amlogic,general-dma.yaml @@ -0,0 +1,70 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/amlogic,general-dma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic general DMA controller + +description: | + This is a general-purpose peripheral DMA controller. It currently suppor= ts + major peripherals including I2C, I3C, PIO, and CAN-BUS. Transmit and rec= eive + for the same peripheral use two separate channels, controlled by differe= nt + register sets. I2C and I3C transfer data in 1-byte units, while PIO and + CAN-BUS transfer data in 4-byte units. From the controller=E2=80=99s per= spective, + there is no significant difference. + +maintainers: + - Xianwei Zhao + +properties: + compatible: + const: amlogic,general-dma + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: sys + + '#dma-cells': + const: 2 + + dma-channels: + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 64 + +required: + - compatible + - reg + - interrupts + - clocks + - '#dma-cells' + - dma-channels + +allOf: + - $ref: dma-controller.yaml# + +unevaluatedProperties: false + +examples: + - | + #include + apb { + #address-cells =3D <2>; + #size-cells =3D <2>; + dma-controller@fe400000{ + compatible =3D "amlogic,general-dma"; + reg =3D <0x0 0xfe400000 0x0 0x4000>; + interrupts =3D ; + clocks =3D <&clkc 45>; + #dma-cells =3D <2>; + dma-channels =3D <28>; + }; + }; --=20 2.52.0 From nobody Sun Feb 8 00:26:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00A2348456; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872202; cv=none; b=IZSkdsyYCpZXjocAQrdVBG+w0xNeDM1+ZRIe3Chp7SjcyrlosBVtFg+2xAGG9FtUHq5rnHrT8P1wu1sbV9VptaZZb0L69256m8BI9+EskIcHB8PrYyxDqGAYafDJVz5NTZ6PL7ZXjFZSeySe7bTs+z+ZYGEicDyo6JClkTtOlN8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872202; c=relaxed/simple; bh=13Iow72BE0Dh5vPaSgEuZSob4H4qkGWNZ+Fa/Y5tZZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fx870ogjS1vRpTlX4wDKym8M1AUB/EKqd92iZu1oe1MDBc78U4Zs/iXkXC9r0eaTvom1WoqJx3J/W650YP4AGqTWcXqDuEQGPlolOwwF6Ev/waTFbPER1QDILn4s7IRVQVI4t5+0rAvJmoZZZJoVWqHk/Z48mCIakrwOC5dlNDk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZgPDpyWz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZgPDpyWz" Received: by smtp.kernel.org (Postfix) with ESMTPS id 594FCC113D0; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765872201; bh=13Iow72BE0Dh5vPaSgEuZSob4H4qkGWNZ+Fa/Y5tZZE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=ZgPDpyWz23sRjPMlIrUt2Os89OGD8FTsJ/7IN6T9TGiNdD8AK3U+NjOnD7cEHre7f yRvuXK1EXySBW/Oxw8pmMBjRgMz+XfAAArTUzDVzXnBaCjajdhW/1oxCDHHgFGi1UY 9TJMSEXYjurWYa4p+2fU1PJ7u/Teat2Yrgqnlmc6fCR06mdlSczBnMTR+wgu492voz CX3XYa+G/dHUMUwO8uogpKzUJYhMfFMqe3NhMBPRCubliJ79+LvHS6015iWE7shjwX 9pK/rGaFmmyR9osaZLfQ3QbWn56lOFH6awJFuY8PnUeqcOJ8NkwsI/+pqptuJYhSZ+ ra0y1fmCGTnNA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B3BD5B16C; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) From: Xianwei Zhao via B4 Relay Date: Tue, 16 Dec 2025 08:03:18 +0000 Subject: [PATCH 2/3] dma: amlogic: Add general DMA driver for SoCs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-amlogic-dma-v1-2-e289e57e96a7@amlogic.com> References: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> In-Reply-To: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , "Gustavo A. R. Silva" Cc: linux-amlogic@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Xianwei Zhao X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765872198; l=19175; i=xianwei.zhao@amlogic.com; s=20251216; h=from:subject:message-id; bh=5z0UO9EA2klunxl5LHlWYHBSMIh8pOWVjCJDpy+YMcM=; b=/gyWo6V1AlVUrWmq01HP+8cgs+s/HyzsLb5rIP26Z5JfSvgySOkBueFXsW53JesFbGUnEnIKN BVArxJpu3c0CQ5KyDYIMjY6xNu4VhNp+iAwEV9ARGXl2N3vl0wmvzFq X-Developer-Key: i=xianwei.zhao@amlogic.com; a=ed25519; pk=dWwxtWCxC6FHRurOmxEtr34SuBYU+WJowV/ZmRJ7H+k= X-Endpoint-Received: by B4 Relay for xianwei.zhao@amlogic.com/20251216 with auth_id=578 X-Original-From: Xianwei Zhao Reply-To: xianwei.zhao@amlogic.com From: Xianwei Zhao Amlogic SoCs include a general-purpose DMA controller that can be used by multiple peripherals, such as I2C PIO and I3C. Each peripheral group is associated with a dedicated DMA channel in hardware. Signed-off-by: Xianwei Zhao --- drivers/dma/Kconfig | 8 + drivers/dma/Makefile | 1 + drivers/dma/amlogic-dma.c | 567 ++++++++++++++++++++++++++++++++++++++++++= ++++ 3 files changed, 576 insertions(+) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 8bb0a119ecd4..fc7f70e22c22 100644 --- a/drivers/dma/Kconfig +++ b/drivers/dma/Kconfig @@ -85,6 +85,14 @@ config AMCC_PPC440SPE_ADMA help Enable support for the AMCC PPC440SPe RAID engines. =20 +config AMLOGIC_DMA + tristate "Amlogic genneral DMA support" + depends on ARCH_MESON + select DMA_ENGINE + select REGMAP_MMIO + help + Enable support for the Amlogic general DMA engines. + config APPLE_ADMAC tristate "Apple ADMAC support" depends on ARCH_APPLE || COMPILE_TEST diff --git a/drivers/dma/Makefile b/drivers/dma/Makefile index a54d7688392b..fc28dade5b69 100644 --- a/drivers/dma/Makefile +++ b/drivers/dma/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_DMATEST) +=3D dmatest.o obj-$(CONFIG_ALTERA_MSGDMA) +=3D altera-msgdma.o obj-$(CONFIG_AMBA_PL08X) +=3D amba-pl08x.o obj-$(CONFIG_AMCC_PPC440SPE_ADMA) +=3D ppc4xx/ +obj-$(CONFIG_AMLOGIC_DMA) +=3D amlogic-dma.o obj-$(CONFIG_APPLE_ADMAC) +=3D apple-admac.o obj-$(CONFIG_ARM_DMA350) +=3D arm-dma350.o obj-$(CONFIG_AT_HDMAC) +=3D at_hdmac.o diff --git a/drivers/dma/amlogic-dma.c b/drivers/dma/amlogic-dma.c new file mode 100644 index 000000000000..40099002d558 --- /dev/null +++ b/drivers/dma/amlogic-dma.c @@ -0,0 +1,567 @@ +// SPDX-License-Identifier: (GPL-2.0-only OR MIT) +/* + * Copyright (C) 2025 Amlogic, Inc. All rights reserved + * Author: Xianwei Zhao + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include "dmaengine.h" + +#define RCH_REG_BASE 0x0 +#define WCH_REG_BASE 0x2000 +/* + * Each rch (read from memory) REG offset Rch_offset 0x0 each channel tot= al 0x40 + * rch addr =3D DMA_base + Rch_offset+ chan_id * 0x40 + reg_offset + */ +#define RCH_READY 0x0 +#define RCH_STATUS 0x4 +#define RCH_CFG 0x8 +#define CFG_CLEAR BIT(25) +#define CFG_PAUSE BIT(26) +#define CFG_ENABLE BIT(27) +#define CFG_DONE BIT(28) +#define RCH_ADDR 0xc +#define RCH_LEN 0x10 +#define RCH_RD_LEN 0x14 +#define RCH_PRT 0x18 +#define RCH_SYCN_STAT 0x1c +#define RCH_ADDR_LOW 0x20 +#define RCH_ADDR_HIGH 0x24 +/* if work on 64, it work with RCH_PRT */ +#define RCH_PTR_HIGH 0x28 + +/* + * Each wch (write to memory) REG offset Wch_offset 0x2000 each channel t= otal 0x40 + * wch addr =3D DMA_base + Wch_offset+ chan_id * 0x40 + reg_offset + */ +#define WCH_READY 0x0 +#define WCH_TOTAL_LEN 0x4 +#define WCH_CFG 0x8 +#define WCH_ADDR 0xc +#define WCH_LEN 0x10 +#define WCH_RD_LEN 0x14 +#define WCH_PRT 0x18 +#define WCH_CMD_CNT 0x1c +#define WCH_ADDR_LOW 0x20 +#define WCH_ADDR_HIGH 0x24 +/* if work on 64, it work with RCH_PRT */ +#define WCH_PTR_HIGH 0x28 + +/* DMA controller reg */ +#define RCH_INT_MASK 0x1000 +#define WCH_INT_MASK 0x1004 +#define CLEAR_W_BATCH 0x1014 +#define CLEAR_RCH 0x1024 +#define CLEAR_WCH 0x1028 +#define RCH_ACTIVE 0x1038 +#define WCH_ACTIVE 0x103C +#define RCH_DONE 0x104C +#define WCH_DONE 0x1050 +#define RCH_ERR 0x1060 +#define RCH_LEN_ERR 0x1064 +#define WCH_ERR 0x1068 +#define DMA_BATCH_END 0x1078 +#define WCH_EOC_DONE 0x1088 +#define WDMA_RESP_ERR 0x1098 +#define UPT_PKT_SYNC 0x10A8 +#define RCHN_CFG 0x10AC +#define WCHN_CFG 0x10B0 +#define MEM_PD_CFG 0x10B4 +#define MEM_BUS_CFG 0x10B8 +#define DMA_GMV_CFG 0x10BC +#define DMA_GMR_CFG 0x10C0 + +#define DMA_MAX_LINK 8 +#define MAX_CHAN_ID 32 +#define SG_MAX_LEN ((1 << 27) - 1) + +struct aml_dma_sg_link { +#define LINK_LEN GENMASK(26, 0) +#define LINK_IRQ BIT(27) +#define LINK_EOC BIT(28) +#define LINK_LOOP BIT(29) +#define LINK_ERR BIT(30) +#define LINK_OWNER BIT(31) + u32 ctl; + u64 address; + u32 revered; +} __packed; + +struct aml_dma_chan { + struct dma_chan chan; + struct dma_async_tx_descriptor desc; + struct aml_dma_dev *aml_dma; + struct aml_dma_sg_link *sg_link; + dma_addr_t sg_link_phys; + int sg_link_cnt; + int data_len; + enum dma_status status; + enum dma_transfer_direction direction; + int chan_id; + /* reg_base (direction + chan_id) */ + int reg_offs; +}; + +struct aml_dma_dev { + struct dma_device dma_device; + void __iomem *base; + struct regmap *regmap; + struct clk *clk; + int irq; + struct platform_device *pdev; + struct aml_dma_chan *aml_rch[MAX_CHAN_ID]; + struct aml_dma_chan *aml_wch[MAX_CHAN_ID]; + unsigned int chan_nr; + unsigned int chan_used; + struct aml_dma_chan aml_chans[]__counted_by(chan_ns); +}; + +static struct aml_dma_chan *to_aml_dma_chan(struct dma_chan *chan) +{ + return container_of(chan, struct aml_dma_chan, chan); +} + +static dma_cookie_t aml_dma_tx_submit(struct dma_async_tx_descriptor *tx) +{ + return dma_cookie_assign(tx); +} + +static int aml_dma_alloc_chan_resources(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + + aml_chan->sg_link =3D dma_alloc_coherent(aml_dma->dma_device.dev, + sizeof(struct aml_dma_sg_link) * DMA_MAX_LINK, + &aml_chan->sg_link_phys, GFP_KERNEL); + if (!aml_chan->sg_link) + return -ENOMEM; + + /* offset is the same RCH_CFG and WCH_CFG */ + regmap_update_bits(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, CFG_CLE= AR, CFG_CLEAR); + aml_chan->status =3D DMA_COMPLETE; + dma_async_tx_descriptor_init(&aml_chan->desc, chan); + aml_chan->desc.tx_submit =3D aml_dma_tx_submit; + regmap_update_bits(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, CFG_CLE= AR, 0); + + return 0; +} + +static void aml_dma_free_chan_resources(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + + aml_chan->status =3D DMA_COMPLETE; + dma_free_coherent(aml_dma->dma_device.dev, + sizeof(struct aml_dma_sg_link) * DMA_MAX_LINK, + aml_chan->sg_link, aml_chan->sg_link_phys); +} + +/* DMA transfer state update how many data reside it */ +static enum dma_status aml_dma_tx_status(struct dma_chan *chan, + dma_cookie_t cookie, + struct dma_tx_state *txstate) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + u32 residue, done; + + regmap_read(aml_dma->regmap, aml_chan->reg_offs + RCH_RD_LEN, &done); + residue =3D aml_chan->data_len - done; + dma_set_tx_state(txstate, chan->completed_cookie, chan->cookie, + residue); + + return aml_chan->status; +} + +static struct dma_async_tx_descriptor *aml_dma_prep_slave_sg + (struct dma_chan *chan, struct scatterlist *sgl, + unsigned int sg_len, enum dma_transfer_direction direction, + unsigned long flags, void *context) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + struct aml_dma_sg_link *sg_link; + struct scatterlist *sg; + int idx =3D 0; + u32 reg, chan_id; + u32 i; + + if (aml_chan->direction !=3D direction) { + dev_err(aml_dma->dma_device.dev, "direction not support\n"); + return NULL; + } + + switch (aml_chan->status) { + case DMA_IN_PROGRESS: + /* support multiple prep before pending */ + idx =3D aml_chan->sg_link_cnt; + + break; + case DMA_COMPLETE: + aml_chan->data_len =3D 0; + chan_id =3D aml_chan->chan_id; + reg =3D (direction =3D=3D DMA_DEV_TO_MEM) ? WCH_INT_MASK : RCH_INT_MASK; + regmap_update_bits(aml_dma->regmap, reg, BIT(chan_id), BIT(chan_id)); + + break; + default: + dev_err(aml_dma->dma_device.dev, "status error\n"); + return NULL; + } + + if (sg_len + idx > DMA_MAX_LINK) { + dev_err(aml_dma->dma_device.dev, + "maximum number of sg exceeded: %d > %d\n", + sg_len, DMA_MAX_LINK); + aml_chan->status =3D DMA_ERROR; + return NULL; + } + + aml_chan->status =3D DMA_IN_PROGRESS; + + for_each_sg(sgl, sg, sg_len, i) { + if (sg_dma_len(sg) > SG_MAX_LEN) { + dev_err(aml_dma->dma_device.dev, + "maximum bytes exceeded: %d > %d\n", + sg_dma_len(sg), SG_MAX_LEN); + aml_chan->status =3D DMA_ERROR; + return NULL; + } + sg_link =3D &aml_chan->sg_link[idx++]; + /* set dma address and len to sglink*/ + sg_link->address =3D sg->dma_address; + sg_link->ctl =3D FIELD_PREP(LINK_LEN, sg_dma_len(sg)); + + aml_chan->data_len +=3D sg_dma_len(sg); + } + aml_chan->sg_link_cnt =3D idx; + + return &aml_chan->desc; +} + +static int aml_dma_pause_chan(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + + regmap_update_bits(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, CFG_PAU= SE, CFG_PAUSE); + aml_chan->status =3D DMA_PAUSED; + + return 0; +} + +static int aml_dma_resume_chan(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + + regmap_update_bits(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, CFG_PAU= SE, 0); + aml_chan->status =3D DMA_IN_PROGRESS; + + return 0; +} + +static int aml_dma_terminate_all(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + int chan_id =3D aml_chan->chan_id; + + aml_dma_pause_chan(chan); + regmap_update_bits(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, CFG_CLE= AR, CFG_CLEAR); + + if (aml_chan->direction =3D=3D DMA_MEM_TO_DEV) + regmap_update_bits(aml_dma->regmap, RCH_INT_MASK, BIT(chan_id), BIT(chan= _id)); + else if (aml_chan->direction =3D=3D DMA_DEV_TO_MEM) + regmap_update_bits(aml_dma->regmap, WCH_INT_MASK, BIT(chan_id), BIT(chan= _id)); + + aml_chan->status =3D DMA_COMPLETE; + + return 0; +} + +static void aml_dma_enable_chan(struct dma_chan *chan) +{ + struct aml_dma_chan *aml_chan =3D to_aml_dma_chan(chan); + struct aml_dma_dev *aml_dma =3D aml_chan->aml_dma; + struct aml_dma_sg_link *sg_link; + int chan_id =3D aml_chan->chan_id; + int idx =3D aml_chan->sg_link_cnt - 1; + + /* the last sg set eoc flag */ + sg_link =3D &aml_chan->sg_link[idx]; + sg_link->ctl |=3D LINK_EOC; + dma_wmb(); + if (aml_chan->direction =3D=3D DMA_MEM_TO_DEV) { + regmap_write(aml_dma->regmap, aml_chan->reg_offs + RCH_ADDR, + aml_chan->sg_link_phys); + regmap_write(aml_dma->regmap, aml_chan->reg_offs + RCH_LEN, aml_chan->da= ta_len); + regmap_update_bits(aml_dma->regmap, RCH_INT_MASK, BIT(chan_id), 0); + /* for rch (tx) need set cfg 0 to trigger start */ + regmap_write(aml_dma->regmap, aml_chan->reg_offs + RCH_CFG, 0); + } else if (aml_chan->direction =3D=3D DMA_DEV_TO_MEM) { + regmap_write(aml_dma->regmap, aml_chan->reg_offs + WCH_ADDR, + aml_chan->sg_link_phys); + regmap_write(aml_dma->regmap, aml_chan->reg_offs + WCH_LEN, aml_chan->da= ta_len); + regmap_update_bits(aml_dma->regmap, WCH_INT_MASK, BIT(chan_id), 0); + } +} + +static irqreturn_t aml_dma_interrupt_handler(int irq, void *dev_id) +{ + struct aml_dma_dev *aml_dma =3D dev_id; + struct aml_dma_chan *aml_chan; + u32 done, eoc_done, err, err_l, end; + int i =3D 0; + + /* deal with rch normal complete and error */ + regmap_read(aml_dma->regmap, RCH_DONE, &done); + regmap_read(aml_dma->regmap, RCH_ERR, &err); + regmap_read(aml_dma->regmap, RCH_LEN_ERR, &err_l); + err =3D err | err_l; + + done =3D done | err; + + i =3D 0; + while (done) { + if (done & 1) { + aml_chan =3D aml_dma->aml_rch[i]; + regmap_write(aml_dma->regmap, CLEAR_RCH, BIT(aml_chan->chan_id)); + if (!aml_chan) { + dev_err(aml_dma->dma_device.dev, "idx %d rch not initialized\n", i); + continue; + } + aml_chan->status =3D (err & (1 << i)) ? DMA_ERROR : DMA_COMPLETE; + /* Make sure to use this for initialization */ + if (aml_chan->desc.cookie >=3D DMA_MIN_COOKIE) + dma_cookie_complete(&aml_chan->desc); + dmaengine_desc_get_callback_invoke(&aml_chan->desc, NULL); + } + i++; + done =3D done >> 1; + } + + /* deal with wch normal complete and error */ + regmap_read(aml_dma->regmap, DMA_BATCH_END, &end); + if (end) + regmap_write(aml_dma->regmap, CLEAR_W_BATCH, end); + + regmap_read(aml_dma->regmap, WCH_DONE, &done); + regmap_read(aml_dma->regmap, WCH_EOC_DONE, &eoc_done); + done =3D done | eoc_done; + + regmap_read(aml_dma->regmap, WCH_ERR, &err); + regmap_read(aml_dma->regmap, WDMA_RESP_ERR, &err_l); + err =3D err | err_l; + + done =3D done | err; + i =3D 0; + while (done) { + if (done & 1) { + aml_chan =3D aml_dma->aml_wch[i]; + regmap_write(aml_dma->regmap, CLEAR_WCH, BIT(aml_chan->chan_id)); + if (!aml_chan) { + dev_err(aml_dma->dma_device.dev, "idx %d wch not initialized\n", i); + continue; + } + aml_chan->status =3D (err & (1 << i)) ? DMA_ERROR : DMA_COMPLETE; + if (aml_chan->desc.cookie >=3D DMA_MIN_COOKIE) + dma_cookie_complete(&aml_chan->desc); + dmaengine_desc_get_callback_invoke(&aml_chan->desc, NULL); + } + i++; + done =3D done >> 1; + } + + return IRQ_HANDLED; +} + +static struct dma_chan *aml_of_dma_xlate(struct of_phandle_args *dma_spec,= struct of_dma *ofdma) +{ + struct aml_dma_dev *aml_dma =3D (struct aml_dma_dev *)ofdma->of_dma_data; + struct aml_dma_chan *aml_chan =3D NULL; + u32 type; + u32 phy_chan_id; + + if (dma_spec->args_count !=3D 2) + return NULL; + + type =3D dma_spec->args[0]; + phy_chan_id =3D dma_spec->args[1]; + + if (phy_chan_id >=3D MAX_CHAN_ID) + return NULL; + + if (type =3D=3D 0) { + aml_chan =3D aml_dma->aml_rch[phy_chan_id]; + if (!aml_chan) { + if (aml_dma->chan_used >=3D aml_dma->chan_nr) { + dev_err(aml_dma->dma_device.dev, "some dma clients err used\n"); + return NULL; + } + aml_chan =3D &aml_dma->aml_chans[aml_dma->chan_used]; + aml_dma->chan_used++; + aml_chan->direction =3D DMA_MEM_TO_DEV; + aml_chan->chan_id =3D phy_chan_id; + aml_chan->reg_offs =3D RCH_REG_BASE + 0x40 * aml_chan->chan_id; + aml_dma->aml_rch[phy_chan_id] =3D aml_chan; + } + } else if (type =3D=3D 1) { + aml_chan =3D aml_dma->aml_wch[phy_chan_id]; + if (!aml_chan) { + if (aml_dma->chan_used >=3D aml_dma->chan_nr) { + dev_err(aml_dma->dma_device.dev, "some dma clients err used\n"); + return NULL; + } + aml_chan =3D &aml_dma->aml_chans[aml_dma->chan_used]; + aml_dma->chan_used++; + aml_chan->direction =3D DMA_DEV_TO_MEM; + aml_chan->chan_id =3D phy_chan_id; + aml_chan->reg_offs =3D WCH_REG_BASE + 0x40 * aml_chan->chan_id; + aml_dma->aml_wch[phy_chan_id] =3D aml_chan; + } + } else { + dev_err(aml_dma->dma_device.dev, "type %d not supported\n", type); + return NULL; + } + + return dma_get_slave_channel(&aml_chan->chan); +} + +static int aml_dma_probe(struct platform_device *pdev) +{ + struct device_node *np =3D pdev->dev.of_node; + struct dma_device *dma_dev; + struct aml_dma_dev *aml_dma; + int ret, i, len; + u32 chan_nr; + + const struct regmap_config aml_regmap_config =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, + .max_register =3D 0x3000, + }; + + ret =3D of_property_read_u32(np, "dma-channels", &chan_nr); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to read dma-channels\n"); + + len =3D sizeof(*aml_dma) + sizeof(struct aml_dma_chan) * chan_nr; + aml_dma =3D devm_kzalloc(&pdev->dev, len, GFP_KERNEL); + if (!aml_dma) + return -ENOMEM; + + aml_dma->chan_nr =3D chan_nr; + + aml_dma->base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(aml_dma->base)) + return PTR_ERR(aml_dma->base); + + aml_dma->regmap =3D devm_regmap_init_mmio(&pdev->dev, aml_dma->base, + &aml_regmap_config); + if (IS_ERR_OR_NULL(aml_dma->regmap)) + return PTR_ERR(aml_dma->regmap); + + aml_dma->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(aml_dma->clk)) + return PTR_ERR(aml_dma->clk); + + aml_dma->irq =3D platform_get_irq(pdev, 0); + + aml_dma->pdev =3D pdev; + aml_dma->dma_device.dev =3D &pdev->dev; + + dma_dev =3D &aml_dma->dma_device; + INIT_LIST_HEAD(&dma_dev->channels); + + /* Initialize channel parameters */ + for (i =3D 0; i < chan_nr; i++) { + struct aml_dma_chan *aml_chan =3D &aml_dma->aml_chans[i]; + + aml_chan->aml_dma =3D aml_dma; + aml_chan->chan.device =3D &aml_dma->dma_device; + dma_cookie_init(&aml_chan->chan); + + /* Add the channel to aml_chan list */ + list_add_tail(&aml_chan->chan.device_node, + &aml_dma->dma_device.channels); + } + aml_dma->chan_used =3D 0; + + dma_set_max_seg_size(dma_dev->dev, SG_MAX_LEN); + + dma_cap_set(DMA_SLAVE, dma_dev->cap_mask); + dma_dev->device_alloc_chan_resources =3D aml_dma_alloc_chan_resources; + dma_dev->device_free_chan_resources =3D aml_dma_free_chan_resources; + dma_dev->device_tx_status =3D aml_dma_tx_status; + dma_dev->device_prep_slave_sg =3D aml_dma_prep_slave_sg; + + dma_dev->device_pause =3D aml_dma_pause_chan; + dma_dev->device_resume =3D aml_dma_resume_chan; + dma_dev->device_terminate_all =3D aml_dma_terminate_all; + dma_dev->device_issue_pending =3D aml_dma_enable_chan; + /* PIO 4 bytes and I2C 1 byte */ + dma_dev->dst_addr_widths =3D BIT(DMA_SLAVE_BUSWIDTH_4_BYTES | DMA_SLAVE_B= USWIDTH_1_BYTE); + dma_dev->directions =3D BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV); + dma_dev->residue_granularity =3D DMA_RESIDUE_GRANULARITY_BURST; + + ret =3D dmaenginem_async_device_register(dma_dev); + if (ret) + return ret; + + ret =3D of_dma_controller_register(np, aml_of_dma_xlate, aml_dma); + if (ret) + return ret; + + regmap_write(aml_dma->regmap, RCH_INT_MASK, 0xffffffff); + regmap_write(aml_dma->regmap, WCH_INT_MASK, 0xffffffff); + + ret =3D devm_request_irq(&pdev->dev, aml_dma->irq, aml_dma_interrupt_hand= ler, + IRQF_SHARED, dev_name(&pdev->dev), aml_dma); + if (ret) + return ret; + + dev_info(aml_dma->dma_device.dev, "initialized\n"); + + return 0; +} + +static const struct of_device_id aml_dma_ids[] =3D { + { .compatible =3D "amlogic,general-dma", }, + {}, +}; +MODULE_DEVICE_TABLE(of, aml_dma_ids); + +static struct platform_driver aml_dma_driver =3D { + .probe =3D aml_dma_probe, + .driver =3D { + .name =3D "aml-dma", + .of_match_table =3D aml_dma_ids, + }, +}; + +module_platform_driver(aml_dma_driver); + +MODULE_DESCRIPTION("GENERAL DMA driver for Amlogic"); +MODULE_AUTHOR("Xianwei Zhao "); +MODULE_ALIAS("platform:aml-dma"); +MODULE_LICENSE("GPL"); --=20 2.52.0 From nobody Sun Feb 8 00:26:55 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2334348458; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872202; cv=none; b=JEvO5rJjJkUVJf//ONIPHT+E6Ko4QTi3p+AwiQTEuahIIDBugxMzP+66eUxfh0wb+nQiHKMMdE/m9cx1xRCFdQVoHVSeynrTaLpijYkaItfTWT5p5oJzCINHryCCxL8bh74QbEmmLRer5/kRUsIzXFzPw8Zs2LXbVZO7FLUz6FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765872202; c=relaxed/simple; bh=uqORFx2rOlGaU1rPovioax/w0dRcQGqNILNOAxN6eUo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IPkyfeYAYSyM943Cw/658XDL8DT1HJm5WRH1lFrdWDkX+jFOiTznNqIixFOyb9hgvsYtJkp4ixuA+vHwG4+gGb1ASR4F66ZWt5Zkulwcs6TGr7JKPZjgjOXM2vSvF/eZqsmu7ks43LLr8vFnlsR8OD0AH49oJQZ0k5VSkYJLWfA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CnPf5Gv+; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CnPf5Gv+" Received: by smtp.kernel.org (Postfix) with ESMTPS id B3C80C2BCB0; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765872201; bh=uqORFx2rOlGaU1rPovioax/w0dRcQGqNILNOAxN6eUo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=CnPf5Gv+/gj4b4XzQiZWd7V26J+0IAtigmCzuuxhwCvZPthj9k75Uxrtyzq0eEwUw XBX3uILfiNA/kuLhisga6pQjwFzwm/QU7OF8P6B4RjNOmYrkDFTspUW7NnLVbVL0vI sL9NsIhrkrjlWwa8/lbqVwu7eM/saKGSIy7C7iQULoNPNq9J2rS+BfDG/aiL2PMJT0 AIRnQGrB3leg7OngwF8WnDJWhMG1ljGSDq/afM7lGZfXRifO8Rl2g0eYk3RouPBgIu hsr20YdbAhGlA2rZc3JtPX9VsOqWmG4JSeAfnfcmw23LxrWRH94jusTWaPe1csL195 GYJp2m9jvG0rQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972FCD5C0D0; Tue, 16 Dec 2025 08:03:21 +0000 (UTC) From: Xianwei Zhao via B4 Relay Date: Tue, 16 Dec 2025 08:03:19 +0000 Subject: [PATCH 3/3] MAINTAINERS: Add an entry for Amlogic DMA driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-amlogic-dma-v1-3-e289e57e96a7@amlogic.com> References: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> In-Reply-To: <20251216-amlogic-dma-v1-0-e289e57e96a7@amlogic.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kees Cook , "Gustavo A. R. Silva" Cc: linux-amlogic@lists.infradead.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Xianwei Zhao X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765872198; l=796; i=xianwei.zhao@amlogic.com; s=20251216; h=from:subject:message-id; bh=gtytR4NUYl71zEdxW3qz6sET8405pfbFKpANdMYABG8=; b=3oYzCundtIihsisvn6/mvf0uZASrPiKzqf4iJ4R33WfBYEDEpv0qPCL4lp4j5YJqYcBLpJwRO vUiH197Ico/A61qhC0l2iPk6K5PaFf0MWw7Dqp7P7dGDNYtKTbNnkDh X-Developer-Key: i=xianwei.zhao@amlogic.com; a=ed25519; pk=dWwxtWCxC6FHRurOmxEtr34SuBYU+WJowV/ZmRJ7H+k= X-Endpoint-Received: by B4 Relay for xianwei.zhao@amlogic.com/20251216 with auth_id=578 X-Original-From: Xianwei Zhao Reply-To: xianwei.zhao@amlogic.com From: Xianwei Zhao Add Amlogic DMA controller entry to MAINTAINERS to clarify the maintainers. Signed-off-by: Xianwei Zhao --- MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b11839cba9d..f522a34c780c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1305,6 +1305,13 @@ F: Documentation/devicetree/bindings/perf/amlogic,g1= 2-ddr-pmu.yaml F: drivers/perf/amlogic/ F: include/soc/amlogic/ =20 +AMLOGIC DMA DRIVER +M: Xianwei Zhao +L: linux-amlogic@lists.infradead.org +S: Maintained +F: Documentation/devicetree/bindings/dma/amlogic,general-dma.yaml +F: drivers/dma/amlogic-dma.c + AMLOGIC ISP DRIVER M: Keke Li L: linux-media@vger.kernel.org --=20 2.52.0