From nobody Thu Dec 18 15:04:13 2025 Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com [209.85.217.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27BF729CE1 for ; Wed, 17 Dec 2025 00:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765932748; cv=none; b=UudNGHvz98LjkIOQ3O2h9Rhy4irwZizHAx4+GJvepLnY4bWc40tIfUxp/llpapuGtISiXuE/s5g9/66cEh4RBtbFRt8+KX4A4w2BULXH0CXHdEDzRjKRhjUPu4k09+M0odfLB51f9OHJb3K6BpXQR6+3tipYvNMkwLz4AZnoSWs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765932748; c=relaxed/simple; bh=OIBwUGMzURsVxHuDAfM9+cndMbjXayjCoeLJwgkHp1Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mLqJpqkiUZr2Zn/RaMEvI0I5QNHGo6NBy/KwQdd8Y+uTmCFigQI3woHoev9P8Qk/vtnF9O1E/7p2wAv3TsISJeGauZ6DsO1MiJHQsDVD3N2KPabiVtNXkr51SfzWWXsTNNP410/AqZJaDwgWmz3+4D6ha4PogKbIJoIvZUUOzXY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WjSBQDiS; arc=none smtp.client-ip=209.85.217.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WjSBQDiS" Received: by mail-vs1-f48.google.com with SMTP id ada2fe7eead31-5dbd1421182so4484130137.1 for ; Tue, 16 Dec 2025 16:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765932746; x=1766537546; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=31v0OvoF82nBFlvwEabpAGVFX3z/UuM7c1Cky+CLtVI=; b=WjSBQDiSgshAJ382WE6+NQ4uKnHyy86FVyEeMLKQJavgu2ry/FVb3U4neE/hECNS01 oh9TglLwy/iGUL5tPfJ9QCUPr2jqaIGg2XhcxW92+H2HqHUEmRgm99o3aX5i0FBFGYaK s2IMLVHXkf0sLh+QEV7nIIFrsI1CXnqnSpKWj4bXr8kRwXJLrK6yZoB1nR2WOTTSovx5 62Pnhxihl5zsZAJiuVIlp+d+q9UbWyUY/N/DKVZUKHgS/nWZYES8b75xsZTptSEkGHAu NFH8nLctyezjXraKA2aqSzed7fg7o2RyQ621h/GeVzrhdqtzqvojGOOeH3Na4xjCD1mw 9PbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765932746; x=1766537546; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=31v0OvoF82nBFlvwEabpAGVFX3z/UuM7c1Cky+CLtVI=; b=cuvGyLFeBeQcxlyhLJViIqRPRhU6gaDEnIeGIT7N3NZDzQItFSxLb7BwDP3B0TdQAg SU7Ik0SmAF9Jsba03fnJrJ+8hOBSe5GgJ1szetRwrGtJdyZ5xpungHcT1IW3Ccj1NmoE v+ktAMvnx12m8NvVzBh+GB7SW9tPG2YRtAeBeNBfnvsZjq0nCLjYZZSWl1TnLeH2SeU9 CphfOvouLbhevo2+YBtQi9PObKs0RxwUea49Na6OP3RC908/Pw4dq84eTqfhOVpKVXVt nkGbUtAIutxocdbwbcxRYn8xFWB0OsEWjT8vj91LDYdLumshiiVfJ7553PAO3oGB03x6 kfpQ== X-Forwarded-Encrypted: i=1; AJvYcCV4FrVuFzqV/pH+gKm77S8f5LuBuJgC2KizSj6g/Ngkr6H3GnOz4DE2dOtDGO4CzdlYYUv/dEU+8D7nsM4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx49bYNZ9PZwV6QiFsRAXobomPX1TGoNaUB0jCSJ0wxe/81NtL7 ARZwFq0RCu7VtiQKFmFCYZv+sp+dNxe5j7r11VX09+Sge9Lt7xGejCsYOlKYEg== X-Gm-Gg: AY/fxX5xhPab/lsu7s/t2WnZtDNe21bnIb8nxlvnHJACuWF3GqTTCbQjzBkXEySjxgA PyLGybpCVED13iEUyx9lPfGDed6JhjyHDFcnX7DKAVuJ2jv+ButPxx5eXxMjqgPYoKrb0gH4lyq 6oLvbDgl62PTd8I/9NaxItifmGlCsldU8+OqAUgt72QxZfni9QHHn5FeE7zqSNCDNYHzEDyJewF s1rmpIM2X3HWUqdIG0I/kyFdB39sm0wXHXcdDusXOMU5F836jxUnx2JlBLx6Oz9H+Z8FDxrz3+k cUtHZzWp7B724uHWKGkl4ZFA0/ugZFk08oLWH7NdGLhoTIDyVKmDcqLfZo4Uh4ZyXSgmsfIDQUn BHu7qf5FLhmt+lMt6JekkVn1P5ZmVpwwsioqP/okEYpE6T0uxrX1MMquoOiuWyjVuuyq0lz+5DY wM5qxrbeVX09VxVA== X-Google-Smtp-Source: AGHT+IEt434s6X2fF9D6aiTtzTp5M5N4ionDEdscyhDZReNu8ZOA8m8/JpzjWnCf0O1Iw1FiQk+H7g== X-Received: by 2002:a05:6102:3711:b0:5db:9ab3:4291 with SMTP id ada2fe7eead31-5e827836d49mr6481794137.33.1765932746056; Tue, 16 Dec 2025 16:52:26 -0800 (PST) Received: from [192.168.100.70] ([2800:bf0:82:11a2:c6ad:1d0e:15de:a612]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-5eaef3999a5sm190289137.0.2025.12.16.16.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 16:52:25 -0800 (PST) From: Kurt Borja Date: Tue, 16 Dec 2025 19:52:01 -0500 Subject: [PATCH] iio: adc: ti-ads1018: Drop iio_device_claim_buffer_mode() call Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251216-ads1018-patch-v1-1-cf41d193e187@gmail.com> X-B4-Tracking: v=1; b=H4sIALD+QWkC/x3MPQqAMAxA4auUzBaS+IN4FXEoGm2WWloRQXp3i +M3vPdClqSSYTIvJLk16xkqqDGwehcOsbpVAyP3xDRYt2VCGm101+qrkNuRBR12UJuYZNfn/81 LKR8PVlCcXwAAAA== X-Change-ID: 20251216-ads1018-patch-ad02382e0a04 To: Jonathan Cameron Cc: David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kurt Borja X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1504; i=kuurtb@gmail.com; h=from:subject:message-id; bh=OIBwUGMzURsVxHuDAfM9+cndMbjXayjCoeLJwgkHp1Y=; b=owGbwMvMwCUmluBs8WX+lTTG02pJDJmO/3b3RTRLrFvB/n7v9L5ltk2aRVsXVts2un0P3CGTY 7d1CSt3RykLgxgXg6yYIkt7wqJvj6Ly3vodCL0PM4eVCWQIAxenAEzkRQTD/+I55+be/85ZnHNo b6uDjMj/T5dsQq0W3q2ve9nsZeCpfZHhf07Cidp9PfM3bpZbNltxutSbts8nfbymLllTenRzctj GZn4A X-Developer-Key: i=kuurtb@gmail.com; a=openpgp; fpr=54D3BE170AEF777983C3C63B57E3B6585920A69A Drop iio_device_claim_buffer_mode() call in ads1018_trigger_handler() as it's not actually protecting anything. Signed-off-by: Kurt Borja --- drivers/iio/adc/ti-ads1018.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1018.c b/drivers/iio/adc/ti-ads1018.c index af08702b62d2..b34184f68e63 100644 --- a/drivers/iio/adc/ti-ads1018.c +++ b/drivers/iio/adc/ti-ads1018.c @@ -557,9 +557,6 @@ static irqreturn_t ads1018_trigger_handler(int irq, voi= d *p) } scan =3D {}; int ret; =20 - if (iio_device_claim_buffer_mode(indio_dev)) - goto out_notify_done; - if (iio_trigger_using_own(indio_dev)) { disable_irq(ads1018->drdy_irq); ret =3D ads1018_spi_read_exclusive(ads1018, &scan.conv, true); @@ -568,14 +565,11 @@ static irqreturn_t ads1018_trigger_handler(int irq, v= oid *p) ret =3D spi_read(ads1018->spi, ads1018->rx_buf, sizeof(ads1018->rx_buf)); scan.conv =3D ads1018->rx_buf[0]; } - if (ret) - goto out_release_buffer; =20 - iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), pf->timestamp= ); + if (!ret) + iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), + pf->timestamp); =20 -out_release_buffer: - iio_device_release_buffer_mode(indio_dev); -out_notify_done: iio_trigger_notify_done(indio_dev->trig); =20 return IRQ_HANDLED; --- base-commit: a7b10f0963c651a6406d958a5f64b9c5594f84da change-id: 20251216-ads1018-patch-ad02382e0a04 --=20 ~ Kurt