From nobody Thu Dec 18 06:16:20 2025 Received: from CWXP265CU010.outbound.protection.outlook.com (mail-ukwestazon11022129.outbound.protection.outlook.com [52.101.101.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA88D2E7179 for ; Mon, 15 Dec 2025 23:03:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.101.129 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765839800; cv=fail; b=JL+m9tm6zA8BrCj/FgH9HJ7HyUmdwqaOC1GvBlEGvHtHSdWnUybiYS6t5WoLSQhpqg+QvpHuyIZadk79WlfNRbHexaJldD4mp35GYU/xJykQ9UdlmAKN/dJplB/Yu5Xnc031YoJ6aaAGneKriC0eEJqUu27QmaTz5eVy7xAbRaw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765839800; c=relaxed/simple; bh=ZuXeCOJ42/hxVLhNwm9UnPetuv0DLGA2xSrc1BZCijM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=oOWcosqK8z3SFguqK1GsX9Jrl8WphKVbZDVsk/uQL/T7ZX6TEycZ82+NrSKs25ci0Xl65ffCFNDATvRzXRsIRZG/LO7AuyrAIcUxG207OwWHL12+ch0jb9IONJjtriz3ZR7HR3Qrmhw+rKssJ2hF0x26WKb7elHybC92jx+ZZcU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com; spf=pass smtp.mailfrom=atomlin.com; arc=fail smtp.client-ip=52.101.101.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atomlin.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M9STUNHbawE8rY2PU41nU2bL1aBnoYDTXV2G5dq5MpO/9etYSbdcSptYVOluEzY5yWreDsN20TOS4z2wCQ/62Sc42PTniDCipEENL/Qinvg/+4DANs2Df/3mAvaZm98gDs4bwqkawfqAblcCFjKrHdeH+rT7/rklgiEsxwBFIJlpKYUsv2Lhe+qnOVTHRQHA0VdYJNSnZgZg8+/nrCKFg4djuqP4VT+J2SkuWSSc6zxb67QQiuWbnCqpefjryzE8p56zR+6AfM/VR4RhkRLxtnNaP6jRVmmz2znWVovwtnHbHlOmP5U1W+CG7amiFQrRdC9Qjqb4ri6uG3spXugfrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Pyz6fyVGVYC1f6yfvl2+opqbPF6e8dX7Nhdc0VwJt4=; b=KT3izYssFFEVUsV1E2kpnghl1k3gbWRrfnDr8OKH6DTrSBB5r8nWhPVTznRc2ATK7mITxcYqpMwQ+MbT8UcADv3ZZYnEQ1LVfQXzkJwT053zWptH1MQbalcRh1ne6SkiUKX9yY1zypn+/btwWO4aGumLppIDA4dXC5eH89RZM3Ki1U7KyyovFpHnzEdxrbYcuWyn2LwrkbG0fQ1h3AxeWfZysZJe0EOBnBQkvLCWn1xfxc7E7g5yVzTwiQ8a7mTbXoIwS7nFA5DX6UuIjPWgNisjwKlpsoh0QpNfwsLyp6C7aDIwb68lvbZCDC1F/6xhSwN4H03usenidX7QSkeAOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atomlin.com; dmarc=pass action=none header.from=atomlin.com; dkim=pass header.d=atomlin.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=atomlin.com; Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) by LO0P123MB6333.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:288::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Mon, 15 Dec 2025 23:03:12 +0000 Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf]) by CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf%5]) with mapi id 15.20.9412.011; Mon, 15 Dec 2025 23:03:12 +0000 From: Aaron Tomlin To: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: dave.martin@arm.com, atomlin@atomlin.com, sean@ashe.io, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] fs/resctrl: Return -EINVAL for a missing seq_show implementation Date: Mon, 15 Dec 2025 18:02:56 -0500 Message-ID: <20251215230257.1798865-3-atomlin@atomlin.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251215230257.1798865-1-atomlin@atomlin.com> References: <20251215230257.1798865-1-atomlin@atomlin.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN1PR10CA0014.namprd10.prod.outlook.com (2603:10b6:408:e0::19) To CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB3523:EE_|LO0P123MB6333:EE_ X-MS-Office365-Filtering-Correlation-Id: e5fef6eb-77be-40c5-b66e-08de3c2e1eec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?6j2dJH+jWc65TusorbpTb6REJ9b1Wv/wLsr3vqdUwC3Adv1SeWbcvemCNbBP?= =?us-ascii?Q?feq+gawa+67/w+Rvk9x8qG1/SdsW9Pcv8aifz3qh4hSlrzWi5rxNf0KANDDr?= =?us-ascii?Q?gzJoTs3svd2NPbSzG1rxwfRLcGzjs/UuOgBvUdLLnvOKuJHQxlGgvCw76Pmi?= =?us-ascii?Q?jauxvbqRYxsIzJq1YGd23+ml1q0LFepDSPRF9nU47HDM5CeEAsdivSRWEBfw?= =?us-ascii?Q?YTppZb9lWHFcAJlB0d+z5jYvlhqHVVcxw73z/j92yRj+oXFF6ld1Poc7JGio?= =?us-ascii?Q?Ic26qNlVOUtTOLGyR7znnfwic2WqEyV58M/DiW1KmRRlv9AhiQGQY08YeLSm?= =?us-ascii?Q?inOV7DeAxxecXVuCccewggHhg7ztx7rs7GI7ikUXMXIdLF8xdBhhTWX9c24E?= =?us-ascii?Q?iK9up3+D+mU94IHywZu8VIKHatQAKHs5xGtI/SMZiRxnIs1A4W7EuyrJlUKA?= =?us-ascii?Q?Jc4LMdf5k5LA2eoDFOMENo8bVFUhNsluWD8PvcdJ7N5sz5VlnXY6N56MtbaT?= =?us-ascii?Q?34z2QEduj43ADTLthLEoLbEvu0BsW/Jg/8/LDRT4ULzCGkAkC1vKMv2CNHwy?= =?us-ascii?Q?2750F+RbImGMXyb/cvi2PGaHzncsfmQbsGgOeNy5NFLffoRrEP0PLDOuXolg?= =?us-ascii?Q?J98ZatS0eXUEyD+zJl8pGCBtsq/WsHnsqNGxQYZVxGjGAk2QNwzF7YK3r4Q1?= =?us-ascii?Q?0yX4WmC5OZaOdbiq9notre8GTLM7s/dzGjwH+aJZTj+uzgybTDhxsqijvuPI?= =?us-ascii?Q?pWg9ND6LiNHZ3c8uqz1FWKDIihMk2NMMK7CuuqMi8lhcwR6Kws4PMIE2yvA8?= =?us-ascii?Q?uAbKFofYwjNyMG/rmYSfi74FLCPDCTQ6X3ACtcjo9ThGYaBTuXQiom7g6Zqz?= =?us-ascii?Q?QkYE6vHF2Du88R8x6MdikXSPiyCt1tuTdCeqc3VgzJ7lAzX5S4Eu+n1Xv0/b?= =?us-ascii?Q?UyH/7Gp547rKbxv7nlmBoAzwCqzFcQ1+5GhQ0TheoKRjF3jqCO0mox0/4d1j?= =?us-ascii?Q?Y73gFOkYtDvdveeFcyuyDHhM+/bFWsw91w7QMbDCLie5bAIyLNnN0QKdcA+n?= =?us-ascii?Q?WGJWUC8K50kvVdDAjrvmT/tzvaDHE+f5F7mLweS71Sgfp0jFyXkLBHmd0bL+?= =?us-ascii?Q?WBsWWiYOTEhSTZpZWcpr3f8DsslcYTLpv5zuelsICHl92R0v2Y1byy6q/VfS?= =?us-ascii?Q?yNpsqn4fgozTgv/VjdoCXucCGvOn8TQJ2LI76CgCIIt/GA9TgEGVQO6RKqVt?= =?us-ascii?Q?pvXccRJ5ZkIurqVrEcFwVCKacXkFExWuD7K7P4nd3aQiCI7bbKWdOuVsozxp?= =?us-ascii?Q?+WE6Z2aIqgkPXHhF1mntNBBM0xw88AsnrWr+iaSpGGEQH2Ncx1Re4csIsd58?= =?us-ascii?Q?ke9KFOU4Z6xjY1v+4CAlnDx0jec4MbcmtGrc6UTXvR9cWQnKV0svPaex23pU?= =?us-ascii?Q?AuZWlJsDJP4me33y+7CLe9mLyTumT9L1?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oR8hedxctMudwOYMpp9eXX2e/x5OlYjS34FZSRfNvo5796X7P467T9vjJaYn?= =?us-ascii?Q?yRYwyi2TWxsfC1LIbzFFeykq8LkBlP3TLVFbsgjKZ2VWJB4CnN59NHpzRWp+?= =?us-ascii?Q?8h3HYxOS49D2ni5YG+YvlX/SgpOLSEMzL3Q8xpxP8OCs9+wbZKajj3s8IzJt?= =?us-ascii?Q?4aH3VVbljXQXKmI5GBb081UfVUBYzBvqgH6aja7YQFdQZo5dT7WbspEOjX+x?= =?us-ascii?Q?fUGAD7F2tVUehFFP7owBYLgD6Uy4WY/OuCLUr93WsLck718MpHzy0ulR1WxZ?= =?us-ascii?Q?nr03RhDT9FCoLyZsmbRWaka/4n+LbxrDKE8UpbYU/61ulWQCNvRqzcCmJnXd?= =?us-ascii?Q?dSrr48lO8H7Z4OfcHBvWRlGuHiSwOdQIywldsvLdsdWburnAeqXO/eb29MIM?= =?us-ascii?Q?vgCTN1111cUyqp+UOq2VdQDUig8Fq9sQH5LvdPO6XH/GKtjc8OfjH0ynZz03?= =?us-ascii?Q?vGM9G+/lVvonWU+/hexvCCQWceOZwRxmkcy4Tg91Dy3xtV1Nv0kGhMrfzfo4?= =?us-ascii?Q?0HTPu+cIaPAND9GKHwNuIh2YDXjBUmIZmS+giP066o+XvxYy7G+o4h9VmMZd?= =?us-ascii?Q?Z4HusGO9t+rGNFNiCcuO7gCBqn9YYgwUrCON7C2cmvhVIJuO+4q4BggVFxhH?= =?us-ascii?Q?2rLzwSgeb9EZTYCDcFTzmXhghBECleatOsQYVtkb6R8VaeRG+keMPTGBeYW0?= =?us-ascii?Q?B5V0BMnnVteoKdTZxnpHtVFavGWs2qZh8ruNrJCdfWIgQTWkeedrrGWn2wpY?= =?us-ascii?Q?uHx0vq6ZWXbMQsoIaImQPqefl6vYzpCfPqZ6PWA+0R/hFZQfwHvmTBY/hskz?= =?us-ascii?Q?tV4eHTDHYySOfVG7++ZfZQjBcLRetgvklcARoda2MSaCTqgFE7NwXpk4rPar?= =?us-ascii?Q?2gifxj/niGiaYoFh2Q5RKuQdwcYnOkCgtpegHBnGgbzGZK1NMG4d7lObDo95?= =?us-ascii?Q?lbl6gygLjmjuqDIzApqIDzh2cySCQyrzaU/oTsI6MLs1o3JjafNmMG5Ou7cw?= =?us-ascii?Q?rhX2fB14WPjcpV5CPrOKlcNDlRJPrECwgCS004MobN3UoyfN3c4T/wdA6B05?= =?us-ascii?Q?nf/lzd/v/Y8u+sH91RGnotL3yRhMzpVWetfehOKvAphHQqEZNh8HJn0sQXQn?= =?us-ascii?Q?y3admWvpDikZepi6IIMHF3yLw/MEWQdhAEGdc5PnXsobXIX8IR0Xd5FtV3Rq?= =?us-ascii?Q?jD8z9exqTGgsAlYzE33iYGKefqjq+I3xGYWYi+4LoC15taiXTZUnvYGFOsI2?= =?us-ascii?Q?973T5QunqbVaVv1rpjUtqIi9wbsMUbv+77tlIdwO1PoAFcXlQ6P8jxHXhz84?= =?us-ascii?Q?EdjfTdxsOM++FfQ+HXLW1RfLyUUo3TGDf/Jbh4sTdHfE7B25FSstfEWclJUW?= =?us-ascii?Q?SNkI/kMDSgSY0lQ3ROjJT0IWh2mao3ctnMLz63dSt9AwXOH6tXNsq60tgHtj?= =?us-ascii?Q?DuHN1ZwtAfgZ6Wy48avkuF/rC128ia8VteA4Zk8sTVQO/xN8cZUXnCbeLVWw?= =?us-ascii?Q?OTZmEhSEC3XRhkmkN4NPs6vjxCq8qu/iRxG2McN0YFi47iku2jaZdp0nl38o?= =?us-ascii?Q?xFdxaunNl8fJIkJbzQqlOVGVSfutJDpgMYfzANsV?= X-OriginatorOrg: atomlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5fef6eb-77be-40c5-b66e-08de3c2e1eec X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2025 23:03:12.3563 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e6a32402-7d7b-4830-9a2b-76945bbbcb57 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ANyFTa2CftFVBErIzQ5S2q9HHKwgTslhKtX7+njq13TQqD3sdVvPoD+gHPNBILhdf9/MD91vRKqy9UQEBCEmVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P123MB6333 Content-Type: text/plain; charset="utf-8" The rdtgroup_seqfile_show() function, which is the sequence file handler for reading data from resctrl files, previously returned 0 (success) if the file's associated rftype did not define a .seq_show implementation. This behavior is incorrect and confusing, as a read operation that does not define a display function should be treated as an error. This patch change the function to return -EINVAL if the file type handler (i.e., rft->seq_show) is NULL, providing proper feedback that the operation is invalid for that file. Signed-off-by: Aaron Tomlin --- fs/resctrl/rdtgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index 8e39dfda56bc..e1dc63b2218f 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -314,7 +314,8 @@ static int rdtgroup_seqfile_show(struct seq_file *m, vo= id *arg) =20 if (rft->seq_show) return rft->seq_show(of, m, arg); - return 0; + + return -EINVAL; } =20 static ssize_t rdtgroup_file_write(struct kernfs_open_file *of, char *buf, --=20 2.51.0