From nobody Sun Feb 8 15:58:00 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1D1532B998 for ; Mon, 15 Dec 2025 19:08:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765825708; cv=none; b=rJKSgSdX9Utv2toAbnjIpsj4yivHVdQu/SWhn19Ozg4MagDh6SEyCB21REd5Jswz7L1DzdUOvCpIfGsVpG0mZU6m8E36k8UHoddRYFVMPhh1T3jZ1C347PizHpy5KI0ueaO5yKIg8jZsS8nZJnYICDRyJFhO2O36Amw+KJdwUiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765825708; c=relaxed/simple; bh=8Ywqlv27SE1AVx+U7diS5Q+GgCHCjgIT5HGMYTgOf08=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mRkEX7vPvvQfLO/f0Gl/ZcX4QoLe3dGj9nKS/6fWzTt0+9BBKgAmK7w3cbjf40T+Z75Ykq0XXtgtVpM5m8IxIHBkSF0dS4MML8k5pRJWyKGxDSRzxM080a1XP0t6MZ6VJKVzz12X/QW1RJ2/prQDbDr5spo+a4Iyz7G7E4OBLbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y/WXt8io; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y/WXt8io" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-34c84ec3b6eso1686491a91.3 for ; Mon, 15 Dec 2025 11:08:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765825704; x=1766430504; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L/Vlev60lRDarHuqvumMkRznWDtRoDHrSo51IVlDT98=; b=Y/WXt8ioVNTyKF1ll/xPgecSkFCAnqEenf+bEpASfbpbdBMsJYwMiiza6N6AU5yiU/ c2iI1cme23zklZZEULZYTmyCwuhhJF1nbWB1SAllr9hYCFId2SXrPNNWZcmuy0dDdYet iZwZwJWrzt6q0waHz7aqporGTPjgFtmGVNDM7UiE6i5mV3bg/610aS8k6iiZ857jEGhH eoWCvhD9RqqknDnPe29AZuDKw+0nImA4LS7rlwn5Gm5s9lOgh7kEHb/wQG9KUYErFMhk M1V9/I4esJ+NxSII3r5q6MbwoQ/iFy+STfEumbEUNGE3F33Z2Bzw++KHhzhGmlpB3Ka+ 6hiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765825704; x=1766430504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=L/Vlev60lRDarHuqvumMkRznWDtRoDHrSo51IVlDT98=; b=q2KCjubecKXZfWy5Hqe7B5b7W6Jk2Xv7txRBGfHdUzK5rVfI0rfZBYH52kMRC1rK2G UID0vpt7Jl5W0zfu8YMv/5VrUjD2rRuudbaiqANGq8cxRuFbyRV5YKotGhpSHaJ6ApWn 0yZbZu4kg6fnfqTdLQWoKnSaoKI7Ahq/E6N3SC0A4IAoITCOwJa15ygZ0K7ABnh4W39H LGrkdaou2nShCQxc89Ityf0ePlA77+4Y3sE4ugA4RIFFtZ+Pg1tMIN13bOSV4Jfh5nr6 XKFPn67hgocoAHtEKMqkMtmrh67wRpkoMVVJZOXzSgIwb2FLzwxp2317bf7mxAd0Jd/1 SjgA== X-Forwarded-Encrypted: i=1; AJvYcCUv2fxWEgsrygGx4ervpcb7kF/ZxctKX90ozci67+RiTfO1L4wKDu8OnF1XOTt/jwOXCo/a6UF8cUld5kQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz96UZanzyzWQQnX71qeiFkXQs4oZvxlu8E4mixblSPW5iSP4FH ntvByoX5ARQ4RA9PO6g6a2M6wH2OBiJx54lcxT99PCVIJ/+AdTiGjUHd X-Gm-Gg: AY/fxX7vubW/juq0bmiWV1FjGY/ZDnnfdpmYdL6yOVEz6OR+eQBBInUfR+LxZGrTqqC ArAKp6wUNfjxqAC/sf/Tr/CrLSf2CNX5JmstEh/WpjVNTcDBb0wtaPBpxRxS5Xt2Ad8xyLU/pT2 eVTcaV1oL8djtKbw+BIS4lurL3F9zHiv5SzzZlXgzP7WVmICTfW4IaeptBKqX20dfWIAMK/7drH HcknUTTwlrT9/eU2nUt2Iin38YlVubSB6mFGW32J4571SkMehpUsnmoQTy/DGoI4LiO0jS4CY8D On+iZqmNNTKEm5Y+1Fy6DbTrvI3QyN+lEVmcEJtXuvljgZjPFhTzOSGk2bt/Git3UO+kNTG4AlJ mCiypMkjZS+f8Go3Zik+SD95S6AaiW779KJdvDp+OEH+XWWHlc03UR4AEP7t7KjxIXSVt9OwEBB c40ja71WW3g7a8HD8vAh6QlPPaA/TLI+ZjA6TFLRzWvzKC5qTwUoMJLMjm9eSjsgrSxX6XbrAyz 2fg5w0ytwUCVRZof/wu5Q4+K90ACP8MSyzZbMweaLxUN+UgC9+a3SwGj3EEg3EpqUD4+nml X-Google-Smtp-Source: AGHT+IHBF5A4JZB5+K4+/QTT0muHdjH1nsLZLkU3qoa/JQPWQRtUpiTd6RkM6KZvMTbmdqoKOdRXeg== X-Received: by 2002:a17:90a:d884:b0:34c:9cf7:60a0 with SMTP id 98e67ed59e1d1-34c9cf7620bmr2870747a91.5.1765825704418; Mon, 15 Dec 2025 11:08:24 -0800 (PST) Received: from Lewboski.localdomain ([181.191.143.42]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe2948d1sm9958875a91.9.2025.12.15.11.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 11:08:24 -0800 (PST) From: Tomas Borquez To: Jonathan Cameron , Greg Kroah-Hartman , Lars-Peter Clausen , Michael Hennerich Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, Tomas Borquez Subject: [PATCH 2/5] staging: iio: ad9832: convert to guard(mutex) Date: Mon, 15 Dec 2025 16:08:03 -0300 Message-ID: <20251215190806.11003-3-tomasborquez13@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251215190806.11003-1-tomasborquez13@gmail.com> References: <20251215190806.11003-1-tomasborquez13@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use guard(mutex) for cleaner lock handling and simpler error paths. Signed-off-by: Tomas Borquez --- drivers/staging/iio/frequency/ad9832.c | 28 +++++++++++--------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/f= requency/ad9832.c index 00813dab7c..f9ef3aede4 100644 --- a/drivers/staging/iio/frequency/ad9832.c +++ b/drivers/staging/iio/frequency/ad9832.c @@ -9,6 +9,7 @@ =20 #include #include +#include #include #include #include @@ -180,9 +182,9 @@ static ssize_t ad9832_write(struct device *dev, struct = device_attribute *attr, =20 ret =3D kstrtoul(buf, 10, &val); if (ret) - goto error_ret; + return ret; =20 - mutex_lock(&st->lock); + guard(mutex)(&st->lock); switch ((u32)this_attr->address) { case AD9832_FREQ0HM: case AD9832_FREQ1HM: @@ -203,22 +205,18 @@ static ssize_t ad9832_write(struct device *dev, struc= t device_attribute *attr, ret =3D spi_sync(st->spi, &st->msg); break; case AD9832_FREQ_SYM: - if (val =3D=3D 1 || val =3D=3D 0) { - st->ctrl_fp &=3D ~AD9832_FREQ; - st->ctrl_fp |=3D FIELD_PREP(AD9832_FREQ, val ? 1 : 0); - } else { - ret =3D -EINVAL; - break; - } + if (val !=3D 1 && val !=3D 0) + return -EINVAL; + + st->ctrl_fp &=3D ~AD9832_FREQ; + st->ctrl_fp |=3D FIELD_PREP(AD9832_FREQ, val ? 1 : 0); st->data =3D cpu_to_be16(FIELD_PREP(AD9832_CMD_MSK, AD9832_CMD_FPSELECT)= | st->ctrl_fp); ret =3D spi_sync(st->spi, &st->msg); break; case AD9832_PHASE_SYM: - if (val > 3) { - ret =3D -EINVAL; - break; - } + if (val > 3) + return -EINVAL; =20 st->ctrl_fp &=3D ~AD9832_PHASE_MASK; st->ctrl_fp |=3D FIELD_PREP(AD9832_PHASE_MASK, val); @@ -238,11 +236,9 @@ static ssize_t ad9832_write(struct device *dev, struct= device_attribute *attr, ret =3D spi_sync(st->spi, &st->msg); break; default: - ret =3D -ENODEV; + return -ENODEV; } - mutex_unlock(&st->lock); =20 -error_ret: return ret ? ret : len; } =20 --=20 2.43.0