From nobody Sun Feb 8 02:08:23 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56DDB322B62 for ; Mon, 15 Dec 2025 17:56:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765821413; cv=none; b=PFXmEmvbZGZpGK7lwVPDploUC3tXkU6wgGjvpwFV2H6XnZP4uNRblx8mpjdxPscXxZL+VLy+SK+7oz8MJq2D+ewBsmXahklwIITiQJz4scdZz5dw2aWHM0HdknunnRth7q7HFENzeRKGbJ6PsnSPMi3LWCkDtN3RTO7TSWLz3Ew= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765821413; c=relaxed/simple; bh=eTM4vD/GLrblu1tIANeWjN21pSJ+nVb2OOpffLpnuQA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qEPAitY63yI25+8IL8mCgRh7hN4rrTJgQYJDEczGwhKkGyY5U2Qyp7EGtw2V08RoASsf4OGeITcOJxOa5PkC4LE2HsCVRYpf5taKIY0LSg2aYPO63+W3hMklLW20MI6T7H3jmcDsQ4rEyZmgFYwl2fPMs3WXPR01LWYyIVCfZdM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M3ZbYi41; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M3ZbYi41" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7b852bb31d9so4279934b3a.0 for ; Mon, 15 Dec 2025 09:56:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765821410; x=1766426210; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Zjy31YUGfLkTOdV/LJQ8OzVl78sbEt8Ql8lU5c5X1XM=; b=M3ZbYi41HfNfUiAGboksMx8syx02xFXKnoH1Mm8qilFA/tTNVgBSB9/iG7YLcTbRRm f5+NaNdGYhXS9FvL5CaDi+eEZflWw8ue37DcwTzlyTh/1sA7V3rA2DqmmtH2sCwBjAVd HW1QnuPnwtYotCQeT+rKR9mM5TCbFDz3TQ0wqjmyOGxPOLS2Cb/KVQ2ky6J4xsG603q/ 4mm+OhAfQawRSBSx6F1fiBnYJQ+0DScP6IS68JvYDQSOQG/qndlprXM5+mUCSNh433+G fnGRIM2v5ht7sP/SAt36Z6aKvK5j49DLhC6ga1C0nrp1IgvS1in4zwRT92exc7Yn/cEe 8B9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765821410; x=1766426210; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Zjy31YUGfLkTOdV/LJQ8OzVl78sbEt8Ql8lU5c5X1XM=; b=iqLZugPg89JXlcAwuKjVUhsn7oKTRpjCgcQ+THUYO3PYcT+688caZVljEVFG2u41kw 947P6LFIFrCOkm6fGMvzO8tmwViI/LVal7jK0nqJwaT/OS5Y1Ts8dauzXoqaiFTCdLJ+ zp16FnOjsczyZrGjUezyzd1uBk7ReWBwDzIlSkkIeiJ1JoAklzcYKAeVgJDFXm2GdA30 cuo+DfdCim5LZBstS/ijNJ5GysUHeN+mja3F1kV8v7zcQ0RQFTd8gaTfUf7tT/c1aDlp yPMHInUOcFlfATy3/QPjULERC1lcqeahG87MRDnU4qrN+LI7wPrlv+FPmdR9v8XSE3BD yfDw== X-Forwarded-Encrypted: i=1; AJvYcCWcdnwBXx1KrcN5cTp/reErROcVLBGDCr5x/FsekSnmIfPXXKaME/2v2t73uR0zA185tSveq+7UN4msEtk=@vger.kernel.org X-Gm-Message-State: AOJu0YzJ8hlKhAgapiL33RtlVwDAhzsVe4L8vUMf9vG3ucrq6rPY0oqj rrvEVdPPSGrsmKOmuOd1DLZIBYzFNVLlbKkggC/znbbeeHzurHzf8Mox X-Gm-Gg: AY/fxX5LA4Sif6l7zA5k5UsG90wG6DW9FisMMR3O+Q+ztADNPisNYBkluLW3LbPA8K9 +JvyT8FjxWCtbJqyh7JT8YgavmG+ePhmBh94Tlwdex3+gBapzUL4auNRLz9ch69+5pKGMlbxVSj MC6QJqvZt4rwRXHkLmGEHKlJeNL86+mTl8l1pal2VginFXiuOWqVVb0vsey3IBDfs3rnZRh+djL xKZ4XFawy3X+oCB7TjcC6C1iAyh9XxxqD5zhjZkFYEXLKXH2HNkKFCtoBEIGeij90tQqanZ6qv2 ufy2/KGASlx4JlnqxjcvX0dJ6ZzT+pVvAQcxnQrYdk5xMrW/RaGOXmViZgnbRL6I7/9GcpnbPBe JfTTd4fE7ftRF6oy3BLwn+v+Kf5mTcI9sNDlPWzRF5FH1zxcbuWBdgC4bt6djlMuqcADcRwfuP+ /e3cI9pJ6bvFPsrq4iMr2sA50i7lXbBFXaQEF7JKcGCpVElQ== X-Google-Smtp-Source: AGHT+IGtZYwtKejQoOFuovNjJaFhF72wzKa/tyvI0qT5HW4xRwabzO+9k2CRNE4A5jL/3vIuG5nD1w== X-Received: by 2002:a05:6a21:6d9e:b0:366:14ac:e1dc with SMTP id adf61e73a8af0-369afff2579mr10516001637.66.1765821410248; Mon, 15 Dec 2025 09:56:50 -0800 (PST) Received: from nikhil-s-Swift-SFG14-73.. ([101.0.63.245]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1361b76c59sm5255040a12.34.2025.12.15.09.56.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 09:56:49 -0800 (PST) From: Nikhil S To: mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil S Subject: [PATCH] media: dvb-core: fix style violation issues Date: Mon, 15 Dec 2025 23:26:28 +0530 Message-ID: <20251215175639.19377-1-nikhilsunilkumar@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix multiple checkpatch-reported style issues. Signed-off-by: Nikhil S --- drivers/media/dvb-core/dvb_net.c | 158 ++++++++++++++++--------------- 1 file changed, 80 insertions(+), 78 deletions(-) diff --git a/drivers/media/dvb-core/dvb_net.c b/drivers/media/dvb-core/dvb_= net.c index 8bb8dd34c223..4c42d3c7cd14 100644 --- a/drivers/media/dvb-core/dvb_net.c +++ b/drivers/media/dvb-core/dvb_net.c @@ -57,11 +57,11 @@ #include #include =20 -static inline __u32 iov_crc32( __u32 c, struct kvec *iov, unsigned int cnt= ) +static inline __u32 iov_crc32(__u32 c, struct kvec *iov, unsigned int cnt) { unsigned int j; for (j =3D 0; j < cnt; j++) - c =3D crc32_be( c, iov[j].iov_base, iov[j].iov_len ); + c =3D crc32_be(c, iov[j].iov_base, iov[j].iov_len); return c; } =20 @@ -133,14 +133,14 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *= skb, unsigned char *rawp; =20 skb_reset_mac_header(skb); - skb_pull(skb,dev->hard_header_len); + skb_pull(skb, dev->hard_header_len); eth =3D eth_hdr(skb); =20 if (*eth->h_dest & 1) { - if(ether_addr_equal(eth->h_dest,dev->broadcast)) - skb->pkt_type=3DPACKET_BROADCAST; + if (ether_addr_equal(eth->h_dest, dev->broadcast)) + skb->pkt_type =3D PACKET_BROADCAST; else - skb->pkt_type=3DPACKET_MULTICAST; + skb->pkt_type =3D PACKET_MULTICAST; } =20 if (ntohs(eth->h_proto) >=3D ETH_P_802_3_MIN) @@ -178,20 +178,20 @@ static __be16 dvb_net_eth_type_trans(struct sk_buff *= skb, =20 #define ULE_OPTEXTHDR_PADDING 0 =20 -static int ule_test_sndu( struct dvb_net_priv *p ) +static int ule_test_sndu(struct dvb_net_priv *p) { return -1; } =20 -static int ule_bridged_sndu( struct dvb_net_priv *p ) +static int ule_bridged_sndu(struct dvb_net_priv *p) { - struct ethhdr *hdr =3D (struct ethhdr*) p->ule_next_hdr; - if(ntohs(hdr->h_proto) < ETH_P_802_3_MIN) { + struct ethhdr *hdr =3D (struct ethhdr *) p->ule_next_hdr; + + if (ntohs(hdr->h_proto) < ETH_P_802_3_MIN) { int framelen =3D p->ule_sndu_len - ((p->ule_next_hdr+sizeof(struct ethhd= r)) - p->ule_skb->data); /* A frame Type < ETH_P_802_3_MIN for a bridged frame, introduces a LLC = Length field. */ - if(framelen !=3D ntohs(hdr->h_proto)) { + if (framelen !=3D ntohs(hdr->h_proto)) return -1; - } } /* Note: * From RFC4326: @@ -214,15 +214,15 @@ static int ule_exthdr_padding(struct dvb_net_priv *p) * Returns: >=3D 0: nr. of bytes consumed by next extension header * -1: Mandatory extension header that is not recognized or TEST SN= DU; discard. */ -static int handle_one_ule_extension( struct dvb_net_priv *p ) +static int handle_one_ule_extension(struct dvb_net_priv *p) { /* Table of mandatory extension header handlers. The header type is the = index. */ - static int (*ule_mandatory_ext_handlers[255])( struct dvb_net_priv *p ) = =3D - { [0] =3D ule_test_sndu, [1] =3D ule_bridged_sndu, [2] =3D NULL, }; + static int (*ule_mandatory_ext_handlers[255])(struct dvb_net_priv *p) =3D= { + [0] =3D ule_test_sndu, [1] =3D ule_bridged_sndu, [2] =3D NULL, }; =20 /* Table of optional extension header handlers. The header type is the i= ndex. */ - static int (*ule_optional_ext_handlers[255])( struct dvb_net_priv *p ) = =3D - { [0] =3D ule_exthdr_padding, [1] =3D NULL, }; + static int (*ule_optional_ext_handlers[255])(struct dvb_net_priv *p) =3D { + [0] =3D ule_exthdr_padding, [1] =3D NULL, }; =20 int ext_len =3D 0; unsigned char hlen =3D (p->ule_sndu_type & 0x0700) >> 8; @@ -232,8 +232,8 @@ static int handle_one_ule_extension( struct dvb_net_pri= v *p ) if (hlen =3D=3D 0) { /* Mandatory extension header */ if (ule_mandatory_ext_handlers[htype]) { - ext_len =3D ule_mandatory_ext_handlers[htype]( p ); - if(ext_len >=3D 0) { + ext_len =3D ule_mandatory_ext_handlers[htype](p); + if (ext_len >=3D 0) { p->ule_next_hdr +=3D ext_len; if (!p->ule_bridged) { p->ule_sndu_type =3D ntohs(*(__be16 *)p->ule_next_hdr); @@ -251,9 +251,9 @@ static int handle_one_ule_extension( struct dvb_net_pri= v *p ) ext_len =3D hlen << 1; /* Process the optional extension header according to its type. */ if (ule_optional_ext_handlers[htype]) - (void)ule_optional_ext_handlers[htype]( p ); + (void)ule_optional_ext_handlers[htype](p); p->ule_next_hdr +=3D ext_len; - p->ule_sndu_type =3D ntohs( *(__be16 *)(p->ule_next_hdr-2) ); + p->ule_sndu_type =3D ntohs(*(__be16 *)(p->ule_next_hdr-2)); /* * note: the length of the next header type is included in the * length of THIS optional extension header @@ -263,13 +263,13 @@ static int handle_one_ule_extension( struct dvb_net_p= riv *p ) return ext_len; } =20 -static int handle_ule_extensions( struct dvb_net_priv *p ) +static int handle_ule_extensions(struct dvb_net_priv *p) { int total_ext_len =3D 0, l; =20 p->ule_next_hdr =3D p->ule_skb->data; do { - l =3D handle_one_ule_extension( p ); + l =3D handle_one_ule_extension(p); if (l < 0) return l; /* Stop extension header processing and discard SNDU. */ total_ext_len +=3D l; @@ -284,7 +284,7 @@ static int handle_ule_extensions( struct dvb_net_priv *= p ) =20 =20 /* Prepare for a new ULE SNDU: reset the decoder state. */ -static inline void reset_ule( struct dvb_net_priv *p ) +static inline void reset_ule(struct dvb_net_priv *p) { p->ule_skb =3D NULL; p->ule_next_hdr =3D NULL; @@ -936,7 +936,8 @@ static void dvb_net_sec(struct net_device *dev, /* we have 14 byte ethernet header (ip header follows); * 12 byte MPE header; 4 byte checksum; + 2 byte alignment, 8 byte LLC/SN= AP */ - if (!(skb =3D dev_alloc_skb(pkt_len - 4 - 12 + 14 + 2 - snap))) { + skb =3D dev_alloc_skb(pkt_len - 4 - 12 + 14 + 2 - snap); + if (!skb) { //pr_notice("%s: Memory squeeze, dropping packet.\n", dev->name); stats->rx_dropped++; return; @@ -949,14 +950,14 @@ static void dvb_net_sec(struct net_device *dev, memcpy(eth + 14, pkt + 12 + snap, pkt_len - 12 - 4 - snap); =20 /* create ethernet header: */ - eth[0]=3Dpkt[0x0b]; - eth[1]=3Dpkt[0x0a]; - eth[2]=3Dpkt[0x09]; - eth[3]=3Dpkt[0x08]; - eth[4]=3Dpkt[0x04]; - eth[5]=3Dpkt[0x03]; + eth[0] =3D pkt[0x0b]; + eth[1] =3D pkt[0x0a]; + eth[2] =3D pkt[0x09]; + eth[3] =3D pkt[0x08]; + eth[4] =3D pkt[0x04]; + eth[5] =3D pkt[0x03]; =20 - eth[6]=3Deth[7]=3Deth[8]=3Deth[9]=3Deth[10]=3Deth[11]=3D0; + eth[6] =3D eth[7] =3D eth[8] =3D eth[9] =3D eth[10] =3D eth[11] =3D 0; =20 if (snap) { eth[12] =3D pkt[18]; @@ -977,7 +978,7 @@ static void dvb_net_sec(struct net_device *dev, skb->protocol =3D dvb_net_eth_type_trans(skb, dev); =20 stats->rx_packets++; - stats->rx_bytes+=3Dskb->len; + stats->rx_bytes +=3D skb->len; netif_rx(skb); } =20 @@ -1001,10 +1002,10 @@ static netdev_tx_t dvb_net_tx(struct sk_buff *skb, = struct net_device *dev) return NETDEV_TX_OK; } =20 -static u8 mask_normal[6]=3D{0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; -static u8 mask_allmulti[6]=3D{0xff, 0xff, 0xff, 0x00, 0x00, 0x00}; -static u8 mac_allmulti[6]=3D{0x01, 0x00, 0x5e, 0x00, 0x00, 0x00}; -static u8 mask_promisc[6]=3D{0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; +static u8 mask_normal[6] =3D {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}; +static u8 mask_allmulti[6] =3D {0xff, 0xff, 0xff, 0x00, 0x00, 0x00}; +static u8 mac_allmulti[6] =3D {0x01, 0x00, 0x5e, 0x00, 0x00, 0x00}; +static u8 mask_promisc[6] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; =20 static int dvb_net_filter_sec_set(struct net_device *dev, struct dmx_section_filter **secfilter, @@ -1013,26 +1014,26 @@ static int dvb_net_filter_sec_set(struct net_device= *dev, struct dvb_net_priv *priv =3D netdev_priv(dev); int ret; =20 - *secfilter=3DNULL; + *secfilter =3D NULL; ret =3D priv->secfeed->allocate_filter(priv->secfeed, secfilter); - if (ret<0) { + if (ret < 0) { pr_err("%s: could not get filter\n", dev->name); return ret; } =20 - (*secfilter)->priv=3D(void *) dev; + (*secfilter)->priv =3D (void *) dev; =20 memset((*secfilter)->filter_value, 0x00, DMX_MAX_FILTER_SIZE); memset((*secfilter)->filter_mask, 0x00, DMX_MAX_FILTER_SIZE); memset((*secfilter)->filter_mode, 0xff, DMX_MAX_FILTER_SIZE); =20 - (*secfilter)->filter_value[0]=3D0x3e; - (*secfilter)->filter_value[3]=3Dmac[5]; - (*secfilter)->filter_value[4]=3Dmac[4]; - (*secfilter)->filter_value[8]=3Dmac[3]; - (*secfilter)->filter_value[9]=3Dmac[2]; - (*secfilter)->filter_value[10]=3Dmac[1]; - (*secfilter)->filter_value[11]=3Dmac[0]; + (*secfilter)->filter_value[0] =3D 0x3e; + (*secfilter)->filter_value[3] =3D mac[5]; + (*secfilter)->filter_value[4] =3D mac[4]; + (*secfilter)->filter_value[8] =3D mac[3]; + (*secfilter)->filter_value[9] =3D mac[2]; + (*secfilter)->filter_value[10] =3D mac[1]; + (*secfilter)->filter_value[11] =3D mac[0]; =20 (*secfilter)->filter_mask[0] =3D 0xff; (*secfilter)->filter_mask[3] =3D mac_mask[5]; @@ -1040,7 +1041,7 @@ static int dvb_net_filter_sec_set(struct net_device *= dev, (*secfilter)->filter_mask[8] =3D mac_mask[3]; (*secfilter)->filter_mask[9] =3D mac_mask[2]; (*secfilter)->filter_mask[10] =3D mac_mask[1]; - (*secfilter)->filter_mask[11]=3Dmac_mask[0]; + (*secfilter)->filter_mask[11] =3D mac_mask[0]; =20 netdev_dbg(dev, "filter mac=3D%pM mask=3D%pM\n", mac, mac_mask); =20 @@ -1059,15 +1060,15 @@ static int dvb_net_feed_start(struct net_device *de= v) if (priv->tsfeed || priv->secfeed || priv->secfilter || priv->multi_secfi= lter[0]) pr_err("%s: BUG %d\n", __func__, __LINE__); =20 - priv->secfeed=3DNULL; - priv->secfilter=3DNULL; + priv->secfeed =3D NULL; + priv->secfilter =3D NULL; priv->tsfeed =3D NULL; =20 if (priv->feedtype =3D=3D DVB_NET_FEEDTYPE_MPE) { netdev_dbg(dev, "alloc secfeed\n"); - ret=3Ddemux->allocate_section_feed(demux, &priv->secfeed, + ret =3D demux->allocate_section_feed(demux, &priv->secfeed, dvb_net_sec_callback); - if (ret<0) { + if (ret < 0) { pr_err("%s: could not allocate section feed\n", dev->name); goto error; @@ -1075,10 +1076,10 @@ static int dvb_net_feed_start(struct net_device *de= v) =20 ret =3D priv->secfeed->set(priv->secfeed, priv->pid, 1); =20 - if (ret<0) { + if (ret < 0) { pr_err("%s: could not set section feed\n", dev->name); priv->demux->release_section_feed(priv->demux, priv->secfeed); - priv->secfeed=3DNULL; + priv->secfeed =3D NULL; goto error; } =20 @@ -1096,13 +1097,13 @@ static int dvb_net_feed_start(struct net_device *de= v) } break; case RX_MODE_ALL_MULTI: - priv->multi_num=3D1; + priv->multi_num =3D 1; netdev_dbg(dev, "set multi_secfilter[0]\n"); dvb_net_filter_sec_set(dev, &priv->multi_secfilter[0], mac_allmulti, mask_allmulti); break; case RX_MODE_PROMISC: - priv->multi_num=3D0; + priv->multi_num =3D 0; netdev_dbg(dev, "set secfilter\n"); dvb_net_filter_sec_set(dev, &priv->secfilter, mac, mask_promisc); break; @@ -1164,10 +1165,10 @@ static int dvb_net_feed_stop(struct net_device *dev) netdev_dbg(dev, "release secfilter\n"); priv->secfeed->release_filter(priv->secfeed, priv->secfilter); - priv->secfilter=3DNULL; + priv->secfilter =3D NULL; } =20 - for (i=3D0; imulti_num; i++) { + for (i =3D 0; i < priv->multi_num; i++) { if (priv->multi_secfilter[i]) { netdev_dbg(dev, "release multi_filter[%d]\n", i); @@ -1189,8 +1190,7 @@ static int dvb_net_feed_stop(struct net_device *dev) } priv->demux->release_ts_feed(priv->demux, priv->tsfeed); priv->tsfeed =3D NULL; - } - else + } else pr_err("%s: no ts feed to stop\n", dev->name); } else ret =3D -EINVAL; @@ -1270,7 +1270,7 @@ static void wq_restart_net_feed (struct work_struct *= work) static int dvb_net_set_mac (struct net_device *dev, void *p) { struct dvb_net_priv *priv =3D netdev_priv(dev); - struct sockaddr *addr=3Dp; + struct sockaddr *addr =3D p; =20 eth_hw_addr_set(dev, addr->sa_data); =20 @@ -1330,14 +1330,14 @@ static int get_if(struct dvb_net *dvbnet) { int i; =20 - for (i=3D0; istate[i]) break; =20 if (i =3D=3D DVB_NET_DEVICES_MAX) return -1; =20 - dvbnet->state[i]=3D1; + dvbnet->state[i] =3D 1; return i; } =20 @@ -1350,7 +1350,8 @@ static int dvb_net_add_if(struct dvb_net *dvbnet, u16= pid, u8 feedtype) =20 if (feedtype !=3D DVB_NET_FEEDTYPE_MPE && feedtype !=3D DVB_NET_FEEDTYPE_= ULE) return -EINVAL; - if ((if_num =3D get_if(dvbnet)) < 0) + if_num =3D get_if(dvbnet); + if (if_num < 0) return -EINVAL; =20 net =3D alloc_netdev(sizeof(struct dvb_net_priv), "dvb", @@ -1387,7 +1388,8 @@ static int dvb_net_add_if(struct dvb_net *dvbnet, u16= pid, u8 feedtype) =20 net->base_addr =3D pid; =20 - if ((result =3D register_netdev(net)) < 0) { + result =3D register_netdev(net); + if (result < 0) { dvbnet->device[if_num] =3D NULL; free_netdev(net); return result; @@ -1413,7 +1415,7 @@ static int dvb_net_remove_if(struct dvb_net *dvbnet, = unsigned long num) flush_work(&priv->restart_net_feed_wq); pr_info("removed network interface %s\n", net->name); unregister_netdev(net); - dvbnet->state[num]=3D0; + dvbnet->state[num] =3D 0; dvbnet->device[num] =3D NULL; free_netdev(net); =20 @@ -1427,7 +1429,7 @@ static int dvb_net_do_ioctl(struct file *file, struct dvb_net *dvbnet =3D dvbdev->priv; int ret =3D 0; =20 - if (((file->f_flags&O_ACCMODE)=3D=3DO_RDONLY)) + if (((file->f_flags&O_ACCMODE) =3D=3D O_RDONLY)) return -EPERM; =20 if (mutex_lock_interruptible(&dvbnet->ioctl_mutex)) @@ -1449,13 +1451,13 @@ static int dvb_net_do_ioctl(struct file *file, goto ioctl_error; } =20 - result=3Ddvb_net_add_if(dvbnet, dvbnetif->pid, dvbnetif->feedtype); - if (result<0) { + result =3D dvb_net_add_if(dvbnet, dvbnetif->pid, dvbnetif->feedtype); + if (result < 0) { module_put(dvbdev->adapter->module); ret =3D result; goto ioctl_error; } - dvbnetif->if_num=3Dresult; + dvbnetif->if_num =3D result; break; } case NET_GET_IF: @@ -1479,8 +1481,8 @@ static int dvb_net_do_ioctl(struct file *file, netdev =3D dvbnet->device[if_num]; =20 priv_data =3D netdev_priv(netdev); - dvbnetif->pid=3Dpriv_data->pid; - dvbnetif->feedtype=3Dpriv_data->feedtype; + dvbnetif->pid =3D priv_data->pid; + dvbnetif->feedtype =3D priv_data->feedtype; break; } case NET_REMOVE_IF: @@ -1515,13 +1517,13 @@ static int dvb_net_do_ioctl(struct file *file, goto ioctl_error; } =20 - result=3Ddvb_net_add_if(dvbnet, dvbnetif->pid, DVB_NET_FEEDTYPE_MPE); - if (result<0) { + result =3D dvb_net_add_if(dvbnet, dvbnetif->pid, DVB_NET_FEEDTYPE_MPE); + if (result < 0) { module_put(dvbdev->adapter->module); ret =3D result; goto ioctl_error; } - dvbnetif->if_num=3Dresult; + dvbnetif->if_num =3D result; break; } case __NET_GET_IF_OLD: @@ -1545,7 +1547,7 @@ static int dvb_net_do_ioctl(struct file *file, netdev =3D dvbnet->device[if_num]; =20 priv_data =3D netdev_priv(netdev); - dvbnetif->pid=3Dpriv_data->pid; + dvbnetif->pid =3D priv_data->pid; break; } default: @@ -1637,7 +1639,7 @@ void dvb_net_release (struct dvb_net *dvbnet) =20 dvb_unregister_device(dvbnet->dvbdev); =20 - for (i=3D0; istate[i]) continue; dvb_net_remove_if(dvbnet, i); @@ -1655,7 +1657,7 @@ int dvb_net_init (struct dvb_adapter *adap, struct dv= b_net *dvbnet, mutex_init(&dvbnet->remove_mutex); dvbnet->demux =3D dmx; =20 - for (i=3D0; istate[i] =3D 0; =20 return dvb_register_device(adap, &dvbnet->dvbdev, &dvbdev_net, --=20 2.43.0