From nobody Wed Dec 17 00:04:43 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B87A280CD5 for ; Mon, 15 Dec 2025 15:46:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765813598; cv=none; b=kWHhbX1OU3tNcHeD5EcQAKrnQW8shDA1N47mvAx03Qg8xAZ+7yb5/GpWhFAH4edOnGOKlPmwPeIMmuTWOFrhFFXBGlGkX5vgjTQz96uWvtdX1YjGklQ2yORW2StgUwgjVB8JGc5EPyyghsqCvCCEeIP7cr1ifd9WS6uX4GOxG4s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765813598; c=relaxed/simple; bh=i7HTV6k47P45ObdvvxS7eMjZZQEjI6MJNjKdvk5f+FI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RVX4qf93p8mbLXbvBLIle+RCq6jr2igeIJg0R8UfAtTcFUOQfAd8OUDf9XJ6voyHV8kvFIo5EOeU7zUhl3QwNxZ86R+TbAQsWyIhILZCLJlcRllGaprd/Rgq/g1SnTe396qvaRHMMHQGqrx8CG8PI8ehCV79YpUrdqZuQN05k6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GHxT/2B/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Hu+wZ9kQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GHxT/2B/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Hu+wZ9kQ" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BFANqX8103096 for ; Mon, 15 Dec 2025 15:46:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=VN9hm8flaXJlAMoKWsCfoolm2x7byHy2J4n I/XIKGkI=; b=GHxT/2B/vp4ORFiWD6ugwf+7jBhquCwUl6HOfG6iwchwrWRPZbG SjHUmZcaqNgMADgoBuXqCxh3ZPFM3j9K2kBzsBaC134QOpCov0FYmmhqpwetFpXQ NfhP2xtc14+QlSEd00XQczfjI4SGGzg9Fwh7uocNGoIDRAoOBekPhYtHkfs+Rumx BiFXstgKJH1sgmMOacblHXOgmHK0X3ztWwHkBoOPM6nioanrz/l99iz0nF2AICtd yvh7LmRyViS9/0knxT2C5RPxyslH77suKVUHMJUieHJ8znJJcHeyA+EJQ28Ha5zq iEJlhfp7MckR5Wn+TX7CTvDVqCdVCghYweQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b119t544v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Dec 2025 15:46:35 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4ed6ff3de05so91870041cf.3 for ; Mon, 15 Dec 2025 07:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765813595; x=1766418395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VN9hm8flaXJlAMoKWsCfoolm2x7byHy2J4nI/XIKGkI=; b=Hu+wZ9kQM6nMOexwDfeCTUVHtvAeYEjmGl3bMOQ//SMnU2OMoTXHYt3uOS7M7oOJXt NPzXpx/1upiwjN8juk2Tc4zr0Bndm83M6p+lzsI3fvW2v3ozLRKhaeXdJLNXQrSOOFFL MMX9kJnxJkM9zaDaN6+GmRMYdWcoHrHbIuZAXW5mtzVJ2lc4ualSf+ehj+2EB3habYNr Sr0LXkg0R3TLjg2izE+B0pw85Upp+fp1gui0cbwhKx+hbfisZVijwO74ylgqDLEC1Z7u b7KaeDq2PgB6xHvBXJbR+fObnNcNxokZbjrWJO12S1jvi7bsGjNmemZSRCK36syjXN5n 7N9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765813595; x=1766418395; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VN9hm8flaXJlAMoKWsCfoolm2x7byHy2J4nI/XIKGkI=; b=v/ukbwfgNxTNPvCPw2QYN1w1a0344MmCKqjFAioqgPOZLDF18zsjV7QCxnsbq85Q+g ZWscNRzPvAGStooSVrFXk3FtMLWOe0pLp+3C7nEHG5xrYlTsQxqQBq/4HwlP9zpExAzE MzyMgGYKclYxE4uNAl4MtasuD8GCzWg0S1xqvJ6y01CUvB/Cj+4yg+DmITOIWYbcppMT pfZoKf7k0Mk7Zh4A0Smv/C9bt9ziyeX83+jbsE438KgRI0dI6MzEfboBCSQR7eL+wm3W G/9F7HwtvgjCC03KpZZ9uQEdGaEI1e/NMQlZj5CjIYHSKaNfDO7RoTyItcUxsnHTobaP YHZw== X-Forwarded-Encrypted: i=1; AJvYcCVWJ1WMfMOJop+QILWn2LITW7YCzC0rJgeuUVq1g2/ZgLVNC3pH6sf7Oq/iX03kLsliSfL90qXNY8D7of4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzyb8h+hC9o1rEBR7Ghkm5aLfbiRVlzhF5m1EunRvnNL1XvbwJf ToTrO6Mb0x/e2eruq7XW/hDMJkNjeNlcohsKR3iYkAyMEHV9YmmOmZGQ3MoQl1FXdl/FmFgRhkz 0c1gUWcPss5MUaHzjdUYXYOV70K+JyzbblyGu1VXHwX/4brZmMEwSsLkCpK9obF6Yr7k= X-Gm-Gg: AY/fxX5NMUFg1rcstLLpaSFEvQ7mUEL1zEyFcQg0Jc4ch04KOuUyROCZ6SWaovpwyCC GdyJz+t5ly7Zqnjaw3clT0F6SQKJ/t2MbheocwUYtJtCDpxYyXS9eb7n9CyuSOsdOEWTVWYIhPy sE0VQ4iLp5OvRIClhpm4G8LBpaKO0AWQTkTnawzyCmu8/JB9oqz9lvRpkopHloTLyNnRoyusVWF +vx4oPOC/V8h8f0xFGCheXEsjwNf1w4avLOvkxV9dWq7p7B5ZC///fu2jzHmotXannzdDmwqq6F ZSiQveehs48ppFgFigBNLkXpAmV9htl2X+/lSFNwlmg83zUi1KosVlRh0WyArBdTrHNVNIiQBB+ xFUoAa80i8/nfyZbwkxRLJ4+BlWEGphBA X-Received: by 2002:a05:622a:130d:b0:4ee:1bc7:9d8d with SMTP id d75a77b69052e-4f1d0467029mr119416811cf.17.1765813594585; Mon, 15 Dec 2025 07:46:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzwhYBddmY792geA2ZrLUAETvcShHFsQm73K1o17VpiJkUAlh0wB1C4+D2At55N2iaoYXOFg== X-Received: by 2002:a05:622a:130d:b0:4ee:1bc7:9d8d with SMTP id d75a77b69052e-4f1d0467029mr119416291cf.17.1765813593925; Mon, 15 Dec 2025 07:46:33 -0800 (PST) Received: from brgl-uxlite ([2a01:cb1d:dc:7e00:9230:746:c30b:f2e5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f4af065sm71408105e9.6.2025.12.15.07.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 07:46:33 -0800 (PST) From: Bartosz Golaszewski To: Charles Keepax , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpio: swnode: compare the "undefined" swnode by its address, not name Date: Mon, 15 Dec 2025 16:46:24 +0100 Message-ID: <20251215154624.67099-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE1MDEzNyBTYWx0ZWRfX8KjOoqBvR+uY B3HccgGAMzTcBnuwsSlIfoltQzwUivAgKljyrW7F4XiZNUzXGlIoYlC+ITpYGqFidKJMp/0qf+g VVwgPxHLR5fOE3iIwNHJVQqEdgC+D74nuJ3EuDEOb8eYJEW9cSbZfN1CNdgA5C4VYpqN958CRhk PuLi5BEtlbUDCp0zBEwLtgX2ZcTCCWBCkRAgZhptDUl9Azdl2HOzAc5f3IY7yovERSnbfmn1u6+ KiqnlVvfe5GbNYoRHmE7TghzjbEcci9omTfnEEA31qaAA1z5oYjp7hBpLWyVd4foyIULlphYG+0 /WWY6uLwlNH1KLBRhEZyQdxun+eJGUZVXeQ+quF2oQnBfLoPMDYuAW1EJzUcdaMfmpm3QYHffXL OCZsPL07Kn9TV6rq6cDAVGekSrKDGg== X-Proofpoint-GUID: d_6BZG2fytxOaVMyB-t0xptIDnBFH3cP X-Authority-Analysis: v=2.4 cv=E6nAZKdl c=1 sm=1 tr=0 ts=69402d5b cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=esFB21bSQ0nGF8Mf3lgA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-ORIG-GUID: d_6BZG2fytxOaVMyB-t0xptIDnBFH3cP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_03,2025-12-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512150137 Content-Type: text/plain; charset="utf-8" We know the address of the underlying remote software node referenced by the GPIO property (if it is a software node). We don't need to compare its name, we can compare its address which is more precise anyway. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib-swnode.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpiolib-swnode.c b/drivers/gpio/gpiolib-swnode.c index b44f35d684590..54bad9e88fe5c 100644 --- a/drivers/gpio/gpiolib-swnode.c +++ b/drivers/gpio/gpiolib-swnode.c @@ -18,19 +18,18 @@ =20 #include #include +#include =20 #include "gpiolib.h" #include "gpiolib-swnode.h" =20 -#define GPIOLIB_SWNODE_UNDEFINED_NAME "swnode-gpio-undefined" - static struct gpio_device *swnode_get_gpio_device(struct fwnode_handle *fw= node) { const struct software_node *gdev_node; struct gpio_device *gdev; =20 gdev_node =3D to_software_node(fwnode); - if (!gdev_node || !gdev_node->name) + if (!gdev_node) goto fwnode_lookup; =20 /* @@ -38,7 +37,7 @@ static struct gpio_device *swnode_get_gpio_device(struct = fwnode_handle *fwnode) * primarily used as a key for internal chip selects in SPI bindings. */ if (IS_ENABLED(CONFIG_GPIO_SWNODE_UNDEFINED) && - !strcmp(gdev_node->name, GPIOLIB_SWNODE_UNDEFINED_NAME)) + gdev_node =3D=3D &swnode_gpio_undefined) return ERR_PTR(-ENOENT); =20 fwnode_lookup: @@ -139,9 +138,7 @@ int swnode_gpio_count(const struct fwnode_handle *fwnod= e, const char *con_id) * A special node that identifies undefined GPIOs, this is primarily used = as * a key for internal chip selects in SPI bindings. */ -const struct software_node swnode_gpio_undefined =3D { - .name =3D GPIOLIB_SWNODE_UNDEFINED_NAME, -}; +const struct software_node swnode_gpio_undefined =3D { }; EXPORT_SYMBOL_NS_GPL(swnode_gpio_undefined, "GPIO_SWNODE"); =20 static int __init swnode_gpio_init(void) --=20 2.51.0