From nobody Mon Dec 15 23:36:16 2025 Received: from mail186-20.suw21.mandrillapp.com (mail186-20.suw21.mandrillapp.com [198.2.186.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29A9532D0CD for ; Mon, 15 Dec 2025 14:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.2.186.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808072; cv=none; b=mh77JjuP3554x4u/WCC47hg12NLb3LbAk/4J3XczPwKmkq8S0yD57dP2WV9LYe6Gh0eTxnSNhEqC/HHXaAWxp3kPNwoh1fDT661jIUE5JLxXDsHHxikHMqfziFUdk+MEN/fci5VXVN7GZk/BPOijQNiTsi4bxRmleKCR/axeEoM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765808072; c=relaxed/simple; bh=r4pR/WZWgxpWH4YZ0HxKYJaXnqglOE1l6sGyaVhvDZQ=; h=From:Subject:To:Cc:Message-Id:Date:MIME-Version:Content-Type; b=gU7i+mA5pOQoXnxlSwMRK0SLaRGEyFay7EkEvRZaWywDLE7pyv1TfVYkBhTRoCJGbOdDYe0gi6K328VOnkn7EyGNZRCTkYgjqfNPSKlENzOviwykh+i1MgnCEbsCYtgbfQV8EoPuI8ORZQ0E64ZVPI0Y0cXUL+G1+NAa829+vaE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=vates.tech; spf=pass smtp.mailfrom=bounce.vates.tech; dkim=pass (2048-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b=jGllSDAK; dkim=pass (2048-bit key) header.d=vates.tech header.i=thomas.courrege@vates.tech header.b=Q/iO2aXO; arc=none smtp.client-ip=198.2.186.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=vates.tech Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bounce.vates.tech Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mandrillapp.com header.i=@mandrillapp.com header.b="jGllSDAK"; dkim=pass (2048-bit key) header.d=vates.tech header.i=thomas.courrege@vates.tech header.b="Q/iO2aXO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1765808069; x=1766078069; bh=MQWFgBdoUX1kknCFzw0JsezB1mvx5zyVSGtfO5OP/iE=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=jGllSDAKrGdCf6k1BpPnf3wIEyOGlVtDkO2Z9lbRLagXAIw+klaTxf2P5wPhFu+wv x3GARbACpkXuRaWNSppa7dNpu0TuMn5bduhOb28yWSvbTFoSJttwR1dOEcQEgVeAhx hkq9vigei0iDDXuAnEpr+hV3q6HY0VaYftacN4ThuYD22tYyoxxL6F+AuqHIJW91pA QgmX95cJKOA7VHyS/gXUFupYM+R2Ysd2YtmNCVl0YUctB1WvO3Tgvyqxo3LV04I+3A 4ffUM3FcOu4mbI+g98YsGXULP2m8GRLBatr6pxaXyr97WhZmPjWCHRWSbeGJBiwkRH EP8wZxKPX1C3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1765808069; x=1766068569; i=thomas.courrege@vates.tech; bh=MQWFgBdoUX1kknCFzw0JsezB1mvx5zyVSGtfO5OP/iE=; h=From:Subject:To:Cc:Message-Id:Feedback-ID:Date:MIME-Version: Content-Type:Content-Transfer-Encoding:CC:Date:Subject:From; b=Q/iO2aXOcIVt+PnazbkMiKw54+AJrk8A2Qo6ckKlK3dmfOE++lpXVx8j8lQnV/Iyp 1i0A3MX7mYh7tinNLgQXWZRoX2ZvZL+gdCg9o5TEGn8VcXEaQn0xAjc2PJRXOxk2dS CVTdupxLtkOi5dDN2XG0gJAQrnuP25gRlvZs7l01hGkThtt9cpC1Q73tF5N4x7vhqb ipYEsBDKk7fs8ZTzSJKYMU/l7BDHMSHhjuVrTOoV0nDO44L9LKwem7uhni+3Ch7YV7 OUm92inCuWc9N5m0v+fgDMSt12Q7r+XRb320WPtxdmasGzefv2tLWeP3eKDzQqfrn0 rUwdnWORxKkgA== Received: from pmta10.mandrill.prod.suw01.rsglab.com (localhost [127.0.0.1]) by mail186-20.suw21.mandrillapp.com (Mailchimp) with ESMTP id 4dVMWT2KSPzFCWqfK for ; Mon, 15 Dec 2025 14:14:29 +0000 (GMT) From: "Thomas Courrege" Subject: =?utf-8?Q?[PATCH=20v3]=20KVM:=20SEV:=20Add=20KVM=5FSEV=5FSNP=5FHV=5FREPORT=5FREQ=20command?= Received: from [37.26.189.201] by mandrillapp.com id 44d5400627cf4d6aaaa896c94d3de8a4; Mon, 15 Dec 2025 14:14:29 +0000 X-Mailer: git-send-email 2.52.0 X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1765808068580 To: ashish.kalra@amd.com, corbet@lwn.net, herbert@gondor.apana.org.au, john.allen@amd.com, nikunj@amd.com, pbonzini@redhat.com, seanjc@google.com, thomas.lendacky@amd.com Cc: kvm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, "Thomas Courrege" Message-Id: <20251215141417.2821412-1-thomas.courrege@vates.tech> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.44d5400627cf4d6aaaa896c94d3de8a4?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20251215:md Date: Mon, 15 Dec 2025 14:14:29 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for retrieving the SEV-SNP attestation report via the SNP_HV_REPORT_REQ firmware command and expose it through a new KVM ioctl for SNP guests. Signed-off-by: Thomas Courrege --- .../virt/kvm/x86/amd-memory-encryption.rst | 27 +++++++++ arch/x86/include/uapi/asm/kvm.h | 9 +++ arch/x86/kvm/svm/sev.c | 60 +++++++++++++++++++ drivers/crypto/ccp/sev-dev.c | 1 + include/linux/psp-sev.h | 31 ++++++++++ 5 files changed, 128 insertions(+) diff --git a/Documentation/virt/kvm/x86/amd-memory-encryption.rst b/Documen= tation/virt/kvm/x86/amd-memory-encryption.rst index 1ddb6a86ce7f..083ed487764e 100644 --- a/Documentation/virt/kvm/x86/amd-memory-encryption.rst +++ b/Documentation/virt/kvm/x86/amd-memory-encryption.rst @@ -572,6 +572,33 @@ Returns: 0 on success, -negative on error See SNP_LAUNCH_FINISH in the SEV-SNP specification [snp-fw-abi]_ for furth= er details on the input parameters in ``struct kvm_sev_snp_launch_finish``. =20 +21. KVM_SEV_SNP_HV_REPORT_REQ +----------------------------- + +The KVM_SEV_SNP_HV_REPORT_REQ command requests the hypervisor-generated +SNP attestation report. This report is produced by the PSP using the +HV-SIGNED key selected by the caller. + +The ``key_sel`` field indicates which key the platform will use to sign the +report: + * ``0``: If VLEK is installed, sign with VLEK. Otherwise, sign with VCEK. + * ``1``: Sign with VCEK. + * ``2``: Sign with VLEK. + * Other values are reserved. + +Parameters (in): struct kvm_sev_snp_hv_report_req + +Returns: 0 on success, -negative on error + +:: + struct kvm_sev_snp_hv_report_req { + __u64 report_uaddr; + __u64 report_len; + __u8 key_sel; + __u8 pad0[7]; + __u64 pad1[4]; + }; + Device attribute API =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 diff --git a/arch/x86/include/uapi/asm/kvm.h b/arch/x86/include/uapi/asm/kv= m.h index 7ceff6583652..464146bed784 100644 --- a/arch/x86/include/uapi/asm/kvm.h +++ b/arch/x86/include/uapi/asm/kvm.h @@ -743,6 +743,7 @@ enum sev_cmd_id { KVM_SEV_SNP_LAUNCH_START =3D 100, KVM_SEV_SNP_LAUNCH_UPDATE, KVM_SEV_SNP_LAUNCH_FINISH, + KVM_SEV_SNP_HV_REPORT_REQ, =20 KVM_SEV_NR_MAX, }; @@ -871,6 +872,14 @@ struct kvm_sev_receive_update_data { __u32 pad2; }; =20 +struct kvm_sev_snp_hv_report_req { + __u64 report_uaddr; + __u64 report_len; + __u8 key_sel; + __u8 pad0[7]; + __u64 pad1[4]; +}; + struct kvm_sev_snp_launch_start { __u64 policy; __u8 gosvw[16]; diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index f59c65abe3cf..ba7a07d132ff 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -2261,6 +2261,63 @@ static int snp_launch_start(struct kvm *kvm, struct = kvm_sev_cmd *argp) return rc; } =20 +static int sev_snp_hv_report_request(struct kvm *kvm, struct kvm_sev_cmd *= argp) +{ + struct sev_data_snp_msg_report_rsp *report_rsp =3D NULL; + struct sev_data_snp_hv_report_req data; + struct kvm_sev_snp_hv_report_req params; + struct kvm_sev_info *sev =3D to_kvm_sev_info(kvm); + void __user *u_report; + void __user *u_params =3D u64_to_user_ptr(argp->data); + size_t rsp_size =3D sizeof(*report_rsp); + int ret; + + if (!sev_snp_guest(kvm)) + return -ENOTTY; + if (copy_from_user(¶ms, u_params, sizeof(params))) + return -EFAULT; + + if (params.report_len < rsp_size) + return -ENOSPC; + + u_report =3D u64_to_user_ptr(params.report_uaddr); + if (!u_report) + return -EINVAL; + + report_rsp =3D snp_alloc_firmware_page(GFP_KERNEL_ACCOUNT | __GFP_ZERO); + if (!report_rsp) + return -ENOMEM; + + data.len =3D sizeof(data); + data.key_sel =3D params.key_sel; + data.gctx_addr =3D __psp_pa(sev->snp_context); + data.hv_report_paddr =3D __psp_pa(report_rsp); + + ret =3D sev_issue_cmd(kvm, SEV_CMD_SNP_HV_REPORT_REQ, &data, + &argp->error); + if (ret) + goto e_free_rsp; + + if (!report_rsp->status) + rsp_size +=3D report_rsp->report_size; + + if (params.report_len < rsp_size) { + rsp_size =3D sizeof(*report_rsp); + ret =3D -ENOSPC; + } + + if (copy_to_user(u_report, report_rsp, rsp_size)) + ret =3D -EFAULT; + + params.report_len =3D sizeof(*report_rsp) + report_rsp->report_size; + if (copy_to_user(u_params, ¶ms, sizeof(params))) + ret =3D -EFAULT; + +e_free_rsp: + snp_free_firmware_page(report_rsp); + return ret; +} + struct sev_gmem_populate_args { __u8 type; int sev_fd; @@ -2672,6 +2729,9 @@ int sev_mem_enc_ioctl(struct kvm *kvm, void __user *a= rgp) case KVM_SEV_SNP_LAUNCH_FINISH: r =3D snp_launch_finish(kvm, &sev_cmd); break; + case KVM_SEV_SNP_HV_REPORT_REQ: + r =3D sev_snp_hv_report_request(kvm, &sev_cmd); + break; default: r =3D -EINVAL; goto out; diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 956ea609d0cc..5dd7c3f0d50d 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -259,6 +259,7 @@ static int sev_cmd_buffer_len(int cmd) case SEV_CMD_SNP_COMMIT: return sizeof(struct sev_data_snp_commit); case SEV_CMD_SNP_FEATURE_INFO: return sizeof(struct sev_data_snp_feature= _info); case SEV_CMD_SNP_VLEK_LOAD: return sizeof(struct sev_user_data_snp_vlek_= load); + case SEV_CMD_SNP_HV_REPORT_REQ: return sizeof(struct sev_data_snp_hv_rep= ort_req); default: return sev_tio_cmd_buffer_len(cmd); } =20 diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index 69ffa4b4d1fa..c651a400d124 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -124,6 +124,7 @@ enum sev_cmd { SEV_CMD_SNP_GCTX_CREATE =3D 0x093, SEV_CMD_SNP_GUEST_REQUEST =3D 0x094, SEV_CMD_SNP_ACTIVATE_EX =3D 0x095, + SEV_CMD_SNP_HV_REPORT_REQ =3D 0x096, SEV_CMD_SNP_LAUNCH_START =3D 0x0A0, SEV_CMD_SNP_LAUNCH_UPDATE =3D 0x0A1, SEV_CMD_SNP_LAUNCH_FINISH =3D 0x0A2, @@ -594,6 +595,36 @@ struct sev_data_attestation_report { u32 len; /* In/Out */ } __packed; =20 +/** + * struct sev_data_snp_hv_report_req - SNP_HV_REPORT_REQ command params + * + * @len: length of the command buffer in bytes + * @key_sel: Selects which key to use for generating the signature. + * @gctx_addr: System physical address of guest context page + * @hv_report_paddr: System physical address where MSG_EXPORT_RSP will be = written + */ +struct sev_data_snp_hv_report_req { + u32 len; /* In */ + u32 key_sel :2, /* In */ + rsvd :30; + u64 gctx_addr; /* In */ + u64 hv_report_paddr; /* In */ +} __packed; + +/** + * struct sev_data_snp_msg_export_rsp + * + * @status: Status : 0h: Success. 16h: Invalid parameters. + * @report_size: Size in bytes of the attestation report + * @report: attestation report + */ +struct sev_data_snp_msg_report_rsp { + u32 status; /* Out */ + u32 report_size; /* Out */ + u8 rsvd[24]; + u8 report[]; +} __packed; + /** * struct sev_data_snp_download_firmware - SNP_DOWNLOAD_FIRMWARE command p= arams * --=20 2.52.0