From nobody Wed Dec 17 00:07:48 2025 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFE8E3164BD; Mon, 15 Dec 2025 10:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.61.82.184 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765795151; cv=none; b=mIA1y5/vMbSWbEEWH5FpFlx6wX1puMCopbqRknFmqu+qY8i017IOJD7AmnEoE7rs4rY7y9+kvD7BoJh2+cG4qY4GjwIRrhLZFZOdtnBYP14JVGyNlpu7CYB2LMoIYsVhi6Yqsgm3FlldkSGIcZrXKhAQiB13mJbZM8U9yUjr6EQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765795151; c=relaxed/simple; bh=Vt2JfkmO0mYcFcvjJqqVNwNLlfwaH65yrX0bhgj6nTI=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=eCys231tmaP8xouAjWMT5LAQSOGuMfxkEhawooJtuJOR+ga6/pTFQejMCuOKlGyyW2L9jT1hZyBOB6EhsSsx7golr/bqR0QFHIGj/HjEanLX1pehbkEorfsaL3Q6OTxL9sKkhn85McjbVMRepwDVAkwCiYTwfTUYc+8yeKWn7jg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com; spf=pass smtp.mailfrom=mediatek.com; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b=QNcdR6eL; arc=none smtp.client-ip=210.61.82.184 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=mediatek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mediatek.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="QNcdR6eL" X-UUID: 446d9e28d9a211f0b33aeb1e7f16c2b6-20251215 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=7XaRLbBJhSEUDHmd2FnN+oJUsUUjUDK/6biwWL7Eots=; b=QNcdR6eL+kQirLta076bPuKRIaKsBrLuei843dKjry65dCwifq+6fNuevpCV3MafIsK9QWRDuRvZ6zgHgRFULE7fUF6MO19ZFyXSN8SMkTkA1lNT9FDYEeDjUCD3FuVMVGAOYJH6ZYK1y59/A2NeIV1ewWmveI181XFsR+hnmRY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:3a5fc7e5-fa8b-4166-bd5c-cb8f3d95daff,IP:0,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:0 X-CID-META: VersionHash:a9d874c,CLOUDID:a8d474c6-8a73-4871-aac2-7b886d064f36,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102|836|888|898,TC:-5,Content:0|15|5 0,EDM:-3,IP:nil,URL:0,File:130,RT:0,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OS A:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 446d9e28d9a211f0b33aeb1e7f16c2b6-20251215 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 901118016; Mon, 15 Dec 2025 18:39:00 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by MTKMBS09N1.mediatek.inc (172.21.101.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 15 Dec 2025 18:38:58 +0800 Received: from mtksitap99.mediatek.inc (10.233.130.16) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.2562.29 via Frontend Transport; Mon, 15 Dec 2025 18:38:58 +0800 From: 20190311120055 created To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , "Matthias Brugger" , AngeloGioacchino Del Regno CC: , , , , , , , , Payne Lin Subject: [PATCH] pwm: mediatek: Add error handling for zero rate in PWM state Date: Mon, 15 Dec 2025 18:38:47 +0800 Message-ID: <20251215103855.3099184-1-payne.lin@mediatek.com> X-Mailer: git-send-email 2.45.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MTK: N Content-Type: text/plain; charset="utf-8" From: Payne Lin Added a check to handle cases where the rate is zero in the mtk_disp_pwm_get_state function. This prevents division by zero errors when calculating the period. - Added error message for zero rate scenario Signed-off-by: Payne Lin --- drivers/pwm/pwm-mtk-disp.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c index bafd6b6195f6..dd0ae041af70 100644 --- a/drivers/pwm/pwm-mtk-disp.c +++ b/drivers/pwm/pwm-mtk-disp.c @@ -176,19 +176,18 @@ static int mtk_disp_pwm_get_state(struct pwm_chip *ch= ip, struct mtk_disp_pwm *mdp =3D to_mtk_disp_pwm(chip); u64 rate, period, high_width; u32 clk_div, pwm_en, con0, con1; - int err; + int ret; =20 - err =3D clk_prepare_enable(mdp->clk_main); - if (err < 0) { - dev_err(pwmchip_parent(chip), "Can't enable mdp->clk_main: %pe\n", ERR_P= TR(err)); - return err; + ret =3D clk_prepare_enable(mdp->clk_main); + if (ret < 0) { + dev_err(pwmchip_parent(chip), "Can't enable mdp->clk_main: %pe\n", ERR_P= TR(ret)); + goto err_handle; } =20 - err =3D clk_prepare_enable(mdp->clk_mm); - if (err < 0) { - dev_err(pwmchip_parent(chip), "Can't enable mdp->clk_mm: %pe\n", ERR_PTR= (err)); - clk_disable_unprepare(mdp->clk_main); - return err; + ret =3D clk_prepare_enable(mdp->clk_mm); + if (ret < 0) { + dev_err(pwmchip_parent(chip), "Can't enable mdp->clk_mm: %pe\n", ERR_PTR= (ret)); + goto err_disable_clk_main; } =20 /* @@ -212,15 +211,23 @@ static int mtk_disp_pwm_get_state(struct pwm_chip *ch= ip, * period has 12 bits, clk_div 11 and NSEC_PER_SEC has 30, * so period * (clk_div + 1) * NSEC_PER_SEC doesn't overflow. */ + if (rate =3D=3D 0) { + dev_err(pwmchip_parent(chip), "rate is zero, cannot calculate period\n"); + ret =3D -EINVAL; + goto err_disable_clk_mm; + } state->period =3D DIV64_U64_ROUND_UP(period * (clk_div + 1) * NSEC_PER_SE= C, rate); high_width =3D FIELD_GET(PWM_HIGH_WIDTH_MASK, con1); state->duty_cycle =3D DIV64_U64_ROUND_UP(high_width * (clk_div + 1) * NSE= C_PER_SEC, rate); state->polarity =3D PWM_POLARITY_NORMAL; + +err_disable_clk_mm: clk_disable_unprepare(mdp->clk_mm); +err_disable_clk_main: clk_disable_unprepare(mdp->clk_main); - - return 0; +err_handle: + return ret; } =20 static const struct pwm_ops mtk_disp_pwm_ops =3D { --=20 2.45.2