From nobody Mon Dec 15 23:27:05 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361B13321CE for ; Mon, 15 Dec 2025 08:50:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765788634; cv=none; b=PMsCr3mqRBFO5jlAula4lGiyGBJmFo+au8dgiIVxzdGDN3k9zmiB7Qels0MulljDFufjnU3PVo+GEahEYwbVF9RAKiKSMjW9s7MaioF1nCiwXP4jZgrWfudy3TeGnxzy9hKrkprsail7HBr2SB7sLU0zlAP+A5hiSM+KftUj7lA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765788634; c=relaxed/simple; bh=UNJhjhBfdgMb0hckhX2MFxw95f5+0F9VDFTwddpYTEE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jeyAaErda8d3m46au+u4b5tAOkqOQEwb+DAE1RR/FPCT0Ij+u0nXIDLAhpkN/4Y5atsgFggVARSQ8Tybg63Kt+MbayPPy7huQb9Z6X0WQ6/IMlAOYQsryJGFv1n77e8GuQG/bqH5Y1wQLwW2p3NCr/PpcoO4UmO9AojE21Mbiys= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F8PmiV8n; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F8PmiV8n" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7aa2170adf9so2495451b3a.0 for ; Mon, 15 Dec 2025 00:50:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765788631; x=1766393431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4cLICT+Xfx3iSAb03bNjdxgJ5nQ9eDd3fe2nx7UuqzU=; b=F8PmiV8n/GRwHprSfCViasNwFUV8VTbwNZ2Va7kQe9QOA3n9d/SnsuxG9rzJ3O7v56 2Y6WpgeBBFOZByZPd7ErRDo+aPgvEp+dcoS8qvKpbC6IUM+9NMzyTTQsN6fDv11gtHZR nV9lFG+aGTPwc1zAfOhJqcNHwoL9f8TRIMqK1TPZLuwZBWHqskKNlSpRLXg1ytamv2rA AlbF7FpilkAgZu085S2YlOb54Up6FvluLQHVE5J4Lbmowf1Ajy1l92cOw+Zqyz/i0a0Y 5N4PtxAVu5ke+5qbF9eZC+JRrvdt+mO6YdAq1t76i2W5j8EQ3U3hAZB3wPXOR2H6amon fzOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765788631; x=1766393431; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4cLICT+Xfx3iSAb03bNjdxgJ5nQ9eDd3fe2nx7UuqzU=; b=ieRy0pIbgqNOlVR8ZDTD2LWuY61p4x1QQEOJ0c+dNk08Jyti3GzssKSk8x4ss/x27U AWXmQJs5qgXyOoZmUqtgstAsY/moJYzNXI8Vm6R3zD6sVwv5+jxv1tmOXJxammgfOBYw vVVwc1bPBcm4vfAoybCM0Sgvr079RuUyTS+N+WgujHOgJuQ3ibFLe2twe/HUiELpd+B1 ylusCiBb/bZnmrtxCxToKdciWeh7UlGqHw2Uyx3faKEvLgIJVQWKhOHuXuI9XmoLlK2s OK3tmwxYn8EJwEPji2dnViuVprzRj6Bcz40hwrPdV9NZxcivjNU6SA2UDZgCEtwpLkTf C2Vw== X-Forwarded-Encrypted: i=1; AJvYcCVaLtsGU4ebl/Cbdte0vMrK/vRw3zA0QeY4F+IZLqO1TEmlTf3EO+ly/4qvs3/wRQf0JyY5l/sBcJ/wiCE=@vger.kernel.org X-Gm-Message-State: AOJu0YxN064fEByX7m2CKjOb0qnlgpPuzQBn92xTFnFpM9qKGey3sS00 O87iAtey6flJZUJ2DHERsmHkRIz5r6M6yH1GFYQU5mfMMl5UDqrp6R8F X-Gm-Gg: AY/fxX4G/YsjFRhfb+FAUP7E4Msj+vlLYpnSXeqUbdH3tH5PChrfNBze9nZW+aH9l4H UhBIoTeqsXUufu3rc7Nb3P8PWSqBxx66bH0Jh+9b7lFrbmIPoNyXiACUvnRMKtmLiu5AUM5aU5z fy+y7Zx8igT2HuFTp8qJCyZvtxhYnsWNd2eObaBFxStXigvUP8b0JnmPqjafgNkMgcUg7Y+9cfY VPB5BGFfMFjJsYU9LFU8hAE5uFtLZ9yXnJhBXtz/2rbfjfgKLVUwZtOSv+fRX39URwxtafv2GIu 0m7fDfdSmX+kzpg66UIfvpNpNiJhOlqzcOMPyoNosEeK0cyH/QH+OAIeXZXicljy1LDzafd/2ZW Opv/hqTnHEMq1/HaIoy/8ZXryXAJejNCXyrL4fsAeXaZugDxwt+bd2VcZEv9eKwJaqmb2wiK904 7yvF3pjMiMStFpqMZ91xwKvwnbBldt+V8TOgY= X-Google-Smtp-Source: AGHT+IHkiONbozf9pjfNVTzEsjplZ/PllBupKMp54qcU+ah02z/Rx4CDnQ/3DyFEalYJchKrsKO91w== X-Received: by 2002:a05:6a00:4510:b0:7e8:43f5:bd44 with SMTP id d2e1a72fcca58-7f6696a3da1mr9612737b3a.48.1765788631390; Mon, 15 Dec 2025 00:50:31 -0800 (PST) Received: from clint-ThinkPad-L14-Gen-2.. ([110.226.180.190]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c4e9d9e3sm11976334b3a.45.2025.12.15.00.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Dec 2025 00:50:30 -0800 (PST) From: Clint George To: ming.lei@redhat.com, skhan@linuxfoundation.org Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, david.hunter.linux@gmail.com, linux-kernel-mentees@lists.linux.dev, khalid@kernel.org, Clint George Subject: [PATCH] kselftest/kublk: include message in _Static_assert for C11 compatibility Date: Mon, 15 Dec 2025 14:20:22 +0530 Message-ID: <20251215085022.7642-1-clintbgeorge@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add descriptive message in the _Static_assert to comply with the C11 standard requirement to prevent compiler from throwing out error. The compiler throws an error when _Static_assert is used without a message as that is a C23 extension. Signed-off-by: Clint George --- [] Testing: The diff between before and after of running the kselftest test of the module shows no regression on system with x86 architecture Let me know if any more testing is needed to be done [] Error log: ~/Desktop/kernel-dev/linux-v1/tools/testing/selftests/ublk$ make LLVM=3D1 W= =3D1 CC kublk In file included from kublk.c:6: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. In file included from null.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. In file included from file_backed.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. In file included from common.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. In file included from stripe.c:3: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. In file included from fault_inject.c:11: ./kublk.h:220:43: error: '_Static_assert' with no message is a C23 extensio= n [-Werror,-Wc23-extensions] 220 | _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); | ^ | , "" 1 error generated. make: *** [../lib.mk:225: /home/clint/Desktop/kernel-dev/linux-v1/tools/tes= ting/selftests/ublk/kublk] Error 1 tools/testing/selftests/ublk/kublk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests= /ublk/kublk.h index fe42705c6..e5eb5f762 100644 --- a/tools/testing/selftests/ublk/kublk.h +++ b/tools/testing/selftests/ublk/kublk.h @@ -217,7 +217,7 @@ static inline __u64 build_user_data(unsigned tag, unsig= ned op, unsigned tgt_data, unsigned q_id, unsigned is_target_io) { /* we only have 7 bits to encode q_id */ - _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7); + _Static_assert(UBLK_MAX_QUEUES_SHIFT <=3D 7, "UBLK_MAX_QUEUES_SHIFT must = be <=3D 7"); assert(!(tag >> 16) && !(op >> 8) && !(tgt_data >> 16) && !(q_id >> 7)); =20 return tag | (op << 16) | (tgt_data << 24) | --=20 2.43.0