From nobody Thu Dec 18 13:40:51 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688EC29E0F6; Mon, 15 Dec 2025 01:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765762990; cv=none; b=I5SM2RJ3JhHKIJApWqPislPAb8OmM9qIdcmgTBDN65+JMI57fGkZnxaR8ewDNZjqG5CwCy5X+uGkuGHzLm1HuxUY1Cuwn/UyLHPkOZKP2ZmHdiKe2U5EznuvLZs1EvJ12cmN3ddeLDER3xDQrF2n5WW20pWAaAgP45Xq5OaHEXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765762990; c=relaxed/simple; bh=A3TSK9J85pbNRB7/61xFX+IxlSgMX2hqlE7LuvPpJ9g=; h=From:To:Cc:Subject:Date:Message-Id; b=g8yro3IY4cw3wUdQdrKDCvhi39tQg4Po9nqVuq5+g/T5EbfFzkcdKbtjk1IZXC7BEAQKtOBFb7CQ2lIeuofa4VbUx0N/iIZs6NelamZGiQWOgplFxS16L7q+c+AmmaZUPFhW2naOymeMckDORQGx34hZcmNxB7VJHpbNGYki22k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [202.112.113.212]) by APP-01 (Coremail) with SMTP id qwCowAC3XmqaZz9pqXmyAA--.23198S2; Mon, 15 Dec 2025 09:42:57 +0800 (CST) From: Ma Ke To: peter.ujfalusi@gmail.com, vkoul@kernel.org Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Ma Ke , stable@vger.kernel.org Subject: [PATCH RESEND] dmaengine: ti-dma-crossbar: Fix error handling in ti_am335x_xbar_route_allocate Date: Mon, 15 Dec 2025 09:42:49 +0800 Message-Id: <20251215014249.11495-1-make24@iscas.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: qwCowAC3XmqaZz9pqXmyAA--.23198S2 X-Coremail-Antispam: 1UD129KBjvJXoWxWr4ktrWfGr18JrWxWF48JFb_yoW5XFyUpa y8Ga4Yv395KF1Ig34rCw4UuFWakr4Fqa1agrWxC340kwnIqryjqrW5Ja40qr1Yyr97JF4D XF17tr4rCFy7urUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9m14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWlnxkEFVAIw20F6cxK64vIFxWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I 648v4I1lc7CjxVAaw2AFwI0_JF0_Jw1lc2xSY4AK67AK6w4l42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8I cIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r 1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x0JUk9NsUUUUU= X-CM-SenderInfo: ppdnvj2u6l2u1dvotugofq/ Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" ti_am335x_xbar_route_allocate() calls of_find_device_by_node() which increments the reference count of the platform device, but fails to call put_device() to decrement the reference count before returning. This could cause a reference count leak each time the function is called, preventing the platform device from being properly cleaned up and leading to memory leakage. Add proper put_device() calls in all exit paths to fix the reference count imbalance. Found by code review. Cc: stable@vger.kernel.org Fixes: 42dbdcc6bf96 ("dmaengine: ti-dma-crossbar: Add support for crossbar = on AM33xx/AM43xx") Signed-off-by: Ma Ke --- drivers/dma/ti/dma-crossbar.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c index 7f17ee87a6dc..58bc515ec8b3 100644 --- a/drivers/dma/ti/dma-crossbar.c +++ b/drivers/dma/ti/dma-crossbar.c @@ -80,33 +80,40 @@ static void *ti_am335x_xbar_route_allocate(struct of_ph= andle_args *dma_spec, struct platform_device *pdev =3D of_find_device_by_node(ofdma->of_node); struct ti_am335x_xbar_data *xbar =3D platform_get_drvdata(pdev); struct ti_am335x_xbar_map *map; + int ret; =20 - if (dma_spec->args_count !=3D 3) - return ERR_PTR(-EINVAL); + if (dma_spec->args_count !=3D 3) { + ret =3D -EINVAL; + goto err_put_device; + } =20 if (dma_spec->args[2] >=3D xbar->xbar_events) { dev_err(&pdev->dev, "Invalid XBAR event number: %d\n", dma_spec->args[2]); - return ERR_PTR(-EINVAL); + ret =3D -EINVAL; + goto err_put_device; } =20 if (dma_spec->args[0] >=3D xbar->dma_requests) { dev_err(&pdev->dev, "Invalid DMA request line number: %d\n", dma_spec->args[0]); - return ERR_PTR(-EINVAL); + ret =3D -EINVAL; + goto err_put_device; } =20 /* The of_node_put() will be done in the core for the node */ dma_spec->np =3D of_parse_phandle(ofdma->of_node, "dma-masters", 0); if (!dma_spec->np) { dev_err(&pdev->dev, "Can't get DMA master\n"); - return ERR_PTR(-EINVAL); + ret =3D -EINVAL; + goto err_put_device; } =20 map =3D kzalloc(sizeof(*map), GFP_KERNEL); if (!map) { of_node_put(dma_spec->np); - return ERR_PTR(-ENOMEM); + ret =3D -ENOMEM; + goto err_put_device; } =20 map->dma_line =3D (u16)dma_spec->args[0]; @@ -120,7 +127,12 @@ static void *ti_am335x_xbar_route_allocate(struct of_p= handle_args *dma_spec, =20 ti_am335x_xbar_write(xbar->iomem, map->dma_line, map->mux_val); =20 + put_device(&pdev->dev); return map; + +err_put_device: + put_device(&pdev->dev); + return ERR_PTR(ret); } =20 static const struct of_device_id ti_am335x_master_match[] __maybe_unused = =3D { --=20 2.17.1