From nobody Tue Dec 16 08:51:45 2025
Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com
 [209.85.167.49])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72E6D314B9A
	for <linux-kernel@vger.kernel.org>; Mon, 15 Dec 2025 09:47:49 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
 arc=none smtp.client-ip=209.85.167.49
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1765792071; cv=none;
 b=FIwbEue5eE/3pLB8ExAcDahZqAOwKvkMudN1D1OFR/QC0Dmkiq4sgTiwk+5qshIE8OSE7C3QAeNaUUJ6Amw3hmNN8ZfafH9MTIB7+J8meKu+aUTQY7DKwgmut46SUswMfeFJJ7ZfaGGgsMX5zrAqKXYHZcIkXVw5a2K3H6RzveQ=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1765792071; c=relaxed/simple;
	bh=fzBEes00MA8LplTokptIrEwWvt/TkrtTz8Xr/mXVBf0=;
	h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:
	 In-Reply-To:To:Cc;
 b=WI4QZelR49oOtV1Q8t4gxA2G6FnKc4O1pXgcMi+oPd75uytmYAiEpfHYwaAy/nx2dLYYGWZyquIik3O4eRzsfef93dLX8H3C+60Ii2JXwvBHQ8OioK5anTqv3fqquM6EK4cv6zSQu0YdObMcdqI7gJiR4uaZR9Qi2cH7JlhiuyQ=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com;
 spf=pass smtp.mailfrom=gmail.com;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b=jFfYeZNI; arc=none smtp.client-ip=209.85.167.49
Authentication-Results: smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
 spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="jFfYeZNI"
Received: by mail-lf1-f49.google.com with SMTP id
 2adb3069b0e04-5958232f806so3780054e87.0
        for <linux-kernel@vger.kernel.org>;
 Mon, 15 Dec 2025 01:47:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20230601; t=1765792068; x=1766396868;
 darn=vger.kernel.org;
        h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
         :mime-version:subject:date:from:from:to:cc:subject:date:message-id
         :reply-to;
        bh=iHh21ATHzk36Wyf37xfOj1ULk6gBmqRm9g0siGaoNDM=;
        b=jFfYeZNIjOmA9tvjyXIQH6Sbf2SaCO+mPnTlMeUzCRqJZj97YERnxhA0+tllO81SYb
         Bk+ZhfjD4ehdvA/q0lLtU8sDn3obq4Q1iUfHbAjfyrt8K8jR7x7ozAvBR7w9mactxzJL
         7BidpqHDItxZ5cghyy+HV63D0uZVVyPRrIvfNsKpWpsYm+UOk9YHaHhS8N113/qwNPkY
         COFs7orn+nUh1sA/5Ls7EGUkCHGvd3Qzig7tjF9aF3Fzb0pOUk+2tWp8HVKRM6oZRJHQ
         q+febJ3qs/D7SUC2+j7csQR4wBG+Qsv9D5lvpclCwaU1fn3I3vWCWXtmNq+p9+A6j83E
         v9/Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20230601; t=1765792068; x=1766396868;
        h=cc:to:in-reply-to:references:message-id:content-transfer-encoding
         :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to
         :cc:subject:date:message-id:reply-to;
        bh=iHh21ATHzk36Wyf37xfOj1ULk6gBmqRm9g0siGaoNDM=;
        b=eYeu/Qx0c0GzpOYOE3ttamLfqSDih/OPOuXojnuRoVIIEhrXhEtEIrvFvFg2z8usx6
         Cz83gYZCklz0HnM/EsxajTH4XRGZgplxzSdpoPROuRGNLr9O0mInUe4N+zmmwRXcilDf
         mOpOnLlF5lRG+y/RrpkCMIN4u66i4kVAFOg8FP377it8F5rW7kXtz/JS6qUJVN1orOW+
         RKLua6JFbDJPqZaaJc9IWGn/ApeSvlBFz+kzqZLBZNjBaFYBKeYCLbJ9WA/s5EDfVZ3e
         OgpSJ8RCN9GQcdiL4j9vC2dQ9AZxJuoUxSHMaNzkjNws/JFL+nVj2dcRxo7ezbA17WPX
         cyzw==
X-Forwarded-Encrypted: i=1;
 AJvYcCXWlDTf7ioKwvzx/JE2tjBAEtIyMq/J79ls7P93+u8P0ExF9vH1yKLjKIRNomBI6hdzBL9A3WmJADK0PoQ=@vger.kernel.org
X-Gm-Message-State: AOJu0YwiLJOAKC+JhVHxa76ramr3HLXK1MHQEvhuQWyOeCDyGF66jOXU
	tWqolrlpTMtlcbivHX+t5znHaP15yw9XTZVenOtRMjlV5spyWfuE4DrM
X-Gm-Gg: AY/fxX6dkSlgaZ8mcrrkVlVqHW3Np/LURhg5VbMdKQqKDrPMAveSHdiHK/fmyED4oPc
	N4y3/Jzyvb5KEjK+ovuJz0DCDQYhN/oP63UJgLL5ooljArN1oDm4JUPSqfOGCgPqIbs+BEVAAnW
	4iW4CgvWwdmq9XtZ7A6UNlTRgVZkFkXqa0N5CjiZwHAlQG7AOJiGkOFlK8m42XTTpGL0aP2eUHs
	jLV3lI2eus3KwJSHsqY2Mv2h9VDTiZu27p0sAnJG6ZaAjJfR6moFpKnIZmQVd+5Jjey141UDref
	MrPg3RKAvVj7VEuUhUcgM7UEl1UWQFUddXDt5hblfskB2TPgmLhKuxEHgRXzaoGy3vT5Tg/eLsg
	BbgiWVg5VThIsK+/Uv1ATs+gXNgILE1PyLyOl1E/kKy19KcFWub+Q3Fqn5uu2yF+S5xerAbvvUs
	cs2wLSpLWLI66smJB+Y9jhm1f4NEnshtX0HOf6QtBB0ipt6xflalm9Vln2
X-Google-Smtp-Source: 
 AGHT+IFPRH7innrMJDrIBL4kUCc67yQcJ0xezI294PNWWxsE6ABkREGAsZxyrbhIxSCXQYYuz+Mw7w==
X-Received: by 2002:a05:6512:3d03:b0:594:5000:4554 with SMTP id
 2adb3069b0e04-598faa3bac4mr3067488e87.28.1765792067276;
        Mon, 15 Dec 2025 01:47:47 -0800 (PST)
Received: from [192.168.1.168] (83-233-6-197.cust.bredband2.com.
 [83.233.6.197])
        by smtp.gmail.com with ESMTPSA id
 2adb3069b0e04-598f2f37ae8sm5397546e87.15.2025.12.15.01.47.44
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Mon, 15 Dec 2025 01:47:45 -0800 (PST)
From: Marcus Folkesson <marcus.folkesson@gmail.com>
Date: Mon, 15 Dec 2025 10:46:45 +0100
Subject: [PATCH v3 3/7] drm/sitronix/st7571-i2c: move common structures to
 st7571.h
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Message-Id: <20251215-st7571-split-v3-3-d5f3205c3138@gmail.com>
References: <20251215-st7571-split-v3-0-d5f3205c3138@gmail.com>
In-Reply-To: <20251215-st7571-split-v3-0-d5f3205c3138@gmail.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
 Javier Martinez Canillas <javierm@redhat.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org, Marcus Folkesson <marcus.folkesson@gmail.com>
X-Mailer: b4 0.14.3
X-Developer-Signature: v=1; a=openpgp-sha256; l=7782;
 i=marcus.folkesson@gmail.com; h=from:subject:message-id;
 bh=fzBEes00MA8LplTokptIrEwWvt/TkrtTz8Xr/mXVBf0=;
 b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBpP9km3U49gakwF/cCdgbYFAuN3Z1+w8fidRrzZ
 ZRX7slrryGJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaT/ZJgAKCRCIgE5vWV1S
 MoRWEAClYp/jOJbpjy1iAIya7dVS0NnxRM41MMyeA2E93KC5T2NEkuTvm1iNvrrcIfEMsumhXE7
 6RpFCVKxMO8qQn3IDJWOGL1axYfsNOwRx0u5VONxS3+hZZ1dOSBpEkdDgq56X8BDiFOHtVxU5EV
 72DmNmAC/lsIYrQHMxnUms4HiLWlTtUVN6gSYMRsIZrUD3i0N4ut+WqAKCFoepTEyEZhzf5q/63
 b2G614AKz/i7AbtPcKL19iiPrK7V8IE3uenD5xrauwBWTsS6gkWN0pX0j3TGRHsV8zYebo2fwo6
 UBlDBbEZ2o13W8MolP0IOhouQzOAojDmCVnZybLoK74D5x4ZgzVTBNJDiEBdaM0MD8GiE+FUCRv
 neMYrG6uXqRSZZqm1+T5De0BiilSgB+egPSKIjjqYuPrx2tX5GK4vDcPBDRLCZar2oQvfGAhY3q
 ikGWgbtm0+XaxVsJ8ddX6hOt4k8rr9LzT6rG7kt61jqZ6/lOhOc6eZ95h/LTaXubpo2lIYeW9Fb
 8dW6iOhtO1qceYRYtI51GLtr3nlGuj/4Z2QCYjf6U5lnu0a+5fjAfi6qwDh+wyDfsvmlxGWgoz4
 8IlJQGBViwZwmCq1EDAByP68jvWBycPFhXALZNNvHmQ74nl7S9moUSIVbdKc3y3g+hYks1H7XFg
 MJkpB3fFgJx7dag==
X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp;
 fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127

Move all structures that will be common for all interfaces (SPI/I2C) to
a separate header file.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
 MAINTAINERS                           |   1 +
 drivers/gpu/drm/sitronix/st7571-i2c.c |  91 +---------------------------
 drivers/gpu/drm/sitronix/st7571.h     | 108 ++++++++++++++++++++++++++++++=
++++
 3 files changed, 111 insertions(+), 89 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index c830fd648572..ac4293d5089c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8106,6 +8106,7 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/display/sitronix,st7567.yaml
 F:	Documentation/devicetree/bindings/display/sitronix,st7571.yaml
 F:	drivers/gpu/drm/sitronix/st7571-i2c.c
+F:	drivers/gpu/drm/sitronix/st7571.h
=20
 DRM DRIVER FOR SITRONIX ST7701 PANELS
 M:	Jagan Teki <jagan@amarulasolutions.com>
diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitron=
ix/st7571-i2c.c
index 2b52919d7dd4..af27658a5e15 100644
--- a/drivers/gpu/drm/sitronix/st7571-i2c.c
+++ b/drivers/gpu/drm/sitronix/st7571-i2c.c
@@ -35,6 +35,8 @@
 #include <video/display_timing.h>
 #include <video/of_display_timing.h>
=20
+#include "st7571.h"
+
 #define ST7571_COMMAND_MODE			(0x00)
 #define ST7571_DATA_MODE			(0x40)
=20
@@ -78,95 +80,6 @@
 #define DRIVER_MAJOR 1
 #define DRIVER_MINOR 0
=20
-enum st7571_color_mode {
-	ST7571_COLOR_MODE_GRAY =3D 0,
-	ST7571_COLOR_MODE_BLACKWHITE =3D 1,
-};
-
-struct st7571_device;
-
-struct st7571_panel_constraints {
-	u32 min_nlines;
-	u32 max_nlines;
-	u32 min_ncols;
-	u32 max_ncols;
-	bool support_grayscale;
-};
-
-struct st7571_panel_data {
-	int (*init)(struct st7571_device *st7571);
-	int (*parse_dt)(struct st7571_device *st7571);
-	struct st7571_panel_constraints constraints;
-};
-
-struct st7571_panel_format {
-	void (*prepare_buffer)(struct st7571_device *st7571,
-			       const struct iosys_map *vmap,
-			       struct drm_framebuffer *fb,
-			       struct drm_rect *rect,
-			       struct drm_format_conv_state *fmtcnv_state);
-	int (*update_rect)(struct drm_framebuffer *fb, struct drm_rect *rect);
-	enum st7571_color_mode mode;
-	const u8 nformats;
-	const u32 formats[];
-};
-
-struct st7571_device {
-	struct drm_device drm;
-	struct device *dev;
-
-	struct drm_plane primary_plane;
-	struct drm_crtc crtc;
-	struct drm_encoder encoder;
-	struct drm_connector connector;
-
-	struct drm_display_mode mode;
-
-	const struct st7571_panel_format *pformat;
-	const struct st7571_panel_data *pdata;
-	struct i2c_client *client;
-	struct gpio_desc *reset;
-	struct regmap *regmap;
-
-	/*
-	 * Depending on the hardware design, the acknowledge signal may be hard to
-	 * recognize as a valid logic "0" level.
-	 * Therefor, ignore NAK if possible to stay compatible with most hardware=
 designs
-	 * and off-the-shelf panels out there.
-	 *
-	 * From section 6.4 MICROPOCESSOR INTERFACE section in the datasheet:
-	 *
-	 * "By connecting SDA_OUT to SDA_IN externally, the SDA line becomes fully
-	 * I2C interface compatible.
-	 * Separating acknowledge-output from serial data
-	 * input is advantageous for chip-on-glass (COG) applications. In COG
-	 * applications, the ITO resistance and the pull-up resistor will form a
-	 * voltage  divider, which affects acknowledge-signal level. Larger ITO
-	 * resistance will raise the acknowledged-signal level and system cannot
-	 * recognize this level as a valid logic =E2=80=9C0=E2=80=9D level. By se=
parating SDA_IN from
-	 * SDA_OUT, the IC can be used in a mode that ignores the acknowledge-bit.
-	 * For applications which check acknowledge-bit, it is necessary to minim=
ize
-	 * the ITO resistance of the SDA_OUT trace to guarantee a valid low level=
."
-	 *
-	 */
-	bool ignore_nak;
-
-	bool grayscale;
-	bool inverted;
-	u32 height_mm;
-	u32 width_mm;
-	u32 startline;
-	u32 nlines;
-	u32 ncols;
-	u32 bpp;
-
-	/* Intermediate buffer in LCD friendly format */
-	u8 *hwbuf;
-
-	/* Row of (transformed) pixels ready to be written to the display */
-	u8 *row;
-};
-
 static inline struct st7571_device *drm_to_st7571(struct drm_device *drm)
 {
 	return container_of(drm, struct st7571_device, drm);
diff --git a/drivers/gpu/drm/sitronix/st7571.h b/drivers/gpu/drm/sitronix/s=
t7571.h
new file mode 100644
index 000000000000..c6fd6f1d3aa3
--- /dev/null
+++ b/drivers/gpu/drm/sitronix/st7571.h
@@ -0,0 +1,108 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Header file for:
+ * Driver for Sitronix ST7571, a 4 level gray scale dot matrix LCD control=
ler
+ *
+ * Copyright (C) 2025 Marcus Folkesson <marcus.folkesson@gmail.com>
+ */
+
+#ifndef __ST7571_H__
+#define __ST7571_H__
+
+#include <drm/drm_connector.h>
+#include <drm/drm_crtc.h>
+#include <drm/drm_drv.h>
+#include <drm/drm_encoder.h>
+
+#include <linux/regmap.h>
+
+enum st7571_color_mode {
+	ST7571_COLOR_MODE_GRAY =3D 0,
+	ST7571_COLOR_MODE_BLACKWHITE =3D 1,
+};
+
+struct st7571_device;
+
+struct st7571_panel_constraints {
+	u32 min_nlines;
+	u32 max_nlines;
+	u32 min_ncols;
+	u32 max_ncols;
+	bool support_grayscale;
+};
+
+struct st7571_panel_data {
+	int (*init)(struct st7571_device *st7571);
+	int (*parse_dt)(struct st7571_device *st7571);
+	struct st7571_panel_constraints constraints;
+};
+
+struct st7571_panel_format {
+	void (*prepare_buffer)(struct st7571_device *st7571,
+			       const struct iosys_map *vmap,
+			       struct drm_framebuffer *fb,
+			       struct drm_rect *rect,
+			       struct drm_format_conv_state *fmtcnv_state);
+	int (*update_rect)(struct drm_framebuffer *fb, struct drm_rect *rect);
+	enum st7571_color_mode mode;
+	const u8 nformats;
+	const u32 formats[];
+};
+
+struct st7571_device {
+	struct drm_device drm;
+	struct device *dev;
+
+	struct drm_plane primary_plane;
+	struct drm_crtc crtc;
+	struct drm_encoder encoder;
+	struct drm_connector connector;
+
+	struct drm_display_mode mode;
+
+	const struct st7571_panel_format *pformat;
+	const struct st7571_panel_data *pdata;
+	struct i2c_client *client;
+	struct gpio_desc *reset;
+	struct regmap *regmap;
+
+	/*
+	 * Depending on the hardware design, the acknowledge signal may be hard to
+	 * recognize as a valid logic "0" level.
+	 * Therefor, ignore NAK if possible to stay compatible with most hardware=
 designs
+	 * and off-the-shelf panels out there.
+	 *
+	 * From section 6.4 MICROPOCESSOR INTERFACE section in the datasheet:
+	 *
+	 * "By connecting SDA_OUT to SDA_IN externally, the SDA line becomes fully
+	 * I2C interface compatible.
+	 * Separating acknowledge-output from serial data
+	 * input is advantageous for chip-on-glass (COG) applications. In COG
+	 * applications, the ITO resistance and the pull-up resistor will form a
+	 * voltage  divider, which affects acknowledge-signal level. Larger ITO
+	 * resistance will raise the acknowledged-signal level and system cannot
+	 * recognize this level as a valid logic =E2=80=9C0=E2=80=9D level. By se=
parating SDA_IN from
+	 * SDA_OUT, the IC can be used in a mode that ignores the acknowledge-bit.
+	 * For applications which check acknowledge-bit, it is necessary to minim=
ize
+	 * the ITO resistance of the SDA_OUT trace to guarantee a valid low level=
."
+	 *
+	 */
+	bool ignore_nak;
+
+	bool grayscale;
+	bool inverted;
+	u32 height_mm;
+	u32 width_mm;
+	u32 startline;
+	u32 nlines;
+	u32 ncols;
+	u32 bpp;
+
+	/* Intermediate buffer in LCD friendly format */
+	u8 *hwbuf;
+
+	/* Row of (transformed) pixels ready to be written to the display */
+	u8 *row;
+};
+
+#endif /* __ST7571_H__ */

--=20
2.51.2