From nobody Sun Feb 8 04:33:50 2026 Received: from smtp-42a8.mail.infomaniak.ch (smtp-42a8.mail.infomaniak.ch [84.16.66.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FE5F3491DE for ; Mon, 15 Dec 2025 16:55:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.16.66.168 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765817715; cv=none; b=KpMljMdXC2NiQ2ysO61WB/LuZzmiAgEErWvY1cj03/a3UxkbxIe8k33jcA58uIayBDs3fmb+4ex8TcsMuzD+QleOpumuwLDrlA2hAc3YVfeLb5wHOuKZhZ4OkH/arGB/5beuowTZh2zWLjCgOzoDW9L/wU0/X2/Kl6ZTWUI0+a8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765817715; c=relaxed/simple; bh=KnKjjGyy5oiElHceVx9Q+yjPqUm+QFl9fOYbN4GMrA0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=lhnmaVdNnPi47wkzgHjCUzDncL+NPrK23OlyDPfHzD8Jaioe+SiPeSHLEjwicgznEPH3hetJzvZKAomGAU/L5Ir9mcfwU9aLkUomQIlliKWi36A37UxCH3jiqY5V0JRZO6uEGClZmidqFfy3K7Jwn6tWlRHFd7eE29SusyD/kD8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0leil.net; spf=pass smtp.mailfrom=0leil.net; arc=none smtp.client-ip=84.16.66.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=0leil.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0leil.net Received: from smtp-3-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:4:17::246b]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4dVQtf6cv1zTkg; Mon, 15 Dec 2025 17:46:18 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4dVQtf0KpFz6NJ; Mon, 15 Dec 2025 17:46:17 +0100 (CET) From: Quentin Schulz Date: Mon, 15 Dec 2025 17:45:56 +0100 Subject: [PATCH] arm64: dts: rockchip: fix unit-address for RK3588 NPU's core1 and core2's IOMMU Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-npu-dt-node-address-v1-1-840093e8a2bf@cherry.de> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x3MQQqFMAxF0a1Ixj9giyK6FXFQzVMzqdLoRxD3b nF4BvfeZEgKo664KeGvplvMcL+CpjXEBaySTb70tfOu5rifLAfHTcBBJMGMm3FGGCsvAS3lck+ Y9fqu/fA8L8QN/89lAAAA X-Change-ID: 20251215-npu-dt-node-address-7bfeab42dae9 To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Tomeu Vizoso Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Quentin Schulz , stable@vger.kernel.org X-Mailer: b4 0.14.3 X-Infomaniak-Routing: alpha From: Quentin Schulz The Device Tree specification specifies[1] that """ Each node in the devicetree is named according to the following convention: node-name@unit-address [...] The unit-address must match the first address specified in the reg property of the node. """ The first address in the reg property is fdaXa000 and not fdaX9000. This is likely a copy-paste error as the IOMMU for core0 has two entries in the reg property, the first one being fdab9000 and the second fdaba000. Let's fix this oversight to match what the spec is expecting. [1] https://github.com/devicetree-org/devicetree-specification/releases/dow= nload/v0.4/devicetree-specification-v0.4.pdf 2.2.1 Node Names Fixes: a31dfc060a74 ("arm64: dts: rockchip: Add nodes for NPU and its MMU t= o rk3588-base") Cc: stable@vger.kernel.org Signed-off-by: Quentin Schulz --- arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boo= t/dts/rockchip/rk3588-base.dtsi index 2a79217930206..7ab12d1054a73 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi @@ -1200,7 +1200,7 @@ rknn_core_1: npu@fdac0000 { status =3D "disabled"; }; =20 - rknn_mmu_1: iommu@fdac9000 { + rknn_mmu_1: iommu@fdaca000 { compatible =3D "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; reg =3D <0x0 0xfdaca000 0x0 0x100>; interrupts =3D ; @@ -1230,7 +1230,7 @@ rknn_core_2: npu@fdad0000 { status =3D "disabled"; }; =20 - rknn_mmu_2: iommu@fdad9000 { + rknn_mmu_2: iommu@fdada000 { compatible =3D "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; reg =3D <0x0 0xfdada000 0x0 0x100>; interrupts =3D ; --- base-commit: a619746d25c8adafe294777cc98c47a09759b3ed change-id: 20251215-npu-dt-node-address-7bfeab42dae9 Best regards, --=20 Quentin Schulz