From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D57216E24; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; cv=none; b=SWB/EAJK9H3JM+sG81giGqRcLHd7QHq2V9r6/Zjaar1Gw1SgJoB5PCPpUIM/XqDn8Mec2zY2iqoDj/oZsEhvV26eyImjdxvfuZN2lDWsmXVZXG8gkpBVpcLiZyQxYFlXTJku1F+QBHGUY8eH/aqJAVi4NEZqsWhCKoVuL2r0zBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; c=relaxed/simple; bh=R9bOuEoZdBBKSqErNlPpPrfNLJ8IyPpF8i2bjBEJBZE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Woyd0jPe6WeQu3WeSA7WZ2YQZd4uxrtkCHkY/jdI6HuOSJ++4ALnoa8KJeTTSda1CYuU4kJjvZ7W/8chtAUOPGAPveVr3OAbKOHUl4dga2kw4pItgdaCJMZtZl6fA9OMff5rcqoOOeQji3ItsyrdUjCESgpTh63OUHXiO6EpGMU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s0w6JiAQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s0w6JiAQ" Received: by smtp.kernel.org (Postfix) with ESMTPS id 5054DC19421; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=R9bOuEoZdBBKSqErNlPpPrfNLJ8IyPpF8i2bjBEJBZE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=s0w6JiAQNS1gkX5Iq8v26Rud5bqgPOWFiUlAQh0/uccDp6Ng5/0GySj/6gTk04TgV KrMxyzuNFar8wHzvMBLzrLOQdO10wW3/kw2PRTMdO2toZh34Mz3f4ELhskYpSXjMpE XhiCD4dREgGVM2LeP+FkhXzItjZpmaU5ecM7jQJVV1lfJt18nMkryUtyZknPCO9dCt e7wTOkYAvHVs4ySEEUXwrKeTq2huQwAeoMdh0fmv9wyx5QBCgaH8Uq2Tjc5V9tHfmS nZLp30IxdJK9eKULur1bTKsGbfEOC/6fP+VKKLjHd4V5iru+74Pd8P84sgaVTxS1yo Q6NyX0UuO3C9Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A79D59D99; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:06 +0400 Subject: [PATCH v7 1/8] firmware: qcom_scm: ipq5332: add support to pass metadata size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-1-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Konrad Dybcio , Gokul Sriram Palanisamy X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=2518; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=CCFYnvFM5T3GiiGMSosO6E7Dk1pLF9EZodgYgOn+Dq0=; b=pMrQta9Nyww8N0EiX2QXHjRk9AjwZzLKwgmLwE6GcDr94P6IZVZnIGEsqSSTA5ddZ8OCp6Xej 4QwDs3nLZWRD1kyrnDrhPMDMLIuaDQT5XgQFcuPuyfRbFHRk94iBB+M X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Manikanta Mylavarapu IPQ5332 security software running under trustzone requires metadata size. With new command support added in TrustZone that includes a size parameter, pass metadata size as well. Reviewed-by: Konrad Dybcio Signed-off-by: Manikanta Mylavarapu Signed-off-by: Gokul Sriram Palanisamy --- drivers/firmware/qcom/qcom_scm.c | 17 +++++++++++++---- drivers/firmware/qcom/qcom_scm.h | 1 + 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_= scm.c index 1a6f85e463e06a12814614cea20719c90a371b69..c970157f75b51027fb73664a58c= 38550344ab963 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -583,9 +583,6 @@ int qcom_scm_pas_init_image(u32 peripheral, const void = *metadata, size_t size, int ret; struct qcom_scm_desc desc =3D { .svc =3D QCOM_SCM_SVC_PIL, - .cmd =3D QCOM_SCM_PIL_PAS_INIT_IMAGE, - .arginfo =3D QCOM_SCM_ARGS(2, QCOM_SCM_VAL, QCOM_SCM_RW), - .args[0] =3D peripheral, .owner =3D ARM_SMCCC_OWNER_SIP, }; struct qcom_scm_res res; @@ -617,7 +614,19 @@ int qcom_scm_pas_init_image(u32 peripheral, const void= *metadata, size_t size, if (ret) goto disable_clk; =20 - desc.args[1] =3D mdata_phys; + if (__qcom_scm_is_call_available(__scm->dev, QCOM_SCM_SVC_PIL, + QCOM_SCM_PIL_PAS_INIT_IMAGE_V2)) { + desc.cmd =3D QCOM_SCM_PIL_PAS_INIT_IMAGE_V2; + desc.arginfo =3D QCOM_SCM_ARGS(3, QCOM_SCM_VAL, QCOM_SCM_RW, QCOM_SCM_VA= L); + desc.args[0] =3D peripheral; + desc.args[1] =3D mdata_phys; + desc.args[2] =3D size; + } else { + desc.cmd =3D QCOM_SCM_PIL_PAS_INIT_IMAGE; + desc.arginfo =3D QCOM_SCM_ARGS(2, QCOM_SCM_VAL, QCOM_SCM_RW); + desc.args[0] =3D peripheral; + desc.args[1] =3D mdata_phys; + } =20 ret =3D qcom_scm_call(__scm->dev, &desc, &res); qcom_scm_bw_disable(); diff --git a/drivers/firmware/qcom/qcom_scm.h b/drivers/firmware/qcom/qcom_= scm.h index a56c8212cc0c41021e5a067d52b7d5dcc49107ea..57d63e932f62dfc03ddc6a3343d= cd89d35de6137 100644 --- a/drivers/firmware/qcom/qcom_scm.h +++ b/drivers/firmware/qcom/qcom_scm.h @@ -105,6 +105,7 @@ int qcom_scm_shm_bridge_enable(struct device *scm_dev); #define QCOM_SCM_PIL_PAS_SHUTDOWN 0x06 #define QCOM_SCM_PIL_PAS_IS_SUPPORTED 0x07 #define QCOM_SCM_PIL_PAS_MSS_RESET 0x0a +#define QCOM_SCM_PIL_PAS_INIT_IMAGE_V2 0x1a =20 #define QCOM_SCM_SVC_IO 0x05 #define QCOM_SCM_IO_READ 0x01 --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7A901F181F; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; cv=none; b=fEjNkJemX2sfzDHl6TK+OVIxFTsxKfuZetHLEJd+YvFgUY/HUaZvpItTmw/F0IsEMfAvChV8CYosWYpuqVpcJwUESew4zSkofh3PxY5IGep/9n0cgBANKS+7arR4EB3qrwpXq9OJBWWkLdAi+pC1Srl4muyqi+gu/1RfhZKMOV0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; c=relaxed/simple; bh=u3U7pkyTwnB7c2Os5WO75v40qCVDPhanlFJnWJJ1KxQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q3lerId0Fa67LotYsyifdQS76oFR6X+01YG4dv6IjOKmvN9CNo651939kG8UPtAF6UpYOS8k5ICVwEbLEM1Zxi0PZhxI/rC2+/zIvFhwqucXq6KtGBmz6RvX9baTd1cyUr7ePQy11L0hADQdBKoMwQwdS5otX8YIap3CAbShxBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=a4LsHIw2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="a4LsHIw2" Received: by smtp.kernel.org (Postfix) with ESMTPS id 6263FC116B1; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=u3U7pkyTwnB7c2Os5WO75v40qCVDPhanlFJnWJJ1KxQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=a4LsHIw2al9d1eC5M6vm/+uX53KtuNpoHqCk7KLtRplKfM8d/+iU50bAG4Ep5WuT3 TOJc8O/nTYpNKoAmT8TZj8pBGcb2BTVp67UQixUG7DpjtD0lp4gUk+oivLhy515T/J 3/eVgOGH2zUW6rtIvbQMJtagWqdRP5T9c2YCpnaX/FwoAiBO7SPMro9ee3Q0qQg3T/ GCWjww+RHySelz59Ea0d/P8gzb+NlGh8SX/W9fnT+xK9ddT8D+UtHb6aBnHhL824WF 9RKbm5olaGFWZEHsiryI9hlz0bD/UHBpNAwj+Mo+pllecxWIxsqbpnp2J1aJxge80P uBL/MEdcjLAmw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528BDD41D74; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:07 +0400 Subject: [PATCH v7 2/8] dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-2-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Gokul Sriram Palanisamy , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=5640; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=DYA2zq1ePczBFUG9d6EFsq6Fency+GX6+e/U5k4kiBg=; b=GMqJirsVFTrxkva5qjKL/HLwY8XO1s+uIsAubd4ZGMkrBd2l9cPYhhDIwYlzVItZVQZ9ARCRx Grrt61Xs2AFDdSxKBklY/sp7EMMLF1hQVt/MgXpyE1jxhZrJqra2YzF X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Manikanta Mylavarapu Add new binding document for hexagon based WCSS secure PIL remoteproc. IPQ5018, IPQ5332, IPQ5424 and IPQ9574 follow secure PIL remoteproc. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Manikanta Mylavarapu Signed-off-by: Gokul Sriram Palanisamy --- .../bindings/remoteproc/qcom,wcss-sec-pil.yaml | 176 +++++++++++++++++= ++++ 1 file changed, 176 insertions(+) diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil= .yaml b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml new file mode 100644 index 0000000000000000000000000000000000000000..ec454c070ba59e763edce5190c9= 66e8608714eaf --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,wcss-sec-pil.yaml @@ -0,0 +1,176 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,wcss-sec-pil.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm WCSS Secure Peripheral Image Loader + +maintainers: + - Manikanta Mylavarapu + +description: + Wireless Connectivity Subsystem (WCSS) Secure Peripheral Image Loader lo= ads + firmware and power up QDSP6 remoteproc on the Qualcomm IPQ series SoC. + +properties: + compatible: + enum: + - qcom,ipq5018-wcss-sec-pil + - qcom,ipq5332-wcss-sec-pil + - qcom,ipq5424-wcss-sec-pil + - qcom,ipq9574-wcss-sec-pil + + reg: + maxItems: 1 + + firmware-name: + maxItems: 1 + description: Firmware name for the Hexagon core + + interrupts: + items: + - description: Watchdog interrupt + - description: Fatal interrupt + - description: Ready interrupt + - description: Handover interrupt + - description: Stop acknowledge interrupt + + interrupt-names: + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + + clocks: + $ref: /schemas/types.yaml#/definitions/phandle-array + + clock-names: + $ref: /schemas/types.yaml#/definitions/string-array + + mboxes: + items: + - description: A phandle to the TMECom mailbox device node + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: States used by the AP to signal the remote processor + items: + - description: Stop Q6 + - description: Shutdown Q6 + + qcom,smem-state-names: + description: + Names of the states used by the AP to signal the remote processor + items: + - const: stop + - const: shutdown + + memory-region: + items: + - description: Q6 reserved region + + glink-edge: + $ref: /schemas/remoteproc/qcom,glink-edge.yaml# + description: + Qualcomm G-Link subnode which represents communication edge, channels + and devices related to the Modem. + unevaluatedProperties: false + +required: + - compatible + - reg + - firmware-name + - interrupts + - interrupt-names + - qcom,smem-states + - qcom,smem-state-names + - memory-region + +allOf: + - if: + properties: + compatible: + contains: + const: qcom,ipq5018-wcss-sec-pil + then: + properties: + clocks: + items: + - description: sleep clock + - description: AHB interconnect clock + clock-names: + items: + - const: sleep + - const: interconnect + required: + - clocks + - clock-names + + - if: + properties: + compatible: + contains: + const: qcom,ipq5332-wcss-sec-pil + then: + properties: + clocks: + items: + - description: sleep clock + clock-names: + items: + - const: sleep + required: + - clocks + - clock-names + + - if: + properties: + compatible: + contains: + enum: + - qcom,ipq5424-wcss-sec-pil + - qcom,ipq9574-wcss-sec-pil + then: + properties: + clocks: false + clock-names: false + +additionalProperties: false + +examples: + - | + #include + #include + remoteproc@d100000 { + compatible =3D "qcom,ipq5424-wcss-sec-pil"; + reg =3D <0x0d100000 0x4040>; + firmware-name =3D "ath12k/IPQ5424/hw1.0/q6_fw0.mbn"; + interrupts-extended =3D <&intc GIC_SPI 508 IRQ_TYPE_EDGE_RISING>, + <&wcss_smp2p_in 0 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 1 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 2 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 3 IRQ_TYPE_NONE>; + interrupt-names =3D "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + mboxes =3D <&tmel_qmp 0>; + qcom,smem-states =3D <&wcss_smp2p_out 1>, + <&wcss_smp2p_out 0>; + qcom,smem-state-names =3D "stop", + "shutdown"; + + memory-region =3D <&q6_region>; + + glink-edge { + interrupts =3D ; + label =3D "rtr"; + qcom,remote-pid =3D <1>; + mboxes =3D <&apcs_glb 8>; + }; + }; --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B770D14884C; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; cv=none; b=a+H9Zm4EooCuY2KyZrhxLhV7aA20YkJcGhyXmZGG/1lh8lUp9ZTryLPPi6dnSvdC4kLDTPZzH87tIrEz0BKViEEa+aYxfgbroCks2yALJwMtx9Qqz8jSkJl+Jo5UiLUPzaq31mdeC9KGHo+uLw0gOfKpovelL7vm6Zur9yG7r6s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; c=relaxed/simple; bh=dx66ViePdpCuN8MqDJW3/fe4f4y/6KcT5fNx5SuOuYA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YV/gnsLN1tnNvzAdeo9qxkosY9mBC9RgVttR0jHpAK1SIqQlhiHPq8pQfBLM8t4/VudvJ2DSvRnFyG3jWRJIWQCRpHKdPiGveg4epNgeaueVYydP8m3dFDb4ryLTE81m3WrQgaVmOMG7HjDesxWfXbHx1vZmJrLvgzzM9cl+ob8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UFcrhJs3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UFcrhJs3" Received: by smtp.kernel.org (Postfix) with ESMTPS id 70979C19425; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=dx66ViePdpCuN8MqDJW3/fe4f4y/6KcT5fNx5SuOuYA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=UFcrhJs3UbqkPxGmae9xHD/CHVvj41ZE8nPxrvOSOFl6vbqAiPNuaqIyYiDsVSMpS ECnYz+uEzgNDJ8apFP3PgfMEQI1ej6pWoUKBjepySwwZP9E/vPSHqWubFIS4xToIKb gSeDOJKs6I2WLFJpMhImzofMsjXQcjFFP1pDZbVgF9luMGrEv/nqcDUtH2zTbzwZNF yB7etSFZHuYvdEKORuApADxAsHRjKGnQib9uW3jt+q8gKIZYGLDFDxlbK7w8HTcK4H 2jUXzI+D3ExyEtE3USf3TBGl48ye2vyGvarRIzdoMwikzLeFwEGgALiih//X0uf/Dz jU8/FF8mYeOSQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62966D5B16C; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:08 +0400 Subject: [PATCH v7 3/8] remoteproc: qcom: add hexagon based WCSS secure PIL driver Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-3-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Vignesh Viswanathan , Gokul Sriram Palanisamy , George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=15057; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=eVGDRLiVkWlYZi9xHIZEfPHMIzsKU5hiKUaCoDXNlhk=; b=EBP+dD+4/xklUfWokF2V6oToH92bycqGbbHVOiUDXMBGziGM4UnEWEC8Ob26d7j+uwmgSC4f3 PI6LCk5aq/DAxKzfLwtEX8jRewTxjZe4rD0mzcurmKoJYjApsZIv8sK X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Vignesh Viswanathan Add support to bring up hexagon based WCSS using secure PIL. All IPQxxxx SoCs support secure Peripheral Image Loading (PIL). Secure PIL image is signed firmware image which only trusted software such as TrustZone (TZ) can authenticate and load. Linux kernel will send a Peripheral Authentication Service (PAS) request to TZ to authenticate and load the PIL images. This change also introduces secure firmware authentication using Trusted Management Engine-Lite (TME-L) which is supported on IPQ5424 SoC. This driver uses mailbox based PAS request to TME-L for image authentication if supported, else it will fallback to use SCM call based PAS request to TZ. In order to avoid overloading the existing WCSS driver or PAS driver, we came up with this new PAS based IPQ WCSS driver. Signed-off-by: Vignesh Viswanathan Signed-off-by: Manikanta Mylavarapu Signed-off-by: Gokul Sriram Palanisamy Signed-off-by: George Moussalem --- drivers/remoteproc/Kconfig | 19 ++ drivers/remoteproc/Makefile | 1 + drivers/remoteproc/qcom_q6v5_wcss_sec.c | 397 ++++++++++++++++++++++++++++= ++++ include/linux/remoteproc.h | 2 + 4 files changed, 419 insertions(+) diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig index 48a0d3a69ed08057716f1e7ea950899f60bbe0cf..eaa427e4e9eca48b853fe064830= 4e67649878d8e 100644 --- a/drivers/remoteproc/Kconfig +++ b/drivers/remoteproc/Kconfig @@ -254,6 +254,25 @@ config QCOM_Q6V5_WCSS Hexagon V5 based WCSS remote processors on e.g. IPQ8074. This is a non-TrustZone wireless subsystem. =20 +config QCOM_Q6V5_WCSS_SEC + tristate "Qualcomm Hexagon based WCSS Secure Peripheral Image Loader" + depends on OF && ARCH_QCOM + depends on QCOM_SMEM + depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=3Dn + depends on RPMSG_QCOM_GLINK || RPMSG_QCOM_GLINK=3Dn + select QCOM_MDT_LOADER + select QCOM_PIL_INFO + select QCOM_Q6V5_COMMON + select QCOM_RPROC_COMMON + select QCOM_SCM + help + Say y here to support the Qualcomm Secure Peripheral Image Loader + for the Hexagon based remote processors on e.g. IPQ5332. + + This is TrustZone wireless subsystem. The firmware is + verified and booted with the help of the Peripheral Authentication + System (PAS) in TrustZone. + config QCOM_SYSMON tristate "Qualcomm sysmon driver" depends on RPMSG diff --git a/drivers/remoteproc/Makefile b/drivers/remoteproc/Makefile index 1c7598b8475d6057a3e044b41e3515103b7aa9f1..08705ef62bceb8b683a9419a5a8= b027cbe2433c5 100644 --- a/drivers/remoteproc/Makefile +++ b/drivers/remoteproc/Makefile @@ -28,6 +28,7 @@ obj-$(CONFIG_QCOM_Q6V5_ADSP) +=3D qcom_q6v5_adsp.o obj-$(CONFIG_QCOM_Q6V5_MSS) +=3D qcom_q6v5_mss.o obj-$(CONFIG_QCOM_Q6V5_PAS) +=3D qcom_q6v5_pas.o obj-$(CONFIG_QCOM_Q6V5_WCSS) +=3D qcom_q6v5_wcss.o +obj-$(CONFIG_QCOM_Q6V5_WCSS_SEC) +=3D qcom_q6v5_wcss_sec.o obj-$(CONFIG_QCOM_SYSMON) +=3D qcom_sysmon.o obj-$(CONFIG_QCOM_WCNSS_PIL) +=3D qcom_wcnss_pil.o qcom_wcnss_pil-y +=3D qcom_wcnss.o diff --git a/drivers/remoteproc/qcom_q6v5_wcss_sec.c b/drivers/remoteproc/q= com_q6v5_wcss_sec.c new file mode 100644 index 0000000000000000000000000000000000000000..7bd45b4fd917e896f8df085c5ff= 2c87fa005e354 --- /dev/null +++ b/drivers/remoteproc/qcom_q6v5_wcss_sec.c @@ -0,0 +1,397 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2016-2018 Linaro Ltd. + * Copyright (C) 2014 Sony Mobile Communications AB + * Copyright (c) 2012-2018 The Linux Foundation. All rights reserved. + * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights res= erved. + */ +#include +#include +#include +#include +#include +#include +#include +#include + +#include "qcom_common.h" +#include "qcom_q6v5.h" +#include "qcom_pil_info.h" + +#define WCSS_CRASH_REASON 421 + +#define WCSS_PAS_ID 0x6 +#define MPD_WCSS_PAS_ID 0xd + +#define Q6_WAIT_TIMEOUT (5 * HZ) + +struct wcss_sec { + struct device *dev; + struct qcom_rproc_glink glink_subdev; + struct qcom_rproc_ssr ssr_subdev; + struct qcom_q6v5 q6; + phys_addr_t mem_phys; + phys_addr_t mem_reloc; + void *mem_region; + size_t mem_size; + const struct wcss_data *desc; + + struct mbox_client mbox_client; + struct mbox_chan *mbox_chan; + void *metadata; + size_t metadata_len; +}; + +struct wcss_data { + u32 pasid; + const char *ss_name; + bool auto_boot; + bool use_tmelcom; +}; + +static int wcss_sec_start(struct rproc *rproc) +{ + struct wcss_sec *wcss =3D rproc->priv; + struct device *dev =3D wcss->dev; + int ret; + + ret =3D qcom_q6v5_prepare(&wcss->q6); + if (ret) + return ret; + + if (wcss->desc->use_tmelcom) { + struct tmel_sec_auth tsa; + struct tmel_qmp_msg tqm; + + tsa.data =3D wcss->metadata; + tsa.size =3D wcss->metadata_len; + tsa.pas_id =3D wcss->desc->pasid; + tqm.msg =3D &tsa; + tqm.msg_id =3D TMEL_MSG_UID_SECBOOT_SEC_AUTH; + + ret =3D mbox_send_message(wcss->mbox_chan, (void *)&tqm); + if (ret < 0) { + dev_err(dev, "Failed to send message via mailbox\n"); + goto unprepare; + } + } else { + ret =3D qcom_scm_pas_auth_and_reset(wcss->desc->pasid); + if (ret) { + dev_err(dev, "wcss_reset failed\n"); + goto unprepare; + } + } + + ret =3D qcom_q6v5_wait_for_start(&wcss->q6, Q6_WAIT_TIMEOUT); + if (ret =3D=3D -ETIMEDOUT) + dev_err(dev, "start timed out\n"); + +unprepare: + qcom_q6v5_unprepare(&wcss->q6); + + return ret; +} + +static int wcss_sec_stop(struct rproc *rproc) +{ + struct wcss_sec *wcss =3D rproc->priv; + struct device *dev =3D wcss->dev; + int ret; + + if (wcss->desc->use_tmelcom) { + struct tmel_sec_auth tsa =3D {0}; + struct tmel_qmp_msg tqm; + + tsa.pas_id =3D wcss->desc->pasid; + tqm.msg =3D &tsa; + tqm.msg_id =3D TMEL_MSG_UID_SECBOOT_SS_TEAR_DOWN; + + mbox_send_message(wcss->mbox_chan, (void *)&tqm); + } else { + ret =3D qcom_scm_pas_shutdown(wcss->desc->pasid); + if (ret) { + dev_err(dev, "not able to shutdown\n"); + return ret; + } + } + + qcom_q6v5_unprepare(&wcss->q6); + + return 0; +} + +static void *wcss_sec_da_to_va(struct rproc *rproc, u64 da, size_t len, + bool *is_iomem) +{ + struct wcss_sec *wcss =3D rproc->priv; + int offset; + + offset =3D da - wcss->mem_reloc; + if (offset < 0 || offset + len > wcss->mem_size) + return NULL; + + return wcss->mem_region + offset; +} + +static int wcss_sec_load(struct rproc *rproc, const struct firmware *fw) +{ + struct wcss_sec *wcss =3D rproc->priv; + struct device *dev =3D wcss->dev; + int ret; + + if (wcss->desc->use_tmelcom) { + wcss->metadata =3D qcom_mdt_read_metadata(fw, &wcss->metadata_len, + rproc->firmware, wcss->dev); + if (IS_ERR(wcss->metadata)) { + ret =3D PTR_ERR(wcss->metadata); + dev_err(wcss->dev, "error %d reading firmware %s metadata\n", + ret, rproc->firmware); + return ret; + } + + ret =3D qcom_mdt_load_no_init(wcss->dev, fw, rproc->firmware, wcss->desc= ->pasid, + wcss->mem_region, wcss->mem_phys, wcss->mem_size, + &wcss->mem_reloc); + if (ret) { + kfree(wcss->metadata); + return ret; + } + } else { + ret =3D qcom_mdt_load(dev, fw, rproc->firmware, wcss->desc->pasid, wcss-= >mem_region, + wcss->mem_phys, wcss->mem_size, &wcss->mem_reloc); + if (ret) + return ret; + } + + qcom_pil_info_store("wcss", wcss->mem_phys, wcss->mem_size); + + return 0; +} + +static unsigned long wcss_sec_panic(struct rproc *rproc) +{ + struct wcss_sec *wcss =3D rproc->priv; + + return qcom_q6v5_panic(&wcss->q6); +} + +static void wcss_sec_copy_segment(struct rproc *rproc, + struct rproc_dump_segment *segment, + void *dest, size_t offset, size_t size) +{ + struct wcss_sec *wcss =3D rproc->priv; + struct device *dev =3D wcss->dev; + + if (!segment->io_ptr) + segment->io_ptr =3D ioremap_wc(segment->da, segment->size); + + if (!segment->io_ptr) { + dev_err(dev, "Failed to ioremap segment %pad size 0x%zx\n", + &segment->da, segment->size); + return; + } + + if (offset + size < segment->size) { + memcpy(dest, segment->io_ptr + offset, size); + } else { + iounmap(segment->io_ptr); + segment->io_ptr =3D NULL; + } +} + +static int wcss_sec_dump_segments(struct rproc *rproc, + const struct firmware *fw) +{ + struct device *dev =3D rproc->dev.parent; + struct reserved_mem *rmem =3D NULL; + struct device_node *node; + int num_segs, index; + int ret; + + /* + * Parse through additional reserved memory regions for the rproc + * and add them to the coredump segments + */ + num_segs =3D of_count_phandle_with_args(dev->of_node, + "memory-region", NULL); + for (index =3D 0; index < num_segs; index++) { + node =3D of_parse_phandle(dev->of_node, + "memory-region", index); + if (!node) + return -EINVAL; + + rmem =3D of_reserved_mem_lookup(node); + of_node_put(node); + if (!rmem) { + dev_err(dev, "unable to acquire memory-region index %d num_segs %d\n", + index, num_segs); + return -EINVAL; + } + + dev_dbg(dev, "Adding segment 0x%pa size 0x%pa", + &rmem->base, &rmem->size); + ret =3D rproc_coredump_add_custom_segment(rproc, + rmem->base, + rmem->size, + wcss_sec_copy_segment, + NULL); + if (ret) + return ret; + } + + return 0; +} + +static const struct rproc_ops wcss_sec_ops =3D { + .start =3D wcss_sec_start, + .stop =3D wcss_sec_stop, + .da_to_va =3D wcss_sec_da_to_va, + .load =3D wcss_sec_load, + .get_boot_addr =3D rproc_elf_get_boot_addr, + .panic =3D wcss_sec_panic, + .parse_fw =3D wcss_sec_dump_segments, +}; + +static int wcss_sec_alloc_memory_region(struct wcss_sec *wcss) +{ + struct device *dev =3D wcss->dev; + struct resource res; + int ret; + + ret =3D of_reserved_mem_region_to_resource(dev->of_node, 0, &res); + if (ret) { + dev_err(dev, "unable to acquire memory-region resource\n"); + return ret; + } + + wcss->mem_phys =3D res.start; + wcss->mem_reloc =3D res.start; + wcss->mem_size =3D resource_size(&res); + wcss->mem_region =3D devm_ioremap_resource_wc(dev, &res); + if (!wcss->mem_region) { + dev_err(dev, "unable to map memory region: %pR\n", &res); + return -ENOMEM; + } + + return 0; +} + +static int wcss_sec_probe(struct platform_device *pdev) +{ + const struct wcss_data *desc =3D of_device_get_match_data(&pdev->dev); + const char *fw_name =3D NULL; + struct wcss_sec *wcss; + struct clk *sleep_clk; + struct clk *int_clk; + struct rproc *rproc; + int ret; + + ret =3D of_property_read_string(pdev->dev.of_node, "firmware-name", + &fw_name); + if (ret < 0) + return ret; + + rproc =3D devm_rproc_alloc(&pdev->dev, desc->ss_name, &wcss_sec_ops, + fw_name, sizeof(*wcss)); + if (!rproc) { + dev_err(&pdev->dev, "failed to allocate rproc\n"); + return -ENOMEM; + } + + wcss =3D rproc->priv; + wcss->dev =3D &pdev->dev; + wcss->desc =3D desc; + + ret =3D wcss_sec_alloc_memory_region(wcss); + if (ret) + return ret; + + sleep_clk =3D devm_clk_get_optional_enabled(&pdev->dev, "sleep"); + if (IS_ERR(sleep_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(sleep_clk), + "Failed to get sleep clock\n"); + + int_clk =3D devm_clk_get_optional_enabled(&pdev->dev, "interconnect"); + if (IS_ERR(int_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(int_clk), + "Failed to get interconnect clock\n"); + + ret =3D qcom_q6v5_init(&wcss->q6, pdev, rproc, + WCSS_CRASH_REASON, NULL, NULL); + if (ret) + return ret; + + qcom_add_glink_subdev(rproc, &wcss->glink_subdev, desc->ss_name); + qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, desc->ss_name); + + rproc->auto_boot =3D false; + rproc->dump_conf =3D RPROC_COREDUMP_INLINE; + rproc_coredump_set_elf_info(rproc, ELFCLASS32, EM_NONE); + + if (desc->use_tmelcom) { + wcss->mbox_client.dev =3D wcss->dev; + wcss->mbox_client.knows_txdone =3D true; + wcss->mbox_client.tx_block =3D true; + wcss->mbox_chan =3D mbox_request_channel(&wcss->mbox_client, 0); + if (IS_ERR_OR_NULL(wcss->mbox_chan)) + return dev_err_probe(wcss->dev, PTR_ERR(wcss->mbox_chan), + "mbox chan for IPC is missing\n"); + } + + ret =3D devm_rproc_add(&pdev->dev, rproc); + if (ret) + return ret; + + platform_set_drvdata(pdev, rproc); + + return 0; +} + +static void wcss_sec_remove(struct platform_device *pdev) +{ + struct rproc *rproc =3D platform_get_drvdata(pdev); + struct wcss_sec *wcss =3D rproc->priv; + + mbox_free_channel(wcss->mbox_chan); + qcom_remove_glink_subdev(rproc, &wcss->glink_subdev); + qcom_remove_ssr_subdev(rproc, &wcss->ssr_subdev); + qcom_q6v5_deinit(&wcss->q6); +} + +static const struct wcss_data wcss_sec_ipq5332_res_init =3D { + .pasid =3D MPD_WCSS_PAS_ID, + .ss_name =3D "q6wcss", +}; + +static const struct wcss_data wcss_sec_ipq5424_res_init =3D { + .pasid =3D MPD_WCSS_PAS_ID, + .ss_name =3D "q6wcss", + .use_tmelcom =3D true, +}; + +static const struct wcss_data wcss_sec_ipq9574_res_init =3D { + .pasid =3D WCSS_PAS_ID, + .ss_name =3D "q6wcss", +}; + +static const struct of_device_id wcss_sec_of_match[] =3D { + { .compatible =3D "qcom,ipq5018-wcss-sec-pil", .data =3D &wcss_sec_ipq533= 2_res_init }, + { .compatible =3D "qcom,ipq5332-wcss-sec-pil", .data =3D &wcss_sec_ipq533= 2_res_init }, + { .compatible =3D "qcom,ipq5424-wcss-sec-pil", .data =3D &wcss_sec_ipq542= 4_res_init }, + { .compatible =3D "qcom,ipq9574-wcss-sec-pil", .data =3D &wcss_sec_ipq957= 4_res_init }, + { }, +}; +MODULE_DEVICE_TABLE(of, wcss_sec_of_match); + +static struct platform_driver wcss_sec_driver =3D { + .probe =3D wcss_sec_probe, + .remove =3D wcss_sec_remove, + .driver =3D { + .name =3D "qcom-wcss-secure-pil", + .of_match_table =3D wcss_sec_of_match, + }, +}; +module_platform_driver(wcss_sec_driver); + +MODULE_DESCRIPTION("Hexagon WCSS Secure Peripheral Image Loader"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h index b4795698d8c2a4e80ccafbe632436c4dfb636a1e..7b2159853345eec3d787f08413f= f086bbc59ae91 100644 --- a/include/linux/remoteproc.h +++ b/include/linux/remoteproc.h @@ -472,6 +472,7 @@ enum rproc_dump_mechanism { * @node: list node related to the rproc segment list * @da: device address of the segment * @size: size of the segment + * @io_ptr: ptr to store the ioremapped dump segment * @priv: private data associated with the dump_segment * @dump: custom dump function to fill device memory segment associated * with coredump @@ -483,6 +484,7 @@ struct rproc_dump_segment { dma_addr_t da; size_t size; =20 + void *io_ptr; void *priv; void (*dump)(struct rproc *rproc, struct rproc_dump_segment *segment, void *dest, size_t offset, size_t size); --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B76CD1448E0; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; cv=none; b=HRiT4MyEVLyngrs3p7sUVVCu56TDaWZmQtwesKqEPLss4zCxMqL86KSbc6v7xTw/WY156eC4O5V7uiSv1dxtTQC3NDzQ/fKeptTzC+MQ5aI7BUIXj1YznkxRRgD3O9PH3H+CdnLYkssumGo7yGBOkePikF3LBlmZAFKvpztmN8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780528; c=relaxed/simple; bh=VnwpWxR/8+nShFX5zfIEPvBeQMXdJgHrpvPMXyO7f/o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rXk1ugwcS83NKm/l8rJFcMmUchJKuYL+4SJMu1WcuxN9WXiHYiggsJwZGaqiaYqSWdlvCcApj4X0Zqzlj7AFo7DpXVbH4E1hix55u1r3fT+WbJgl6jFmNbv3WGHMOurJzbRvN64HRhcpgyq8kRPOQayHbDYd2EtldErEWi/QoIQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OKI66DoG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OKI66DoG" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7697BC2BC87; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=VnwpWxR/8+nShFX5zfIEPvBeQMXdJgHrpvPMXyO7f/o=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OKI66DoGBTmFAoRAImFSwNjDYMtMm2teSmOIuISJCkZLXhooCZh//pYtzMcOojhF6 HJ7tVkq2669oofn2shaiXdHcIFI3J3e2dmmh8nM2HR3nOH0BzBb50lJmHPvLkENS3q +GJQ3KPkXLBXS/q1IJGERskhkAP+FKpJlz/8R7+K4TqBawJhnnz+NxYJueSzQCcqvg PKxImsKwvJXcBCV+/cyCEMbsSs4nsrX587SoAcm99+ktcvMB3ZwfDbuKj9J+BYmY4r zElOCa5gLzKkpNMPTprbRdQ9Jcg4+hRIqr++0TOnXD0s9bcjpKl8Yshh5xiqgSiUVf QPuiL7Ok8DGWg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711DCD5B16F; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:09 +0400 Subject: [PATCH v7 4/8] mailbox: qcom: fix IPC register offset for IPQ5424 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-4-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=1407; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=bQie0gh5+yB2rgVd9SAgk+hMuExkZX7LZ4wgufEEF9I=; b=ejBjz1LnFrBL/mN4ZXwRdohWziR6hrBgFOzVNjlMYOPl3t3qhEz31c6JPnxymw5zM8PgRY6+P dvXEaL+YUfHDWVkNsPgJFw+gE37Bea24ptnDnd7MjIVPqKR6KcHwSwU X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem The IPC register in IPQ5424 is at offset 0xc instead of 0x8 as defined in driver data for msm8994. As such, switch to the existing apps_shared_apcs_data driver data which has offset set to 0xc. Signed-off-by: George Moussalem --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom= -apcs-ipc-mailbox.c index d3a8f6b4a03b368821ef9a5b24fee78037104610..258b03307869b244e053e7a3555= 31268114906df 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -164,7 +164,7 @@ static const struct of_device_id qcom_apcs_ipc_of_match= [] =3D { { .compatible =3D "qcom,sm6125-apcs-hmss-global", .data =3D &msm8994_apcs= _data }, { .compatible =3D "qcom,sm6115-apcs-hmss-global", .data =3D &msm8994_apcs= _data }, { .compatible =3D "qcom,ipq5332-apcs-apps-global", .data =3D &ipq6018_apc= s_data }, - { .compatible =3D "qcom,ipq5424-apcs-apps-global", .data =3D &msm8994_apc= s_data }, + { .compatible =3D "qcom,ipq5424-apcs-apps-global", .data =3D &apps_shared= _apcs_data }, { .compatible =3D "qcom,ipq8074-apcs-apps-global", .data =3D &ipq6018_apc= s_data }, { .compatible =3D "qcom,sc7180-apss-shared", .data =3D &apps_shared_apcs_= data }, { .compatible =3D "qcom,sc8180x-apss-shared", .data =3D &apps_shared_apcs= _data }, --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EA330C344; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; cv=none; b=UGqFrNxmaAIH4MCBJNX3qfGUOGHmTNNd0Eyzob158qvBls4lOJ8UjwOfgud5j7kzEFFhLolKUJ54qiIaBOa4Npjama4mBBIIwxe/DkDjnbuvFY6CmKyj6jAzOd8qGv/wh7V/RcI3v/a7zAdmiF8ndgptvkdzgembks+CiQ1Ij6o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; c=relaxed/simple; bh=Lf+FQE4DVs8wvHLmolFVttU+W2l4hGvMNlsCOthE8w0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bY5D4oStplk/GbIw47L3NF1fnYzYmBEdgE5GgVucU7C2jKoexqL6vfjWpVZEonQWJHX/86yTHk1A0aIpYpY4snRUJq/mmbl46q+oncl1/IoL2aFnBxqSa4PrFwjWQI1CrNAxfk/bG3axVgUTMZXhksqm/qdDAwAikLuZ87gvRqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CDUZHd7p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CDUZHd7p" Received: by smtp.kernel.org (Postfix) with ESMTPS id 86FB0C2BCB7; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=Lf+FQE4DVs8wvHLmolFVttU+W2l4hGvMNlsCOthE8w0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=CDUZHd7px6P96hRWWgMmLKbDWT9203Z+RWlP9vEDdjh1enmCFtGYNP+T5rEdSMIlS UiCC0ycZQjB/8m5GrCgfnuUsL/BUaW+OuOQ8Qle3x5dbZrPqw6m6iQ9JZipQDXNEyk dfXp8dr8x5Izo59Ol10QPMsSe7ARcKgAXjEA1GbZvBGtb5oJb7gneJMTM9nO70+LXp Y5mczCZlniW+09+RJ3hPKcqILMS/pFqg5+uQaj33jHetL4dFB27FbrU8SrlTv0HsKR Y5hP3MnS5Y0b34/8j0FTR8vbZSHqDeCy8chrv2CkNe2IZFvFDbl2lN11ciSaQXqmbp gSlaHcMcDNEig== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802B0D41D74; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:10 +0400 Subject: [PATCH v7 5/8] arm64: dts: qcom: ipq5018: add nodes to bring up q6 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-5-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov , George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=2536; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=U+CxhXV7IiW6598EUIu9tQZCBq0lj8MkLhtP7TD5I8s=; b=diC55B13ROdDqKiaREz99TYj8BPbt26jlvPd59SAQ/K2Tl03xaXfV+ZfQitXtNU0Pe00JSdmR DwZoF00y1EdCiq9z7gIv4Z1cqscP6ufceM5n+XDyGRXmyYPUdX0GYbg X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: George Moussalem Enable nodes required for q6 remoteproc bring up. Reviewed-by: Dmitry Baryshkov Signed-off-by: George Moussalem --- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 64 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 64 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qc= om/ipq5018.dtsi index f024b3cba33f6100ac3f4d45598ff2356e026dcf..7bb09621891ea6d287d1c83c77e= 2feb71b93a0c6 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi @@ -158,6 +158,35 @@ tz_region: tz@4ac00000 { reg =3D <0x0 0x4ac00000 0x0 0x200000>; no-map; }; + + q6_region: wcss@4b000000 { + no-map; + reg =3D <0x0 0x4b000000 0x0 0x1b00000>; + }; + }; + + wcss: smp2p-wcss { + compatible =3D "qcom,smp2p"; + qcom,smem =3D <435>, <428>; + + interrupt-parent =3D <&intc>; + interrupts =3D ; + + mboxes =3D <&apcs_glb 9>; + + qcom,local-pid =3D <0>; + qcom,remote-pid =3D <1>; + + wcss_smp2p_out: master-kernel { + qcom,entry-name =3D "master-kernel"; + #qcom,smem-state-cells =3D <1>; + }; + + wcss_smp2p_in: slave-kernel { + qcom,entry-name =3D "slave-kernel"; + interrupt-controller; + #interrupt-cells =3D <2>; + }; }; =20 soc: soc@0 { @@ -717,6 +746,41 @@ frame@b128000 { }; }; =20 + q6v5_wcss: remoteproc@cd00000 { + compatible =3D "qcom,ipq5018-wcss-sec-pil"; + reg =3D <0x0cd00000 0x10000>; + firmware-name =3D "ath11k/IPQ5018/hw1.0/q6_fw.mbn"; + interrupts-extended =3D <&intc GIC_SPI 291 IRQ_TYPE_EDGE_RISING>, + <&wcss_smp2p_in 0 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 1 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 2 IRQ_TYPE_NONE>, + <&wcss_smp2p_in 3 IRQ_TYPE_NONE>; + interrupt-names =3D "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + clocks =3D <&gcc GCC_SLEEP_CLK_SRC>, + <&gcc GCC_SYS_NOC_WCSS_AHB_CLK>; + clock-names =3D "sleep", + "interconnect"; + + qcom,smem-states =3D <&wcss_smp2p_out 0>, + <&wcss_smp2p_out 1>; + qcom,smem-state-names =3D "shutdown", + "stop"; + + memory-region =3D <&q6_region>; + + glink-edge { + interrupts =3D ; + label =3D "rtr"; + qcom,remote-pid =3D <1>; + mboxes =3D <&apcs_glb 8>; + }; + }; + pcie1: pcie@80000000 { compatible =3D "qcom,pcie-ipq5018"; reg =3D <0x80000000 0xf1d>, --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB6FF3009E8; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; cv=none; b=Ac+A1k2Iy1zS2siJWEqkbDBkm0JfvWjlNGKi33gDDgbhAwjhWY0b+xEYLjgEF3SygUQPPJskfQORdNzch8qR5F4k3dnA6Wj632fXOeGpjV4V7ABLuf23c3dvdaw9GsmAKvLVIQ5X4alS8A0l67YYATmYjjJyH0uf608EIb7QxFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; c=relaxed/simple; bh=k+rp1wLoy0SJ9elXcUNeQ5srX67PFojXk0aEwDQrD3g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zs1MU+XqED2BTRM8cr5SRuFi2hvicdeOCd0PSANWHo5DO3U/jYTRqunpZLxtYTRR/e3fo2BAFji3cuXNcB9cfCd3uaLGHUhTxv+Xzx7igTNRFFI4nSQXjeD1GaehmyaKq0l1vl7QEh7lzzkFIdxxNMIIGUbSXatl9uJP/uM4Iho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QneqUN+6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QneqUN+6" Received: by smtp.kernel.org (Postfix) with ESMTPS id 9A380C2BCC7; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=k+rp1wLoy0SJ9elXcUNeQ5srX67PFojXk0aEwDQrD3g=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=QneqUN+6XYJLJVKKBAISPQkgQIgnDNM4FfrYKzkDoVNRZ8gfVCBsWa3IaBv5oIp6F ODscUOVF1RR5EoJ5zDty4Srx09qOuWQHlCP8IUFSYdMyhRJCRUWCcfSQ0HAi7xTpZt fRhDJR6tSVxH2snGzqa0rQlSAW+S6dBj4q7cJZpQxvEJ0mbJ6yN/RWT2c9ggIYWnH/ KrvTLAk/utJU+WPBmF9vbBQgi9xPTYmOzXP+F+gKJG2I+h4zm/pmJHW2h2W0ZWom9M sbr0xKixPYwnvBlY70YEyg86VzRhFj3IUxGwLaWIxt/ux+h7za4L6RZZpT0IktvoDC YlKrN6HD819DQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D0ED5B16F; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:11 +0400 Subject: [PATCH v7 6/8] arm64: dts: qcom: ipq5332: add nodes to bring up q6 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-6-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Gokul Sriram Palanisamy , George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=2823; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=RFwP414pKiR9g6tQiK0sXcMEO0nCLBZxMpD6b2bmUe8=; b=LSg182aeYhdwHLTKx0Q5Os/4O+5kPfvaSUbjnMHVKc5nmEzJ+dFyWc+k071LcbSVu/E764IPc NWFZMLH5P32B3eboalNVK+5yBE667E4+vDi0L2VBR231iwwNxMcKnj8 X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Manikanta Mylavarapu Enable nodes required for q6 remoteproc bring up. Signed-off-by: Manikanta Mylavarapu Signed-off-by: Gokul Sriram Palanisamy Signed-off-by: George Moussalem Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/ipq5332.dtsi | 64 +++++++++++++++++++++++++++++++= +++- 1 file changed, 63 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qc= om/ipq5332.dtsi index 45fc512a3bab221c0d99f819294abf63369987da..c31b6906355ed7f7e8dd0fd8e1f= 46654cc5560eb 100644 --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi @@ -2,7 +2,7 @@ /* * IPQ5332 device tree source * - * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights res= erved. + * Copyright (c) 2022-2025 Qualcomm Innovation Center, Inc. All rights res= erved. */ =20 #include @@ -146,6 +146,35 @@ smem@4a800000 { =20 hwlocks =3D <&tcsr_mutex 3>; }; + + q6_region: wcss@4a900000 { + reg =3D <0x0 0x4a900000 0x0 0x2b00000>; + no-map; + }; + }; + + wcss: smp2p-wcss { + compatible =3D "qcom,smp2p"; + qcom,smem =3D <435>, <428>; + + interrupt-parent =3D <&intc>; + interrupts =3D ; + + mboxes =3D <&apcs_glb 9>; + + qcom,local-pid =3D <0>; + qcom,remote-pid =3D <1>; + + smp2p_wcss_out: master-kernel { + qcom,entry-name =3D "master-kernel"; + #qcom,smem-state-cells =3D <1>; + }; + + smp2p_wcss_in: slave-kernel { + qcom,entry-name =3D "slave-kernel"; + interrupt-controller; + #interrupt-cells =3D <2>; + }; }; =20 soc@0 { @@ -586,6 +615,39 @@ frame@b128000 { }; }; =20 + q6v5_wcss: remoteproc@d100000 { + compatible =3D "qcom,ipq5332-wcss-sec-pil"; + reg =3D <0x0d100000 0x10000>; + firmware-name =3D "ath12k/IPQ5332/hw1.0/q6_fw0.mbn"; + interrupts-extended =3D <&intc GIC_SPI 421 IRQ_TYPE_EDGE_RISING>, + <&smp2p_wcss_in 0 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 1 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 2 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 3 IRQ_TYPE_NONE>; + interrupt-names =3D "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + clocks =3D <&gcc GCC_IM_SLEEP_CLK>; + clock-names =3D "sleep"; + + qcom,smem-states =3D <&smp2p_wcss_out 1>, + <&smp2p_wcss_out 0>; + qcom,smem-state-names =3D "stop", + "shutdown"; + + memory-region =3D <&q6_region>; + + glink-edge { + interrupts =3D ; + label =3D "rtr"; + qcom,remote-pid =3D <1>; + mboxes =3D <&apcs_glb 8>; + }; + }; + pcie1: pcie@18000000 { compatible =3D "qcom,pcie-ipq5332", "qcom,pcie-ipq9574"; reg =3D <0x18000000 0xf1c>, --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16CB730BF78; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; cv=none; b=bujoSqwNWjgj+ACmVREsL8zdYA6eiPc7upSCwrs6doAGyYf7Vpa8OnYJ8W7YDADEknBDpxCi4kaqNPqk8XVHHNg2uIGre/TN5D4Px2XsD9jKvRtN4VQ3sALYMw0lSx3qzWJw7rO7RHVjsszB1wTtNKqJcGQ6my1iMay4jj/Ue8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; c=relaxed/simple; bh=ZB+ibr6dilxZnutwmYn2gcBErrUE9nWV6PvJR01uJRU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aTpRd/oRJANadrk4I5iYrzvGCGEkP50al+9hnCxXA4GsqS81Z1DT4yCOG0az1tYO0n2fuCX+S+jhedXP+TtTwHy3mSqph/eISPhEGfHN4oqTlNccHRAapsbl2XTMv5If14jX3D9AgWpeKmmp1hRb1q43qK9gzdt2OEW4ddkpC/o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OsXRE9XD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OsXRE9XD" Received: by smtp.kernel.org (Postfix) with ESMTPS id B4A72C4AF19; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=ZB+ibr6dilxZnutwmYn2gcBErrUE9nWV6PvJR01uJRU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=OsXRE9XDaX4RhSgtmTGEP4tALitWEUwHtVgejOXo++/ly6biy8TfmrzP+LdPdDdx9 2oj66rYxpJMCt3H+9GPiep7h7ir1piEKYVOcaIHYsNVHQtDAJpwku9StaLzh0h0BmM zgFM/fu9pTE2axdbVvJv3yJJiraJCSVU5gMAdcfRZ6mwoJ2WKl563w4DGYySJdNJTc PFcMyQJF6IymGwwYwC2gEFZNZAwSi+jFvg+EtMFwwte3ctNUXVuA7JMWz+c1UGNZDV Nge/+rqtXliiNU7Qk+/Z3apWDMf/gJwsy25qY32FE1I0i/He/SmM1A4xMg6lgl0kUX zFVIwguPdOR8Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA082D59D99; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:12 +0400 Subject: [PATCH v7 7/8] arm64: dts: qcom: ipq5424: add nodes to bring up q6 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-7-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Gokul Sriram Palanisamy , George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=2766; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=+Zkxc9uM0DSPpECVa8dmf4bSp6l72OxtVRlDoafOAek=; b=UkasRBP1Cb17TLka2FEA3pzS24OsJ8PcpNRMcPxX/kyS1T7mSKScWfT5VIgKIfykB60TVlgIz ny9mA4ak3wICHfjcSx+RVGn0AH0oBLGVWi2DLV14JsSuh7GmnrzyEKb X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Gokul Sriram Palanisamy Enable nodes required for q6 remoteproc bring up. Signed-off-by: Gokul Sriram Palanisamy Signed-off-by: George Moussalem Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/ipq5424.dtsi | 68 +++++++++++++++++++++++++++++++= ++++ 1 file changed, 68 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qc= om/ipq5424.dtsi index eb393f3fd728f0b2fc8cd93c849f8c170d76e312..08fcda401556eb2a16d317966cd= 39c006e109b25 100644 --- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi @@ -222,6 +222,35 @@ tfa@8a832000 { no-map; status =3D "disabled"; }; + + q6_region: wcss@8a900000 { + reg =3D <0x0 0x8a900000 0x0 0x2800000>; + no-map; + }; + }; + + wcss: smp2p-wcss { + compatible =3D "qcom,smp2p"; + qcom,smem =3D <435>, <428>; + + interrupt-parent =3D <&intc>; + interrupts =3D ; + + mboxes =3D <&apcs_glb 9>; + + qcom,local-pid =3D <0>; + qcom,remote-pid =3D <1>; + + smp2p_wcss_out: master-kernel { + qcom,entry-name =3D "master-kernel"; + #qcom,smem-state-cells =3D <1>; + }; + + smp2p_wcss_in: slave-kernel { + qcom,entry-name =3D "slave-kernel"; + interrupt-controller; + #interrupt-cells =3D <2>; + }; }; =20 soc@0 { @@ -752,6 +781,37 @@ dwc_0: usb@8a00000 { }; }; =20 + q6v5_wcss: remoteproc@d100000 { + compatible =3D "qcom,ipq5424-wcss-sec-pil"; + reg =3D <0 0x0d100000 0 0x4040>; + firmware-name =3D "ath12k/IPQ5424/hw1.0/q6_fw0.mbn"; + interrupts-extended =3D <&intc GIC_SPI 508 IRQ_TYPE_EDGE_RISING>, + <&smp2p_wcss_in 0 0>, + <&smp2p_wcss_in 1 0>, + <&smp2p_wcss_in 2 0>, + <&smp2p_wcss_in 3 0>; + interrupt-names =3D "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + mboxes =3D <&tmel_qmp 0>; + qcom,smem-states =3D <&smp2p_wcss_out 1>, + <&smp2p_wcss_out 0>; + qcom,smem-state-names =3D "stop", + "shutdown"; + + memory-region =3D <&q6_region>; + + glink-edge { + interrupts =3D ; + label =3D "rtr"; + qcom,remote-pid =3D <1>; + mboxes =3D <&apcs_glb 8>; + }; + }; + timer@f420000 { compatible =3D "arm,armv7-timer-mem"; reg =3D <0 0xf420000 0 0x1000>; @@ -811,6 +871,14 @@ frame@f42d000 { }; }; =20 + apcs_glb: mailbox@f400000 { + compatible =3D "qcom,ipq5424-apcs-apps-global", + "qcom,ipq6018-apcs-apps-global"; + reg =3D <0 0x0f400000 0 0x10000>; + #clock-cells =3D <1>; + #mbox-cells =3D <1>; + }; + apss_clk: clock-controller@fa80000 { compatible =3D "qcom,ipq5424-apss-clk"; reg =3D <0x0 0x0fa80000 0x0 0x20000>; --=20 2.52.0 From nobody Tue Dec 16 11:09:29 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16D9930C342; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; cv=none; b=Qf+pDESEEdt4ufH9Hposcqy0Km0ZTBMyqnwL6XTeR2EQTkTkDHiqscIoKBmzLE2bAe6SgkzNFVO0doDMR4xMwWYL6SQEXYfjPocTvEkyRr4KO3fNuj50IF1FEMTEyOpTFZ64OigogkZykGC0P2sFmbFPi0e5jGeJVwptgkBHMUo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765780529; c=relaxed/simple; bh=MjS9jO6VD8+QfNYdXo7oPN32Tfcb6ilrD8GEfqBrgw8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K2lsspEZv0kBBa+cgCMXcYUYYZFLGm0QAQFN9EMaERIyQ2G5i2T42W9P/qCPMBJDBfqB25sFvGoAxdTAUewQfleJBC+mjDzmo3bEf3MRNC/xACrgVbAFj3Yeaoyfaxh6vW5I3wc8EBco690XHzJj6fCbpuYG1kF65+rscCgpqrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=seox4hWF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="seox4hWF" Received: by smtp.kernel.org (Postfix) with ESMTPS id C506BC19423; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765780528; bh=MjS9jO6VD8+QfNYdXo7oPN32Tfcb6ilrD8GEfqBrgw8=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=seox4hWFlpqhY3/3pLfRjPM1k5qsAyJHK1H7dByU2cKzg+l+Rd5q43DWe8Ip4bAQ3 xcxKIDZULgTgnULPMdxT8KyWJWpJeWbJ/P1u8VppNYSftDDiHU5Dahv8uoPcqpDmj6 rN01MdKOkrWrVhuPGT84n0WN859Woa3/uagi0ZNn1IpGEYIMxpYIxsea3Umg5Pse7j sHGYRvI+hnG9sZth5gSHkyw71TJxFyekFj+QEYD34rZ99UW6oxuYyRfFkQEsJVr2cY 4qh+u8BPun8jnN0jyC8PU0l5f0yJIxgy8zhlPN/dNvDjDP2ymCr8albOr7NpufvI8O F3ga+tlIWocFQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD9AD5B16C; Mon, 15 Dec 2025 06:35:28 +0000 (UTC) From: George Moussalem via B4 Relay Date: Mon, 15 Dec 2025 10:35:13 +0400 Subject: [PATCH v7 8/8] arm64: dts: qcom: ipq9574: add nodes to bring up q6 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-ipq5018-wifi-v7-8-ec4adba941b5@outlook.com> References: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> In-Reply-To: <20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com> To: Bjorn Andersson , Konrad Dybcio , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manikanta Mylavarapu , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Gokul Sriram Palanisamy , George Moussalem X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1765780526; l=2816; i=george.moussalem@outlook.com; s=20250321; h=from:subject:message-id; bh=HKTfeNlvwv54VP9MClIaUbWPmauz+nFR6j+evzOUhRA=; b=QHcNLjccGRJ/zY5+DvMVYmiNZsfbuRfKVBQvOY3GSa9bYz3wIageg7+VUzLQFpy/d3A+Jxpx4 O7dFD5ocHMxDkNfM0LNydUmWTEyWX6KOEmkUS4ot5hJE87kWJBqv8Mz X-Developer-Key: i=george.moussalem@outlook.com; a=ed25519; pk=/PuRTSI9iYiHwcc6Nrde8qF4ZDhJBlUgpHdhsIjnqIk= X-Endpoint-Received: by B4 Relay for george.moussalem@outlook.com/20250321 with auth_id=364 X-Original-From: George Moussalem Reply-To: george.moussalem@outlook.com From: Manikanta Mylavarapu Enable nodes required for q6 remoteproc bring up. Signed-off-by: Manikanta Mylavarapu Signed-off-by: Gokul Sriram Palanisamy Signed-off-by: George Moussalem Reviewed-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 60 +++++++++++++++++++++++++++++++= +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qc= om/ipq9574.dtsi index 86c9cb9fffc98fdd1b0b08e81428ce5e7bb87e17..6d513fe6ad582c4923ec96a7302= 9681fcba37d70 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -3,7 +3,7 @@ * IPQ9574 SoC device tree source * * Copyright (c) 2020-2021 The Linux Foundation. All rights reserved. - * Copyright (c) 2023-2024, Qualcomm Innovation Center, Inc. All rights re= served. + * Copyright (c) 2023-2025, Qualcomm Innovation Center, Inc. All rights re= served. */ =20 #include @@ -226,6 +226,35 @@ smem@4aa00000 { hwlocks =3D <&tcsr_mutex 3>; no-map; }; + + q6_region: wcss@4ab00000 { + reg =3D <0x0 0x4ab00000 0x0 0x2b00000>; + no-map; + }; + }; + + wcss: smp2p-wcss { + compatible =3D "qcom,smp2p"; + qcom,smem =3D <435>, <428>; + + interrupt-parent =3D <&intc>; + interrupts =3D ; + + mboxes =3D <&apcs_glb 9>; + + qcom,local-pid =3D <0>; + qcom,remote-pid =3D <1>; + + smp2p_wcss_out: master-kernel { + qcom,entry-name =3D "master-kernel"; + #qcom,smem-state-cells =3D <1>; + }; + + smp2p_wcss_in: slave-kernel { + qcom,entry-name =3D "slave-kernel"; + interrupt-controller; + #interrupt-cells =3D <2>; + }; }; =20 soc: soc@0 { @@ -903,6 +932,35 @@ frame@b128000 { }; }; =20 + q6v5_wcss: remoteproc@cd00000 { + compatible =3D "qcom,ipq9574-wcss-sec-pil"; + reg =3D <0x0cd00000 0x10000>; + firmware-name =3D "ath11k/IPQ9574/hw1.0/q6_fw.mbn"; + interrupts-extended =3D <&intc GIC_SPI 325 IRQ_TYPE_EDGE_RISING>, + <&smp2p_wcss_in 0 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 1 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 2 IRQ_TYPE_NONE>, + <&smp2p_wcss_in 3 IRQ_TYPE_NONE>; + interrupt-names =3D "wdog", + "fatal", + "ready", + "handover", + "stop-ack"; + + qcom,smem-states =3D <&smp2p_wcss_out 1>, + <&smp2p_wcss_out 0>; + qcom,smem-state-names =3D "stop", + "shutdown"; + memory-region =3D <&q6_region>; + + glink-edge { + interrupts =3D ; + label =3D "rtr"; + qcom,remote-pid =3D <1>; + mboxes =3D <&apcs_glb 8>; + }; + }; + pcie1: pcie@10000000 { compatible =3D "qcom,pcie-ipq9574"; reg =3D <0x10000000 0xf1d>, --=20 2.52.0