From nobody Mon Dec 15 23:31:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0926F347FF8; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; cv=none; b=ETc8nHtn9FZHBe1e1A9FWbte9fEZHbr4ghsFZG9jtvnCglnZSSt4c+7yWX0BzFtfWv7VZB7iM1V1OO/OchM1ZYvol6stIeaHx0SR0oslXSZkU7OdgbpIyDCZVrjvYym0gaulv97FrbuFB+KjO0GLWE3fA0Rq5LvhRZ/Bg8233m0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; c=relaxed/simple; bh=YVvjG+ad6pHMfUraBILNT039YVFkeM0faHWTaRTnmfo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OUGE/LLmZw7kKSEyHnIS0puYefzrFP8LFR/SSaizZ4nE8bi6poGEXayYFsg9FUWnpRkFINAwHx3WgUn4vqNAAQevS+IlZ1dyppM09etvK9q4lh5RU7WAizPbD3+pbtrrffs6ojPKlBYK04hqy6w6z6qLCdzWY4qDlW0NX0udB3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WdduVxGz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WdduVxGz" Received: by smtp.kernel.org (Postfix) with ESMTPS id ADDB7C4CEF5; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765809005; bh=YVvjG+ad6pHMfUraBILNT039YVFkeM0faHWTaRTnmfo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=WdduVxGzhJQVjN6khiLe4OSbXFN3OPJbly6stOErcrXSJZPW+OtXAPfvpqxXNx4Lr R/wfbGNMZn8gTeyQoC65rLrrBCoJCFx0i/ugKopUL5aHaJzlntwPR6sNbXyN0lRdXF 5aAW1J/l/oApl/cuNJSgi5Eq4iSGMCGSVXz4O+4dD0LSlHkp8M1O2Wqd/qN9+aaEXA L83Ej0lJZ2hmO6TsaYbX/zAnYPaSL38S0/76nLlf9k9NSBqGZXG2yTOtiTeCnNKnTF M5vXwT0D5D9ZPyk7+QN3pV55GWVyulhgae9wvgBJlSmrQHfgrYkWXFyeDbLxx8BavQ uX54pneNFylrg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C3C0D5B16C; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 15 Dec 2025 15:30:01 +0100 Subject: [PATCH 1/4] Input: stmfts - correct wording for the warning message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-fts-fixes-v1-1-8c1e3a63ebf1@ixit.cz> References: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> In-Reply-To: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Petr Hodina , Javier Martinez Canillas , Rob Herring , Andi Shyti Cc: linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=901; i=david@ixit.cz; h=from:subject:message-id; bh=zOdQuMRtwbT9fTBVbDJbgo/FBNojnDOTgGlU+/RFodc=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpQBtrMN45yASJj+00VAkGd5xdIZEokXHQ2coVt zB6A4cgLICJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaUAbawAKCRBgAj/E00kg cmt/D/0WqN7Qnefn04HGZtDjWqh6Xd3bFVndWwMvuHkGWgqXin0Zz/PSV9ITNRECWqPY/ijIjzb QRs1FjZjoX0fwPn1I32WGLypaGIwk64KWTIY1vegL/Ocrl++34Y2YIBphH6P6uw+n5yzGRK0/Xh hAsOWgiN2FwBd1Q3qn98deFk9PJVrPq7YIDeAp7/58aBIUxvdd9kWq/B8bRv2LzufshyTkxNjq0 LExaY/z3xkYjEwuI2D9mXagWS3doWS4womk7GYxbfcWhTfW9JuLP5X6YxDhXX0efbf34/xet2Yk x4t9PEtwiYR53Y0LbJS18egxymFMXJlJezYbUTIxN8OoK+Kcaqceg3CioSQwrOyzxaeRQNizSo2 hd2sfwAREdCgTfKy9KX7CrGoMvSSxynuHrYP+0785QiwU9+dXb/kV53HQK9hDGqWJ2xTw24zpKF hjeGgxU5qQJsr60EzcT8fFnuh3sn7v5EQP3zO3dyCqG3f7RIX4uT5VQnbEO+IEaTq9g+0EdbfbH xdtPtlgZ7i9KmKXBNZRGHnKn3HJB9qLBa/K1OgKsLkos6GHp5qLew9HGDlUhouQns6M4qxBT/d7 cdUy5LSPRkuW+cBEq54O20NMWj/GwWVs7Vfq5x8lGiYfjX3F51KFq90B91xqliZXDkgphc9wqAC GPMM7leEGyjXGuQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg We're trying to enable regulator, not disable it. Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerT= ip touchscreen") Suggested-by: Petr Hodina Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 119cd26851cf6..9f5609524fef6 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -120,7 +120,7 @@ static int stmfts_brightness_set(struct led_classdev *l= ed_cdev, err =3D regulator_enable(sdata->ledvdd); if (err) { dev_warn(&sdata->client->dev, - "failed to disable ledvdd regulator: %d\n", + "failed to enable ledvdd regulator: %d\n", err); return err; } --=20 2.51.0 From nobody Mon Dec 15 23:31:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2784F346FD0; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; cv=none; b=FhAeJLTt98XzoADy4LBD4GMNaw3pFUYfjnJVYHl2OJKbjvtBGTcuqMYeXsTUGjHXXSeE24feWkEKzvX5EN73p4tlbGf1zNzlRFC3JrTeHVx3oWNH4pzFeI0+G4hQZY6kH0o7r1MAOtpdp3YFi2e1B4cxZkyIf20mdun3fx/FMCI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; c=relaxed/simple; bh=ECIRge4VolAPtMWjM+w9B4pFiGXOGHl1dGi9UBY1dM0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lEMrVzG7hnExMtFIO5EBtTx24fofyc5tPJaj3LdUmPa1xFpW48nqa9o2l8l/7YIhhUNh1O45P7dWJQUwnwlqT5V6AUyn3rifLpDnkN1s9X1Tdw7n/cVVNQJAtif0rYxb400qlbcARwC9eRehS/NcPAd3xK7qfSent+/sbWidIWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XS/JYPfi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XS/JYPfi" Received: by smtp.kernel.org (Postfix) with ESMTPS id BA85DC16AAE; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765809005; bh=ECIRge4VolAPtMWjM+w9B4pFiGXOGHl1dGi9UBY1dM0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=XS/JYPfig7JEX+7lPY5AXwkqXjRfzQLYaZ7C8zl16YUHkUsuB7TCJ9E9Bw16tLLVu oLySkVnQDZtNjBYAZbrUwuxBA+B3rd3/CiA2jAyyY5vdTJ4taSly1e5Fih/sVYBJ6E hDO0t86Wbqs3/b4PvOFOPGpUwpvvcrO3P/kxzH7j7bLoWCv4MFkHmjepGab/fYibdt TZGLAIcsJx8rQpNR7Bx5AsRiefu5aAUtKN9/biNpMQZCpp8VMKH+dVgiDAVcynQAC3 4iESSd/SQ8u52DKY48Ef1NDxmnW/UrRaQA4Ihwy55DQu9NepoHlk/3qvB6An7n1eF6 LTPY8ZuiwXXIg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B158FD5B172; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 15 Dec 2025 15:30:02 +0100 Subject: [PATCH 2/4] Input: stmfts - Make comments correct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-fts-fixes-v1-2-8c1e3a63ebf1@ixit.cz> References: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> In-Reply-To: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Petr Hodina , Javier Martinez Canillas , Rob Herring , Andi Shyti Cc: linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1218; i=david@ixit.cz; h=from:subject:message-id; bh=+8T1xTsOJVjn1XL+OiuDFzpjTwMdaheaKiJkn4uzNC0=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpQBtrVk+/KB6coTqNYuMnIBrB/vm2/YxgSKgeO 8D5TYOcCq2JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaUAbawAKCRBgAj/E00kg covAEACkdHFzLF0RrJb2jwOKLvgWbj8IznAZvFQpIEQkeIU5AwcTJ1W9s2KF9wToGtq0+B0VWj+ fhPAsSz1iFl5SYfbBL56CuJp821p0Yn4QY0SyNrahuGyu9n6i900VLzcvB0rWqrR4RV4Bc9UOio VUmytGFM0q3f2/tY2pvHMsjhV9bD3DsUOc5e9WiXBViDmgnr7WCIjtTpFyhGRJ4jMw+bA14Y2TC 07emPYv7j8L2Eq+9sQ4dNmQnP08J4XVlT1049ul3d5gfTNebtKcKoEDQ4rpcSIClPU1ODnMITnu rcWLOekQH4/CgsX62gA7rUqVISQJ0O+2XQmHaIdj6/pDLU+iQNaXcaDI7v/moY03HVuDQBpqrJ3 JD8QnHAjwIRiKKG6EDj+i72lrQ21a3w4MMMSnoGTx3k4uJP8/AE3DLzyIaYf107Hrw0hDyC5ji7 CbSlohpGYP8vOfzJccv1RnhhfoZeSmVWMPEa6G5mvuHCooAz2qT0d/tWqM3ML1Q2JAfPK6BHfK8 rgAfBlxaUqI3lwDntbn9r3fNCuGvQwiaYIZiWGuGFEoBMJbANQuULYQEXDf1kY8o0UMfNb+Qx9C mS8D/VtdQl5WRPVB2YeSpQZgUf9UMQaa6G+oZaS41jzFGqvw/Di6gFm94TxnUW14NK2BbmeCcIw hVftWP6lsLGmQUQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina No functional change. Fixes: 78bcac7b2ae1 ("Input: add support for the STMicroelectronics FingerT= ip touchscreen") Signed-off-by: Petr Hodina Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 9f5609524fef6..ad363b3c344cd 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -141,7 +141,7 @@ static enum led_brightness stmfts_brightness_get(struct= led_classdev *led_cdev) =20 /* * We can't simply use i2c_smbus_read_i2c_block_data because we - * need to read more than 255 bytes ( + * need to read 256 bytes, which exceeds the 255-byte SMBus block limit. */ static int stmfts_read_events(struct stmfts_data *sdata) { @@ -594,9 +594,6 @@ static void stmfts_power_off(void *data) sdata->regulators); } =20 -/* This function is void because I don't want to prevent using the touch k= ey - * only because the LEDs don't get registered - */ static int stmfts_enable_led(struct stmfts_data *sdata) { int err; --=20 2.51.0 From nobody Mon Dec 15 23:31:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 278CD347FFB; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; cv=none; b=KWkHasvtnKpjBHleBI1P2kbEKZskBnRCPBFV59+uthur5FCXU5b9y895N4Hzr94mbgI765E1YC+E8/uhYlU8081pPY6IPLanldJC3nncmorNH0FRivjWgplKX6cCuyz/Op5qzjth0M1j8UrBfOkws56Kv0da/O0bWSvKYE69kQ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; c=relaxed/simple; bh=wFu7HDRMAdpVlowB+kOuTDIm7pWaAUtn4h3uu6I0uGU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MyocbPvt6RFESZnrdeNYshZGcbCv4r6nZewmTxSuubdPE3hON8QQl7C4B8gcOPCdzTBvSojHcq9n/6MXYrqOxvqVJnpuLMYa2YNeTukUnx1LWbXjQn+hp/tDWfUOljQVEAYzPbOJmwVphCDK6mHq9WJbAWuL/Flbfep4nMxBUME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mVlvm8DG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mVlvm8DG" Received: by smtp.kernel.org (Postfix) with ESMTPS id CA977C19422; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765809005; bh=wFu7HDRMAdpVlowB+kOuTDIm7pWaAUtn4h3uu6I0uGU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=mVlvm8DG13DHRlf6pbQ0CwxjRX7e1QBXoyQ4zS6YYr4pwOUdlWxurFqgBKXGDtIsG Ez78EesXd/mLsNT5lLW3o2DgVPlG8fXDRuygtDjlC154UDHiNbkrgyxRkos3ifCrnm BYtZfmOevor613ejDsdJLsT503qrS/i3kIiDOeI0rCKtyuiSExeO4oJtDzwu/jXQoq QfKqhMSvajMBTbvKgpO1/iae3BGh4HstWrVKUe8Z+MhE/kjrUYyIs01+Tg4pvauLLH RQNyuEVC+c2Ed4ZKOOTFpQoOSzRoVo/n+/bg1jVEOYLMn/IYYduvNv4iePGnlhqdCk 44CJUh4W1+RoQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CBDD5B16E; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 15 Dec 2025 15:30:03 +0100 Subject: [PATCH 3/4] Input: stmfts - use sysfs_emit() instead of sprintf() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-fts-fixes-v1-3-8c1e3a63ebf1@ixit.cz> References: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> In-Reply-To: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Petr Hodina , Javier Martinez Canillas , Rob Herring , Andi Shyti Cc: linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2787; i=david@ixit.cz; h=from:subject:message-id; bh=3xHAswUTtGvoQ6NmHBshFsBrqnYL61pqa0b3OMWeB7I=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpQBtrnuNSlCDEp3U0AMCL9StDPaBZkQm8UpZo5 tdO7QEjWDuJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaUAbawAKCRBgAj/E00kg ctYxEACflPTTG5VIeyFgwBgtxU3aAkYDozrwSyYm7rqhN45yyb+3Lj+UkzWI1NLtbuG1vk1o8Ql wcRbmjLeFtLKzOWvGprKN57MWOeQRduWiYWua/ZES83aVbK9SekWaxB3r7CAdMrPwjegBrDu7Lc cJDIz3yMv1AIEpwlN/eNxj85cpJP7F8+URLSuwE4NEGZcQ+AS/+nOmG0ri9WXvMz1WCs7GwZSL6 AbOfbbHS0NVVJnSI0BqY1IlSzqBeQl9JSvGVqxgPiWXatmDFaWw+R/MDOiD/Eebfg6/S6onh4+Y K7ALIXs8jyrwovmA1FU0vVeHi/hRTvfQONG4G4r1vM4XceEVZyd8u4VHoN7O3M0RGIpxRa+X48/ JYrrw0Bfe7tNzsl/m6tin9niNbdOQ6IULtAfRbA/E2PVaZDvm5VYRA5bIbb9fmWTnARq0vjshS9 Cdk5P8sbVjT9Z5AACXDF/0cMszhIU1lnq6NA0rfIO2wfqgPqTPOI8sRdld2lnG0rz7F5NM/Pc6X nioeug9YnEXFUKhdPAfEGq/xFPNyE6nukMO9zV10WU/Duc0uE1n5gapGiXvuiwVUlbn+wYGhqpx D8vVJvrBlXjrtEtD15BONuFCNhJLSfMOrccvCSbTWRQyChqsrIOVVGkMHzQgZknDgF7OMM5pXMq kci2Br62lLhawTw== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Petr Hodina Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index ad363b3c344cd..4b166b0a9a5a6 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -410,7 +410,7 @@ static ssize_t stmfts_sysfs_chip_id(struct device *dev, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%#x\n", sdata->chip_id); + return sysfs_emit(buf, "%#x\n", sdata->chip_id); } =20 static ssize_t stmfts_sysfs_chip_version(struct device *dev, @@ -418,7 +418,7 @@ static ssize_t stmfts_sysfs_chip_version(struct device = *dev, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%u\n", sdata->chip_ver); + return sysfs_emit(buf, "%u\n", sdata->chip_ver); } =20 static ssize_t stmfts_sysfs_fw_ver(struct device *dev, @@ -426,7 +426,7 @@ static ssize_t stmfts_sysfs_fw_ver(struct device *dev, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%u\n", sdata->fw_ver); + return sysfs_emit(buf, "%u\n", sdata->fw_ver); } =20 static ssize_t stmfts_sysfs_config_id(struct device *dev, @@ -434,7 +434,7 @@ static ssize_t stmfts_sysfs_config_id(struct device *de= v, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%#x\n", sdata->config_id); + return sysfs_emit(buf, "%#x\n", sdata->config_id); } =20 static ssize_t stmfts_sysfs_config_version(struct device *dev, @@ -442,7 +442,7 @@ static ssize_t stmfts_sysfs_config_version(struct devic= e *dev, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%u\n", sdata->config_ver); + return sysfs_emit(buf, "%u\n", sdata->config_ver); } =20 static ssize_t stmfts_sysfs_read_status(struct device *dev, @@ -457,7 +457,7 @@ static ssize_t stmfts_sysfs_read_status(struct device *= dev, if (err) return err; =20 - return sprintf(buf, "%#02x\n", status[0]); + return sysfs_emit(buf, "%#02x\n", status[0]); } =20 static ssize_t stmfts_sysfs_hover_enable_read(struct device *dev, @@ -465,7 +465,7 @@ static ssize_t stmfts_sysfs_hover_enable_read(struct de= vice *dev, { struct stmfts_data *sdata =3D dev_get_drvdata(dev); =20 - return sprintf(buf, "%u\n", sdata->hover_enabled); + return sysfs_emit(buf, "%u\n", sdata->hover_enabled); } =20 static ssize_t stmfts_sysfs_hover_enable_write(struct device *dev, --=20 2.51.0 From nobody Mon Dec 15 23:31:36 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D74230C37D; Mon, 15 Dec 2025 14:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; cv=none; b=SiVWXxhWzaRPcQcdkI1K0NQmWrQvi0BuufW8kLcIMhZnSA/vylo5/aJmki7ydoLTWvJms5MoPvCuVwyqsZgx2E9RP4No7X9CpNGPwFcnn90eW4tQPUDjaUEsaUtTT9L413/V+ffukFyz+AzI9bmUhXCOtXg7iEE1CmHMxNxfaVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765809006; c=relaxed/simple; bh=TVMBoDrL66oVfaYiSBbPmPDD5+tqhVvfo29udD0zzsc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OsZs8ooGiFu5tqKXq0TzmeyA5Ot7Encf2xh8Q+nXnLdQFGa3jek7lj15O5SZoHL8Rkt8zxG/G9gAil79MfSPCosBSYmpBPFS0PbsPOugUJ4+nO5gIPjROciyWya1UTdU0J+PtVSSZSJHr6txvG8+xnMlZYWTWp23K0j2X3Fwuwc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FXf41P+Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FXf41P+Y" Received: by smtp.kernel.org (Postfix) with ESMTPS id E1E61C2BC86; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765809005; bh=TVMBoDrL66oVfaYiSBbPmPDD5+tqhVvfo29udD0zzsc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=FXf41P+Yh1GfPML23QnV7Bglz7xoYIrMdIqY3p175Xv7szqQCdVLjQXf52BYoLitr 3k1Np+HOL3rCMXcbwfETwgkudaSYmayHERn3mL2t7Z6036cHw/PyEflrWgnVe8j5CJ k0Qu+SiopJ76/4/y6I6lAQ7uwerSe43igYYt7A7WTTvsM2zcsExH43uRl4tS24sNBX gZ+aKwX+jfRPknW/VTcgA/F1bnaFkBMC9iqua7btgFJayNZDox2RFJFPD7Z5f4p9sY IfjSDr/J9ufUKTHneCHD16VLZ1X7zodk1aIwoay4yZYNwTF77X+rSStoIT90f1smIX ZL4647+5oNiVw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id D82FBD5B176; Mon, 15 Dec 2025 14:30:05 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 15 Dec 2025 15:30:04 +0100 Subject: [PATCH 4/4] Input: stmfts - use client to make future code cleaner Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251215-fts-fixes-v1-4-8c1e3a63ebf1@ixit.cz> References: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> In-Reply-To: <20251215-fts-fixes-v1-0-8c1e3a63ebf1@ixit.cz> To: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Petr Hodina , Javier Martinez Canillas , Rob Herring , Andi Shyti Cc: linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, David Heidelberg X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=999; i=david@ixit.cz; h=from:subject:message-id; bh=roHV704aaY9rcMfaAuaHi+mzFaL37M4mv+RVt1dZ7JA=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBpQBtrW0Sc0TA1KAN4LrhLHI2SDk8w1khRX2x3I BJwsriezd6JAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaUAbawAKCRBgAj/E00kg choAD/9+4C7jcAftRIQrmL5PLcMe0RuAWm3WOJFJAENwF817DbTZ1B+tnoDmaq4JHk6tiS+koRK 3UflGChw68pIVdGkPMb46OmqKMJDnMynFu0J4I924oEfXtIOBygHbGn9xYuD3QdX0YiaPJFFuw4 O/OLlxo5UGd8ADmNvKnJZh+G9yeKrYnRj+hCW/cXex8+mJsPLILQTPWX0ct48oVfO6kAYF36jgZ 6BlxX0mnl+7X36LhV8nbj5mh2/3ucXyJHw90gjQXS/AwbF9Ltgmfxc0G2CHrsu/8MzoeB9ZBlhW PfEctdTDsaDOhZYDRM8D4DE4MrTQPsgDsZTKaDZjoZXawdooPQ33nJCWIyRxBgIaNUcJvNbZ7B1 cbsmz+RakyxukqjY6Ori/Jkfq99jL2IAihPjPVy20FWiVAS/NgyeRKMhuSh1Q5hwJPqc8MWAQCq 1a2u7SexBs2sx/BeQ14OuEJOBphYTKjDaymVVPbV2/24pADHQFl73+9XdLiaqogU4Tk45ts9mzx NwAtPN5nIpQLX4g3F7X2diyHKHH5XrspYM30IozfcRsEN+hNH1/y8jLhkZ47f6Rze4WUUcHBo/i j1ajLbNS9B40ZPjanNwzbW4uaNPmTTNBvuqygoURHJV5kZi0a3BSLUWh533P7/3dKWAW1qz5gqt Lx2twOZKVbNUeBA== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: Petr Hodina Make code cleaner, compiler will optimize it away anyway. Preparation for FTM5 support, where more steps are needed. Signed-off-by: Petr Hodina Signed-off-by: David Heidelberg --- drivers/input/touchscreen/stmfts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen= /stmfts.c index 4b166b0a9a5a6..06845a00348cc 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -747,9 +747,10 @@ static int stmfts_runtime_suspend(struct device *dev) static int stmfts_runtime_resume(struct device *dev) { struct stmfts_data *sdata =3D dev_get_drvdata(dev); + struct i2c_client *client =3D sdata->client; int ret; =20 - ret =3D i2c_smbus_write_byte(sdata->client, STMFTS_SLEEP_OUT); + ret =3D i2c_smbus_write_byte(client, STMFTS_SLEEP_OUT); if (ret) dev_err(dev, "failed to resume device: %d\n", ret); =20 --=20 2.51.0