From nobody Tue Dec 16 07:27:54 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8F237494 for ; Sun, 14 Dec 2025 14:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765721007; cv=none; b=CFWUdVpUE8hMJim+UnK2zGuPh4GmlAUxn8R4+AMRLONn9DhN9UsocOf25Qe3BUx0wMMT5bM8sUd/Hg+y/JVAahkynVWeQsYLSO0wGO/UvC1r/zza2Z1tz7pTufQjd26s2xrHNS0+A9TyibDyqg53QpKHIwiUaogxcOb3kd24IF8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765721007; c=relaxed/simple; bh=8dYqH8ucPcxWPakcYR3zwCTGQCldVdK45hSaE3kOkvE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QWUXEp7ZKy0RxULYRx/iH+U6dDpsMLvAIuFegzmWCqETAO9mlmujeE5S3rUT7gc/9ADSNX697t8QuIN9r3LBg7pwGTtHC7oTmO/I61cz87SqChyPBZ0p8hTzpJIzLgEHcvFZaVdd5OvmTNEXFg4Xx8UqU70wEgm6s5QIe8hBxL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pq2aQQCl; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pq2aQQCl" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7d26a7e5639so2945042b3a.1 for ; Sun, 14 Dec 2025 06:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765721005; x=1766325805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lCxY3lhzUAu/xvlgVrdpK38D40VSsWRpy5wQseo6TFU=; b=Pq2aQQClh8N/2JkSalcestdKFKBMhubFJ1Xol/fFymS5H3tiG/Nmnvg9M8P0yreMO3 4ZRrGqdqFd8v3+CLU6cs+QLJ+O1cJpbzXaMVEmtZfo4wswWMPHu6WDgHGvVsF964fmpg fK8VzAhtfMgnbE0GDW9vRXg6NZ9hhnZtxu3SLWTMkNmXMunKdZU7Ds9IIYkebBy2Nnko pYnfmx6nfTr10dfgnM5nvY2lyHXOWvOpVmityFnujEWyjeURQ6l74g6VVZZs2uE3yHaf ed7LVg9850pdCEqqDoeW4k2CnZrV6FFbzaIJXRQOlHJzUHzbGdNlQXj6KLCL7dZ6L/2c sAmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765721005; x=1766325805; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lCxY3lhzUAu/xvlgVrdpK38D40VSsWRpy5wQseo6TFU=; b=RJhxMKe9PFpWR6lYbjpY72xpG1FGSN7UrgpZcSPaOTnXg15xpsrCKSBdNzURNf2bih Lc7quAU7IyZvWw4WJQzqQ4Wj9S8LOAL7ub/clr3c9lZb4+muLQPRNXJ/NsSFHlPjMh9+ 3hMs3vUMbxUNBzVcAOi7b6mln2Lx74tAtWA25HFrjzQSkJRpfsSK9ReMD/SK6WYSdzTY Stz1ddJ8l+uUNgZ7bQ5M3ZD3ZAO10Zx2aAEc8BmvTfghcfihNschR3yXjML+Ku55ljlL v0pimcND3zNs/REeelkIBYtcTJqMc1/b9Ki1haYsF/bmVjF4jrmfovN+jGV6KelL1Na8 rUKw== X-Forwarded-Encrypted: i=1; AJvYcCWilV+5rzPcHl4TegduSPD7myOoXF1lG9cCED2RBIed+BNGJ8EXYW6T3xzwlOmGk/0kRuwUtvNgbF2aZU0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv75m89+INTpPHqHB/fDObXjLs4xG7B8kQnGS/QvO0QyPn0OnU pYCV28qZOh/xqkdXgHPWlx2C7J3MO77PINQ4GCG1FfAAGXLNBvEPamcl X-Gm-Gg: AY/fxX58nCNcNAkJMA8fWCARHRE1Bbdzv0r4w7PO/jhSBJzKLvvlnHpHpnHoRFuhWzN cJ6matGP8ONZBKFc98m+7eY+GOJ96pu5kAgAXaYDcndvCLXLBgX0frUGIZm7/Gqc1S8Xw/hNRe+ MCBA/sM1C0mL3/BY5FrFv7VJCUGXhOS2p16u+U95TBTaCTwsO6XYpHJZc6SRVtq251EnZF+Ou3p 5EaD+OxdLH4Q66ZvvFUqPEBDsUxComGICuEcIUmBHvTQY6QGQgbLtQET0kjJvTWYXk0dFpYbBVG bOTVF9T3EI0pzTAtmdRAacuNeICdLFGMA+uiF2BGrEat07yZMiV+8oaEDWUQspKNASpzm7hVKgB CdvIv83WAUr9AX5x3HF9pABTDRQt77wibnHfutYRxZ/yPgasT+CwQg8TAI1rH8wEh/GrbbzJ7d5 dDwVTbJY+yFtRATAb9zTc= X-Google-Smtp-Source: AGHT+IF/8DyCTIDqIiNfR2carEZCo4WMAg6ZpjrHBT+vhF1qd9c3UkgS9nbSXUeUzJ5pPptBTCplOw== X-Received: by 2002:a05:6a00:8c11:b0:7e8:450c:61c1 with SMTP id d2e1a72fcca58-7f671960f07mr6478071b3a.49.1765721004997; Sun, 14 Dec 2025 06:03:24 -0800 (PST) Received: from LilGuy ([2409:40c2:105b:dc88:1107:395c:23c0:2b1b]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7f4c53847e4sm10130683b3a.56.2025.12.14.06.03.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 06:03:24 -0800 (PST) From: Swaraj Gaikwad To: Sui Jingfeng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list), dri-devel@lists.freedesktop.org (open list:DRM DRIVERS FOR LOONGSON) Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Swaraj Gaikwad Subject: [PATCH] drm/loongson: Replace custom dumb_map_offset with generic helper Date: Sun, 14 Dec 2025 19:33:01 +0000 Message-ID: <20251214193302.14589-1-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The lsdc driver implements a custom dumb_map_offset callback which is functionally equivalent to the generic drm_gem_dumb_map_offset helper, but lacks standard safety checks. The generic helper adds: 1. A check to prevent mapping of imported objects (which is invalid for dumb buffers). 2. A call to drm_gem_create_mmap_offset() to ensure the offset is correctly allocated before access. Replace the custom implementation with the generic helper and remove the now unused lsdc_dumb_map_offset() function. This addresses the TODO: "Documentation/gpu/todo.rst: Remove custom dumb_map_offset implementations" Signed-off-by: Swaraj Gaikwad --- Compile-tested only. drivers/gpu/drm/loongson/lsdc_drv.c | 2 +- drivers/gpu/drm/loongson/lsdc_gem.c | 16 ---------------- drivers/gpu/drm/loongson/lsdc_gem.h | 5 ----- 3 files changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson= /lsdc_drv.c index abf5bf68eec2..50023b5573a4 100644 --- a/drivers/gpu/drm/loongson/lsdc_drv.c +++ b/drivers/gpu/drm/loongson/lsdc_drv.c @@ -45,7 +45,7 @@ static const struct drm_driver lsdc_drm_driver =3D { .debugfs_init =3D lsdc_debugfs_init, .dumb_create =3D lsdc_dumb_create, - .dumb_map_offset =3D lsdc_dumb_map_offset, + .dumb_map_offset =3D drm_gem_dumb_map_offset, .gem_prime_import_sg_table =3D lsdc_prime_import_sg_table, DRM_FBDEV_TTM_DRIVER_OPS, }; diff --git a/drivers/gpu/drm/loongson/lsdc_gem.c b/drivers/gpu/drm/loongson= /lsdc_gem.c index 6372db2d3093..9f956e63cce3 100644 --- a/drivers/gpu/drm/loongson/lsdc_gem.c +++ b/drivers/gpu/drm/loongson/lsdc_gem.c @@ -234,22 +234,6 @@ int lsdc_dumb_create(struct drm_file *file, struct drm= _device *ddev, return 0; } -int lsdc_dumb_map_offset(struct drm_file *filp, struct drm_device *ddev, - u32 handle, uint64_t *offset) -{ - struct drm_gem_object *gobj; - - gobj =3D drm_gem_object_lookup(filp, handle); - if (!gobj) - return -ENOENT; - - *offset =3D drm_vma_node_offset_addr(&gobj->vma_node); - - drm_gem_object_put(gobj); - - return 0; -} - void lsdc_gem_init(struct drm_device *ddev) { struct lsdc_device *ldev =3D to_lsdc(ddev); diff --git a/drivers/gpu/drm/loongson/lsdc_gem.h b/drivers/gpu/drm/loongson= /lsdc_gem.h index 92cbb10e6e13..f79f06874286 100644 --- a/drivers/gpu/drm/loongson/lsdc_gem.h +++ b/drivers/gpu/drm/loongson/lsdc_gem.h @@ -14,11 +14,6 @@ lsdc_prime_import_sg_table(struct drm_device *ddev, struct dma_buf_attachment *attach, struct sg_table *sg); -int lsdc_dumb_map_offset(struct drm_file *file, - struct drm_device *dev, - u32 handle, - uint64_t *offset); - int lsdc_dumb_create(struct drm_file *file, struct drm_device *ddev, struct drm_mode_create_dumb *args); base-commit: a859eca0e4cc96f63ff125dbe5388d961558b0e9 prerequisite-patch-id: 84f019e50f016ed5c37c15cb809158ab022686be -- 2.52.0