From nobody Tue Dec 16 14:48:24 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB3930CDB1 for ; Sun, 14 Dec 2025 18:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765738404; cv=none; b=qFjLjfGkFqcM4UD4gyITFhf2Jrv8+XwHb+pEuLiuvWaoBqZwVrSR6HrQeVNYuOoRB1jcQWhKUzUC4tKFguuyO0GVpH1QFFVCrjzN9yszrPDJ7Ya4HOW/3bSi6BPvJJpL+4RlOQ7L3tzTp+wz2ynLFjGxnLqF02cc/+HT+rrybzc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765738404; c=relaxed/simple; bh=xcTi/ArLHJMIefI7yhd+nfuJMCAY9cQOZ3lzKT4AGW0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T9Sy6ctm14pA1c/lokTpkGK4YfxwHxidRxLkm2Ieo5ZuwknJGucG2MEbv3IQWfR0kVV/cUGeIlFifBfYxopG+lHmB1oYwyAWNBxaK/ey5SMCThvpHTiBBfXJX6hGfLHTzgvu7JztfkxZeHMUn9ij2Y4kwhLQxIZ9RFNQ0kKRDP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V4Yk5ER0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V4Yk5ER0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8FDBC19424; Sun, 14 Dec 2025 18:53:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1765738403; bh=xcTi/ArLHJMIefI7yhd+nfuJMCAY9cQOZ3lzKT4AGW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V4Yk5ER0KFrOAKZfEuJzTk1Vnm2W0rPv2K6TwxoonVVZ9d3yPrr6kwXyxYS1CwXH7 3vsF5dM7wc6ltFpEUwbXfQ6BU+fBRoXwsdoI0XnGqo/1mfM3ndQly+mPWG5guPgBQX /D8b4ksJE2msw0Dpdn7xqLfGF4m/oH+mUqXvQfGvsEbOKqMbeCk5uyZUvKkW4AsBnQ gs6lhZxOV7f+9QxUyJuUucB8I8HgTZ0bVwvBL6OB8i4Ixtht4s/4wd6pAU7Tw55UXh 3vZiKBdnxX8lutOMnqWV6XIloh80w1RdTCEGuJhPMBar6o0K7AZE5VOeyiCTt8Akda zJXK6W+VLPPVA== From: "Mario Limonciello (AMD)" To: Yazen Ghannam , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), Jean Delvare Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org, "Mario Limonciello (AMD)" Subject: [PATCH 2/5] firmware: dmi: Adjust dmi_decode() to use enums Date: Sun, 14 Dec 2025 12:53:06 -0600 Message-ID: <20251214185309.152614-3-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251214185309.152614-1-superm1@kernel.org> References: <20251214185309.152614-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dmi_decode() has hardcoded values with comments for each DMI entry type. The same information is already in dmi.h though, so drop the comments and use the definitions instead. Signed-off-by: Mario Limonciello (AMD) Reviewed-by: Yazen Ghannam --- drivers/firmware/dmi_scan.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 70d39adf50dca..80aded4c778bc 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -484,14 +484,14 @@ static void __init dmi_memdev_walk(void) static void __init dmi_decode(const struct dmi_header *dm, void *dummy) { switch (dm->type) { - case 0: /* BIOS Information */ + case DMI_ENTRY_BIOS: dmi_save_ident(dm, DMI_BIOS_VENDOR, 4); dmi_save_ident(dm, DMI_BIOS_VERSION, 5); dmi_save_ident(dm, DMI_BIOS_DATE, 8); dmi_save_release(dm, DMI_BIOS_RELEASE, 21); dmi_save_release(dm, DMI_EC_FIRMWARE_RELEASE, 23); break; - case 1: /* System Information */ + case DMI_ENTRY_SYSTEM: dmi_save_ident(dm, DMI_SYS_VENDOR, 4); dmi_save_ident(dm, DMI_PRODUCT_NAME, 5); dmi_save_ident(dm, DMI_PRODUCT_VERSION, 6); @@ -500,33 +500,33 @@ static void __init dmi_decode(const struct dmi_header= *dm, void *dummy) dmi_save_ident(dm, DMI_PRODUCT_SKU, 25); dmi_save_ident(dm, DMI_PRODUCT_FAMILY, 26); break; - case 2: /* Base Board Information */ + case DMI_ENTRY_BASEBOARD: dmi_save_ident(dm, DMI_BOARD_VENDOR, 4); dmi_save_ident(dm, DMI_BOARD_NAME, 5); dmi_save_ident(dm, DMI_BOARD_VERSION, 6); dmi_save_ident(dm, DMI_BOARD_SERIAL, 7); dmi_save_ident(dm, DMI_BOARD_ASSET_TAG, 8); break; - case 3: /* Chassis Information */ + case DMI_ENTRY_CHASSIS: dmi_save_ident(dm, DMI_CHASSIS_VENDOR, 4); dmi_save_type(dm, DMI_CHASSIS_TYPE, 5); dmi_save_ident(dm, DMI_CHASSIS_VERSION, 6); dmi_save_ident(dm, DMI_CHASSIS_SERIAL, 7); dmi_save_ident(dm, DMI_CHASSIS_ASSET_TAG, 8); break; - case 9: /* System Slots */ + case DMI_ENTRY_SYSTEM_SLOT: dmi_save_system_slot(dm); break; - case 10: /* Onboard Devices Information */ + case DMI_ENTRY_ONBOARD_DEVICE: dmi_save_devices(dm); break; - case 11: /* OEM Strings */ + case DMI_ENTRY_OEMSTRINGS: dmi_save_oem_strings_devices(dm); break; - case 38: /* IPMI Device Information */ + case DMI_ENTRY_IPMI_DEV: dmi_save_ipmi_device(dm); break; - case 41: /* Onboard Devices Extended Information */ + case DMI_ENTRY_ONBOARD_DEV_EXT: dmi_save_extended_devices(dm); } } --=20 2.43.0