From nobody Tue Dec 16 07:34:51 2025 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C4041917FB for ; Sun, 14 Dec 2025 16:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765731494; cv=none; b=GVnq9U77AaLrp5fqC3nundGGdOYXiIOG4afAilNFSDCCh5HffhFQgm66PE5Lxm10kS+UJpUolbCDD0LVZnu7kdXrFBXxcnp9DRZgqh5oGTVoqpXoIZNyJZAkBpxZvjqtC4YnZ1wm91sh3x/uhZ1kdqiF+Sp2ZdaeihCsZI90DRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765731494; c=relaxed/simple; bh=ISmycqYky+2NTb7BAZDQOfuDKX8IRgjkA876AxwZVks=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=M5bJsiZ8WOjmRCl+7YP0k/r/JGZPX7wsEGHGmyj8X7FkkvghZP6FE3BmJ7n+/aKCGR/g0tj9DwRIPNGahvoIL0OrvPKY4dBg/GvnIcDJKIUGoKyJ34K1Ees57JhdIxM8rBnOQuiqVmmcn2fYPIG4peoFoyUGU3r3gmQDyn3pEOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kYlCNCxF; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kYlCNCxF" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7acd9a03ba9so2890613b3a.1 for ; Sun, 14 Dec 2025 08:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765731490; x=1766336290; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lL6hygbxUVsI8BHZfLnA/K5LJDNfo5wluQiltS/Md34=; b=kYlCNCxFWJ2guB2ByOmWCZCuWw7qCFNtbXZWutLNpGtLtmKzRYr7KLmMLb8Bf4TWXM qMmHdHn+8HZopIyqcx0DRuyYG+XtPVty80AhrQMlLTJDDEi/lPQkI0ds9KaxiLU+mI8F 4T7q4otkeQR1z7jwzUI6Q9uIKF5Uytr7oBl1NYU4j2BV+brVqumWlyYAEmyo1gVv2AdN BbcenZD3as4zToyUsM9wnefrEER1Z19CCQj1jpsND53XYtzyMBnsBls4dXofzToNFrGC cLlGCMwtGD1IJ5ziyZl5Zm4LIB2ezZyJDMieXNYVMsuT3JL2M3On/Dzwd1HCeRXSyjtP Zr5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765731490; x=1766336290; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lL6hygbxUVsI8BHZfLnA/K5LJDNfo5wluQiltS/Md34=; b=lncj2HyesUd8WR5quUTxuNqyY8umag/iFNogYpVUN17H4849sSaizZJQe0fPdhM3fS ysMDFpVVdpOBMWXPSCj9TtFL1gTMAA1IgO4lz9T1S/XntGmw+R89eIRJJyqRWudwBjMn 0SD8lZn3UfvUw3KWzfMgPymPT9EsFNGEZVhcKGoeCFteU0LCsBxTqpAzyjLzU0GSb4DB cQUqW1M5r3l1R7NTMYswKh7qN8suU3ANUcf36bAzQgJHcN/W/GdpnZd1Mu082BI1YerX HU/D41yar3uGIAsEhMxlQHQ1MiZzSdBNBTi5qS+pgEaTk09kGVOb90xDA/4l4mgp/Fo6 z9cQ== X-Forwarded-Encrypted: i=1; AJvYcCVP8kghXMuf9HqfvB3tDPffrUC8NR6KHL62DZZBcjnkntdMmJ92Hg6qGNBOpcMQUlOEH3WC9LySm22/tVE=@vger.kernel.org X-Gm-Message-State: AOJu0YzGQXbNPaYM+fO79oOQ7Zofr15evM5AQwuGR+vjIJyo3O0dXwEA DVFbrHWv1LG9oB27v87fwf7tIvcfeAfAylU8L8aly/iBh7qUrqM+nls9z0YpK/8Jev5lKw== X-Gm-Gg: AY/fxX7WQllPGcmtkDZeYhYzXWqzKBBQwAjrfTKBIk54sUjphkYXhd3VCro2d7q1QGW nRUGpB5KmPUOMskh6KTPxLe3nzMtFy5Yi+Z0IJIWtRilGg1fclgt1GAuiSSfpwKh0Cik2NdR+BK 4grY7sRlCUnGyYSkJ55Kqqg+1qYl2bUfnEz2S/xjPWyj2MIQs9veGwPMcXlSognD2SHuLkr9hZS 1FLN98D51hTl0pzXAimMbl4A4wH1N8g03Ab7ywYOU+rNj5tAXSx7+vGQN/WWi0QMRBrxag6b5KE tULfSQJFQusB8jcEDygSajibWetUFNJmJ3HeQd4cpQCMkTc21d3bL/J9Nx0D16tPn8zaeYA/aih dOQgDk9ni7WQaNSElY/Ut5RzA9Zp8+/ttviEMytNtCyEyZE9CYmIzjm/R0JzNxqlkBYg+P1D0YN OSzdqAxv8MVzn46/IbetcKizOTuxLv3D9KBhVL2Q== X-Google-Smtp-Source: AGHT+IHsbInXRQqbTLdEFr1P1BC4SUBFzkFik/LvrU0xazrRQVNGRoe6iJFGpI4ueVdgoVxmyjkniA== X-Received: by 2002:a05:6a00:3403:b0:7e8:4398:b35a with SMTP id d2e1a72fcca58-7f6691b1669mr7385481b3a.45.1765731490348; Sun, 14 Dec 2025 08:58:10 -0800 (PST) Received: from localhost.localdomain ([210.228.119.9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c2d48514sm10342023b3a.30.2025.12.14.08.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 14 Dec 2025 08:58:09 -0800 (PST) From: Ryota Sakamoto To: Andrew Morton Cc: Andy Shevchenko , David Gow , linux-kernel@vger.kernel.org, Ryota Sakamoto Subject: [PATCH RFC] lib/tests: Convert test_uuid module to KUnit Date: Sun, 14 Dec 2025 16:54:53 +0000 Message-Id: <20251214165453.333210-1-sakamo.ryota@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move lib/test_uuid.c to lib/tests/uuid_kunit.c and convert it to use KUnit. This change switches the ad-hoc test code to standard KUnit test cases. The test data remains the same, but the verification logic is updated to use KUNIT_EXPECT_* macros. Also remove CONFIG_TEST_UUID from arch/*/configs/* because the configs already defined CONFIG_KUNIT_ALL_TESTS so new CONFIG_UUID_KUNIT_TEST will be enabled by CONFIG_KUNIT_ALL_TESTS. Signed-off-by: Ryota Sakamoto Acked-by: Geert Uytterhoeven --- Note: This patch performs both the move and the conversion in a single commit. As a result, old file is deleted and new file is created instead of moving file. So I am sending this patch as RFC to check if single commit approach is acceptable, or I should separate two commits to preserve git history. Regarding license: The original file used MODULE_LICENSE("Dual BSD/GPL") but lacked of SPDX-License-Identifier so I add "SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0" to match original license. arch/m68k/configs/amiga_defconfig | 1 - arch/m68k/configs/apollo_defconfig | 1 - arch/m68k/configs/atari_defconfig | 1 - arch/m68k/configs/bvme6000_defconfig | 1 - arch/m68k/configs/hp300_defconfig | 1 - arch/m68k/configs/mac_defconfig | 1 - arch/m68k/configs/multi_defconfig | 1 - arch/m68k/configs/mvme147_defconfig | 1 - arch/m68k/configs/mvme16x_defconfig | 1 - arch/m68k/configs/q40_defconfig | 1 - arch/m68k/configs/sun3_defconfig | 1 - arch/m68k/configs/sun3x_defconfig | 1 - arch/powerpc/configs/ppc64_defconfig | 1 - lib/Kconfig.debug | 11 +++ lib/Makefile | 1 - lib/test_uuid.c | 134 --------------------------- lib/tests/Makefile | 1 + lib/tests/uuid_kunit.c | 106 +++++++++++++++++++++ 18 files changed, 118 insertions(+), 148 deletions(-) delete mode 100644 lib/test_uuid.c create mode 100644 lib/tests/uuid_kunit.c diff --git a/arch/m68k/configs/amiga_defconfig b/arch/m68k/configs/amiga_de= fconfig index bfc1ee7c8158..1439abb69f73 100644 --- a/arch/m68k/configs/amiga_defconfig +++ b/arch/m68k/configs/amiga_defconfig @@ -618,7 +618,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/apollo_defconfig b/arch/m68k/configs/apollo_= defconfig index d9d1f3c4c70d..6a4e71866f60 100644 --- a/arch/m68k/configs/apollo_defconfig +++ b/arch/m68k/configs/apollo_defconfig @@ -575,7 +575,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/atari_defconfig b/arch/m68k/configs/atari_de= fconfig index 523205adccc8..46ad7d57b4fc 100644 --- a/arch/m68k/configs/atari_defconfig +++ b/arch/m68k/configs/atari_defconfig @@ -595,7 +595,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/bvme6000_defconfig b/arch/m68k/configs/bvme6= 000_defconfig index 7b0a4ef0b010..867bfa13a44c 100644 --- a/arch/m68k/configs/bvme6000_defconfig +++ b/arch/m68k/configs/bvme6000_defconfig @@ -567,7 +567,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/hp300_defconfig b/arch/m68k/configs/hp300_de= fconfig index 089c5c394c62..5dfe602cafd4 100644 --- a/arch/m68k/configs/hp300_defconfig +++ b/arch/m68k/configs/hp300_defconfig @@ -577,7 +577,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/mac_defconfig b/arch/m68k/configs/mac_defcon= fig index 5f2484c36733..f5d30310a349 100644 --- a/arch/m68k/configs/mac_defconfig +++ b/arch/m68k/configs/mac_defconfig @@ -594,7 +594,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/multi_defconfig b/arch/m68k/configs/multi_de= fconfig index 74f0a1f6d871..fe54e9222cc0 100644 --- a/arch/m68k/configs/multi_defconfig +++ b/arch/m68k/configs/multi_defconfig @@ -681,7 +681,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/mvme147_defconfig b/arch/m68k/configs/mvme14= 7_defconfig index 4bee18c820e4..4ff2ff0993ad 100644 --- a/arch/m68k/configs/mvme147_defconfig +++ b/arch/m68k/configs/mvme147_defconfig @@ -567,7 +567,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/mvme16x_defconfig b/arch/m68k/configs/mvme16= x_defconfig index 322c17e55c9a..6bb4738a65aa 100644 --- a/arch/m68k/configs/mvme16x_defconfig +++ b/arch/m68k/configs/mvme16x_defconfig @@ -568,7 +568,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/q40_defconfig b/arch/m68k/configs/q40_defcon= fig index 82f9baab8fea..14166c8fe234 100644 --- a/arch/m68k/configs/q40_defconfig +++ b/arch/m68k/configs/q40_defconfig @@ -584,7 +584,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/sun3_defconfig b/arch/m68k/configs/sun3_defc= onfig index f94ad226cb5b..5db924e3caf7 100644 --- a/arch/m68k/configs/sun3_defconfig +++ b/arch/m68k/configs/sun3_defconfig @@ -564,7 +564,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/m68k/configs/sun3x_defconfig b/arch/m68k/configs/sun3x_de= fconfig index a5ecfc505ab2..318c9fe42f46 100644 --- a/arch/m68k/configs/sun3x_defconfig +++ b/arch/m68k/configs/sun3x_defconfig @@ -565,7 +565,6 @@ CONFIG_ASYNC_RAID6_TEST=3Dm CONFIG_TEST_HEXDUMP=3Dm CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/pp= c64_defconfig index 2d92c11eea7e..684b3ea80f39 100644 --- a/arch/powerpc/configs/ppc64_defconfig +++ b/arch/powerpc/configs/ppc64_defconfig @@ -443,7 +443,6 @@ CONFIG_TEST_KSTRTOX=3Dm CONFIG_TEST_PRINTF=3Dm CONFIG_TEST_SCANF=3Dm CONFIG_TEST_BITMAP=3Dm -CONFIG_TEST_UUID=3Dm CONFIG_TEST_XARRAY=3Dm CONFIG_TEST_MAPLE_TREE=3Dm CONFIG_TEST_RHASHTABLE=3Dm diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ba36939fda79..b7faacf2bca3 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -3285,6 +3285,17 @@ config RATELIMIT_KUNIT_TEST =20 If unsure, say N. =20 +config UUID_KUNIT_TEST + tristate "KUnit test for UUID" if !KUNIT_ALL_TESTS + depends on KUNIT + default KUNIT_ALL_TESTS + help + This option enables the KUnit test suite for the uuid library, + which provides functions for generating and parsing UUID and GUID. + The test suite checks parsing of UUID and GUID strings. + + If unsure, say N. + config INT_POW_KUNIT_TEST tristate "Integer exponentiation (int_pow) test" if !KUNIT_ALL_TESTS depends on KUNIT diff --git a/lib/Makefile b/lib/Makefile index aaf677cf4527..586a9f9b27a9 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -89,7 +89,6 @@ ifeq ($(CONFIG_CC_IS_CLANG)$(CONFIG_KASAN),yy) GCOV_PROFILE_test_bitmap.o :=3D n endif =20 -obj-$(CONFIG_TEST_UUID) +=3D test_uuid.o obj-$(CONFIG_TEST_XARRAY) +=3D test_xarray.o obj-$(CONFIG_TEST_MAPLE_TREE) +=3D test_maple_tree.o obj-$(CONFIG_TEST_PARMAN) +=3D test_parman.o diff --git a/lib/test_uuid.c b/lib/test_uuid.c deleted file mode 100644 index 0124fad5d72c..000000000000 --- a/lib/test_uuid.c +++ /dev/null @@ -1,134 +0,0 @@ -/* - * Test cases for lib/uuid.c module. - */ -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt - -#include -#include -#include -#include -#include - -struct test_uuid_data { - const char *uuid; - guid_t le; - uuid_t be; -}; - -static const struct test_uuid_data test_uuid_test_data[] =3D { - { - .uuid =3D "c33f4995-3701-450e-9fbf-206a2e98e576", - .le =3D GUID_INIT(0xc33f4995, 0x3701, 0x450e, 0x9f, 0xbf, 0x20, 0x6a, 0x= 2e, 0x98, 0xe5, 0x76), - .be =3D UUID_INIT(0xc33f4995, 0x3701, 0x450e, 0x9f, 0xbf, 0x20, 0x6a, 0x= 2e, 0x98, 0xe5, 0x76), - }, - { - .uuid =3D "64b4371c-77c1-48f9-8221-29f054fc023b", - .le =3D GUID_INIT(0x64b4371c, 0x77c1, 0x48f9, 0x82, 0x21, 0x29, 0xf0, 0x= 54, 0xfc, 0x02, 0x3b), - .be =3D UUID_INIT(0x64b4371c, 0x77c1, 0x48f9, 0x82, 0x21, 0x29, 0xf0, 0x= 54, 0xfc, 0x02, 0x3b), - }, - { - .uuid =3D "0cb4ddff-a545-4401-9d06-688af53e7f84", - .le =3D GUID_INIT(0x0cb4ddff, 0xa545, 0x4401, 0x9d, 0x06, 0x68, 0x8a, 0x= f5, 0x3e, 0x7f, 0x84), - .be =3D UUID_INIT(0x0cb4ddff, 0xa545, 0x4401, 0x9d, 0x06, 0x68, 0x8a, 0x= f5, 0x3e, 0x7f, 0x84), - }, -}; - -static const char * const test_uuid_wrong_data[] =3D { - "c33f4995-3701-450e-9fbf206a2e98e576 ", /* no hyphen(s) */ - "64b4371c-77c1-48f9-8221-29f054XX023b", /* invalid character(s) */ - "0cb4ddff-a545-4401-9d06-688af53e", /* not enough data */ -}; - -static unsigned total_tests __initdata; -static unsigned failed_tests __initdata; - -static void __init test_uuid_failed(const char *prefix, bool wrong, bool b= e, - const char *data, const char *actual) -{ - pr_err("%s test #%u %s %s data: '%s'\n", - prefix, - total_tests, - wrong ? "passed on wrong" : "failed on", - be ? "BE" : "LE", - data); - if (actual && *actual) - pr_err("%s test #%u actual data: '%s'\n", - prefix, - total_tests, - actual); - failed_tests++; -} - -static void __init test_uuid_test(const struct test_uuid_data *data) -{ - guid_t le; - uuid_t be; - char buf[48]; - - /* LE */ - total_tests++; - if (guid_parse(data->uuid, &le)) - test_uuid_failed("conversion", false, false, data->uuid, NULL); - - total_tests++; - if (!guid_equal(&data->le, &le)) { - sprintf(buf, "%pUl", &le); - test_uuid_failed("cmp", false, false, data->uuid, buf); - } - - /* BE */ - total_tests++; - if (uuid_parse(data->uuid, &be)) - test_uuid_failed("conversion", false, true, data->uuid, NULL); - - total_tests++; - if (!uuid_equal(&data->be, &be)) { - sprintf(buf, "%pUb", &be); - test_uuid_failed("cmp", false, true, data->uuid, buf); - } -} - -static void __init test_uuid_wrong(const char *data) -{ - guid_t le; - uuid_t be; - - /* LE */ - total_tests++; - if (!guid_parse(data, &le)) - test_uuid_failed("negative", true, false, data, NULL); - - /* BE */ - total_tests++; - if (!uuid_parse(data, &be)) - test_uuid_failed("negative", true, true, data, NULL); -} - -static int __init test_uuid_init(void) -{ - unsigned int i; - - for (i =3D 0; i < ARRAY_SIZE(test_uuid_test_data); i++) - test_uuid_test(&test_uuid_test_data[i]); - - for (i =3D 0; i < ARRAY_SIZE(test_uuid_wrong_data); i++) - test_uuid_wrong(test_uuid_wrong_data[i]); - - if (failed_tests =3D=3D 0) - pr_info("all %u tests passed\n", total_tests); - else - pr_err("failed %u out of %u tests\n", failed_tests, total_tests); - - return failed_tests ? -EINVAL : 0; -} -module_init(test_uuid_init); - -static void __exit test_uuid_exit(void) -{ - /* do nothing */ -} -module_exit(test_uuid_exit); - -MODULE_AUTHOR("Andy Shevchenko "); -MODULE_DESCRIPTION("Test cases for lib/uuid.c module"); -MODULE_LICENSE("Dual BSD/GPL"); diff --git a/lib/tests/Makefile b/lib/tests/Makefile index 601dba4b7d96..9a20608f65f5 100644 --- a/lib/tests/Makefile +++ b/lib/tests/Makefile @@ -49,5 +49,6 @@ obj-$(CONFIG_STRING_HELPERS_KUNIT_TEST) +=3D string_helpe= rs_kunit.o obj-$(CONFIG_USERCOPY_KUNIT_TEST) +=3D usercopy_kunit.o obj-$(CONFIG_UTIL_MACROS_KUNIT) +=3D util_macros_kunit.o obj-$(CONFIG_RATELIMIT_KUNIT_TEST) +=3D test_ratelimit.o +obj-$(CONFIG_UUID_KUNIT_TEST) +=3D uuid_kunit.o =20 obj-$(CONFIG_TEST_RUNTIME_MODULE) +=3D module/ diff --git a/lib/tests/uuid_kunit.c b/lib/tests/uuid_kunit.c new file mode 100644 index 000000000000..de71b2649dac --- /dev/null +++ b/lib/tests/uuid_kunit.c @@ -0,0 +1,106 @@ +// SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 +/* + * Test cases for lib/uuid.c module. + */ + +#include +#include + +struct test_uuid_data { + const char *uuid; + guid_t le; + uuid_t be; +}; + +static const struct test_uuid_data test_uuid_test_data[] =3D { + { + .uuid =3D "c33f4995-3701-450e-9fbf-206a2e98e576", + .le =3D GUID_INIT(0xc33f4995, 0x3701, 0x450e, 0x9f, 0xbf, 0x20, 0x6a, 0x= 2e, 0x98, 0xe5, 0x76), + .be =3D UUID_INIT(0xc33f4995, 0x3701, 0x450e, 0x9f, 0xbf, 0x20, 0x6a, 0x= 2e, 0x98, 0xe5, 0x76), + }, + { + .uuid =3D "64b4371c-77c1-48f9-8221-29f054fc023b", + .le =3D GUID_INIT(0x64b4371c, 0x77c1, 0x48f9, 0x82, 0x21, 0x29, 0xf0, 0x= 54, 0xfc, 0x02, 0x3b), + .be =3D UUID_INIT(0x64b4371c, 0x77c1, 0x48f9, 0x82, 0x21, 0x29, 0xf0, 0x= 54, 0xfc, 0x02, 0x3b), + }, + { + .uuid =3D "0cb4ddff-a545-4401-9d06-688af53e7f84", + .le =3D GUID_INIT(0x0cb4ddff, 0xa545, 0x4401, 0x9d, 0x06, 0x68, 0x8a, 0x= f5, 0x3e, 0x7f, 0x84), + .be =3D UUID_INIT(0x0cb4ddff, 0xa545, 0x4401, 0x9d, 0x06, 0x68, 0x8a, 0x= f5, 0x3e, 0x7f, 0x84), + }, +}; + +static const char * const test_uuid_wrong_data[] =3D { + "c33f4995-3701-450e-9fbf206a2e98e576 ", /* no hyphen(s) */ + "64b4371c-77c1-48f9-8221-29f054XX023b", /* invalid character(s) */ + "0cb4ddff-a545-4401-9d06-688af53e", /* not enough data */ +}; + +static void uuid_test_guid_valid(struct kunit *test) +{ + unsigned int i; + const struct test_uuid_data *data; + guid_t le; + + for (i =3D 0; i < ARRAY_SIZE(test_uuid_test_data); i++) { + data =3D &test_uuid_test_data[i]; + KUNIT_EXPECT_EQ(test, guid_parse(data->uuid, &le), 0); + KUNIT_EXPECT_TRUE(test, guid_equal(&data->le, &le)); + } +} + +static void uuid_test_uuid_valid(struct kunit *test) +{ + unsigned int i; + const struct test_uuid_data *data; + uuid_t be; + + for (i =3D 0; i < ARRAY_SIZE(test_uuid_test_data); i++) { + data =3D &test_uuid_test_data[i]; + KUNIT_EXPECT_EQ(test, uuid_parse(data->uuid, &be), 0); + KUNIT_EXPECT_TRUE(test, uuid_equal(&data->be, &be)); + } +} + +static void uuid_test_guid_invalid(struct kunit *test) +{ + unsigned int i; + const char *uuid; + guid_t le; + + for (i =3D 0; i < ARRAY_SIZE(test_uuid_wrong_data); i++) { + uuid =3D test_uuid_wrong_data[i]; + KUNIT_EXPECT_EQ(test, guid_parse(uuid, &le), -EINVAL); + } +} + +static void uuid_test_uuid_invalid(struct kunit *test) +{ + unsigned int i; + const char *uuid; + uuid_t be; + + for (i =3D 0; i < ARRAY_SIZE(test_uuid_wrong_data); i++) { + uuid =3D test_uuid_wrong_data[i]; + KUNIT_EXPECT_EQ(test, uuid_parse(uuid, &be), -EINVAL); + } +} + +static struct kunit_case uuid_test_cases[] =3D { + KUNIT_CASE(uuid_test_guid_valid), + KUNIT_CASE(uuid_test_uuid_valid), + KUNIT_CASE(uuid_test_guid_invalid), + KUNIT_CASE(uuid_test_uuid_invalid), + {}, +}; + +static struct kunit_suite uuid_test_suite =3D { + .name =3D "uuid", + .test_cases =3D uuid_test_cases, +}; + +kunit_test_suite(uuid_test_suite); + +MODULE_AUTHOR("Andy Shevchenko "); +MODULE_DESCRIPTION("Test cases for lib/uuid.c module"); +MODULE_LICENSE("Dual BSD/GPL"); --=20 2.34.1