From nobody Sun Dec 14 05:56:49 2025 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B58531E5205 for ; Sat, 13 Dec 2025 14:53:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765637589; cv=none; b=WAuXktHEo0qD5Jp/bms0FEfyUUsfHaEoOsRF1LDg6LXcbfcbL2w8nJwethCobP4JFB6aLfrgk6TJnFTPPG8BNkszgqK/HVviMlribwZWpqAW3kLJRim2bquf/R5VI/IiTD6VL/ZJRM0Jeg73unNHvsab2Rj5Z2VBlDy7NWsJHFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765637589; c=relaxed/simple; bh=4R6TSlXfUMmFdJR4o1UhCXmiq6RYJfcD5Q+FvL+r66M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UdXgGmDZEdghG1FM1GFIoDZD4+Tc3o5vaIQctmIBsTOkCvxikGIpwmnsaUfVGBisHoO8DgzKeKoAKQImps1oiEGzoorS8yPqZmEM1cd7CR6eZEtVx5ue2XmTevDjFs6skzom3SyTP0WdV5E32CBsBW2ywDJh4DxeIH7C/5t3/q8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Tqhbs7wh; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Tqhbs7wh" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-3436a97f092so3619989a91.3 for ; Sat, 13 Dec 2025 06:53:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765637587; x=1766242387; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dqhPVfC6SZiXAXM+VHctjJfUvTdA8pHgty0TuL9jqcc=; b=Tqhbs7whYrArHRnvRodg0hi8GFZu5sqdCJfTDyqOh4kUQtp7u6axlx6EhLLNStZ8Mc 8R7p9WaD9q1oKUCj2Bmkp0Ktx5jnh3af+AQD1J6akjXm7tv+nL/bLF3TdeRpqBgZi41n U5EbWyrI2HbZ0I+F0yiLhpoK5cp4BhdvXZ88+DK1uBbA+l8OMK4kQKckrqe1dCWks0y3 3bFUQbzm+FpVFQdJH5ZO3+Bj1DTIKV7SyvS4qm4Od/YRhTHMl9AMhj7wMzD2fcSKMb/K QNwISYyuGfDffGSQkFCAbHRVOqxZdhg3fmk1ErFOqlmiW2y8685uT3pjnjCtAaPook9p 4fNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765637587; x=1766242387; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dqhPVfC6SZiXAXM+VHctjJfUvTdA8pHgty0TuL9jqcc=; b=KjA8LvvfPI5DxoTdmP/S27NUX94dt1BNuwDsixRDaHJrFS+UyNtf8cGRnnZSMGSvwK VDqUR7L+6Xb6G1eZr/GwpHLjyZc0IPFFHKxNlSLRKRGgzGOd4Req6eCpiNzja7quHJwx I/VknGGcIVmeiLCVRJA6IgcIP2vrXUePgbTmVAP5ox+M6bgDEGdaMpxwEHolkIegPWq6 LMvJ8pylG0IfgMDQbHWwf8OX1XkUoc1oPEZjAu96qc6ppIui4nFNkIud3oInNy37X/gB 8TZ5bHlhIOErqcGDsMq/UEHbKYq9knSwBNVJIzkLvgpiJT4gay0mORat94JETuwAkT55 nV6Q== X-Forwarded-Encrypted: i=1; AJvYcCWyoveEbppqU8e/498Y0pw8iMqJa3E1BYwWFPKJgdrJBkp0LgjJNNvK1CPx4tWIqyM1fDCcekGzpvc60mQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1zhDyCRxCOzj4ALyaMEnqxnu3Ow6cowhtc6axNEXfnQph2rdT k/7w5nqVez9GJCZZpoIj7aN5CX7EzTfsExs5vUPvPnvmr701ulGR1a3x X-Gm-Gg: AY/fxX4HHWkuWjxvt1YDJTMxd4T1Xolpg0cRM828uTy8i6beP20fUd/oCeGgf09EZLn rmAUfmwvIGLNRt8zZeJVyEDuumbiW+dBy51bmUpouYVS2/bVWSgQ0i8mBypNin0jQsMCiKc9/Ys x48MuVaFFFz9hC0ZA0kYdbEc2PCnCgt30ocClJoffw8MIIAlyffAdoKcmEvX1s2XAgVkU3Ay5u0 uJMp/gqY6kBG1X1XuC5x7BEiswYEwaLZbpJwxtJk9dJCZ2rUveMiZ0TLhaoFgHWYsBuW0n6XCoc sw4CEKdyvHRcqYoLpmp6L6cZO/VcrBA9Kc0CLhJs3b6P8/a6q+17VIQTTC8km3xVyTkQewj2Klv lwxG/RyQhLSML9DYjpmDpz2vCTEKb7Zi54209qtf1YO0GxyJCkUHMJpaU7HIVzkyMd8KqOpK/fP /LeLKVWVckN2briJnGstk= X-Google-Smtp-Source: AGHT+IHs94AtaIdi/LK1f1GL3oQjfIDINw0e2ryNLZ6e/m2MH5qRKb0B7VnFS+f9bCSyi3GmlCJ2Sg== X-Received: by 2002:a17:90b:2e0c:b0:340:ff89:8b62 with SMTP id 98e67ed59e1d1-34abd78fbedmr4750217a91.21.1765637586883; Sat, 13 Dec 2025 06:53:06 -0800 (PST) Received: from LilGuy ([2409:40c2:105b:dc88:1107:395c:23c0:2b1b]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c0c2c48bf7asm8146647a12.32.2025.12.13.06.52.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Dec 2025 06:53:06 -0800 (PST) From: Swaraj Gaikwad To: Helge Deller , Andrew Morton , Hans Verkuil , Nicolas Dufresne , Frank Li , Zi Yan , Donet Tom , Yann Dirson , Konrad Dybcio , Vivek Kasireddy , Qianfeng Rong , Kees Cook , linux-fbdev@vger.kernel.org (open list:FRAMEBUFFER LAYER), dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER), linux-kernel@vger.kernel.org (open list) Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Swaraj Gaikwad Subject: [PATCH v2] fbdev: arkfb: Request legacy VGA I/O region Date: Sat, 13 Dec 2025 20:22:34 +0000 Message-ID: <20251213202239.8772-1-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The arkfb driver uses the legacy VGA I/O range (0x3c0+) but does not request it. This can cause conflicts with other drivers that try to reserve these ports. Fix this by using devm_request_region() during the probe function. This ensures the region is properly reserved and automatically released on driver detach. v1: https://lore.kernel.org/lkml/20251213154937.104301-1-swarajgaikwad1925@= gmail.com/ Signed-off-by: Swaraj Gaikwad --- v2: - Use resource_size(&vga_res) instead of hardcoded 64 * 1024. - (Feedback from Kees Cook) Compile-tested only on x86_64. drivers/video/fbdev/arkfb.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/video/fbdev/arkfb.c b/drivers/video/fbdev/arkfb.c index ec084323115f..24e4c20d1a32 100644 --- a/drivers/video/fbdev/arkfb.c +++ b/drivers/video/fbdev/arkfb.c @@ -1018,6 +1018,12 @@ static int ark_pci_probe(struct pci_dev *dev, const = struct pci_device_id *id) pcibios_bus_to_resource(dev->bus, &vga_res, &bus_reg); + if (!devm_request_region(&dev->dev, vga_res.start, resource_size(&vga_res= ), "arkfb-vga")) { + dev_err(info->device, "cannot reserve legacy VGA ports\n"); + rc =3D -EBUSY; + goto err_find_mode; + } + par->state.vgabase =3D (void __iomem *) (unsigned long) vga_res.start; /* FIXME get memsize */ base-commit: a859eca0e4cc96f63ff125dbe5388d961558b0e9 -- 2.52.0