From nobody Sun Dec 14 06:40:55 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65CB330E0E5 for ; Fri, 12 Dec 2025 20:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765572676; cv=none; b=Q9KMvQgs3kU/uecm+dnA4mwiiD2iT+zHVkInIMAA4DUQ/iUFNZfze0GgvR1i7K2jWRI8lfUXmBc2i1a2EO0688edUEN74mt+dgYFcbFahZ8iHlAEjsD4Jz1oCy+ZDoF3MuSBYzKVLcAEK1YkEwYhZz5a0rKLw+E3jlMeiL6HSn0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765572676; c=relaxed/simple; bh=HZElLVOBo++aUOfBn0dfeQ9TDOuzLpu6pDq8v/AVPfI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kOXj7u6jlXFcHl2n5wBKa67BBGm6uJZGAVQTbbN5K3V/i9y95kL+9knw25dBnVDb7uGtpOvhfWd+JSVlV6suLlcN/ghDtmk7NNHnUmsRSD2faEldgzGaaZ8pcwojZcj5RP4SH5z79ifeNf7dZXXi5pALa8KKrb4+e8XNF53gOWE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PjvMyWMH; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PjvMyWMH" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-6419b7b4b80so2478529a12.2 for ; Fri, 12 Dec 2025 12:51:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765572673; x=1766177473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rjtjqxP7XdUENHCexmCRFp1dqpJh3fEH6pKkpxM/TLo=; b=PjvMyWMHHSIcOvuxBlvgqeXIyqwyHl/64zAgza74W5+PoERM2K7LSB0VpAHZYTU/Z2 MDxYT8rJe7HZCqz5v558ORBJZvPW1RKpf2AYY2huMPNnR/Z88K7RisCaPzG0/Slzaqk1 Cd/H34KivsH/H+6ny/Mgth3Dxu1nyE5FdpYvQ+iWqXJLheuTfYufmKvM7915Zn31AbSA hh8QObx4YxqAQit4ijhwt4UdNlgWLyLqHBidFqT5SaQTagS6PkFYW0icpUrfpkT5onms Jf573kzZ76lkviqs8BSJ4WVYBvRUYveW7YmpXZcpcSypwLhKFi9S451c3Bkcez1zIFPQ yO7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765572673; x=1766177473; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rjtjqxP7XdUENHCexmCRFp1dqpJh3fEH6pKkpxM/TLo=; b=F24t4drsixNNpAkaJBkbnzC5nUdaZtx1xoaqUxpSvZ6yVJoosp8ejo0jgADxPPPfSn eDEBKu7tzU8OHeYy+m/I0ZxkjkRbupuIIoDSmXyw9mQUBnnL3AbMVkbE4Vy9nO+bkWXI zM5S16wQTUxDtpmdbQ6db2piz8tfThiMmY+6W7iHfMAlRVjZznPxEM8Wj/0mS75SI83P movhjLiNtgz3nIfBY6vx/R/ZW1hQj+3qbMz4CZfppBi8sJbq47zrfBupkWMyrgwQmxVZ lbU/Yg3XvvYhM+D+zkL7sby4YxPTb6xDjlmOTpUXHQtgJgWqSvEYVuZRjLnPA8NptB3p dRkA== X-Forwarded-Encrypted: i=1; AJvYcCUM/Go28HS/dxD1BMM+6Xlv3tvseZVZTUZJf64a3z0/lntn0sxHIVv2HbHcBuWje2pKrdCMdr0hB+UnRf4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6XzIcLUIzx31NFH8pPYJf73p3d5Iz7FqzeXwH+v/+sCuKcLT/ l5jNdh30LOidNwTYsfJdLY38sPGHj7Y8t6OctXtYGQPsnGPQrI9ou2M/ X-Gm-Gg: AY/fxX68gpo9AW545fKNO803mH5iGOYCiA0JTgwc93ZcBf9kTOjinzwhVIonrw2BAfp ANf+bEjB3/mIU6Nr3WORCXEzK4nkC2C3TFsBMjGcpjP8RWivoxb4xw9SCSpIgy8nQW4JTiL7SUu YCQjYkn/pndAOnT2ciZmXhtxHOxIPaEpXEoRy5BVekueltVGGEbVYxA6WlnbsL3zesQ9P/cmNW6 Uz/t02v+rYG+FDWTmMK1+UXx3iVO/C4jaUqBiB4EpaFOFPrkOYI3bufk4MYjo2BiNUmWD02LptX +9iLGpvuehEc9d6SG7fRU07qeSsWydD311hGGyYEPgBRkGSvHcYKepqbGrqOgnH8gN7yXRGL0/k zAU/Byp3BN4Wpw1tablRzFuBOU8zY61mmnT1s8OPEgtX3TNqlRTgbhKy0gABsEfn/JbrkHSMI6F sTCL87xw74Zo8FIwU= X-Google-Smtp-Source: AGHT+IH0G8rGAjvaE42wch55hSIA5VimrXWt5TN/hh537MIqh383tSvfDzdlGbn8S/gXANm16as6JQ== X-Received: by 2002:a17:907:2d93:b0:b73:7158:d9cd with SMTP id a640c23a62f3a-b7d23a22af7mr366919966b.52.1765572672256; Fri, 12 Dec 2025 12:51:12 -0800 (PST) Received: from osama.. ([2a02:908:1b4:dac0:1401:37b6:6a29:b0c5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa570167sm656400366b.57.2025.12.12.12.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 12:51:11 -0800 (PST) From: Osama Abdelkader To: Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH] dmaengine: sun4i: fix resource leak on promise allocation failure Date: Fri, 12 Dec 2025 21:50:22 +0100 Message-ID: <20251212205022.83482-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When promise allocation fails in sun4i_dma_prep_dma_cyclic() or sun4i_dma_prep_slave_sg(), the contract and already-allocated promises are not freed, causing a resource leak. Fix this by calling sun4i_dma_free_contract() to properly clean up all resources before returning NULL on allocation failure. This addresses the TODO comments that asked whether we should free everything on error. Signed-off-by: Osama Abdelkader --- drivers/dma/sun4i-dma.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index 00d2fd38d17f..d81e705ae91f 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -861,7 +861,7 @@ sun4i_dma_prep_dma_cyclic(struct dma_chan *chan, dma_ad= dr_t buf, size_t len, plength, sconfig, dir); =20 if (!promise) { - /* TODO: should we free everything? */ + sun4i_dma_free_contract(&contract->vd); return NULL; } promise->cfg |=3D endpoints; @@ -954,8 +954,10 @@ sun4i_dma_prep_slave_sg(struct dma_chan *chan, struct = scatterlist *sgl, sg_dma_len(sg), sconfig, dir); =20 - if (!promise) - return NULL; /* TODO: should we free everything? */ + if (!promise) { + sun4i_dma_free_contract(&contract->vd); + return NULL; + } =20 promise->cfg |=3D endpoints; promise->para =3D para; --=20 2.43.0