From nobody Mon Dec 15 00:34:37 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 154023126A6 for ; Fri, 12 Dec 2025 09:09:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765530588; cv=none; b=iqZTPxBhygLMJBaSkL72DVU1WU8ME27DpTQGFRuctZ6QzrpAcc8L5op7E4lynFNe34CeeuTAXFzPHDaZ5/eIWuEEYCp2asFnBOat6bDOmg2dwR0asYx0xWNrgDoXWtl15WGhlLaXrYWqI+V7s73bDuhBzE3QCnbOn282NNXHSbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765530588; c=relaxed/simple; bh=D3r6i/9NO+Z8npqC3z8MwA4TdeRf+4guQ8E3+jDRfts=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JsiU1aBXIsO+AK0viUP2ftVm6MG3klIt+WViwfP5zIUEWsPJYBbyuOpmlWKELfdhR0QGR/eg1zVkqLtnDwWK4HGVZa2Od5H5JdH1SakG5IVeZ7r/GEIlBG284QZq68pr1OM9xkBfeGZ7Xz68L8JnruL2oHBngFvTviatO9785/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RndcCDmY; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RndcCDmY" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4779b49d724so2007185e9.0 for ; Fri, 12 Dec 2025 01:09:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765530584; x=1766135384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z0bywhy8b7lhxjwCitj4kHzqHoOqcr4/tmmb6FN4ugs=; b=RndcCDmYv4jE4JXBpvja99NQWf3OibvDDa3so8yLSCVmutiWwT7iUMfPVJBdGa/E9z TpXPdfXp8XZrbER2GcrjFseqUMX17earYyFN4rs8ZltmMI+CU7YjDeTDSFTboAJMW+kO A+uHOuT/iu6Ya7KJfteI2QFOGBMBc3FAzAN1MTCEveDT+3ozhy6wIQM67HhytoFheXdd 7BVsZCvpAC4BW3TBR68L8YqWoTzJGDP4jy7WATmIdtkC1XrsyELey+IwuhjThMU2mdG1 PutgWILQxRr+RtSW6YJOy7vjv6v1apdztaKEB96ZMVyHhRhN/nWhtzR6zO2K0Nx/MC9A X4Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765530584; x=1766135384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z0bywhy8b7lhxjwCitj4kHzqHoOqcr4/tmmb6FN4ugs=; b=Zm+ANGtHD0LYBTSdRKL+KlMzhmQM3cGzZiFYQubhPYgkPYx5eWkSHBmzDL40lktUvf kffGeo3/GwNflHsBwNTphDRRqSL3TMLPQaxDXQwoFHu2QUlo8bRCBP/jyPUyJiIyBBy0 nV3gYD7c5dtsO7fulM80f1DiY6Zz3qhuUd/5tPlQCwKXI0bbYTpxtQiIGGYjyxI62FxK chTJeIiDVs/sLnfT5PYYCasONHiqT/KaiaRaTwAraD0GRQzpbfyM5fYhX9tDKczJa4FS kpw1Qi9cViQ/JZ8dT3zrGRuCCn8jVdJk43fNnA75gqfyiBBPTGYBBT6AGGz1MaIWQrj4 Y8gA== X-Forwarded-Encrypted: i=1; AJvYcCXtFo4cmo2NV+SxJP4r8i+nWYPW6hw8tCUquHIj6Ue8qtUSaTWpNAJ/a+falxG0yWg9/gJ3KTm7wIFn/qg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0rha6YGMAIQYHUc2ttNq3LBncUGAMwYPrFmxuPRk0N3dOCLl+ nwT91sbYrWu7h4k7bCzT/ryUOzvtrU9vYHmV9iewHTCvDRk3SPgzCEqT X-Gm-Gg: AY/fxX4ClMf8Tcwj3wHL3eLrB5rzQkcz2Z32GAzYeoRTsENedlhRW4KdKCNYZN7wbZo oC7TK5PMfSkfGP7qBDNGrxAnwCH3qeW/qwkp4O7bnpfi0jQW9jHS//kEB1vMPvPVFQWjevA2Fax byPHNmxOoW3mpA43tvWqkrB0bieeaAZ7hjjBHtXKnIr20/FTT56jz+cItBS+iPQna6sS4fzp34J YSlsoLnVzm8w833dvEqGsLhrPQnb/1mk9HCvgJnjON+8XWnycQqG8EZdeE1Znm4tECvQP4oDxG+ zHVp6jJzUeJBpa0T44pW+S/SLtYzI28sqxtbM9/04d5Jn857BYgFbYV4Q78w7Zyt01JDPW83FHk q69jtuOEoVFGgqg6ES64UIsuTL5pnVKOr3XIbJy2+958dK3YXc0fQprSO1yfLvDwCIhk4oc5yo5 HoeIYjYxklf4ipxjtgCOKUnoc9uP6AsTN/Zk0NMk2xCsJnp2uY0ZPl+L+i X-Google-Smtp-Source: AGHT+IGBXNFRXnl7TTmyc+Mpbg2I69mKInzMUHolOjpY480LxHY8Q9SSmMQGsanH5vxG1DT9j2vV7w== X-Received: by 2002:a05:600c:8b62:b0:471:1387:377e with SMTP id 5b1f17b1804b1-47a8f90f781mr8789955e9.6.1765530583578; Fri, 12 Dec 2025 01:09:43 -0800 (PST) Received: from DESKTOP-5CG7AFG.localdomain ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a8f8d9c6fsm21403645e9.11.2025.12.12.01.09.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 01:09:43 -0800 (PST) From: Giorgi Tchankvetadze To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH] staging: rtl8723bs: fix memory leaks on rtw_enqueue_cmd() failure Date: Fri, 12 Dec 2025 13:09:21 +0400 Message-ID: <20251212090920.84238-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add error handling for rtw_enqueue_cmd() failures in multiple event reporting functions. When rtw_enqueue_cmd() fails to enqueue a command, the allocated memory for the command object and its parameter buffer is not freed, causing memory leaks. Add proper error checks and free the allocated memory on failure in report_survey_event(), report_surveydone_event(), report_join_res(), report_wmm_edca_update(), report_del_sta_event(), report_add_sta_event(), and survey_timer_hdl(). Signed-off-by: Giorgi Tchankvetadze --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 34 +++++++++---------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index f0e3f5568..f0831d582 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -4431,10 +4431,10 @@ void report_survey_event(struct adapter *padapter, = union recv_frame *precv_frame process_80211d(padapter, &psurvey_evt->bss); =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); + kfree(pcmd_obj); + kfree(pevtcmd); return; - } + } =20 pmlmeext->sitesurvey_res.bss_cnt++; =20 @@ -4481,8 +4481,8 @@ void report_surveydone_event(struct adapter *padapter) psurveydone_evt->bss_cnt =3D pmlmeext->sitesurvey_res.bss_cnt; =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); + kfree(pcmd_obj); + kfree(pevtcmd); } =20 return; @@ -4534,8 +4534,8 @@ void report_join_res(struct adapter *padapter, int re= s) =20 =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); + kfree(pcmd_obj); + kfree(pevtcmd); } =20 return; @@ -4581,8 +4581,8 @@ void report_wmm_edca_update(struct adapter *padapter) pwmm_event->wmm =3D 0; =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); + kfree(pcmd_obj); + kfree(pevtcmd); } =20 return; @@ -4640,9 +4640,9 @@ void report_del_sta_event(struct adapter *padapter, u= nsigned char *MacAddr, unsi pdel_sta_evt->mac_id =3D mac_id; =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); - } + kfree(pcmd_obj); + kfree(pevtcmd); + } } =20 void report_add_sta_event(struct adapter *padapter, unsigned char *MacAddr= , int cam_idx) @@ -4685,9 +4685,9 @@ void report_add_sta_event(struct adapter *padapter, u= nsigned char *MacAddr, int padd_sta_evt->cam_id =3D cam_idx; =20 if (rtw_enqueue_cmd(pcmdpriv, pcmd_obj) =3D=3D _FAIL) { - kfree(pcmd_obj); - kfree(pevtcmd); - } + kfree(pcmd_obj); + kfree(pevtcmd); + } } =20 /* Following are the event callback functions */ @@ -5116,8 +5116,8 @@ void survey_timer_hdl(struct timer_list *t) =20 init_h2fwcmd_w_parm_no_rsp(ph2c, psurveyPara, GEN_CMD_CODE(_SiteSurvey)); if (rtw_enqueue_cmd(pcmdpriv, ph2c) =3D=3D _FAIL) { - kfree(ph2c); - kfree(psurveyPara); + kfree(ph2c); + kfree(psurveyPara); } } } --=20 2.47.3