From nobody Sun Dec 14 05:53:23 2025 Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C08722C181 for ; Fri, 12 Dec 2025 07:18:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=54.207.22.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765523925; cv=none; b=ut+rnY0o0xSk3xXTE17MgzJb3UqT9IqBwbgGa+ZwmIdNPZEIBrtlUKcDBI/juOLGO6Hu5kvOca9oDHfkx4iRJU/R3SaVuKOa/0geeT/aHP+o6+Deuoak2QjMJouT9LlHfDle8jRbOTqqEJAnI0Bxfm8wMqePHmrQ3h7M1QyzZe4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765523925; c=relaxed/simple; bh=lfoQ5hQbLIDIYgTaYC6MzUaEJ9xyIvkzPIT+wtQoe1k=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=O98lA85oMSA0lZUFXfMpq/MAtmF847TFRWVqX3SqBv3BKgKQRE0DHaCZT2SuzMsyZgGHYuqX/TF9x2UpL68PR3Nu06CoEwet5/KrShY5flE8LdiagOKJlW4Mn9d3cgWzG0UhG1aHiKZGbZ3/Qg5pmSjSMSBE0g94pAE0zAyZ1ak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com; spf=pass smtp.mailfrom=uniontech.com; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b=N8NbqwK9; arc=none smtp.client-ip=54.207.22.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=uniontech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=uniontech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=uniontech.com header.i=@uniontech.com header.b="N8NbqwK9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uniontech.com; s=onoh2408; t=1765523873; bh=xqDNPQMA0ZXb9beqvbbiNQ2l/epurNxInDyeK+Wd+xQ=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=N8NbqwK9GwWGSMFJxoCYEr4s/Izl8lVKjIJTBYcN5/wFmpGYZVVjgppMI5NFHopKX zW2GpYfHeXdBk6abeT4HOJsCmkHOuwcixnX+m+oQht8RVOWpyHYmMI973dRHmxxytA /ZJOEh7BsMIo22QaF8I+o5rFzIU/IDuRpyrxQAkE= X-QQ-mid: zesmtpgz3t1765523868t4cd87e0f X-QQ-Originating-IP: Yg3483df6YQga4Ka682rLXb/HS16D3bbdDLlND/VZow= Received: from localhost.localdomain ( [123.114.60.34]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 12 Dec 2025 15:17:46 +0800 (CST) X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 1 X-BIZMAIL-ID: 6577007258687033009 EX-QQ-RecipientCnt: 5 From: Qiang Ma To: akpm@linux-foundation.org, bhe@redhat.com Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Qiang Ma Subject: [PATCH] kexec: Fix uninitialized struct kimage *image pointer Date: Fri, 12 Dec 2025 15:16:56 +0800 Message-Id: <20251212071656.834079-1-maqianga@uniontech.com> X-Mailer: git-send-email 2.20.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: zesmtpgz:uniontech.com:qybglogicsvrsz:qybglogicsvrsz3b-0 X-QQ-XMAILINFO: M5AoSkhGr8pk9OXVH0aNOypp7UmeW5dgMh83rLQvnTULcORfb3UGs1wj 8F0heAm2bSqPxbk5UaKBuPkEXj404m3d8hDQLfsnBKZuyqQz66C2vNYywqtTGDlpwXsNXa9 K9CjGDxzfmpLDBEz10RUn7KeE8Ca0+sr2Ta+2goRFrIIYkmuqEqgZDnfeE6hrrzHaC8HWtA 2QFdHkbw6Xhp2dSQVu9jbodbYTjWd3+Hv58Z6H2yJodUAUA1hAR5sf3QK6OMVWam/tbX05V 0FUwCdQn1JsmdmFfTmajAWKenuecjQC3N76Yd7fFaVn36uaQvsNeAltxx6apa0Sx4EchAwr 93mud9cSbpUJKHQqomVuyYSy/OUAbyyZRTEUy1zJnE6MKl3MqEDjqCErVWRPzB4aKy+Q1uP TtAhnWYK9b6GSPgmPd+JF8EtCaZreLDsTVbd+v4zvikKYgHUsUCra7ZIFLnUY2pFG6DoigK 1XvvXCxREFQo/uUfT9ioEEqrcm1LUvRTttmBazivD/6lXpv7GpVQxGycKgv6xG6aoXKYbDj m1C2g/UAe+FYf7JewFFJ+TwnU0+BAQdPzRmpaxsKHWup66r92G+7Ma4K/MEX6HJdOd6hXGO SESsY6zMRbh2AjJjoisGF2S3290P+EspiFyyWQGuDptRNSss88EtEi/0A9D5AfXQOsAWAzN voC+IsF45GJ1MX0+Y6gyq/l+iVnBLPXXAlIByi+ulmB/KUEz2mf6cdxjEZtQ1pkofZVCBUH sHs62kEyPPXuCLNtsJQQ0IpleH0wFPMvni3IZxEXfo1am1W1pMeBKKxejUSqp5+L29L8idw Upflo0S97BAslDas18EFUewR6X5ZG054DeAaT7RMfgPFd12IvsLrA6HWGd6dUGPmfPJbe7m tLmxHrAh27ZklIFop8YCs1GrmKW1Q+zzl4EHRTjlYIz/5iXqF5BJhVMBftuRhqijBLsjKJo 5trgOj0obZLo36OE2pIQoklFJEgRSAoHn3th0pBtwWv8DkwbOMF2ddA0FA2u6zfGLKdF0vf B0PTwHbcfRj161RE/KjLvJav7M8DQ= X-QQ-XMRINFO: M/715EihBoGSf6IYSX1iLFg= X-QQ-RECHKSPAM: 0 Content-Type: text/plain; charset="utf-8" The image is initialized to NULL. Then, after calling kimage_alloc_init, we can directly goto 'out' because at this time, the kimage_free will determine whether image is a NULL pointer. Signed-off-by: Qiang Ma Acked-by: Baoquan He --- kernel/kexec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index 28008e3d462e..9bb1f2b6b268 100644 --- a/kernel/kexec.c +++ b/kernel/kexec.c @@ -95,6 +95,8 @@ static int do_kexec_load(unsigned long entry, unsigned lo= ng nr_segments, unsigned long i; int ret; =20 + image =3D NULL; + /* * Because we write directly to the reserved memory region when loading * crash kernels we need a serialization here to prevent multiple crash @@ -129,7 +131,7 @@ static int do_kexec_load(unsigned long entry, unsigned = long nr_segments, =20 ret =3D kimage_alloc_init(&image, entry, nr_segments, segments, flags); if (ret) - goto out_unlock; + goto out; =20 if (flags & KEXEC_PRESERVE_CONTEXT) image->preserve_context =3D 1; --=20 2.20.1