From nobody Sun Dec 14 05:53:25 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E5782BD024 for ; Fri, 12 Dec 2025 05:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765519118; cv=none; b=gy/viyybYi/gTgkdXaqQINLcD4Xb0u74SSrm32su3Pb6KPwoLbOcolRdKA37WTDzXsEIa+GuBJf0p7GOCmtPsE8EaW+FQkJGcQqRTOCKHGkdUdCk96cN1nwiGKy2u7LVb9h+YlPo0+5amlhxAm94bYD6j/q79Xe8WzxaH0tyeQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765519118; c=relaxed/simple; bh=QDQh1hFjJw4Rwp21p2CYU5tmiVME/0qXLmcAtZx6An0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DIUXXellw4OU5w7JYJ+Ov6YOjh1BQqmH1ZO48BLRyNnQNwqnegxaNJ/YZ7JsIaqZ91wVHaZxssaG/n3nXhULMvJ/0I8wDqaWVLBWV+OjegsRsUbGP13ZidS6HHvWx+y5Fvj8Tox0bAMqTBFBrWx3xsKwmhYEp+ThuEW9882KFhA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nUrzgBP3; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nUrzgBP3" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-298144fb9bcso8486065ad.0 for ; Thu, 11 Dec 2025 21:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765519116; x=1766123916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f5tFOINPA5hU9NBLjqWlAIwU53x93j72lMljtonQguM=; b=nUrzgBP38L/R9jtWTOBlufU4Kv+If4k2o3D3ODL67CaL6QqXq8p4tsyUtkZikj+Rue EQc8PwYdTM7YqSh/PkNzd5tbTYN66PklJQPG6ujM7IPuj54NLoQwzVxe8jlAcHz3Aw72 cwyFVNrNQ1oRhstFHb7tZhBR4Z5S/nYeqZ/mQcDRIjHssoLlrLcOQI5cHL1G5VjQ85gK TFLz+tPTK9jTGdOOEfpezzOg8ibj5ArgT4rBaooWfITvoEUu51Enkc2NZ2PzHHwvaTCP Cq9OmDOBGuTLfH1TMradhE9mytgzC5bZIQrBJX7Xvq0loheq9ls23KDJl69sllgJxj4Z /a2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765519116; x=1766123916; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f5tFOINPA5hU9NBLjqWlAIwU53x93j72lMljtonQguM=; b=c7ZjYpkxd9/f+O0N/6R9qbQ3OLFsuQqrgW+dqQ2T593UUpxis9TENkLJkp9JHzstzP j3IRkjI3YTMGRv/p/y+6MYsoK4uq+bbEkwrSzC1EJVYZUTCP6q3lYHTgV5iPbOf61vVm ePreH7XJY+tNKbiPglTLg4i4hFX/Ho1iQXjJSmM+KyG3bEud/pvra3moLZOkN0hlCIix jCOGAJLNOZvZbfwuXlH/jVEE8IllamrtP4AnbB1Y/a8TJSZB16nb3H/OOvIO9HcQ2TEM kpC0GXPrAV/2Zk+jdTKZ0ECdewT4D/XAeZC5XVko23ujYnflzaDtXJGzKm5Wskh83T7y yxiA== X-Forwarded-Encrypted: i=1; AJvYcCUDB3qcBPbmrhlDZumzwsEOrMoe7VJHSf6c6t0cc4wjTgvHcO7nmFv+cETF9DaT6eU4f2Jq9DuyDJCyTHs=@vger.kernel.org X-Gm-Message-State: AOJu0YyXOwO3eqf12ZlvWFa+PMZCGPUv1uSLlZgnp8k1wU5biMbeNda8 uKsm7+9r22r1xF+LNfJ2dCP+2tb2IBjHeqD7fcnSfNlDl5iToYUrjGe15/Jp9sFY X-Gm-Gg: AY/fxX57lrwMgQHOB1yzLYj0wYWpOesaY9ElczSknRXJn9Mo8vLZKIoALZ5rwqdrKgY UgmCFWBYQ6r8N6d41yRaHo3PRC38kdcW37hcfNK1Eiio3ZUuTtyl2OoWbOMVASIBiUuuFag7mmI nRr32p442zVO2YDP7eWg6L64AK0apYFbzQuOplr0qHc3y3s3iMvkGs/arP3clHKpSmk4OGQp/8w xuinfqrOG3FxLyGwFIHvRXur+gW9Pv9vokvO0GeHoVLabZagVIcoKcWTwKCiARLMis3VZtt5K49 ViRM5o+F/vYnYwEW32gKq1BRXH8K01VGCud4ntSykaWa1cjX7zMvnEN0NhMZ8qPQHAmUZ0+A2rc XUg9EqLEKeN1Q3XjvUA8DARMTi3B7WHlh3Zc7a5hTS0HxSmm9HkdjPRQueGrgD0AZL1SvmaqcN0 h3jat7Hgq3h2x7SzCMVmOGS6Ick7YFJKDUd/4FJLdIHvRuTOfoYmtlfzVFlcybO8ygLqHIJcjvu KZ2qw== X-Google-Smtp-Source: AGHT+IGNup7YmTDugDMC+CiM3JJ8sIDmyXTKagZK2geQUoICzXXLoyCBmxi7MUva3cKPoITMIh0bmA== X-Received: by 2002:a17:902:c403:b0:29e:38de:6140 with SMTP id d9443c01a7336-29f23e1d4d0mr10560205ad.13.1765519116173; Thu, 11 Dec 2025 21:58:36 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:569d:4eca:4ab8:f2d8]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29eea04038dsm41782445ad.76.2025.12.11.21.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 21:58:34 -0800 (PST) From: Deepanshu Kartikey To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, heming.zhao@suse.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Subject: [PATCH v3] ocfs2: validate i_refcount_loc when refcount flag is set Date: Fri, 12 Dec 2025 11:28:26 +0530 Message-ID: <20251212055826.20929-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add validation in ocfs2_validate_inode_block() to check that if an inode has OCFS2_HAS_REFCOUNT_FL set, it must also have a valid i_refcount_loc. A corrupted filesystem image can have this inconsistent state, which later triggers a BUG_ON in ocfs2_remove_refcount_tree() when the inode is being wiped during unlink. Catch this corruption early during inode validation to fail gracefully instead of crashing the kernel. Reported-by: syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D6d832e79d3efe1c46743 Tested-by: syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/20251208084407.3021466-1-kartikey406@gmai= l.com/T/ [v1] Link: https://lore.kernel.org/all/20251212045646.9988-1-kartikey406@gmail.c= om/T/ [v2] Signed-off-by: Deepanshu Kartikey Reviewed-by: Joseph Qi --- v3: Use le16_to_cpu() for consistency with other checks (Joseph Qi) v2: Shortened error message to fix line length (Heming Zhao) --- fs/ocfs2/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 78f81950c9ee..1019ca80760c 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1484,6 +1484,13 @@ int ocfs2_validate_inode_block(struct super_block *s= b, goto bail; } =20 + if ((le16_to_cpu(di->i_dyn_features) & OCFS2_HAS_REFCOUNT_FL) && + !di->i_refcount_loc) { + rc =3D ocfs2_error(sb, "Inode #%llu has refcount flag but no i_refcount_= loc\n", + (unsigned long long)bh->b_blocknr); + goto bail; + } + rc =3D 0; =20 bail: --=20 2.43.0