From nobody Sun Dec 14 05:53:38 2025 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 405192DC320 for ; Fri, 12 Dec 2025 04:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765515418; cv=none; b=leD5sv+WjXKcO2IyjLVryBK4/kkQIriGrJQMdBCs2NMmS4JREldz74UWTcWQABC4EMF1Nbj3e+mrJdPHI8t3oF+2LF4O2nJiM4oy0nOEmdOz4+BaS+Q5zBoG3NAJSKT7+V+Y6d/fS+EuMOJGEl1lPR9SK/WC8V3Rb2jsUVBCZjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765515418; c=relaxed/simple; bh=wDAwyUet+HBPvyZd2hV45MphUZ08MbtAOwGGRPWXIjs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=quCoevA84Q4KKXXCxEviFWM0/8CyRjxqBtouAG3wJhcTgjXwW2eG60kyCO/eb2He15N/WOMEzDNfzYB17JTxYI6VCUEfK/ju/Z78LmUbiKNW5dOrE5aDG30AdFhJKPFkakzVsU5eG5ruzrQsqYI4edGcZ+CACSPGf5PFk0jSqpU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFGZCLSv; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFGZCLSv" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-343f52d15efso857238a91.3 for ; Thu, 11 Dec 2025 20:56:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765515416; x=1766120216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T/iZj20w2idoOaAIIJHJiS6sUHBCE9D0SQnvyRsKZlg=; b=nFGZCLSv1K2YbQ4pOo6IUa+og04YQTHJyB0h0D1wIjmWBQgaJ/Adx0iEz10ayYf8ti /ilK6fqLbXeKgx6VhDBgNFdAuF/AxilbSeSMt0CmZGG1Hd9iOVCVtx1BVyesSvQGrQZQ BEkcTfliY/KZpAfuweRgKksjG8kktDMXIjXLKD8JiVUKi2AIL40GYiwr8WPl9AyHx/tL UHDy9b5el47kyxpva0WS8EgtnQ2sZDB1+hsM/lA4Ig3MENvhydX4rTMaqJGtizgR5dlW klcbUejjaX3/0VgISEQoJSHkSLa9SiBni5f/GsLBaEs29lw3O6RFV/U7cEE6KkutLP0J un2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765515416; x=1766120216; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T/iZj20w2idoOaAIIJHJiS6sUHBCE9D0SQnvyRsKZlg=; b=fY+KrpFRs6Xx6HyN02WUZ9owIPwaU2oyAQ3PMgvKNtV88MxiO3WEOGZMJjoWmTDxkG mfuJ0kvihxFeUfNo7wsOsNje87vtI+VgHxtQp7yP+alQesK4EpKIErapVPsv4glH/qsO 2CA8CjgaxS9uu2zTlQkwa+wJ8VZo+8GfZmpg98ZtXqzpyunHQ7sh8d4ASzqvJXhGRXI5 vNWLqojvLoQD8xUlnPIfEVbs6Ya7c5WVidktFtxXMOw1E7ytWKVfQlGzvmaZOy38zjMf c+Vv8cNqO+Ohlo5J9vJK4jcQOH7G4QjAqnw/vfclfaLKVKOE1oCS4nq2ATkba6WqmoLR bVIQ== X-Forwarded-Encrypted: i=1; AJvYcCXfhKVfXpSBDfxiZLyRDqIdaHMhlh2NeEJKI6cNT6W/QmWh2MlGJ3uwZshEbvDR8RUkLdCWt/gFNk5AXLI=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ5JQlRS7cxlRnbVZgcax43QzD4ok2L7YVUXRMj83n1OA/Pdba urdw14OQELHXEHbjB3oFrhNjn59OC5XGBHkWBSSHmiEvHPpRBmKPXUD5 X-Gm-Gg: AY/fxX6PR4oxlYXHLn/jYBs4EdZK+hM4VbBc4fwDu5kwQYOGYpfq/WP2UsVfWWQ4zAH ZOpAXN6aiZ/3G0/vaijz1EUjwxBrdX0QL3f5maGPGJlfqE5qGF3kGYSdwsp2y+34Hc7tr+k3lKP p3BJoYGmxXpMEUDgMaNwUeEtm9u4UeR0uOjWHfJ00QmgOe7rutKpUAJDEtz8QFWbaspQYHsJvKS hRLDgyndczdBaGEC14obBPMuNBLX4EM8Enyn3xpgFgONnC97+DEIAgDvNlk/pUHlnkLuy/pyNoY VxII7t5gn5UWhwnABM0PO8iZypzo6lBAEe5ZmHfCWI8jqqu9SU5qer9Bc8b5Y0A2+WS+o27R1Ze 1yxT3lTLwgfXn1eEHLwt66AMNnq+KptLQq6hi7LOzflibU9kEeT/oB00rsWGhBskLAkOYkINfBE 0x9wbcXUXQ4s36ZZNDtFVe6/EhA8zgXHLBpV51HUO1qgwd1U0BVyN/AZSORH4UnTSTg4M= X-Google-Smtp-Source: AGHT+IGCnLEF6u3xo0XUTk14kOPwTB9ln5c3WkA98d4h3qWXYq/GxLoYR5+TSsEZM0OntcBdzu5PMQ== X-Received: by 2002:a17:90b:2fc7:b0:343:87b1:285 with SMTP id 98e67ed59e1d1-34abd76160bmr959581a91.18.1765515416351; Thu, 11 Dec 2025 20:56:56 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:aae7:653e:9526:17a4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34abe218793sm597534a91.8.2025.12.11.20.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 20:56:55 -0800 (PST) From: Deepanshu Kartikey To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, heming.zhao@suse.com Cc: ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Subject: [PATCH v2] ocfs2: validate i_refcount_loc when refcount flag is set Date: Fri, 12 Dec 2025 10:26:46 +0530 Message-ID: <20251212045646.9988-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add validation in ocfs2_validate_inode_block() to check that if an inode has OCFS2_HAS_REFCOUNT_FL set, it must also have a valid i_refcount_loc. A corrupted filesystem image can have this inconsistent state, which later triggers a BUG_ON in ocfs2_remove_refcount_tree() when the inode is being wiped during unlink. Catch this corruption early during inode validation to fail gracefully instead of crashing the kernel. Reported-by: syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3D6d832e79d3efe1c46743 Tested-by: syzbot+6d832e79d3efe1c46743@syzkaller.appspotmail.com Signed-off-by: Deepanshu Kartikey --- v2: Shortened error message to fix line length (Heming Zhao) --- fs/ocfs2/inode.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/fs/ocfs2/inode.c b/fs/ocfs2/inode.c index 78f81950c9ee..06f1f9e21423 100644 --- a/fs/ocfs2/inode.c +++ b/fs/ocfs2/inode.c @@ -1484,6 +1484,13 @@ int ocfs2_validate_inode_block(struct super_block *s= b, goto bail; } =20 + if ((di->i_dyn_features & cpu_to_le16(OCFS2_HAS_REFCOUNT_FL)) && + !di->i_refcount_loc) { + rc =3D ocfs2_error(sb, "Inode #%llu has refcount flag but no i_refcount_= loc\n", + (unsigned long long)bh->b_blocknr); + goto bail; + } + rc =3D 0; =20 bail: --=20 2.43.0