From nobody Sun Dec 14 05:53:25 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 556CC30BB83 for ; Fri, 12 Dec 2025 04:45:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765514743; cv=none; b=ndMTgm0yB+tyxdD0pjXzfu8xm2laQVGC5RlTfcQyKop7INJW3rJyv10fLmJmrmYjNreOCDqfBdqwjJH5AF8eOc+/vXeqv/03GUDMfhT9w0uFtrc5+hQSAIbgq/CO9lqx57x/2NtrQos6iSREoqwZ0aRNu0qT4ZKX3X3CtfScagA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765514743; c=relaxed/simple; bh=kN8wNtyrFPMNkBMnseS+/dcIHc+YV5MfHN3kVM6Rs2k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JxyCbPjAKkgRFGyaN+3mYgQPFest3eW90+qxF6k+cX4WHlRsObpjU2SEphsSSag9arev4tkbGEfAUmTJgnCTuIeZ3ycO0VhSKf/aKjrT8dnWdDh48DIcuhMvQ3kjDvLEBY7WeysInmgw7shguSBS/zfv30U0MEC+c8ArvpK0RC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FdDNqWrR; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FdDNqWrR" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-47775fb6c56so6559095e9.1 for ; Thu, 11 Dec 2025 20:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765514739; x=1766119539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QW5cVIdovQWDv+bqBSbnBeQJjt2jpyUHW2uxiLg7ptY=; b=FdDNqWrRHFjb0QRCgIt6CYQ1b1ehtMK0IMrog2tmegKPR7uVukAEkz8QwR2hBjJSN7 rbrgA4MBnnbYhFVmb1UEJWTb6hAluAiRk7F/Oety7o5TOjwS5OBoJJGZoXtoEjdxjFzp EXeHCg3eqJN/NLE6D+DkBlZlP+RWJBvd0IfUx3poByHlhmrmAul7LCuiUP+Nrg8575Rj Ah48dvm4xmlEwlEb4Va7vpLGoNsqtfcknpq+tnKabSt7+fqbjcBQ8yDp4kfTh6gqObHO 9k5vZD6phVeZuEv434juw40QOH6ojSRbfuanSzC16ZW1amIfgPxkXhf+BebMpKiNLB/V aobg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765514739; x=1766119539; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QW5cVIdovQWDv+bqBSbnBeQJjt2jpyUHW2uxiLg7ptY=; b=q+v0vlUHkoTX2Nadp9CttyCIo0tgQ5DndwjcWfKVHJ5ijZ2zr3OIxd1lKmx/orZzjy iFuwmHJ9A0eGMc70Pafkw2I5On54FfnJijQUmE1HlhF5dhVVgXl2UtleRS/Y1Q7V3aMM UCgaz97bCSwZHt0JvzGwi4ri2/OvW6c7bsMt28GUjZ6JWoHNb8l1Cle3nDjvLY+py5K8 +/ZKKXy4IUjLEbtYUsQBV+yuyWV1uzIMYqyM8PM5H7v0rTd2HJD4qiv1MAj9ywijLJs8 Am1Z1vgHq1ugJUD4M9yTci4lNGRST0jgaT2PM/4usy4XHRGT4/3JLQul/tfVvra5AET7 /J8g== X-Forwarded-Encrypted: i=1; AJvYcCWJkPxQmgvLh5pL+Twd3hMCaCcPTQNfvAknE9lsmOPbmJ2JFrZlcRvFn5BGvSfoMRRoyew3ef+zofN3tBk=@vger.kernel.org X-Gm-Message-State: AOJu0YzspiKjkHWaul3VsynCXzKP7Zj/vgHu7jhLyBfDVucSAZZK6iNb M49aU3IOYu30l+CgqAsC/JlaPxz56ELo04ezFsI9CWEu49xh010UJLIv X-Gm-Gg: AY/fxX5eRN57MpI0/wXVTt0Ipu/hXVPugx/MU2mWkhRGbRizIWgQIlitepE7H5elzZ7 8NO8Lw+YgNG0vWPJfeNWDlNe39Qc+izTUrVu3AqiJ8BIdzaCZMBPdh1s+DeqpZYovRdot7l/DBO bFnQSIAwn0WiVP2HRg1eXIwkR+q5fnvtb8v0GqAuVlxOuUtO/Rd0uJRDfbVq//3rAPhgKZXMkgy sm0k1XDlClSvGMRCEwaLJvsYpTsF7kDkMGPm1SUcKfimVvvKZzf3aR9IoxP1+tgnrrHX0Tu2l4Z KqreYtQGQVUk8UU4xGzumnoodlDry8Q4MqjXxEDY2TXN4polcfyRGlcAwnpdJQJ94h8K9t/WGsK FhSTI785VHOpGbYFu3WZGSvMxS4QfYkDFRMJ4mMtrDQCL4ho9ygrad9+1BML5iNIRbkxnvm+xmk AvXlsPk+ISKXy+9g== X-Google-Smtp-Source: AGHT+IHxEK1dPtN1EkZbAF0nXgZC4Mys7ot/TMtb/qd/CFD63zDMK/TbKWYGp7RBSHzfv3pozTJ40w== X-Received: by 2002:a05:6000:24c5:b0:429:8daa:c6b4 with SMTP id ffacd0b85a97d-42fb44d402amr567209f8f.21.1765514739163; Thu, 11 Dec 2025 20:45:39 -0800 (PST) Received: from gmail.com ([147.161.143.105]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8a665e3sm9861822f8f.6.2025.12.11.20.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 20:45:38 -0800 (PST) From: hariconscious@gmail.com To: lgirdwood@gmail.com, broonie@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com Cc: perex@perex.cz, tiwai@suse.com, khalid@kernel.org, shuah@kernel.org, david.hunter.linux@gmail.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, HariKrishna Sagala Subject: [PATCH RESEND] ASoC: mediatek: mt8195: optimize property formatting error handling by using scnprintf() Date: Fri, 12 Dec 2025 10:14:09 +0530 Message-ID: <20251212044408.1286-2-hariconscious@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: HariKrishna Sagala Replace snprintf() with scnprintf() when constructing the property and remove negative return error handling as scnprintf() returns the actual number of bytes written to buffer. snprintf() as defined by the C99 standard,returns the number of=20 characters that *would have been* written if enough space were=20 available.Use scnprintf() that returns the actual number of=20 characters written. Link: https://github.com/KSPP/linux/issues/105 Signed-off-by: HariKrishna Sagala --- This patch optimizes the error handling part of property formatting using the scnrpintf(). Removed the error check ret < 0 as scnprintf() doesn't return the negative value as per contract. https://www.kernel.org/doc/html/latest/core-api/kernel-api.html#c.scnprintf Thank you. sound/soc/mediatek/mt8195/mt8195-dai-etdm.c | 44 ++++++--------------- 1 file changed, 12 insertions(+), 32 deletions(-) diff --git a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c b/sound/soc/mediat= ek/mt8195/mt8195-dai-etdm.c index fd4f9f8f032d..77c58c9ec3e2 100644 --- a/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c +++ b/sound/soc/mediatek/mt8195/mt8195-dai-etdm.c @@ -2652,14 +2652,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base= _afe *afe) =20 etdm_data =3D afe_priv->dai_priv[dai_id]; =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-mclk-always-on-rate", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-mclk-always-on-rate", + of_afe_etdms[i].name); ret =3D of_property_read_u32(of_node, prop, &sel); if (ret =3D=3D 0) { etdm_data->mclk_dir =3D SND_SOC_CLOCK_OUT; @@ -2668,24 +2663,14 @@ static void mt8195_dai_etdm_parse_of(struct mtk_bas= e_afe *afe) __func__, sel); } =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-multi-pin-mode", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-multi-pin-mode", + of_afe_etdms[i].name); etdm_data->data_mode =3D of_property_read_bool(of_node, prop); =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-cowork-source", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-cowork-source", + of_afe_etdms[i].name); ret =3D of_property_read_u32(of_node, prop, &sel); if (ret =3D=3D 0) { if (sel >=3D MT8195_AFE_IO_ETDM_NUM) { @@ -2707,14 +2692,9 @@ static void mt8195_dai_etdm_parse_of(struct mtk_base= _afe *afe) dai_id =3D ETDM_TO_DAI_ID(i); etdm_data =3D afe_priv->dai_priv[dai_id]; =20 - ret =3D snprintf(prop, sizeof(prop), - "mediatek,%s-chn-disabled", - of_afe_etdms[i].name); - if (ret < 0) { - dev_info(afe->dev, "%s snprintf err=3D%d\n", - __func__, ret); - return; - } + scnprintf(prop, sizeof(prop), + "mediatek,%s-chn-disabled", + of_afe_etdms[i].name); ret =3D of_property_read_variable_u8_array(of_node, prop, disable_chn, 1, max_chn); base-commit: 30f09200cc4aefbd8385b01e41bde2e4565a6f0e --=20 2.43.0