From nobody Sun Feb 8 07:33:03 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BFD02ECE92 for ; Fri, 12 Dec 2025 03:27:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765510035; cv=none; b=GNxJ9048Nklnad5KJQDkHK5wCPwEFJuz7ZirZHW6Wa11zoiKv9vZxL2sEt3+IcYsoKKokfHrhdNlFxDffnsprdiNjbU4S1nsj/x5Q7fiE7yT9w/SGUMSP3YPiBUdxqxeAjawIDNAxUSr00rnf2C3Tv+xuyBsNVp7n6Oo8a0pa6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765510035; c=relaxed/simple; bh=vzplLiySwXqToPIZp7dgIiGEvLdy3UQNWntDgq+R38M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nqYNwv8r39JmTo4deX/E/7JwUURD388+w/q9cEKN5wZGNtLsnnuCnyF9joIbStU5ZmcfEzF5gK5rTmOfyiC65jITWE66fJ7ZTnKSQae42Sraq+W26C+aV1yFTIVtdvEi2FDsPgWB4W3KCKwZM4ffLH2lvxwok5RMyBJjqJDHO34= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ODQGYmd3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i91hOi0H; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ODQGYmd3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i91hOi0H" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BBGVeEO2372414 for ; Fri, 12 Dec 2025 03:27:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=+jNsDy2q710P3fBK1IktYIT/VJazGzVybt6 zeKfg1Sc=; b=ODQGYmd3uLd3a+GK5FI3cMkP/Y0LmQPBnpCwdUGpzdeNRthX5Tc V1SiLH/yMNE6qK8ovI08i655UOmmCAZNuqeoLF1HnnRkf5B6WH5zTgmrnK0iwdBW N6jBvPUbm3x4l2yOOvG8/ggM6E0WYun3+n5gI/55UZvgOzVL+bu8PX347itke/W1 IW4uW1tOBK3im/GMeF3cfMMkzZeSMnNrP3YtWGVp5khny/3B+rOiWr+umzPprCGN LU5lF6DvUf0F5LHlJ+Gsude12sHhgEr+oV7Z9g+z0XZ9jeqPo0c1EEfwYlCwl0H8 eL29cU9FFFPiglsHi0b3kYKC9CkP8BiPadQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b01j8hhr6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 12 Dec 2025 03:27:03 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34943d156e4so1624330a91.3 for ; Thu, 11 Dec 2025 19:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765510023; x=1766114823; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+jNsDy2q710P3fBK1IktYIT/VJazGzVybt6zeKfg1Sc=; b=i91hOi0H/+w5DKsZcT8la80Kx62e0cQ0zgegsXmtoQz54Mv+O+J0ylDfNtu3olR8++ EYGswQ5Vtb2RtPMEvi5sVKdXS/ucPlLRR/nF6/Jbl+1Cds5KXzkIOfIcr46opL1v8SQ9 9ykIXeYiTwOt4MzsN1w4GT72BVa8w8ght7NEW/NqPNoEGy+u0iZGULxM7SC6aL0JT7vq BCf5hyM0FwNdMa9v/MoBJUFowqNHgyGk/XPf1JKKPb42IhflIEDQeh72dYJrSWny7kYV bEnlEe2SOpX1NT9JWN+ExZCCsVfJY8Xj8z/GAVwxpCvCsOZ1Dec2RSNBgz7HJFcsaPq4 /U/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765510023; x=1766114823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+jNsDy2q710P3fBK1IktYIT/VJazGzVybt6zeKfg1Sc=; b=OcikuSUJPYSQ8iWa/qilsB+2//5ejjN1CVVn1rqeJynIgEckHGL9O9jpgPrOhAMzwE eUNL7jqCt9uDX/Xs+ueb6wLn/4IiZpCt8NA8A35hnvXrbqzYUMBNy9sX9Tpt7iSYpFig GN8+GS5z+YXiX2/s9zH3yA9juRFcw7t7Ap/xuTweQQbFohKI4EHPlsIS1mf6VL3zlh69 MgioOs1RZw/C+rFn5HC5ZFi/991fWZwiK47IwzCv/YUKb+KyEW7geOMEh/RzgXHCOoc0 B9MYpg5rHAoCOTWoyNbQcqRRnVBXnGKarAmgZjII64NZjolYYYiVdYK3x5KB2UeApj03 Y4Hg== X-Forwarded-Encrypted: i=1; AJvYcCVVfNd5KPbjzDIRiVJDqMJ+6Qm7Va7yRl5wFCtCdMeeOazbCCRwSHTP2IYuKhzfEFoacGQ0Cu540YmIXng=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2kz4+R3aY4brit8DBMAQdxwyxJB3/PRIKVhHxA3U0fre7GzEf tyAX4Qo08yt2bpiP7u1tQhBt6bmJDo6pXvjp6TGCccrpm8q4sqZXqY0JJJ7VC7MiLE6eGKg3LIl Wc7UGyyZEm5FkL2VLLX73K2Nek1O7OeDUjNQk6S+JEy8weRDneROegeAgqVVrRmwb1v8= X-Gm-Gg: AY/fxX6bzEE9n/mIzxq4EDJaaqmli+8OWyBt9Y1MIAPngmIGPkfMjYMMIRcdiKM/J2Q 4bdI0bl8+COjQxyptS7Yq//pYO8cnsIYAxnh6Z4rDIIS7mHwP9S5z8k2snIHomMk+ktEg/xpSMB vUU+n+oLIEjyhwzryuUuFGCfiRZR+gQU43hQPsv60gIjqXV8eGjh+jXJMi6qd/Lr3MKOvbY/4Jo mr43i/vKb6ublRr9g3UpVb5ajB25Ho36WQxYLof9iyF4pYIpQXd3YmFkJUpMa+/gGXVC0hkrBfx 8J2kDptPG6eT84fOS+X9kU+gxNjqf0O25uJUacoAQ+8ZBzGdeIx89gt0+hi7jh+tL4ur67rjeeq 9+Q7r9oDiesJqEtj1DW1XnV6MNXsBjVKd4G//iRfBkUlJFBawEq1+61OMXRi1JAU= X-Received: by 2002:a05:6a20:6a0d:b0:366:2341:4980 with SMTP id adf61e73a8af0-369ad9d3463mr723838637.11.1765510022561; Thu, 11 Dec 2025 19:27:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrkOHMeP63nKgD5aeWawmvmQw1jorX3iqI4MMXcNtI/7N6miObTs/RFSNZ+drQF18tS+ZBXw== X-Received: by 2002:a05:6a20:6a0d:b0:366:2341:4980 with SMTP id adf61e73a8af0-369ad9d3463mr723817637.11.1765510022076; Thu, 11 Dec 2025 19:27:02 -0800 (PST) Received: from brgl-uxlite (fs96f9c361.tkyc007.ap.nuro.jp. [150.249.195.97]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c264211cbsm3535538a12.11.2025.12.11.19.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 19:27:01 -0800 (PST) From: Bartosz Golaszewski To: Bartosz Golaszewski Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] eeprom: at24: use dev_err_probe() consistently Date: Fri, 12 Dec 2025 04:26:46 +0100 Message-ID: <20251212032646.49336-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: mH8ufAoirwIdz1qRrALaZmgJRrNIuCHu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjEyMDAyNiBTYWx0ZWRfX+pFPQMaI5oTe mmOu9dU1SXij5FsWmY/O0LqYpa8OFj5gEVpmAhvCbmkY/htmIkgl898uVZLTTLybbTH1k0eJkO5 vZ45C7ukauGGXyFDgv0Is1DCjw6uAiGD2JPd/YXwCqIYwkGv/C18e8lJ0BABuDo/KZjgjBkHW4n fpxA9cA/qmvUKfyuNfwJWCKzzP1LaxNTaGP9N2h6UebLCy10Nk69vsd0i3c53ZpxiVLpC1ZRDWh 0YN87JksZuLf3KXAs+YFf0lZzNe+qPCsKucICAD+A7e4dABRU3JcoUMQUzbjAKk7Pme55n9w63k +OlYMRzh77ZWrD4TqyeHFr5gWtlhVQqj+lilfYTsl0ImfB/ldJCCamDFwx2juBp+m98FUgUNZ9N sxnvW9Kz7nYhu20/CN0I9PePV2hwtw== X-Proofpoint-ORIG-GUID: mH8ufAoirwIdz1qRrALaZmgJRrNIuCHu X-Authority-Analysis: v=2.4 cv=MuxfKmae c=1 sm=1 tr=0 ts=693b8b87 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=kS9sT8ua8GhuIhCqqd6Lkg==:17 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=76UdmbcYvL-UdFPH1r8A:9 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-12_01,2025-12-11_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 adultscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512120026 Content-Type: text/plain; charset="utf-8" Save some lines by consistently using dev_err_probe() when bailing out with an error message. Signed-off-by: Bartosz Golaszewski --- drivers/misc/eeprom/at24.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c index f721825199ce..0200288d3a7a 100644 --- a/drivers/misc/eeprom/at24.c +++ b/drivers/misc/eeprom/at24.c @@ -657,10 +657,8 @@ static int at24_probe(struct i2c_client *client) if (!i2c_fn_i2c && !i2c_fn_block) page_size =3D 1; =20 - if (!page_size) { - dev_err(dev, "page_size must not be 0!\n"); - return -EINVAL; - } + if (!page_size) + return dev_err_probe(dev, -EINVAL, "page_size must not be 0!\n"); =20 if (!is_power_of_2(page_size)) dev_warn(dev, "page_size looks suspicious (no power of 2)!\n"); @@ -674,11 +672,9 @@ static int at24_probe(struct i2c_client *client) (flags & AT24_FLAG_ADDR16) ? 65536 : 256); } =20 - if ((flags & AT24_FLAG_SERIAL) && (flags & AT24_FLAG_MAC)) { - dev_err(dev, - "invalid device data - cannot have both AT24_FLAG_SERIAL & AT24_FLAG_MA= C."); - return -EINVAL; - } + if ((flags & AT24_FLAG_SERIAL) && (flags & AT24_FLAG_MAC)) + return dev_err_probe(dev, -EINVAL, + "invalid device data - cannot have both AT24_FLAG_SERIAL & AT24_F= LAG_MAC."); =20 regmap_config.val_bits =3D 8; regmap_config.reg_bits =3D (flags & AT24_FLAG_ADDR16) ? 16 : 8; @@ -759,10 +755,8 @@ static int at24_probe(struct i2c_client *client) full_power =3D acpi_dev_state_d0(&client->dev); if (full_power) { err =3D regulator_enable(at24->vcc_reg); - if (err) { - dev_err(dev, "Failed to enable vcc regulator\n"); - return err; - } + if (err) + return dev_err_probe(dev, err, "Failed to enable vcc regulator\n"); =20 pm_runtime_set_active(dev); } --=20 2.51.0