From nobody Sun Dec 14 11:59:44 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A38C3233FA for ; Fri, 12 Dec 2025 15:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765553591; cv=none; b=OvWCEz9V8F7wKQzVcoVEYqUPaXIkI0hqXETEaquWa/ecVROvJlLSJEPuHWLSnwuYCXdoIT5Nag5msad7hz5oK6iFXxNim6Rw51LVxuff1ai7cHTEbtrsYO3P5IxRA/vJbNjdy3X2Gip+/qd8cH+dcpCL1u32iIV1w4/RAobacGI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765553591; c=relaxed/simple; bh=+3Y3lcxZMqFLbNOWqAJ1uO9Sw58KGFuwnvIdXYYIXjs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eZw65EeuxBjOs0FKdkWeAGTQNhKA7A2I4mBAdAZyxpvSYcLXueuNNDgTD4CTHlnsD8KG9LMzWwn8e66BI3pjrLuj4L8f4Otz18d3qJ9/QJfwCf4GtzWSNWDL02wDGoqphugX34pXEhnWF4WS/7l4BlJQPa76Bvv3Bv4d8hDs4nM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lXjTv0nr; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lXjTv0nr" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b7636c96b9aso223177366b.2 for ; Fri, 12 Dec 2025 07:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765553586; x=1766158386; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=40w1+RpiFWn7cLTaBFnZfKV4QslzhNGDu3cnJiEGNGY=; b=lXjTv0nrAbJPl9W3BvxIeEVMca+rsYwaijKtXfThOzay2EKojwvB3HihiRzMU1HwN7 5Co2ACZgtieBQYy43tKg5bJ+XVFAiBCmDEMJx24daizO+n8mSqpmeU4vHcKdMS+2ug2Q 6UNsn4IqXFUxB47yWHHiXi4DjynO5l3bX4MAHqMQuVp2OHROgd41p6rU/aDBFDSC0MIK 1BC91E01Mb+X5VDrn+WWHEYK4FHMML5C2UVLYKT67J9mLBh8oMXn1UiOraLeqoVJays0 hwGhad8bKnwJvx7qVI68C0DCJ841mMmRfZPtzozd7ZrhWXTlbO7CZvfQi8ZKJe1IStrJ s4Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765553586; x=1766158386; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=40w1+RpiFWn7cLTaBFnZfKV4QslzhNGDu3cnJiEGNGY=; b=v6uTle0kQWmok/Qy6Fexl2Qcaa31NQMSCi5e/p58YvYz/U9Eg4FBvOA+SFqNhd8Oq+ HYzOJqIQyyFZUgVx8Gwi5ejKagmoHPjJN/KnVeK5/6P26y4V1gejAdKR0BzfiglfeElK 8E7lIzsjRkVqPKvsCYU4kIYFMkH1NwkRZXDViqWoOzEgsN7WBwBYlma1NLr4+pryLZ3K 9E4kKTHdaeJB7UlcCi0Q4390mE8N0zblthnQLIXnHLHwSeSMEL0bpJ498bIrdjdvqNP4 GJ8sc/S2Y4cULDsbd7z/awN+zvhPkulHy3eZu1jhf2h/v75HmFcdjTYPJw9CJnRugmzf Q3Ug== X-Forwarded-Encrypted: i=1; AJvYcCUtkqj65/qBBZbCUAYaqFtCDtSB6BXKF2KHltkDlB4vXG7MpB0A4XGQJB5JQ9uAdftDpbTA/45Xd5H3Sz4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4Dictgz202kBOVXu11LyVgKjD1yNyf2fqFNMeWQgorSrIC9ee N9vGOt4RFxtkQ6u+Gv1B42sP64zYmB79jHv232/CEzTsCsSF6A8mJc+kfHvO6RwUgDU= X-Gm-Gg: AY/fxX5tK694ZnRvCwC4groXJIva2OVo3LvePuOMDVXE/P9c+C2sdUwhfMBTjZutpBC 0fbZUUQvdqDDNELbkUSgxqyny7fYJ5yzUcnMk6gPQwzzl1rEy0UExYkFIrTmEvfTQdEEKMQkOP1 Ow3J4sXlnF2+9IrPNTr+Qqr8GbdakylUcwyWb2ZzBicqRKgNl5z18kUoQFpC8Br+pBJjAMNiUJQ MQZjUuUc6OWRlHq1ke07OaefRV0TfoY5WrRo2FhYwIg7Hmo+3ywhHpWIiOgdoUzUKaV5eVRpvFu MvjKGRSTOvcwVaImxvpVRiEfk/9gTqUKzVuTIY51+OnnlFdESli5pPUAuYeP/66DTSRPJmo6NT8 /8C5CUsG0iiH30hZQuDzARzozAswoR9nz+c+PCPuWydHgmTw52HXj9iOH/6uJXE53xlPi1RPZTm Lgn+mgiSHazwpf+PMAi/Jt X-Google-Smtp-Source: AGHT+IGymdzTOhM5jbelcMXcQ4KMKi4yIZCo10XakrCUVGapuKUtwGCZXcqj0byfMgnvUtzZVv51aQ== X-Received: by 2002:a17:907:1ca1:b0:b76:bfa9:5ae7 with SMTP id a640c23a62f3a-b7d236bcc17mr232174966b.29.1765553586158; Fri, 12 Dec 2025 07:33:06 -0800 (PST) Received: from e133063.arm.com ([130.185.218.160]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6498210ed32sm5433234a12.29.2025.12.12.07.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Dec 2025 07:33:05 -0800 (PST) From: James Clark Date: Fri, 12 Dec 2025 17:32:29 +0200 Subject: [PATCH v3 12/12] perf arm-spe: Don't hard code config attribute Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20251212-james-perf-config-bits-v3-12-aa36a4846776@linaro.org> References: <20251212-james-perf-config-bits-v3-0-aa36a4846776@linaro.org> In-Reply-To: <20251212-james-perf-config-bits-v3-0-aa36a4846776@linaro.org> To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Suzuki K Poulose , Mike Leach , John Garry , Will Deacon , Leo Yan Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, James Clark X-Mailer: b4 0.14.2 Use the config attribute that's published by the driver instead of hard coding "attr.config". Signed-off-by: James Clark --- tools/perf/arch/arm64/util/arm-spe.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/perf/arch/arm64/util/arm-spe.c b/tools/perf/arch/arm64/u= til/arm-spe.c index d5ec1408d0aec7e0d39a2cae7ad73694950ab67b..6c3dc97fde308cf4a1f289fab51= 01ead2765b140 100644 --- a/tools/perf/arch/arm64/util/arm-spe.c +++ b/tools/perf/arch/arm64/util/arm-spe.c @@ -256,7 +256,7 @@ static __u64 arm_spe_pmu__sample_period(const struct pe= rf_pmu *arm_spe_pmu) =20 static void arm_spe_setup_evsel(struct evsel *evsel, struct perf_cpu_map *= cpus) { - u64 bit; + u64 pa_enable_bit; =20 evsel->core.attr.freq =3D 0; evsel->core.attr.sample_period =3D arm_spe_pmu__sample_period(evsel->pmu); @@ -288,9 +288,10 @@ static void arm_spe_setup_evsel(struct evsel *evsel, s= truct perf_cpu_map *cpus) * inform that the resulting output's SPE samples contain physical addres= ses * where applicable. */ - bit =3D perf_pmu__format_bits(evsel->pmu, "pa_enable"); - if (evsel->core.attr.config & bit) - evsel__set_sample_bit(evsel, PHYS_ADDR); + + if (!evsel__get_config_val(evsel->pmu, evsel, "pa_enable", &pa_enable_bit= )) + if (pa_enable_bit) + evsel__set_sample_bit(evsel, PHYS_ADDR); } =20 static int arm_spe_setup_aux_buffer(struct record_opts *opts) @@ -397,6 +398,7 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, struct perf_cpu_map *cpus =3D evlist->core.user_requested_cpus; bool discard =3D false; int err; + u64 discard_bit; =20 sper->evlist =3D evlist; =20 @@ -425,9 +427,8 @@ static int arm_spe_recording_options(struct auxtrace_re= cord *itr, evlist__for_each_entry_safe(evlist, tmp, evsel) { if (evsel__is_aux_event(evsel)) { arm_spe_setup_evsel(evsel, cpus); - if (evsel->core.attr.config & - perf_pmu__format_bits(evsel->pmu, "discard")) - discard =3D true; + if (!evsel__get_config_val(evsel->pmu, evsel, "discard", &discard_bit)) + discard =3D !!discard_bit; } } =20 --=20 2.34.1