From nobody Sun Feb 8 02:34:01 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3329E3064B9 for ; Thu, 11 Dec 2025 15:28:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765466894; cv=none; b=qOmeSng6k001J6gR9DpgHdOLMagDlL/o/lhTHvdmFPeLXqGXFso4qP8nP0Sr041XECjNWnPpvQb4k4llIg0pwVcZXzCDlI2SP/VWkw186tZKeqpNHJqsI9W9ZM4ni645mLbc3MK7DwA/+K43qrIkadGPyYsMTpPdYUuzMKqO7Wg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765466894; c=relaxed/simple; bh=xePkpZbrNIejTV+/eBvIF3yGcCY2SKIZ1oKG3VWeink=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=O9rU6NYj1Zotb+BUTlRtAyDz2FLfYF18IB6lRTtAlDMcsP6fKWksa6VLYI6pbbo0nrFSooZTIdP903C9R1SVz938GvpOqFYTMiVsqJBwCeEQAosWKJ1dxc/4RLF9UCExpsjstmK0Lmh0MymgMs9SMTP4PWijO+s+vCNGj3dtY5I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QqTz0iwb; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QqTz0iwb" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-29d7b019e0eso2788985ad.2 for ; Thu, 11 Dec 2025 07:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765466892; x=1766071692; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=IeE1L9lCPfTWMZGJYdbjvoHvkM1Avioc8h0oyJcvAGA=; b=QqTz0iwb61MlSKbFx/4kTR762hTUDXdSqCkmRnqkT0KyUKujtWV2dLrKKfcmmNyZK9 PUP2yjaH4q53WYotfF7kyaT/RLmQiAm3w7BA7dHrOwM8HnKDDOhPOcDFGt2V5y7nvXAh ZeEFrVYLR7WJDvuAbCdMLvfCaIr0RF6x2k1tu691HcPg+eg8AFr6sgKxjcXKVOhfb79Y ovbMWWeocif77diAgfgp5CYXzBLxTfcdF0U+0Rqdl1RDcIcssir7qTv4GSj02JldDj63 hH8/a+v725zP0oHnzuCAsjX8KbI6nrfGs1i/etmYTmIEQateK+ZLAU0MVYTDYBcPbFOB 3lJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765466892; x=1766071692; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IeE1L9lCPfTWMZGJYdbjvoHvkM1Avioc8h0oyJcvAGA=; b=GRuXFZ42zhvry2zFmM5fZWSOuO7GJsRyGaMeVgvf3FXpY3WNY34W0CnAvGG9bhvLob o5sbum+MiguSxhtvq33QuiXOjPHOHT3fTrOiNZgMvrIiNMt9kmMQW5h1OmZXXD3+gkda TQTA4Z8fdR/JVD5NjGLEu/5LDmdYFpuqiH30PwGjov+nWgHLUcc5UnIo35Hg0W/RfeLl u7BcymqT3U7b2rLksC5gbUvPGDy+8iVuchpweSnR0McrRZcl5bU6sJPpyGpLeE9Kugbi n9aAiWcfqxdqpt4MMLvUh2LKxk9LoU132cuKde3gugcIAbNJjVQjeJoAvvCJ0q6KW7Fe f/DA== X-Forwarded-Encrypted: i=1; AJvYcCXRB+lk5FZtlzGk35L+emkux6UuyuFHz2Kg62w2Ip+5oDyrqywRbMMi6wmlOTQCPu7KlaIzLQG+wyzYiVk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyss3w6f3z/1zt7K3+y7oiJvBUayaxOTNdNdvV1WADToar88zFb GU4GqCgSADMxi3K6x1GwhINNLS1b/2q5Skqv+9+X8fECzMrqEGYq2iRUQt+C6x1leQA= X-Gm-Gg: AY/fxX6RszP/ITZB2e2+Mh+hNAgt0kSrQnNAWham9rfgoM0O1QrJyRiXaJF2mFK2niS IYFzGRbcyCj26uzIvsW3d8yc6PmckpdXZTXfrqDKHNkUay+653bRsmtIcQnmKufEe4oQ46eA/pH dIqXgNdxQG9f3JAqONr/5aO+laIYs8ckexHuXiy/iQSqJrAAG3eyzyKlzRhjkHZOJrbjjOpPUaA LNEdzH0B327C7hCdqfSCRCFv4Xgs52GvNwv9OQrVe16lY97pPAQuxfEA1I246ZKgJOlqO1rg163 TO4BO0wiwHNyJG1KgbwBCzNQeBY/vWw9gpnSYK0t5ZX1Tk4mRYYIF3jjF2mKH1K3LBzAze0C5CY 0XhDXW3wFiVXyAjHJ7iWbLCe4RgMcdic++nV2fYwz3JUsXOzE8lu0fxpA1RdXPtQ4gQzGvXJM+c vzcrrK6rP6X+ZiY4GZUuvH0Ps= X-Google-Smtp-Source: AGHT+IHlArwVcYz3DUfciqyKswTQ68mcxdpSevFo5EUCuZKAfdt91RYKMdSWdPGZCDeyqbGrwmzkjg== X-Received: by 2002:a17:903:2ec7:b0:295:745a:8016 with SMTP id d9443c01a7336-29ec22ca8e0mr60093495ad.11.1765466891603; Thu, 11 Dec 2025 07:28:11 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29eea0169easm28614045ad.50.2025.12.11.07.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 07:28:11 -0800 (PST) From: Miaoqian Lin To: Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Alan Cox , Dave Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] drm/gma500: Fix refcount leak in oaktrail_hdmi_setup Date: Thu, 11 Dec 2025 19:27:59 +0400 Message-Id: <20251211152759.2421435-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pci_get_device() increments the reference count on the PCI device. Add missing pci_dev_put() in error paths to fix refcount leak. Found via static analysis and code review. Fixes: 1b082ccf5901 ("gma500: Add Oaktrail support") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma50= 0/oaktrail_hdmi.c index 20d027d552c7..2be12acc93d2 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c @@ -712,10 +712,10 @@ void oaktrail_hdmi_setup(struct drm_device *dev) dev_info(dev->dev, "HDMI hardware present.\n"); =20 return; - free: kfree(hdmi_dev); out: + pci_dev_put(pdev); return; } =20 --=20 2.25.1