From nobody Sun Feb 8 06:56:43 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C540312805 for ; Thu, 11 Dec 2025 13:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765458027; cv=none; b=FXu8NpbSXbYjOaCAggnNDtr95owXbGCG/HtkvBkgqNX56uQg36SKFRPsKqINV7SthetW8l/oRrtzPOwsKqNzTl37WX25Rv8Wk0hlssK4IVtAOtz9hTcLgBJBpNdPwyI5x8XFXj6t61dfiAH+zIhU35Hq+i7klRBphcGrJY9rzfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765458027; c=relaxed/simple; bh=nOJrqhXprnEUUHOfBOArqXtu4GOGbhTn/RtljS8Zg9o=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=pPLYEiQYwP+NdhFrjiWwbIPshlO8CBp0ofLHPKuUEyitBNaaALHNr0jKJT2giY7w1xKR2D10/l120j/fUduHCeqlZtnDFyksyjdOazsOFkUbE158CeQO8EJKoqgCEf4QgxfWa9XOZQFu+0ALBVItNlJ6BSeD9KgNi7XXSCA1v64= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nqJUJKI8; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nqJUJKI8" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-29844c68068so511765ad.2 for ; Thu, 11 Dec 2025 05:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765458026; x=1766062826; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dDAsvYkgSFLdL6xLRP+bc26z9IdaiXQyqHMp+JNzIOs=; b=nqJUJKI8aGjj+hhRaPizCO/5fu7HqSAQ2RkGar11M2uWgcwfDAx+/ElW5kwUGpgyZS 50NJBDMtf/XnIoirsbBht+VHk3lZ6/HF2D7Rv1f+nb8ySsqA8WS0zQZixbqToM2y2cOH JAebkcxUgZWyEVG0IeNzppLpS027qFp0pBROt2IR6D/wwB1bZKGbGc0W9hw2HVcbnR6/ j9scrFtT5NzZclMU2+NwR68/G9T3UbyP6j+ItVE77hxI7Ip7T3zQBOR4s8wK5Ag5vELZ mf52p99cy/I5AmLQ8yv65rcUdSKpuCseM+TJ8JEUH+CHmD+vzb63pmLEQZ20OAJFTYob gh9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765458026; x=1766062826; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dDAsvYkgSFLdL6xLRP+bc26z9IdaiXQyqHMp+JNzIOs=; b=iTt3VNdFCdmCeSNXFGvA4y11QqodeGLPJKKNUXod6msHjE4Ms2j3TCUiOCQz43CMhJ 1cnjSWisVaSY5jyG1icm/Q70u+0VhwMLHFx2MxvXUV+JsZpE6vjaADRyve/TDc51M5gd +VpZAGB4O8tS4clfk63VyVUkZaC+1XX6hfGAbhyHVUiG48wG81wzfT1h8J3PJrXekBuR HaewehpeIMKA7kMgUUv6UPWxbbXW78NoNEMCgiYDlKfATSC9fLqPCjVTuLopUHK8YAZr hmABE+RsCoCN80NRiYP/B+TdM6yuYYjZluFzPYPlnYo/QICkpuwE/HPCreijQu6kcbNo rUpg== X-Forwarded-Encrypted: i=1; AJvYcCUlYsWiZ3Jki9/ubA01klU29kJrvPhUijBq4oYdCqGER/qGwuBb3EEXe2Aaux3wxrYPT4R1dlNv511t8E8=@vger.kernel.org X-Gm-Message-State: AOJu0Yy601784TgZukkWwd5S4A3hiW0JjOWJrlMhwj5yI6xLOl9gTIEs UjgI8fHqAVcWWBmQEQ5awnEyxqw7weACUlm0y+oHeI/8dbgu257UvvGDjk6p6xR1pac= X-Gm-Gg: AY/fxX4c4TOE6DzeNUYANMYFpI0D7RaxvlbDmtGBiYd6UlP/63oZzCFmma9QXpDByBt vTgSUGRpPSt+vT/3/DCMn33uZPGEq+nIEVjvCqEOBzRkF5oFgGML/QNMJ1AaO6Y4urB0UY+XZ7Y GL5YifUwsJ1tGHGhq6PlP0Qq96/zGNGiww8kP5CYhM/qeKujz2bTvWv2rXzuqEKhysA9mTNYEy9 Tnc2URRVUP8zSiI8rxqvCfIvbx5DCHvXy1fQfBi/SsAmfz3mxdu4AGjQgvOyVpxO8Zlfl/veNrL WOLCavbDi6AVN2ko+C3NGbTPzWUfNQFl8DEi6MadwOlcOE/EiOdYNCoyfz4zFfdUU1H8Z1qCZ68 /Nz2+zBY2RxFlGzvQprFl6g2s4KJh2ddHo3s1x8AwIPIu+iwbdGtrHMQnh18HbZmVlJtzON5i3K RxTqAqeObW2bvmhHi/qLkDM84= X-Google-Smtp-Source: AGHT+IHCGc+wX/qEdHGCPxqGaidrGfAk9+GRE4Z80gqvvl1W8SoOFEaqzM4r/56TCEwbdRiTPyGRAg== X-Received: by 2002:a17:902:ef0b:b0:298:33c9:eda2 with SMTP id d9443c01a7336-29ec2484b8cmr62794805ad.33.1765458025622; Thu, 11 Dec 2025 05:00:25 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29ee9d5116dsm24766855ad.45.2025.12.11.05.00.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 05:00:24 -0800 (PST) From: Miaoqian Lin To: Scott Wood , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Miaoqian Lin , Trent Piepho , Kumar Gala , Andy Fleming , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org Subject: [PATCH] powerpc/85xx: Fix device node leaks Date: Thu, 11 Dec 2025 17:00:10 +0400 Message-Id: <20251211130012.2404862-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add missing of_node_put() calls for device-tree nodes returned by of_find_node_by_type() and of_get_cpu_node() to avoid leaking DT node references. Found via static analysis and code review. Fixes: d5b26db2cfcf ("powerpc/85xx: Add support for SMP initialization") Fixes: 563fdd4a0af5 ("powerpc/85xx: Update smp support to handle doorbells = and non-mpic init") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- arch/powerpc/platforms/85xx/smp.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/platforms/85xx/smp.c b/arch/powerpc/platforms/85x= x/smp.c index 32fa5fb557c0..cc5bf097c26f 100644 --- a/arch/powerpc/platforms/85xx/smp.c +++ b/arch/powerpc/platforms/85xx/smp.c @@ -199,6 +199,7 @@ static int smp_85xx_start_cpu(int cpu) cpu_rel_addr =3D of_get_property(np, "cpu-release-addr", NULL); if (!cpu_rel_addr) { pr_err("No cpu-release-addr for cpu %d\n", cpu); + of_node_put(np); return -ENOENT; } =20 @@ -217,6 +218,8 @@ static int smp_85xx_start_cpu(int cpu) else spin_table =3D phys_to_virt(*cpu_rel_addr); =20 + of_node_put(np); + local_irq_save(flags); hard_irq_disable(); =20 @@ -485,6 +488,7 @@ void __init mpc85xx_smp_init(void) smp_85xx_ops.probe =3D smp_mpic_probe; smp_85xx_ops.setup_cpu =3D smp_85xx_setup_cpu; smp_85xx_ops.message_pass =3D smp_mpic_message_pass; + of_node_put(np); } else smp_85xx_ops.setup_cpu =3D NULL; =20 --=20 2.25.1