From nobody Sun Feb 8 00:50:24 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18F423B186 for ; Thu, 11 Dec 2025 12:33:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765456440; cv=none; b=H66824NDOE3xWFY6Fp6g/ALJMYE9sX8HKI6pMJv2xy9sU+g1cMQMvNYN0c4Dp/o+gDEnuhmjX1M3W9+/kfKjIGazZik7/9/FU1CUzIO2lQz31iVFJ0BtVT1gW0/u9wT+vaUovK8QaPSbjKy17ogxK8rXnil7HAqitYSeniE+F7A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765456440; c=relaxed/simple; bh=lw0EwoqT+IslF2eir1EkiX1oESNKVQo/Z8AZKR+KMr4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=O38+gMhYrD+j+UdILneDry7I7ZMAYq1jXDYoJk8RSptkJt+lU7LoWMHqMrTNRwqHvEDCpyPQPTdj/xSJVGgTLYQiBxfNW9jLr1e22Lh7PnbTHjHmL9PpjZKGPakiCOjqVLYe/axjiRUwjrHLb5gGFCxSZL+lfuUrHjsNTnCngOM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GHka6oOk; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GHka6oOk" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7a9c64dfa8aso2375b3a.3 for ; Thu, 11 Dec 2025 04:33:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765456438; x=1766061238; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3dXU3GOLINLe9EjEUjPXBDJ3oxRXZRIziVkVY2yv9CM=; b=GHka6oOkfhHWQ8bTpXvYATTeBh+/6xTUlYP1v3AT4P+RZyAuXnZN2k0B50V+TEqiVk 176ZvdkKE/woXgNvnA6geFnmluGcwtzCN4PxWnYvhGvZVUVptVjJ+pYDpw3U9prbAG4u akM6eB6+jGL+Bb7ULxERrkYV26wy2pdowUF17Io6yoY7v2QhiqFWckGtjxXJWwFV/G50 UGOat+RuHrU2w2VM+K4BjI3GX8W3fU554ixGrxY+nWnnZZySqSe6nkRWa77qc8X9gwn/ h6pVrT3HPEEyr6kXOP2vR3HMM05nGOkL3LCDiRWWKFpLcih2hZ+XjlRMdTKNT8bFzhaO +nDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765456438; x=1766061238; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3dXU3GOLINLe9EjEUjPXBDJ3oxRXZRIziVkVY2yv9CM=; b=iRnzzo2Ct9Ho3BDQ4PByxxG7vxfQUsCrq3ulBgYznRUM73+HjxMzKa99QnJniBkOkR Fmmq6ZZDxjj179OHeP+nY/OBN8w4W6qU9M4meBYI6NV0UrQqGspcgTLQ5xQu9W8GLhSI DNn1KguM2uHJCNptJq8ijakQEWu7pHYbHTajdwlBf9weLFmIX/9CFKwqmKmjXMujnWwU jN42EhpjqWHE6vZOr1ZhCYQS/nk8E3AodbyHtpPyKpP/jTMq6ymNXuZcKO7TjGwLKBCQ lO9Y434mlzAMUau76pRPVULaPtNtDGZzBFLG3j35Yc8r7cETwxBsW+XkvRFpwbJpO9yY Ki3Q== X-Forwarded-Encrypted: i=1; AJvYcCXp4AMe7kxEnmBQODOsUQHyD8cWqWVee17Jxl4RBwDwVarDd4LFsDTZ9k9rmPDhX85Rh2Slc0SrWLLZhvA=@vger.kernel.org X-Gm-Message-State: AOJu0YxkkCxT9T7+gQnipY+WKfIuvciad6r3zBPUxSpCDTOGADgFL9Mb WZpV/kjmIpgFItbb0D0uMH3Gzf30L57FPjkbMNJBLE2RlZbmeN52tgak X-Gm-Gg: AY/fxX5bl54KEERb35EPnd8TIJkW7UY1A+b6avcwqKJZcCHqZrJIIHXnS7F/Vkk29bk 4D6keZMxxXfMA7t4Bg25CFCK3I0aUWuY0r+TzCF5w2PocxkAjCxs0mLCBVnU1OK9/d4mgbXWVym s9jQY3gNXmB35GIlLxYr4v8uzsaQkrL+LEIWXmyvejsRymymxrR09CGqZPXjllL2iZuw0WMEnQS CqAlgnKozplZX50Hp0X6NfdJFQEe4JkzfylGJ3oV/B/FDRFNnua5b6ZjmXu8jbS2hp0wBMxXNYM 8hwSIiFR/vvOfST5YGnVHqdtBw+AvJaY1xzFsiKHs5NIu0Tuws9XorKICFBa/nCxoxCUhuTQddJ k28dgnk/SVucXGrCvEJkNGuCcsK0ehxF2p+u3eJj26FUBPkT3IJNQESZIOanTHeMFi1k8TLBlF6 8rcwvtwxlmEO6jVDdnsYSZUL8= X-Google-Smtp-Source: AGHT+IHDxSfBltK6rQPgl+NpCNPIOrqOJbDt51JmeLKoJKrrNu4oCo5oerpmzjaZy4g1sKK8owEQ/Q== X-Received: by 2002:a05:6a00:18aa:b0:7b8:10b9:9bec with SMTP id d2e1a72fcca58-7f22dcb515cmr5589040b3a.19.1765456437862; Thu, 11 Dec 2025 04:33:57 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7f4c27771b3sm2471892b3a.27.2025.12.11.04.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 04:33:57 -0800 (PST) From: Miaoqian Lin To: Linus Walleij , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Tom Cooksey , Eric Anholt , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] drm/pl111: Fix error handling in pl111_amba_probe Date: Thu, 11 Dec 2025 16:33:44 +0400 Message-Id: <20251211123345.2392065-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Jump to the existing dev_put label when devm_request_irq() fails so drm_dev_put() and of_reserved_mem_device_release() run instead of returning early and leaking resources. Found via static analysis and code review. Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c b/drivers/gpu/drm/pl111/pl11= 1_drv.c index 56ff6a3fb483..d7dc83cf7b00 100644 --- a/drivers/gpu/drm/pl111/pl111_drv.c +++ b/drivers/gpu/drm/pl111/pl111_drv.c @@ -295,7 +295,7 @@ static int pl111_amba_probe(struct amba_device *amba_de= v, variant->name, priv); if (ret !=3D 0) { dev_err(dev, "%s failed irq %d\n", __func__, ret); - return ret; + goto dev_put; } =20 ret =3D pl111_modeset_init(drm); --=20 2.25.1