From nobody Thu Dec 18 19:05:20 2025 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B04D10E3 for ; Thu, 11 Dec 2025 10:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765447274; cv=none; b=H3PMgIdyBSEt7KHs7w4xw9CM21qKYNkLplp/T1W1ylPl/Gh1jDz2Cui2x9lRNIxSRi+0ZfYDA/zYgMK+CB5bwWYID9QGTBlKm9rVt57TocfTY6LuVXInnuqCmLA4mtC+9LMnggyM4He8h+zWf8ka9YDbh7NP3GJLFrdtxNafR78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765447274; c=relaxed/simple; bh=pVqkKjEXVMsrV1BoKv6j4NeN5cbUKVI6QzaVPeB0uR8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=spevN5qx1Q91Fa1wXxW90csOiTFqVLkUDd3GhRys/V8F7/LKEL9dekcNW7qk+wm3C4xStiXrtWazjDenPKzStjTnmUy0kCbmJE/GhgT0OhzM9/hrCKeM7KI8OxCMfHt5inr2AfHlM211ZIlPHPF+p4B+9nw+9bjHHynwZ+r3NyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BRXx8sO9; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BRXx8sO9" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-7b9c17dd591so655088b3a.3 for ; Thu, 11 Dec 2025 02:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765447272; x=1766052072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qxUAwgYNPZb3dBwYcv0C/4y2So0BODQraJ+2jRjaA7w=; b=BRXx8sO9DbfIf3MxVh3J1zO/pxQ2xGwAaS7mtZGEWPlSB36gUgFApqqLyer8GQtTyg I4hWJyDYQPFeC+KT0mouOjfGnkQqu8kYA6MfjtVY8RPISm4fJPrbaFpo7juSbe/tESwQ /p+07p3yOmeW8oPstwsP5NWEPl1nNw9NQa4i4sNHwtQMFd+kvGzEE7d42ZSZOm8jq8LY 1N7A7IatW1yw5ztQA9QPcRN+HzUcIsyJRQfrxHtS0xOZPy3p1BHJl2c5kWydSsIQ6wkR yyOVSRtPEz41dBsjoCe86v+xIrKi3sYWag2iN3J8ITWF+vw/SS3RL9pJepWgd9gp6GeF haBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765447272; x=1766052072; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qxUAwgYNPZb3dBwYcv0C/4y2So0BODQraJ+2jRjaA7w=; b=hR7E+bsVFjwaqEZtti81vPetoh5JuWqa/CkxlhGVIrbWYwyuZ38U2PyRXuarMPpGPI FkKASWcojaEcZ/Fdl7pBMa/XSuwGCHxPmTtfLCPNkm7RAcDr6vLHeUYz0vrRmCs5uMtd 4eWKzcXzFIg5KXV711TEwfyiaF3ltF18RYBTxO2XHNhTUukrN0NXinsau3tFYchfKpUB R3mAmzmlC7t78qDX6/EnzjJFWbpwQmdbwOQwN2iOdY7anWe7pwm3blDQcSM3S2r0V1Q1 omOQjwvUJzj+zgRV82YJ8vORQ1VyLvozteisMnazUu370Ukj6BByXRxtgWBuRM8LZzFA 9eLQ== X-Forwarded-Encrypted: i=1; AJvYcCUE/UGshH9O9VMbLAl8LIbRDARiqbo44iO2mOipXMYpztLvse8IDuoMHCW6m1jvTY6nrrEzw1Jln4nU4yA=@vger.kernel.org X-Gm-Message-State: AOJu0YzK6WdhjGqx9X+PxRqEC8k3CE2M7WKpzYP3LlxMEUbvOZCJwmhf wbksGLlr76gXpac5FqmogSs4OkwnNIDmOxDoW37RoJ5lKBUJs4GhQWFd X-Gm-Gg: AY/fxX53VpadXSygNthe7E9uG7uZfNwFuyyF7YUbehDjLl0RfHHk0ZTKkdzniGNQxlo IYLIVJ+yFVJQ7PnJHjv+2SO5YXTjZAr57NgGG0TMMByDY8Ofcx5Z6AcH4lVnGQi9vJ9j5ekU6iU D92romSt51U1I0V9LCULLOADeRYQB/WBM2khJG8rs48Lc021gfBM7LXlyAbryOqxkBybfU2weWs 5px4tGd9001x4EOPvVtgA9r8KtYkqbmj95jUxe5uz1Rw9PbgCs9yQIMsrPa7+bqW/j043KW7Rrh OwjAi/i8XtRxi6S4um0t58rhKozumDCV+TXAm4j6r5MqukPpfvjmek/QE5T8CVe574v1lhOXdN1 4915WuqsoTooNTuKEj9jYm4m3FQSaPDZ3af6vWfn2k0RUCnwUB+6diGpi3rgKtSyyXTZLYUc8Zh OPFSqDunTjJsZz X-Google-Smtp-Source: AGHT+IE28P5MxEOst+lrzYcF5oWn2Bj1irMns/TapvB1X3yMs4xi6bm3rBPZTYcsNMKqPvxAsdI4cg== X-Received: by 2002:a05:6a20:6a1b:b0:350:66b2:9729 with SMTP id adf61e73a8af0-366e2fc161dmr5264654637.60.1765447272165; Thu, 11 Dec 2025 02:01:12 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-c0c2c48bf7asm1932653a12.32.2025.12.11.02.01.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 02:01:10 -0800 (PST) From: Miaoqian Lin To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Tom Zanussi , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] tracing: Fix error handling in event_hist_trigger_parse Date: Thu, 11 Dec 2025 14:00:58 +0400 Message-Id: <20251211100058.2381268-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Memory allocated with trigger_data_alloc() require trigger_data_free() for proper cleanup. Replace kfree() with trigger_data_free() to fix this. Found via static analysis and code review. Fixes: e1f187d09e11 ("tracing: Have existing event_command.parse() implemen= tations use helpers") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin --- kernel/trace/trace_events_hist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index 5e6e70540eef..f9886fff7123 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -6902,7 +6902,7 @@ static int event_hist_trigger_parse(struct event_comm= and *cmd_ops, =20 remove_hist_vars(hist_data); =20 - kfree(trigger_data); + trigger_data_free(trigger_data); =20 destroy_hist_data(hist_data); goto out; --=20 2.25.1