From nobody Tue Dec 16 16:38:46 2025 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D0292F6579 for ; Thu, 11 Dec 2025 09:15:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765444513; cv=none; b=NJ3agttGcBXMpBa7EgzmtPO/0JaQ9bL5HtqOasyzpwHMUadMhJT+AB1SxwvZOENRVy33B+L44O9SjNbAoTiz2I4FjRZZxyVNoQOzYmsHKxczbmFF9FnIRgouAsPUAEuJuqh0tl68vDbHLrXQkR2LN7qQa6VIlsYrbAxf/IOYOXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765444513; c=relaxed/simple; bh=+3m2ewgrRMtEyuYJTG8OIagUfIZwRdcHx9eCoo7koXs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=imzv5PPbNoQ3RLZNtlj0g9AbDvhEGbRl1QCrORgOk+WEjr7fheRN6WEHYp5vNXy9QfShJDmR53skMEIgugP3QLYHO8W/ccvKk7SssjahvvI64ehFdfy5+Ymn+sFgupJCZsDC+Vx9dliFluA/Nf86LaED8WAzX9zTutIKCbnr40w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: dd340266d67111f0a38c85956e01ac42-20251211 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.6,REQID:df43ebc3-e5f9-41af-8869-503a66b43dfd,IP:0,UR L:0,TC:0,Content:0,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:25 X-CID-META: VersionHash:a9d874c,CLOUDID:f4e41260fbdb3521b62fb05e69e35ea7,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|850|898,TC:nil,Content:0|15|50,EDM:5 ,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV :0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: dd340266d67111f0a38c85956e01ac42-20251211 X-User: jiangyunshui@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 708675501; Thu, 11 Dec 2025 17:14:57 +0800 From: chen zhang To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com, mjg59@srcf.ucam.org, pali@kernel.org Cc: linux-kernel@vger.kernel.org, chenzhang_0901@163.com, chen zhang Subject: [PATCH] platform/x86: dell-laptop: use sysfs_emit() instead of sprintf() Date: Thu, 11 Dec 2025 17:14:53 +0800 Message-Id: <20251211091453.300768-1-chenzhang@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: chen zhang --- drivers/platform/x86/dell/dell-laptop.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86= /dell/dell-laptop.c index 57748c3ea24f..bac75769a5f4 100644 --- a/drivers/platform/x86/dell/dell-laptop.c +++ b/drivers/platform/x86/dell/dell-laptop.c @@ -1909,7 +1909,7 @@ static ssize_t kbd_led_als_enabled_show(struct device= *dev, return ret; enabled =3D kbd_is_als_mode_bit(state.mode_bit); =20 - return sprintf(buf, "%d\n", enabled ? 1 : 0); + return sysfs_emit(buf, "%d\n", enabled ? 1 : 0); } =20 static DEVICE_ATTR(als_enabled, S_IRUGO | S_IWUSR, @@ -1958,7 +1958,7 @@ static ssize_t kbd_led_als_setting_show(struct device= *dev, if (ret) return ret; =20 - return sprintf(buf, "%d\n", state.als_setting); + return sysfs_emit(buf, "%d\n", state.als_setting); } =20 static DEVICE_ATTR(als_setting, S_IRUGO | S_IWUSR, --=20 2.25.1