From nobody Tue Dec 16 16:39:14 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CA2155322 for ; Thu, 11 Dec 2025 08:59:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765443576; cv=none; b=lntWPcIda6QDkSzYN5No4cutD9xptUU3OLCZqWf1Fu2IArtK5DgawB8tmiAqdYBkQJ1q9mYDq1kJEpZ6zmZwUxqMqWO0+vdB0KWORjjFFth66jlsAtWzF3/OtkwoynO6lG6T3XQ5Q99Nk5jJiaIwdYzRiHbij2yOnKk2unPGWzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765443576; c=relaxed/simple; bh=SRO96EqP0vU6DoBkk2gLV8rIpiatEHZA61vji09KYLU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gfg7frtDyrqND7q7Ggq/T4aAw0mx6cUlPjBBDv7MqvC+6t7voJWjf2/TXrV2oHcCEYA+Yih10bwo0mVso/vBhOC5REGDVBsXcQRPDv7660B2U90vv/75J0pSLe142pov9282dEF9E86OUKyCMFRMVomnII1/T95q3XfuOZJZilM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z0FToCKb; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z0FToCKb" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4779cc419b2so6473605e9.3 for ; Thu, 11 Dec 2025 00:59:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765443572; x=1766048372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d7Dcmeo17/ho3pwIJKnx+P3oKTwjiCKC8M+QuOO4Bzs=; b=Z0FToCKbjCS1/p4D534+0m+In14FAkA78Rv6Q+MRGMsHP68Voz8/D57YkGty5niXnT bAbYIRnwb8TsrYjApB3mCHbOG0tBChqc9FExL3Fd+EOOO27b8945yGSppz/Ce3R5ludL gUyCLz2JMMO+Pb8kd8Fg2WhPXA4rzQZpVrNoHQO8RxitYmZfD7vKZrLaimfKg8FMmnRp jTd8qt7DMUI2TssRV/5jV3MYIV1Oc7FyorCRZryk78+TwnqdQ0fyXJL9AQzcJKn4Iu4j ZKKSJitoRpAEHYFE+UAB6raHqoiYj6XTXyn/UmkkziiZO4u+nPDoaW//cd90EXrwWYLL Lzsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765443572; x=1766048372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d7Dcmeo17/ho3pwIJKnx+P3oKTwjiCKC8M+QuOO4Bzs=; b=g9HbaPtI/AY/a6N7YPHnxDdyBktjkk8Jhs1bWDGBX5IyH6z3rFjXj0fc0pSDdjS/Tg wuPqzjBevoUpiq2NIsgM4Zg465Co0Hs7qGEjKlPnZUHgJ0nviielO8VUDDD9kcRGqzme /saQp52+ymvomjjKd5sUp2Mn53WJ/VLr0Q4t0dC+hoB/EOim7YVNdKFL6S/0tBKG4QWZ oCuCQffRN7CQ2CjNf52SMzbPLnHF8BrGYKg7ClxeDHAtIJ+XER4JP76J7X95ic57TWC1 Vw0UqV0mh0g1kz7YpLNeeZ0sGag386lbxd9CDOuehc/FQFuyqyhjNsvSi5L99ln7bgTD ZVEw== X-Forwarded-Encrypted: i=1; AJvYcCVjAPCZyv9J230BSfYGLX2ienZI4iYlnAqP1SlAwyNhCqsklo0tAEZqkJs33ZDNxXgX09GHgefKUTxrHHk=@vger.kernel.org X-Gm-Message-State: AOJu0YwXobDoj4j1KKxptJqwqwvpA4F31n5X3zrjESCIdRmik4hc926J 3xFDq+dMdlDVOQijOt7RpEPRxCN3kzo5CKeYsQqCCBr//TJV1cCzAYbn X-Gm-Gg: AY/fxX4lcCdCgfYvqkJbWawffPz/bJw0kDWblOai4r7N4BA7I1oTS8oHG/K4YpYDIVc GhX6XUqw7Q+aiKIFdYnuBiNZKY/KiKZdnXZ3WncNL04zJg7fwNLlVWh/XewnNMLQeOGgdoT8BRk sAa1huKV6l/EnSMB0dEwYqAoZLdaTWZUzxvjonLJ5v2EweDSnK5neBXP2q/BDryK3uVOPntzrNx WHY4FBqnITfvAuCJyGkm1LFRcXbxqVauSqgrYJSFEqUaKLfMLLBGotwxjh3yvBUlhslXllm7kBh qMMK/ZI0OLZf+FyjfYK6t+1Q4GCm07M42WGljo/tkHt1d6MlJxvd14ST8HyCefenye0lAxpyURT Pejxyu6gqXmJUnDFMECpOYGtugfAMR2K+NsR0QvrD7qNA8WgPsa4cwDQcwAGlHxHL8IygTT2GCC wZ73MCZw== X-Google-Smtp-Source: AGHT+IFfevukgFnWT3LKBWertJrehx/v0qPaRwBDg4O1Pd1KYzneq0UfgHhekRMu8pvpp3JFeKvIGQ== X-Received: by 2002:a05:600c:354a:b0:477:97c7:9be7 with SMTP id 5b1f17b1804b1-47a837fcbb4mr55532325e9.1.1765443572110; Thu, 11 Dec 2025 00:59:32 -0800 (PST) Received: from pc.. ([105.163.2.215]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a89ed6c64sm8683195e9.12.2025.12.11.00.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 00:59:31 -0800 (PST) From: Erick Karanja To: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Erick Karanja Subject: [PATCH] drm/radeon : Use devm_i2c_add_adapter instead of i2c_add_adapter Date: Thu, 11 Dec 2025 11:59:23 +0300 Message-ID: <20251211085923.737742-1-karanja99erick@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace i2c_add_adapter() with devm_i2c_add_adapter() and remove all associated cleanup, as devm_i2c_add_adapter() handles adapter teardown automatically. Signed-off-by: Erick Karanja --- drivers/gpu/drm/radeon/radeon_i2c.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/r= adeon_i2c.c index 1f16619ed06e..f3ba4187092c 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -931,7 +931,7 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_de= vice *dev, snprintf(i2c->adapter.name, sizeof(i2c->adapter.name), "Radeon i2c hw bus %s", name); i2c->adapter.algo =3D &radeon_i2c_algo; - ret =3D i2c_add_adapter(&i2c->adapter); + ret =3D devm_i2c_add_adapter(dev->dev, &i2c->adapter); if (ret) goto out_free; } else if (rec->hw_capable && @@ -972,15 +972,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_d= evice *dev, =20 } =20 -void radeon_i2c_destroy(struct radeon_i2c_chan *i2c) -{ - if (!i2c) - return; - WARN_ON(i2c->has_aux); - i2c_del_adapter(&i2c->adapter); - kfree(i2c); -} - /* Add the default buses */ void radeon_i2c_init(struct radeon_device *rdev) { @@ -999,10 +990,8 @@ void radeon_i2c_fini(struct radeon_device *rdev) int i; =20 for (i =3D 0; i < RADEON_MAX_I2C_BUS; i++) { - if (rdev->i2c_bus[i]) { - radeon_i2c_destroy(rdev->i2c_bus[i]); + if (rdev->i2c_bus[i]) rdev->i2c_bus[i] =3D NULL; - } } } =20 --=20 2.43.0