From nobody Tue Dec 16 16:35:57 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4D022DC333 for ; Thu, 11 Dec 2025 08:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765440814; cv=none; b=WTamanaaphQeJY9tfqtr+gqTV4f0NAfGYVaGknTtumdGIO2cL8+VMJIVh54vZyWPD5VooTIX3UU6s3j4Fdy/ICuT3znz+Ai0jISlhVxJ31NFIrt2ATFQY7WLu8d37/l6ffOu3pURKyUWoLlQAaDZnd6jUxbfpAOdgkX6EDtuOiI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765440814; c=relaxed/simple; bh=CRdQskgW/O6U/RpBs/bh42YAt536V9Rswk+rIj7pjMU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=D3Uf3ClUQLn+NvwxaLC4n0/XOUHEzxqKrAW+5HsDO6Zm40GbW2iZJA3XIm3UAnJh5fgrkWzdEFXpMgSGFZVPJkIDQCUqyEhsz1OhoOtbatYSxYywIo/5WTi1s5PJG+5bBtuQ/TvUG3bmN5mWG15eII2ouAsv8uQe30PFVCWR3iQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NlfLN/PI; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NlfLN/PI" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297e264528aso8242475ad.2 for ; Thu, 11 Dec 2025 00:13:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765440810; x=1766045610; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=trUfnuuHzLWg0hqtTbFZbrBapbqubE16vGf51eAqUyI=; b=NlfLN/PInJl3l93OXCX/IrY6gg8tW2yrkeDFDYQ75GGNEGfhf61rtrqglE0t7tFr/e OkRBc1lkaFE/q2IGYbP16CwLYiWAc95IffbvIR5pvYBNGr+48ZTc4koCbVgnJnK89tQu DjF++058N2d8Kpl9FIUiKbdGbWk10xK21EjG2IW09EoEDOLvRe+isNwC6Z3OFx0wpjSv JfoRwjY84Wy8BgUw1rSiqshv8fqS2o77QYG77MbusJsreJx8lPfpYvcXZkfOi+2WtQ20 YUJEaYXHwCPfMUxQ64JozbC+B2SnYg9jlKbjOQ5051BV8k+HQ/gg4nxWkhLi3nlQhgGB hlkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765440810; x=1766045610; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=trUfnuuHzLWg0hqtTbFZbrBapbqubE16vGf51eAqUyI=; b=cO4qybBg9BzBDvQncln/PDb6eSDMgtnc0vGVP0OfrQJWCXLTBOIf+MSxXQov/OxVGB PYUn6XCygMEhYSt/NtjHueO2tyTMVSZ7ybCR9DTzxwHHfXIOYuADG/GwSHughHc+7PxN E4nYyktNOR8cj0isSq7YjCCxyohYUC8RmKmciB2TfWPjppGZ8mHTYlm8rMKWeMcpIjZ8 4KH+9ee2gfsW0re4LjRndMTqcssCr4rH1LQHcEMy11jR2wbyzK8bTTQX6QkiczWHANIy H+m1RMniLSk1a0EaY7sRu4WR0/0jcUhY4raaA86ViVu0yMda0I2BVS1rqSGeWKMS9OAd 6Q6A== X-Forwarded-Encrypted: i=1; AJvYcCWzgvA3VeZ73KpfjfS+xUiIQpQMPoWTTU/UrYObKzpF4fJphouLRsPVgEWnKz/UD0KHnSvWkncj78MHTc8=@vger.kernel.org X-Gm-Message-State: AOJu0YwU49p9ScLEZH0JZQl9kR1ay34QXhbrHYqQFVb3r1OYH397sNb1 zBtdAqg6NJQeUrXhQwhn5bSmiXCXCeC/VN67C0aj413GZ2/o20JwDhyy X-Gm-Gg: AY/fxX57Vorqu+gTljHaPlQiKk67gESxuPBK7CALOmP4rjA7toHgDUJEYVX6QoNg1Ak nDNM1I+tP1yJFI8nOMRflK9yQPeUPFFZfCnkYBpSFdxRjH0hPlYQtv1/P3wT4BPqC4d6DUTNcDM ZpAd5+ag/sRc0j9NK34OzqmEd/VkolWE/RCVywyQSzUMVrwZ1OetM8Tvd6tzlEKGU7UFSvpbdtZ UtDJjEdzu9b2raVhD/qPjC7PH+/hRr2ZaZZ8ZkI5/9+4eTcgp/YvYzIqWsHS0fUHi+1K07c1u1Z 0p1nNF/KxBnOwBX7sJOv5skMjFmP1JGGmHEpGe64ej43KRDb3He7ZrbRIoW95yyPEZBUpFcdzNQ THlsA/YPrL1WLsJpLuMjlodTjF9JjVj/7xq91CLO2URrLVPGL4LpTtRPmc2BjKiVUJrhtWDwR4w yrm8SAkkIY X-Google-Smtp-Source: AGHT+IGpU0Pf7s9UlmMW8EGY8yYMuomHFnlX0/Df9bPI6JMt8uShHZ+gMWWhZpAR4wob/58V/qG9Zw== X-Received: by 2002:a17:903:2c7:b0:295:6a69:4ad5 with SMTP id d9443c01a7336-29ec2803d18mr60221255ad.56.1765440810038; Thu, 11 Dec 2025 00:13:30 -0800 (PST) Received: from c45b92c47440.. ([202.120.234.58]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29eea04036bsm16048855ad.78.2025.12.11.00.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 00:13:29 -0800 (PST) From: Miaoqian Lin To: Daniel Golle , Qingfang Deng , SkyLake Huang , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: linmq006@gmail.com, stable@vger.kernel.org Subject: [PATCH] net: phy: mediatek: fix nvmem cell reference leak in mt798x_phy_calibration Date: Thu, 11 Dec 2025 12:13:13 +0400 Message-Id: <20251211081313.2368460-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When nvmem_cell_read() fails in mt798x_phy_calibration(), the function returns without calling nvmem_cell_put(), leaking the cell reference. Move nvmem_cell_put() right after nvmem_cell_read() to ensure the cell reference is always released regardless of the read result. Found via static analysis and code review. Fixes: 98c485eaf509 ("net: phy: add driver for MediaTek SoC built-in GE PHY= s") Cc: stable@vger.kernel.org Signed-off-by: Miaoqian Lin Reviewed-by: Andrew Lunn Reviewed-by: Daniel Golle --- drivers/net/phy/mediatek/mtk-ge-soc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/mediatek/mtk-ge-soc.c b/drivers/net/phy/mediat= ek/mtk-ge-soc.c index cd09fbf92ef2..2c4bbc236202 100644 --- a/drivers/net/phy/mediatek/mtk-ge-soc.c +++ b/drivers/net/phy/mediatek/mtk-ge-soc.c @@ -1167,9 +1167,9 @@ static int mt798x_phy_calibration(struct phy_device *= phydev) } =20 buf =3D (u32 *)nvmem_cell_read(cell, &len); + nvmem_cell_put(cell); if (IS_ERR(buf)) return PTR_ERR(buf); - nvmem_cell_put(cell); =20 if (!buf[0] || !buf[1] || !buf[2] || !buf[3] || len < 4 * sizeof(u32)) { phydev_err(phydev, "invalid efuse data\n"); --=20 2.25.1