From nobody Tue Dec 16 16:40:34 2025 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 397CB301039 for ; Wed, 10 Dec 2025 21:57:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403879; cv=none; b=JnrwQbWQEMl01OaMOn2sFvMth6KdD4iqXNux6wxyOCAJQUp64LY0YGPTvm9+mxZdneN4cT5h+sPNu8ict2M7BmaegjUgsFrZvxBMB6fpOfi+zt1GhHi7KX+YQIY6Cp2vSDpkfw/bTydYIEKZ64AVxuqdeZcGlgHOwyMGtEnKiVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765403879; c=relaxed/simple; bh=hjFMPk59DGnxn00qcVwY32mfbF1V9dBUxD/wPXoJNFU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qoT0GnY99keArv0cyxly1aPVBbBv9N/j5v6NXkr/RFAvvVLKaACyW1WBgMVHT/yL/XLHM73OBRdJ3+kvkHg6cgdzfDhfxfIzQwI/Fnn31KlFDgxzwCeC0KHeXIw+/RBciGXKORZ9zZqVgDpvFIzUF5JxU/RLbhS0EmV0NSFAu7I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dByU5Equ; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dByU5Equ" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-7e2762ad850so277230b3a.3 for ; Wed, 10 Dec 2025 13:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765403877; x=1766008677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+hm1NbizhX2u/6oOBSk1ArXnzSC2i/yu4zfAVJxLwRo=; b=dByU5EquAQrM1bYDLHN/Xm7p6rsxWpVdGtXJnFFKebH0UeppNoQMD5Po9NgjfZb8pk Lqz5kfCaDlI/lzLV3Whm0tuO2hlYh69Wgf1Sf+gsrZEeLssUf04FRjUO28uz1EQw1uiv vAJX+qTlvXXlK+81k1Rf/8KshTzKwhs5xYQ18QC7BvCx7uYo9Cs2XHl73YhUzgxGxxz4 swaMEWex35mugR4Dp/Cy2xK2sh8YfAA7qvJf3poMTIJi8GmwBiwJe+egN5BEmelIbkQZ MTq6s9CHEe82NHeZMCJzJuVnOz2sT7+xbzmPKFZUYoR/e9FDxR8cYyiZwGxDPffRDrNL gGZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765403877; x=1766008677; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+hm1NbizhX2u/6oOBSk1ArXnzSC2i/yu4zfAVJxLwRo=; b=aSw5cuij2xRKEm4ICj3E94QW+fDBCwUerUzEj+bsBiOxUlkGFQ4L8Fyt1KeHfPpPOH s9xZv1wwncNnAct04r3PImI5K5k2n5852+y8R117cZbR4jP6p4/KzgpVYJSe/n9TcG5W qKKol8Afr73YjdCeuDifbRJyaPcDxDqKL+9vD44BAtYV4KcX/aEfQnWOJwNdN/xbDrsr vi/7SsGMloFyRlJ2RcuO2Q/H3nAptfYalewnPz5Tvn6XYlK9KS4g15EXTT9kb7BKIwZ9 cFNVqoRxshmNi1I7O9E5b4jN9SA+JNdkCwjOA4EzXCwi4d6P/p5rTRanWBV4j8QDj6vy I1Vw== X-Forwarded-Encrypted: i=1; AJvYcCURnslUPgoF2KmdckgdpVaxQ6YZmnjGQ45przzZRZrV0yhpAFjFGFTaZfBHJgKhJQQDyvsGThN/YNW3lEY=@vger.kernel.org X-Gm-Message-State: AOJu0YyJN0gTLqbSI7zbdfBgUCZ6lKcD3dvglmhwRrGrVMC0XVMfMMkO DDzqqf7tDMzVzPUOtbCT8UPrG8VatoXEnC6zR01y3jjWqAWjCN7TsdLz X-Gm-Gg: AY/fxX4ID5/fSDJaH84ITy6fYUnwHGzonR0fxynJS3O1Gi/7E/ENZVOnL+7sMpVhrdD lBfu6cX73I8yEL0HiBZGNU0Jon/DuhvN3nIXVD5UY4snqD6vTyhw1Dh/prtljN/+3a55RwHWY82 MfjRdwhlp5A6dMgHVXFsG32cKiY7okgA7dhAXx9K9lMw53t9LvIjSNRWYVDCjDQCBkTHjIDyYQ6 KRLywZZCwJEh65NLruFi/Ro7lx4/ykqIto/59OIrxl0Dl/O1y5QaZCuul1j9UsJZy3u2WnwzmYk C6593EgtPjEb1DRIisHlU+tfCBpZiYtenWxuvSD2F7RSLscYni+2YVFogelr3OGsN/KwBRRyxim CpsKGygvCWD1KMVSmSaQ2ZVVhCOdJkcttqjeYOJO4XDAEUYQk0aKDg5QL6bG+FYjgEhvUPMUFIT w2+huOi83bfMDnSUK1+OeZFg9lZus= X-Google-Smtp-Source: AGHT+IHA+9Qz7ydU3Ty9NpHFSEVIZQE81z8wV2mYZQOhee792sM2qH9nyagSd+BRXofaMXiX+aNkbA== X-Received: by 2002:a05:6a00:4f82:b0:7f1:7c82:fe2e with SMTP id d2e1a72fcca58-7f22dabffacmr4111460b3a.1.1765403877452; Wed, 10 Dec 2025 13:57:57 -0800 (PST) Received: from LilGuy ([2409:40c2:1056:3997:289:7d28:d8ed:a86]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7f4c54812aesm453133b3a.65.2025.12.10.13.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 13:57:56 -0800 (PST) From: Swaraj Gaikwad To: SeongJae Park , Andrew Morton , damon@lists.linux.dev (open list:DAMON), linux-mm@kvack.org (open list:DAMON), linux-kernel@vger.kernel.org (open list) Cc: skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Swaraj Gaikwad Subject: [PATCH v3] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid_store() Date: Thu, 11 Dec 2025 03:27:22 +0000 Message-ID: <20251211032722.4928-2-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TODO comment in target_nid_store() suggested adding range validation for target_nid. As discussed in [1], the current behavior of accepting any integer value is intentional. DAMON sysfs aims to remain flexible, including supporting users who prepare node IDs before future NUMA hotplug events. Because this behavior matches the broader design philosophy of the DAMON sysfs interface, the TODO comment is now misleading. This patch removes the comment without introducing any behavioral change. No functional changes. [1] https://lore.kernel.org/lkml/20251210150930.57679-1-sj@kernel.org/ Suggested-by: SeongJae Park Reviewed-by: SeongJae Park Signed-off-by: Swaraj Gaikwad --- v3: - Added Reviewed-by tag. - Moved version history below the '---' line. v2: - Removed the logic changes (validation) introduced in v1. - Updated commit message to reflect that only the comment is being removed. mm/damon/sysfs-schemes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 6536f16006c9..14a17da350ab 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2245,7 +2245,6 @@ static ssize_t target_nid_store(struct kobject *kobj, struct damon_sysfs_scheme, kobj); int err =3D 0; - /* TODO: error handling for target_nid range. */ err =3D kstrtoint(buf, 0, &scheme->target_nid); return err ? err : count; base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c -- 2.52.0