From nobody Tue Dec 16 16:41:32 2025 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F84C1F5851 for ; Wed, 10 Dec 2025 21:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765402653; cv=none; b=emtN7m8vXhRc6KSsLVK45uQ6Ww5PmC/AYez+Vaz/aI2qvqQCU6ptO+VwB/kf7+dAIcjHe47BiD9cAmrOYmLcUS/ak0wsRaTiIV7ViAYbmItO9zTh241ZSaxCiMQmeT82s6JEK+Jl6JhJx5GysYIpGIn8BChv2gGkcktti56GWtI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765402653; c=relaxed/simple; bh=AyEbySivgLXxF2lNHpPjplLtb1DpRYpjqjealx++z0U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dq3H5WkGNb5pvJr7m9GE10zSNbfEKTzpy2vd+2+enDBiDvM/zLlmlN7IInF6No6fahZZUq3aXG41+2weLqsoCLDx1L4ck0RXSwvl8MlVJyF6dwUaiscTelNUUIrZYaK620Qi0yaqHwVY4oDet0O0WTxIj2hhuLXZ5EW4uI50SvA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KSXLwQez; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KSXLwQez" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2981f9ce15cso3857015ad.1 for ; Wed, 10 Dec 2025 13:37:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765402651; x=1766007451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9hLmL5UBaH7Jl//7hZV10HWpa1IsgMF0lpOrAgcARCs=; b=KSXLwQezwZKdoknQVMjGZSkOEN9mTbqlKuAbOUOHXK9tvqjek1uGdl/ZmOKm4iHV42 e4ZjXuw6EUjruwSjPATWdUl8nVk4mxCoyfR+JXAAltQ4V+BNQkSNXQTFHicCfFfErVg4 fmFtEKkDhGQQ5Rx+TCC8bxObmOU7cP9vu0QHjmaWl6y+vMHE+h5D2mejk6B4/I0jUOWj 0SRE9VoMmz/p3+EtrLLjdVNRtQtieWgpSd4Rxeop4fn/m1nL/Z3vXx+Ypnp15F5KNmCP o9qKS44YnmpClegUUjHNXa/j/xpoJTMvHmZ9FTV7+KgyZ9iLMIyciIKg9qvG8gyuVu+u vX5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765402651; x=1766007451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9hLmL5UBaH7Jl//7hZV10HWpa1IsgMF0lpOrAgcARCs=; b=bF7sjBkz7hDxgYE9qWIRLWw3tmUB0ZJS46h6eQnoqVECw5+mXQNngue1Ozuu79CY3o Ct/7PeyFd+i+CDmZqYWZa0ZmY60pe4xfkc/xllZ+9oUyEAkNwjH6fgIibtahAIlpWP+z 4S/t13ek6AycDm7MGcHQnkny/lRx1S3QnPXUYYDQAefrCZ+S5Qas5LISXba5cOElAvBz UuAAqO6HlkI0ED12KjuapvhSCc+4Vzrw7MkG3jBFcU8lg+Oe3s2akVeh6zDhie1TB9Do k/Izs7XrDwfd1E/nD2d+tfixAhpA68vO+piFLGgOiVMTq451LW5m6uu67yMzTAIjWGgJ Gp/A== X-Forwarded-Encrypted: i=1; AJvYcCVhBqcIRHhpyGFkvPpNrLgKcxZHHCyVQKj+i2wU9yECwYsFCB7etmCLxoAnxJ2zQc+whw9uz0hitHt1P1Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5WiKo9dMrjXyRwOiKGe5xEdf6aVJhx8fxsMO+XC+Esx/Dz5P+ GpKS6XNCmVAzGa+jRYp/66fLD0gOHAoRUkrkpOjWcU12fcrWovFpoQpBvQ3BNiGB X-Gm-Gg: AY/fxX4n9IcqWQCBMrpn5ZqaNzIlYx/DUhFdWSvLpgP55E43YtwoLfzmwnin3RA2qfF iiUmeMhdYRc8pSo7gDOP9E0u+1ndKZMW2sv4TR1L23TGH16AxeY4/mh90IuH7P46Vb0zu5IZ4X2 z833tbaqBjEfl/Kqf8jIhOE8XUmd9yIcuOk/1oZEOb9PAwJpkBnYRshyX7OijKdJ7AkqNBU3m/1 3emsmdYbNqEEayS5aepaSKpDAxit7LYjDdSoZ/BahW5PhIxJsacYL+7SevOjLHtwrIQ7a7UKnZ+ vhhV5piB5GAhFVuulJzCVqP3vrq6kscTMzbrJFweD1cYOdPvqClhZztT4Yi+FIY1Dtn7iWcciTW XTDUt8FDG9DYdHs2MqB9hVNhPsWthzy/f2quP8Ho6C/dfM4NG1IFmE9uacLx1FXP6hoxkXQoDxf mf6B5wTD1f7bCAd5I9gCr89ArNnXs= X-Google-Smtp-Source: AGHT+IFOKeCD7SLJaoyaxSzMzfFpQdgEfp6KhJDB1eupbtl6YbSdpyQhFlSIJb3jOZCFQdhFRs3+hQ== X-Received: by 2002:a17:903:32d1:b0:295:8db9:305f with SMTP id d9443c01a7336-29ec2d40dd6mr37532245ad.34.1765402651414; Wed, 10 Dec 2025 13:37:31 -0800 (PST) Received: from LilGuy ([2409:40c2:1056:3997:289:7d28:d8ed:a86]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-29ee9d38b3dsm2922135ad.36.2025.12.10.13.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 13:37:30 -0800 (PST) From: Swaraj Gaikwad To: sj@kernel.org Cc: akpm@linux-foundation.org, damon@lists.linux.dev, david.hunter.linux@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, skhan@linuxfoundation.org, swarajgaikwad1925@gmail.com Subject: [PATCH v2] mm/damon/sysfs-schemes: Remove outdated TODO in target_nid_store() Date: Thu, 11 Dec 2025 03:07:08 +0000 Message-ID: <20251211030707.16417-2-swarajgaikwad1925@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210150930.57679-1-sj@kernel.org> References: <20251210150930.57679-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TODO comment in target_nid_store() suggested adding range validation for target_nid. As discussed in [1], the current behavior of accepting any integer value is intentional. DAMON sysfs aims to remain flexible, including supporting users who prepare node IDs before future NUMA hotplug events. Because this behavior matches the broader design philosophy of the DAMON sysfs interface, the TODO comment is now misleading. This patch removes the comment. No functional changes. [1] https://lore.kernel.org/lkml/20251210150930.57679-1-sj@kernel.org/ v2: - Removed the logic changes (validation) introduced in v1. - Updated commit message to reflect that only the comment is being removed. Suggested-by: SeongJae Park Signed-off-by: Swaraj Gaikwad Reviewed-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 6536f16006c9..14a17da350ab 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -2245,7 +2245,6 @@ static ssize_t target_nid_store(struct kobject *kobj, struct damon_sysfs_scheme, kobj); int err =3D 0; - /* TODO: error handling for target_nid range. */ err =3D kstrtoint(buf, 0, &scheme->target_nid); return err ? err : count; base-commit: e9a6fb0bcdd7609be6969112f3fbfcce3b1d4a7c -- 2.52.0