From nobody Thu Dec 18 10:32:51 2025 Received: from canpmsgout07.his.huawei.com (canpmsgout07.his.huawei.com [113.46.200.222]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 152B7223705; Thu, 11 Dec 2025 02:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.222 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765420742; cv=none; b=mxVXq11aLULWEjuvWmYj1lIk6Y59dX9L1BIMTsIgRjdNwGSdcQESo7YblOKirw/MweFPJ3Bl2SY0xj62cjq3joGPFIdYP9sh1pwqAtd6MUq/qlZiww05rRvVN9T3ddYgchydaf2FCPv+r67ixtHUIoCXpivFLvCAPtZ2FNQZOXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765420742; c=relaxed/simple; bh=Fs/ETSAwP5WSaxBg1LqvBTkcXyLghTmKNoognJyWMBw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GxMpAzWv1YWvMBoLogY6+4tjN1jPD9Wh0WikFTwgsFO1u5jnWhhuk1h2idAUI40tV5z/8yS3CPNM46nWAazE/A3YELesFqdmcvSQCDots76dh2TVfOXRubYTtK32BkO//YRkFJ9VudcJygR59g9uNlNyRgceuqBCg6Z5dhlEkt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=iRRSdWon; arc=none smtp.client-ip=113.46.200.222 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="iRRSdWon" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=79uTi9ykoKshWNVQ9n4i3+AsUlVwH3rbZnGTwyENPyw=; b=iRRSdWonB1XD+0l1q9310kZHNFVhRM1zTds3ZJ7ygF7aWBwBxlPJ/HePWMmFPgpdKIBCVOcUz t25ZDHdC0d0crM5/RMa5tAvprTxjVkO/KbY+2gJJPSDrZcPf1byMeYJ3STHGAdhmR4FheoUx64G ph1YpyW9nzVpornt71bao78= Received: from mail.maildlp.com (unknown [172.19.162.112]) by canpmsgout07.his.huawei.com (SkyGuard) with ESMTPS id 4dRcDY1qYpzLlVn; Thu, 11 Dec 2025 10:37:01 +0800 (CST) Received: from kwepemk100013.china.huawei.com (unknown [7.202.194.61]) by mail.maildlp.com (Postfix) with ESMTPS id BA6D6140143; Thu, 11 Dec 2025 10:38:57 +0800 (CST) Received: from localhost.localdomain (10.90.31.46) by kwepemk100013.china.huawei.com (7.202.194.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 11 Dec 2025 10:38:56 +0800 From: Jijie Shao To: , , , , , CC: , , , , , , , , , , Subject: [PATCH V2 net 1/3] net: hns3: using the num_tqps in the vf driver to apply for resources Date: Thu, 11 Dec 2025 10:37:35 +0800 Message-ID: <20251211023737.2327018-2-shaojijie@huawei.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20251211023737.2327018-1-shaojijie@huawei.com> References: <20251211023737.2327018-1-shaojijie@huawei.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemk100013.china.huawei.com (7.202.194.61) Content-Type: text/plain; charset="utf-8" From: Jian Shen Currently, hdev->htqp is allocated using hdev->num_tqps, and kinfo->tqp is allocated using kinfo->num_tqps. However, kinfo->num_tqps is set to min(new_tqps, hdev->num_tqps); Therefore, kinfo->num_tqps may be smaller than hdev->num_tqps, which causes some hdev->htqp[i] to remain uninitialized in hclgevf_knic_setup(). Thus, this patch allocates hdev->htqp and kinfo->tqp using hdev->num_tqps, ensuring that the lengths of hdev->htqp and kinfo->tqp are consistent and that all elements are properly initialized. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Lay= er) Support") Signed-off-by: Jian Shen Signed-off-by: Jijie Shao Reviewed-by: Simon Horman --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/dr= ivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c index 8fcf220a120d..70327a73dee3 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c @@ -368,12 +368,12 @@ static int hclgevf_knic_setup(struct hclgevf_dev *hde= v) new_tqps =3D kinfo->rss_size * num_tc; kinfo->num_tqps =3D min(new_tqps, hdev->num_tqps); =20 - kinfo->tqp =3D devm_kcalloc(&hdev->pdev->dev, kinfo->num_tqps, + kinfo->tqp =3D devm_kcalloc(&hdev->pdev->dev, hdev->num_tqps, sizeof(struct hnae3_queue *), GFP_KERNEL); if (!kinfo->tqp) return -ENOMEM; =20 - for (i =3D 0; i < kinfo->num_tqps; i++) { + for (i =3D 0; i < hdev->num_tqps; i++) { hdev->htqp[i].q.handle =3D &hdev->nic; hdev->htqp[i].q.tqp_index =3D i; kinfo->tqp[i] =3D &hdev->htqp[i].q; --=20 2.33.0