From nobody Tue Dec 16 16:37:17 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B652314B71 for ; Wed, 10 Dec 2025 23:21:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765408890; cv=none; b=TAREeTDEgKRCzcox3Al2pNE2nsIc6vy30vHJc5F1/lpOFBINTPHoZ3m580LHr7GBj8wIeuVNqiz02QhD0YGiOun4yPQmt3bHJ6v297aKGj2XFcOrSDWsuEEtWqXGsR4JWt58BAUllWrDRIVVCwdp4V7HkCN0Hlzc1216Le+n90A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765408890; c=relaxed/simple; bh=7U6Hf0CN4Pzn/d+Dmrxb012ZiCGtKjQudcOEFKhWfgo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sqHGNqJMlgjndvGxsEM8ASntnShnDM8e5vqJrYMPfq384aqcZMeIk/oWMlpxeaER102dc8W0vo1HrhRcoY9cdJ9t4M8Zj9B8GSN+YMIPf8BiSqq7JXCSSUvIS+0ay1WC4W0ryW4RPhgg/jVmsdQrZDcbGW6H17lZAlIXaBP8haw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YmWHvfJ7; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YmWHvfJ7" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4775895d69cso1387205e9.0 for ; Wed, 10 Dec 2025 15:21:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765408885; x=1766013685; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L08jHXpXjen58cg14Adrr2f98WJp67FFgA9qD2YXBHU=; b=YmWHvfJ78XWy0tgjXo1NcrTeVrmvUk9zr6aph0VUPcXF2BIf9rg0vDy111OToOolSy c1x3A2AISxATOAI39GFIM2FYc/D92E/DYK/t1CriigOhymbppGsEY0Wim6BMebrf7xxl TncGrjqHM6Sb9H483rnAh6Hv5bDVT5q73lUhd1w3t41Gu3xMqn7YtqNugMyv64luKruo AxCzoU2jS+sGGtdNWx23nCh+Fya5vKsQgFJjppQq7N/ufwSz2Na0O++cWpmnza9NTdpN AUfQGlIRILlPBiZTy/305Lavw1ZQdcfzhN65CfFZ1Qy+Yc4U5jqUL1mRR4OoWBwXzjD6 GT0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765408885; x=1766013685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=L08jHXpXjen58cg14Adrr2f98WJp67FFgA9qD2YXBHU=; b=JWOFz9k//rjokzVwX5dtlDV4BJkaHeca+qYoKajBqVMSjp7ANT6h9NwGIk96qBLiHL USB4FOtsL5GSVm83wd0rwkNd4fBG8fJZFZqhwwDhkzN7KU9kbFRQhHUbBguSRrjSCskG IU9pBWEEAB5WUWvJWCeplB/K1rsiQATuEITy16NiJXjQIkCBAxzpPVfdUnSMpPk9DZUy DbeR95wGLssmZbJQoHIO+geW4Fy3nilnFmHmwOyeMW8UTrESIV1mf68O3pwii2H8wUD2 kwkGFOVnI5V+Q//g8r8uNpM1Gaoo7s/dEWHVAfCQGRzvEx0Qb0tb4HoCZnFR4LZbgETR /zBg== X-Forwarded-Encrypted: i=1; AJvYcCUCPxS9j9jHmUER4GwpO9Rp+152IKjNWK4H7J7dPZvEvQo4X+R7Cb5OCMd3SzmdPn6JGtSTj61IRNsIrs4=@vger.kernel.org X-Gm-Message-State: AOJu0YyuhBAut64jCDOZOVB1fyE22bteRnN2cU5ZtQoa9CqlCnduy4z6 EAeohNCDp1XjMx/JzvtAjP5+WpEUL3D2VECHNrHTqaplsjls85e1YcyR X-Gm-Gg: ASbGncuw1eMmNYzfV9TKYkcIbV4nqgjcI+OxGXwHsZ1ZAKLxB9W33WUVztaDDxNv9kY aqdceHHXghAUrt4Cy+/lXqXHjQjeXUg9/7eYJhzke+OmnNs1HBI8omD5O0NCaeDvpsbnJxxUL3u 65aTjFdyFPRBA/1m9hl0RSuVjuFV6y8A9YeiZuYS8m4LvImrt7Zw2O3uvBfBTL+ORtHsz/Wqwc/ ys23wwIY6AzjRDl/wsOSy4BiQarRyfF615DfQxoguJdh04G/OMFQj4kaF8U9JecWmvM3iFwkMuv AZjZW0inyY4U4Y1aI3tjWd+T5UxJKlbz8Spe+KktGg/KkRM7JOU9HgcO4kC/HCHQ6iPYQgmFzit VMV2YJ0U4N5dalJ74JdrME/cGHVP1h9DQeRQ7Pne2vLgQ79DCi/kS5ouGTokmoOAMJTRlRbelyV PwRSEEqm3WjRi7SoZuYqm4kFL3nCCGtjRUyQ== X-Google-Smtp-Source: AGHT+IGHScSlL9cu47vMGSsn/jos8nO6lMKdreWx01YeiMB6yIIL90yCPe3N5A1FoFFavDktLuDS7g== X-Received: by 2002:a05:600c:1c93:b0:471:d2f:7987 with SMTP id 5b1f17b1804b1-47a837b9a4cmr42271815e9.26.1765408885028; Wed, 10 Dec 2025 15:21:25 -0800 (PST) Received: from dev-linux.homserver.local ([51.154.248.28]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a89f742a4sm654425e9.10.2025.12.10.15.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 15:21:24 -0800 (PST) From: Vaibhav Gupta To: Sven Peter , Janne Grunau , Marcel Holtmann , Luiz Augusto von Dentz , Neal Gompa Cc: Vaibhav Gupta , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] Bluetooth: hci_bcm4377: Use generic power management Date: Wed, 10 Dec 2025 23:21:09 +0000 Message-ID: <20251210232115.547729-1-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251210211728.544677-1-vaibhavgupta40@gmail.com> References: <20251210211728.544677-1-vaibhavgupta40@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Switch to the generic PCI power management framework and remove legacy callbacks like .suspend() and .resume(). With the generic framework, the standard PCI related work like: - pci_save/restore_state() - pci_enable/disable_device() - pci_set_power_state() is handled by the PCI core and this driver should implement only hci_bcm4377 specific operations in its respective callback functions. Signed-off-by: Vaibhav Gupta --- v2: v1 has a typo in its subject. This patch is not part of a series. So there should be no '[.... 1/2]'. --- drivers/bluetooth/hci_bcm4377.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/bluetooth/hci_bcm4377.c b/drivers/bluetooth/hci_bcm437= 7.c index 45e6d84224ee..925d0a635945 100644 --- a/drivers/bluetooth/hci_bcm4377.c +++ b/drivers/bluetooth/hci_bcm4377.c @@ -2416,8 +2416,9 @@ static int bcm4377_probe(struct pci_dev *pdev, const = struct pci_device_id *id) hdev); } =20 -static int bcm4377_suspend(struct pci_dev *pdev, pm_message_t state) +static int bcm4377_suspend(struct device *dev) { + struct pci_dev *pdev =3D to_pci_dev(dev); struct bcm4377_data *bcm4377 =3D pci_get_drvdata(pdev); int ret; =20 @@ -2431,8 +2432,9 @@ static int bcm4377_suspend(struct pci_dev *pdev, pm_m= essage_t state) return 0; } =20 -static int bcm4377_resume(struct pci_dev *pdev) +static int bcm4377_resume(struct device *dev) { + struct pci_dev *pdev =3D to_pci_dev(dev); struct bcm4377_data *bcm4377 =3D pci_get_drvdata(pdev); =20 iowrite32(BCM4377_BAR0_SLEEP_CONTROL_UNQUIESCE, @@ -2441,6 +2443,8 @@ static int bcm4377_resume(struct pci_dev *pdev) return hci_resume_dev(bcm4377->hdev); } =20 +static DEFINE_SIMPLE_DEV_PM_OPS(bcm4377_ops, bcm4377_suspend, bcm4377_resu= me); + static const struct dmi_system_id bcm4377_dmi_board_table[] =3D { { .matches =3D { @@ -2541,8 +2545,7 @@ static struct pci_driver bcm4377_pci_driver =3D { .name =3D "hci_bcm4377", .id_table =3D bcm4377_devid_table, .probe =3D bcm4377_probe, - .suspend =3D bcm4377_suspend, - .resume =3D bcm4377_resume, + .driver.pm =3D &bcm4377_ops, }; module_pci_driver(bcm4377_pci_driver); =20 --=20 2.51.0