From nobody Sun Dec 14 06:36:57 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE96276050 for ; Wed, 10 Dec 2025 13:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765373297; cv=none; b=R8mkh3rPf+60vizj1J9VeViR9a6W9v+omVJmOVVkzOa++nIt3OgNdeT1QGLSan1SCiMp2byZDiTTiDWl1GhRHRO+LvFOQGsLz4T5OMu2YYnGk2qipTIc7aN6W+qxPwUk3mM+eacRCkUUfj39eJqtYDChV4QDjq/dfMm2rHcK5lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765373297; c=relaxed/simple; bh=0y96Rg/Sc/DZKTjXrB2SLvbAEQwO5jU1Mj9ZyK0f/uQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m3TXW9h+O7nmsLsv0bvlRNcwLZlGn5QEHnKdcrfuhGK8VADTm/Yd5an4W3JjHNj2m38mn8B0I6JbskRhoTeBf04UoqnIzxp3RkyMOZHGdNt32nl3f5OduAoLDte+W2Ei7bAJbhY6uKS74Ygr5eRtHo4Wrw1YSiJF9e9lNtSKIlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m/0VNokm; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m/0VNokm" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7bb710d1d1dso10687951b3a.1 for ; Wed, 10 Dec 2025 05:28:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765373295; x=1765978095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a0EoHRAJjLBPvzSiHbkVQuwxwrsFggD1yN2TuQx/kfs=; b=m/0VNokmyc7yF00ImCp0qEuOLjjAXB+9E/yDJP2413iN5aquFAvWL+geNEcn45A5vH P8OMpgIF2jHwMaqPEsFbysnMlnRSodC2qZyW9sCsakk2k+9vMp0HR2ki2vihjMAtFPLp Fd5BgXiDrl3rtO40hY6JnpKSqDflJxZDi42/CbCRP0dHezhBdOIhLeojrX2seHYd5Zkp ekFbtIrIOETvMJbQLUClgWYoIu1yyzf6RbbYpB2oxbwJeHgebdCO5Ss+Hqk2n9QqLSzx NAZKj9QU70yrZTXS+a3PzpO/kpVN72BbNSf8ACgGLnp7mDIsfUlGaRA0TGBelz8Eg8wI VyyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765373295; x=1765978095; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a0EoHRAJjLBPvzSiHbkVQuwxwrsFggD1yN2TuQx/kfs=; b=dZvpNSU9GKOxjVaAXOhO9Exj/ydmTALAtfIZ2fHRUPBBlsqAJQ6mNQwXroKdbILPf0 CI9V4bb/cF3zygNTD4Q1WUlAX2hBeoxqzzhxylRvG8H6fzXp0QJiBqoWIYSB6UlhOIwD vXoA7tSTrRrh7CTWUfiuV+vM68QGiLKNvI0o7QjmjFenRqpGONzq1W2mV/oJ98a5nxKT ftfVEOOip5n6lSvay3c9Q2tSrmRidCko2f8TAIQDpCmjTS6uM0wMU5jayS/aAlmtdACH oN+DBEtb3hEIPdJn1Zi8bzJ0PkH/cTYmakLDNSebEvdqOi24Aum2BEjF+e0NYnl4TQxN wnTA== X-Forwarded-Encrypted: i=1; AJvYcCVuB50Vo1foBYnvK8SYdrlI8zwW1WDIzvbJ71x1V9Cm2LNim7zcgP8n9JuPZXcD90CoUBF5le5wqra5qN0=@vger.kernel.org X-Gm-Message-State: AOJu0YxM6upKL1+efExuBBcKIhppQOH+wmGw9evJdf0hJVtHkYFpK1rN WbG/1jvRBIptzsgfaIGkKb2BibcgKc2DLzAh91+RbtoadJxwWVZKPbyK X-Gm-Gg: ASbGnctBfpY/eXl7GwGzydtQHM+PDwMSN2889jLQ+sHmvPvd1N5UoHxfVw/6G+qK2md D8v0LeLT8qUuiQtR9+VlgxyLPyLyigNwUvrfYvnqpNc4Nmy7omcF440X35pb0R5ncMNFT54DKyA n+QBUNmMstPd8dip+h1ejBxdwFwqzdiMeky2FlTtm0cz8ZHiHIiC4oO6ASqq0OEoRYqBbkKaEM3 R5cEHlEYqjot84RN3ScBsm0uQqqTp0bpWnYepjXubV67nNI15mzbxnw+X7RAnMUyr83l9WtMs7U 2bXTNpOZdoMIAOzGveqTNPe722Rd9vMDa4WKzZZbRHLD/m1CylRMI5zv6vwgJC02vbvVl9BZ9cK 6NVYJI1nxmoTLUc74JlraRkceWBbpGXN3aAPPe7/FzM9xUoK4jmld2EH6iJZb2vZlRWisfqQIVn tAinvPThcfRG09bFVRrbjtC04CPguS85iHKmdK3xwK8wTHTrLS1Uy9xPu8xZ3MfQdsSVw= X-Google-Smtp-Source: AGHT+IH3DAL63v5RtYmyafCCdGI7zA1aGFzW2ktPKp/miOeQXmJX/6zfEPMPaSCoKE/7giEgdyRpzg== X-Received: by 2002:a05:6a20:7f91:b0:364:144a:d21c with SMTP id adf61e73a8af0-366e0ef01f9mr2401134637.26.1765373295222; Wed, 10 Dec 2025 05:28:15 -0800 (PST) Received: from deepanshu-kernel-hacker.. ([2405:201:682f:389d:ff8a:290f:c19a:6d03]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf748c6bcacsm17435261a12.0.2025.12.10.05.28.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 05:28:14 -0800 (PST) From: Deepanshu Kartikey To: clm@fb.com, dsterba@suse.com, miaox@cn.fujitsu.com Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Deepanshu Kartikey , syzbot+eadd98df8bceb15d7fed@syzkaller.appspotmail.com Subject: [PATCH] btrfs: fix memory leak of fs_devices in degraded seed device path Date: Wed, 10 Dec 2025 18:58:07 +0530 Message-ID: <20251210132807.3263207-1-kartikey406@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In open_seed_devices(), when find_fsid() fails and we're in DEGRADED mode, a new fs_devices is allocated via alloc_fs_devices() but is never added to the seed_list before returning. This contrasts with the normal path where fs_devices is properly added via list_add(). If any error occurs later in read_one_dev() or btrfs_read_chunk_tree(), the cleanup code iterates seed_list to free seed devices, but this orphaned fs_devices is never found and never freed, causing a memory leak. Any devices allocated via add_missing_dev() and attached to this fs_devices are also leaked. Fix this by adding the newly allocated fs_devices to seed_list in the degraded path, consistent with the normal path. Fixes: 5f37583569442 ("Btrfs: move the missing device to its own fs device = list") Reported-by: syzbot+eadd98df8bceb15d7fed@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=3Deadd98df8bceb15d7fed Tested-by: syzbot+eadd98df8bceb15d7fed@syzkaller.appspotmail.com Signed-off-by: Deepanshu Kartikey Reviewed-by: David Sterba Reviewed-by: Qu Wenruo --- fs/btrfs/volumes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index ae1742a35e76..13c514684cfb 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -7128,6 +7128,7 @@ static struct btrfs_fs_devices *open_seed_devices(str= uct btrfs_fs_info *fs_info, =20 fs_devices->seeding =3D true; fs_devices->opened =3D 1; + list_add(&fs_devices->seed_list, &fs_info->fs_devices->seed_list); return fs_devices; } =20 --=20 2.43.0