From nobody Sun Dec 14 06:40:53 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5180D308F0A for ; Wed, 10 Dec 2025 10:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765360882; cv=none; b=JcyMv54BxCVpcIYz82pNRXnYRYp8QmqKYIx/0olgDD7kFtzejZPkfBbFyczpGlWLieNuWF1Qwz+Gno00tqMhgg5PP6F83UPJo6QhuKORriwH5bQUwkzpLrj4N151IO0CQBcYMrEoGFt95p5dbnpEwp3izN5Va5nUfthHLB6u6SM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765360882; c=relaxed/simple; bh=UjEnzoPrmTkPkVAe6WxOo+pApZ3/c0EoApU/AryGhMs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TOyAgXfkRCU48kQI8FQ8z5iAsRzEk3F7btsx9N9fdgYGhuMycoSeMrQeCiVqIGiU018s6qM4mhVX06XkRKeZXexqqfe3ne09MTzoVWE5WJ8hHzJda5jTZvM/1OTWCLeP0J9wi5k/2hl40qAfddJyLPC4KJQlyzkixU51Pg6ZD9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AjHd9Ipb; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AjHd9Ipb" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-297dd95ffe4so62061965ad.3 for ; Wed, 10 Dec 2025 02:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765360880; x=1765965680; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=a/fshd7X7uki2whPgbyHXdLwERbC2fRt/X2iMSKqiUc=; b=AjHd9Ipb7L3co1xNS3Z8yvHZbbS8AR2RWrQ5I0N3SIwEuw1fdB3kcyUrImLbBo9f+g Pn2nz16jYeO5rZDfqAqinA4O5kQAM7fToI+aYzcvW4u90YkZYNac9zNjDWt/fr4ooQEk Etw/AUzgrbklOvM1P9/npYo6r+772TZyXARvNg2imh0KMmMTVko/hDqN6cwN87XncopS KUa18nfx3c99uKiET8/tL63B4XzscH4es5K3ntNyfvc9MskMLGVNfcQPma9yV6Gd0VIC tUMTLy6HjYfDGXIb7GJboSvwlQsn1wk1qY/Zx+SFvyeGpKUJGQd4Mg1h7hUWcAl2KeKX RivQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765360880; x=1765965680; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a/fshd7X7uki2whPgbyHXdLwERbC2fRt/X2iMSKqiUc=; b=ueCqeBjDTBDqoJdxkextUowJXW5z5Zhm8q2KCiNTuQQ9SNr+ZgMIQd/ZdbEf+L6WfF AaCrZRXQO+OCbbFl/GVsWY24kraWGTo6j5xx0fNu2QA0MoCk64IXp4y1YMUOmV9vUCu3 6PaK3xIT+XH5WqCF/Yxxcf7QxTVh2Ii9K2Lg4vlZQGTxqsscodWfYQG9txkv8fzpH1qD GuQ6ILp3gX9RPu3qo++NpMG9Q7vl4GLOrWM6R6GMb8bA7dl7HVN+3cbKqy6fMiGLxBn9 cvDDXdAQ6qZU6fiF3o0cFwfww7SbJRuKxHfvg6XoOKkssUyO9NK11iZQbe94ynGUPclc lw9w== X-Forwarded-Encrypted: i=1; AJvYcCUTWt9+L5DzdC3rHZhm/biLBCcZCkYtKbwyfjqIvm5pZV8OqAKYgDN4MiazyigOKdxZIHNj8QugjvTsNQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YxW94yQFR28lRIm6jsdOrjqLzdzhTuLnyk7vsRm38dcNKZytYrx A/cNSLI47SdXe9PyWgwetESjRReL9LdauLunKCwsm2aYTt+e1NTa90PQ X-Gm-Gg: AY/fxX59Np3eXB3c7ALU5xEPlLgg9dBELpnYKM9DmJrl8r7tG+YNyK2ILIL4CNvG1IU OOKsF+446a93V/RTwSqQAIsmerlQxQAAPceUPm0KsH+209mZ7Hq6+uDHc3faN+guJL2K6fxtNog W8E6urB/XX79UIDZ8I1LI3/nHyvl3Lwy7tALfW7S/r2XeFuIV7WcxnXGSbFdOBSkhGx/Cmzi3uO 15M37Uc/a8YGRtNipi+gB7UAE2PZz3sNrb4X/965b7Lrm4CTDpUDr86d4tTnj62WK/FUb4vWkjR BuzgHN9hXWbFhJ6Q228zMJwZcV+OyZDxN+nUUvOr77C2z5kVP3O4SEU2sBPLYeYltiM2kqZImMl 6joYdiU5Yepi8zjPx7PgskftD/25sTH0YjPZw4ZMHXBlg7yxxwX9cCMxOVEZ59qhzd5u/hWdKTZ zkshuEDbAeaKfDbYTcWhLdJTpTgMJpcrAI X-Google-Smtp-Source: AGHT+IGlAFwVNmFR4OozRE7y9JbL6Erh1jOVM6v6qblipw+WFGHORbKbKPwSEc6Q9/boHVvKIxyfXA== X-Received: by 2002:a17:902:d588:b0:269:82a5:f9e9 with SMTP id d9443c01a7336-29ec26b9c3emr20869245ad.29.1765360880446; Wed, 10 Dec 2025 02:01:20 -0800 (PST) Received: from localhost.localdomain ([38.134.139.135]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29dae49ca50sm177163105ad.20.2025.12.10.02.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Dec 2025 02:01:20 -0800 (PST) From: Dharanitharan R To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, dharanitharan725@gmail.com, david.laight.linux@gmail.com Subject: [PATCH v3] staging: vme_user: simplify bus number allocation using ffz() Date: Wed, 10 Dec 2025 10:00:24 +0000 Message-ID: <20251210100023.33753-2-dharanitharan725@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" David Laight pointed out that the loop in vme_register_bridge() is effectively searching for the first zero bit in vme_bus_numbers. Add a check for vme_bus_numbers =3D=3D ~0UL before calling ffz(). Replace the manual loop with ffz() and use BIT(n) for consistency. Suggested-by: David Laight Signed-off-by: Dharanitharan R --- drivers/staging/vme_user/vme.c | 15 +++++++++++++---------- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme_user/vme.c b/drivers/staging/vme_user/vme.c index 2095de72596a..45381e677475 100644 --- a/drivers/staging/vme_user/vme.c +++ b/drivers/staging/vme_user/vme.c @@ -1765,16 +1765,19 @@ int vme_register_bridge(struct vme_bridge *bridge) int ret =3D -1; mutex_lock(&vme_buses_lock); - for (i =3D 0; i < sizeof(vme_bus_numbers) * 8; i++){ - if ((vme_bus_numbers & (1 << i)) =3D=3D 0) { - vme_bus_numbers |=3D (1 << i); - bridge->num =3D i; - INIT_LIST_HEAD(&bridge->devices); - list_add_tail(&bridge->bus_list, &vme_bus_list); - ret =3D 0; - break; - } + /* Ensure we have a free slot before using ffz() */ + if (vme_bus_numbers =3D=3D ~0UL) + goto out; /* No free bus number */ + + /* Find the first clear bit */ + i =3D ffz(vme_bus_numbers); + + vme_bus_numbers |=3D BIT(i); + bridge->num =3D i; + INIT_LIST_HEAD(&bridge->devices); + list_add_tail(&bridge->bus_list, &vme_bus_list); + ret =3D 0; + +out: mutex_unlock(&vme_buses_lock);=20 return ret; @@ -1787,7 +1790,7 @@ void vme_unregister_bridge(struct vme_bridge *bridge) struct vme_dev *tmp; =20 mutex_lock(&vme_buses_lock); - vme_bus_numbers &=3D ~(1 << bridge->num); + vme_bus_numbers &=3D ~BIT(bridge->num); list_for_each_entry_safe(vdev, tmp, &bridge->devices, bridge_list) { list_del(&vdev->drv_list); list_del(&vdev->bridge_list); --=20 2.43.0