From nobody Sun Feb 8 13:43:35 2026 Received: from cstnet.cn (smtp81.cstnet.cn [159.226.251.81]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8381C1EBFF7 for ; Wed, 10 Dec 2025 03:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.81 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765337953; cv=none; b=N8oGDuoQRmkmjqJQeSsgnlmuk4Ce4i7SE9oAwsXPf8gsUiDerGkJUTa4/JiObCS8O3Yc9oUM5J4gGL+PdEdgG9rDcMLBgf0sHTmafa42ts//hl+Za/O9EZxS4dDN3WihL1DtG93VzzE75KCm4WTHn7sWfR7Sg4V4r2MIqS0nx8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765337953; c=relaxed/simple; bh=nPGIeCyDjBrZWAlQUbDskcvJnCESIxtHgTwVRYSs9/k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hBMGsfjYBmmQsZehZjlE1dN8/l5D0nLUvx2Au0EA6ak0VCPWcCjYw6WeNY7d/IS4muoRW7ioIQTEZOTt00LGv/ZDdFlNwo3kEqjR9Wr2mzADVe6Kd2m8eYA+8bvtbEO9NJYhZctnyg16hV7wrAxTPK790P5Q6KO6N9XnrOxN3Xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from DESKTOP-L0HPE2S (unknown [124.16.141.245]) by APP-03 (Coremail) with SMTP id rQCowAAnRNtY6zhpZmMsAA--.9770S2; Wed, 10 Dec 2025 11:39:06 +0800 (CST) From: Haotian Zhang To: srini@kernel.org Cc: linkmauve@linkmauve.fr, linux-kernel@vger.kernel.org, Haotian Zhang Subject: [PATCH] nvmem: nintendo-otp: Fix potential NULL pointer dereference in nintendo_otp_probe() Date: Wed, 10 Dec 2025 11:38:03 +0800 Message-ID: <20251210033803.1720-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: rQCowAAnRNtY6zhpZmMsAA--.9770S2 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr4rZw1rXw4Utr45AF13urg_yoWfAwc_Cr W8Xrn7ur10k3Wvyrnakw4xZ3sFya1Ygr1v9a1Sqw4fZrWUGFs8Zr9YvwnxXw129FWrAasF vw1UXrWa9rWYkjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbwkFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v26rxl6s 0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxAIw28IcxkI7VAKI48J MxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwV AFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6xIIjxv2 0xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4 v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AK xVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbrMaUUUUUU== X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiDAYMA2k4uBrTEwAAs2 Content-Type: text/plain; charset="utf-8" of_match_device() may return NULL if no match is found. Dereferencing the return value of_id in nintendo_otp_probe() without a check could lead to a NULL pointer dereference. Add a check for of_id and return -ENODEV upon failure. Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and W= ii U OTP") Signed-off-by: Haotian Zhang Reviewed-by: Link Mauve --- drivers/nvmem/nintendo-otp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvmem/nintendo-otp.c b/drivers/nvmem/nintendo-otp.c index 355e7f1fc6d5..89b15a58bf88 100644 --- a/drivers/nvmem/nintendo-otp.c +++ b/drivers/nvmem/nintendo-otp.c @@ -87,6 +87,9 @@ static int nintendo_otp_probe(struct platform_device *pde= v) .root_only =3D true, }; =20 + if (!of_id) + return -ENODEV; + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; --=20 2.50.1.windows.1