From nobody Sun Dec 14 06:39:54 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2CC62F261F for ; Wed, 10 Dec 2025 03:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765336842; cv=none; b=DZWLfOkdC+0AtxAc7CZAvhDdjryGevUAjDZW6G5vMDrcghwA0rRmEddG0HpWs+jiswZrsaoHQqXXl6MKzBsmwpcjhAQA+ITkmb5jKVmOiZlHXSp2gNUAdfAk+IvrUmveWq+xmeG/Uc86fOFtOxfIH99vnwHjGZHGtowdlysxpJE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765336842; c=relaxed/simple; bh=ZhvJoJg28WY8WddGDgYpoOtsuRlwXLVvWpwlSL6k1pQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=IfZvKl7ietYZXag7jNLKw6c5foyFYx4gYxfDbh8HIB9buMX1QlYHpWhL7Ej8WB1uz+ZODDZlGt3DM+Z7yhA0+c0+1iM8Jn+/cHdCyhQqaQRkG7FCiz4s7ZIWrA+9U//WLbsXIRaEfI+fdsOoNf0TuxuHdfRULfYYm2nsNf1+2/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T9sXRcJl; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T9sXRcJl" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-29845b06dd2so85662795ad.2 for ; Tue, 09 Dec 2025 19:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765336834; x=1765941634; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vbN+EuPmocUOeBG82RSMhzZ2IRHbxuavHhm0ZQadrtM=; b=T9sXRcJl/S7GrTHmiXfaRS4/OWJNrXwvkQZZJWEWwrsW1Zyw7NClhym0Y8hvu7bZej yYO0EmKteKyFC7vLGeZegPNoz0z3mlboYeienDj2OXE32dFGJB8q3ro25H1bs5MH7owA Jtxh1AIQtfHA59QcOb4FarILHMOw/OOURZLQIoBACZMkB3xmWfKkqSPT/uuIqtSZXU3o iqVGhCoTl2LaM7TvAJzn6a+9o2Kmxp6+120LUhdILrJqyg9lXUIYKN0b5hcvcptefy5K 375Vw9GERejiuqtK/Zj2zbHmaLx/AJB3eXIyL/tyDq5f1PyYtiHpNlPRATv/zidaEKCd HTMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765336834; x=1765941634; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vbN+EuPmocUOeBG82RSMhzZ2IRHbxuavHhm0ZQadrtM=; b=VdcP0PrEYNJTyHiHcKhZRTFFxZexUFn4Jx5nc2wz8zl5Zk40/9iebXnzkswaJDopYQ hXewzS0KDU0klzgR3oeSacOUJBXkY4zAcRT5PnlznbQIITRyFOy6PfPZT/a9Uh19c/z1 9d5Z0Sco1er6yCATOMDkpMBvqFBd4yRiCnUwmXyw/ymCU7eKjrBp78YUiWi1zFHXZWRi YQp3PYIJaDQJSAZ1qs4FOxuG2vbwxkvYvfWh/2Cb+owbHG5JY5kZxCwBmgp4OsbYtTm5 PRKH2QZEugVYmicbwqdivsqCj8A+wDVphOKiZQZytnnGfs41KgVO/PY3KRcToEb0YUW/ sz2A== X-Forwarded-Encrypted: i=1; AJvYcCXyovns2chy5O1YPmVjLFYpLExNOo28gYzLLuyAnfNwh2Im/vx3V+QFE1xnnz3a/80MuWI3ry1KwJ+uyLQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwSKhwjZkFaF++hjEbTzazM3U0hHPDV0WgBJdM4JfcLKnnqo5FK w6O6tX+CGuKJFXrLm0kKRmM3DBCXY4oaEOPTadtxLwX4Vnj7XdoIGK/a X-Gm-Gg: AY/fxX4BqH45OAj139WKU+RrZgYy2zgXZbC8j+B4MNSyWN1bWMkUiUDHhrNXPWdJVmZ 0aEU16ie3bVcbBCAyxrS5mFhytKs6qgbiZhmBc/efd6mpPhwewOZP3pAnvOQbDqdTeYN18DRAzw ZA6F3V1Z/DLZWErpbUR6qrCTHNUQfa24pzBJvlMtktGy1JwVLiB8DdX1pU5O6qVqWzUKHsa17uk jjFfm6S9GYko+tQfSe/u8hpgSdXCpNZ6vF2duWQIG5WYVsgy1uTdSmi1XyAHY2gbaZgjBh78Q+s +ImwG7/m1nzRi1zW1Bgaxxolwfn/D6FORdTajkvD287bvP75/phuHZ+d+D0/T9n0EnAi0IlBIGT CkGxeef4e936P9uSD6trUZ32C8oO6mQ9QgMXDIXYoCH/ni1u6/Ncz59m3DT4xaq1mj8lG1lRuwZ 2phukQV/HEY8KKPCo2npmc5MTF8q0axg== X-Google-Smtp-Source: AGHT+IEMtGD+A/RMPic2C2F5xkyR72IvoSEeanxQ+MeKzBVevm0+/eQmMUxld8jyk73UQBIfukkjdg== X-Received: by 2002:a17:902:fc86:b0:297:f09a:51cd with SMTP id d9443c01a7336-29ec22cac38mr11779605ad.14.1765336834147; Tue, 09 Dec 2025 19:20:34 -0800 (PST) Received: from localhost.localdomain ([121.190.139.95]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29daeae6ad1sm169717995ad.90.2025.12.09.19.20.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 09 Dec 2025 19:20:33 -0800 (PST) From: Minseong Kim To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Minseong Kim Subject: [PATCH] input: synaptics_i2c - cancel delayed work before freeing device Date: Wed, 10 Dec 2025 12:20:27 +0900 Message-Id: <20251210032027.11700-1-ii4gsp@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" synaptics_i2c_irq() schedules touch->dwork via mod_delayed_work(). The delayed work performs I2C transactions and may still be running (or get queued) when the device is removed. synaptics_i2c_remove() currently frees 'touch' without canceling touch->dwork. If removal happens while the work is pending/running, the work handler may dereference freed memory, leading to a potential use-after-free. Cancel the delayed work synchronously before unregistering/freeing the device. Fixes: eef3e4cab72e Input: add driver for Synaptics I2C touchpad Reported-by: Minseong Kim Cc: stable@vger.kernel.org Signed-off-by: Minseong Kim --- drivers/input/mouse/synaptics_i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/mouse/synaptics_i2c.c b/drivers/input/mouse/syna= ptics_i2c.c index a0d707e47d93..fe30bf9aea3a 100644 --- a/drivers/input/mouse/synaptics_i2c.c +++ b/drivers/input/mouse/synaptics_i2c.c @@ -593,6 +593,8 @@ static void synaptics_i2c_remove(struct i2c_client *cli= ent) if (!polling_req) free_irq(client->irq, touch); =20 + cancel_delayed_work_sync(&touch->dwork); + input_unregister_device(touch->input); kfree(touch); } --=20 2.39.5