From nobody Sun Dec 14 06:37:00 2025 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4C738C1F; Wed, 10 Dec 2025 03:02:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765335746; cv=none; b=JKdGGi1oq+sUdB4ymOII88wGIr4JaC+qUWtzT16tLbDKWYv2Gzfy+PfWsmHeDXRFcc2BzjFSv9T20wbAwLM2xQhHNKbZtbHQ2aNeU23TZOq2ducBSrRO9aWT3msRWTE2hln8FgtaMM5LXEY6iLHSgWCWgVfEvn523HwWSkLgSEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765335746; c=relaxed/simple; bh=PXI14LuevfjEPjIh7vA5pnRrNv6cMn+s2Mka2Oi8Eqk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=B6UB37HUxzIXCHqihP1K0LQipBUqOCJUvpb47PiVHa7QDxh4tYwKqDxOnVugqMV87HiMzkwbyPPj6Ar81fMQK/75RdWk2r7fjHurkOSpOxKapSYXaRV4t54ebyE+7olArdM1ennLPXCqnG9BDBlLmPU5PNSyVB5QPOOJiXtwyRc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.239]) by APP-01 (Coremail) with SMTP id qwCowABXAGy64jhpXmgoAA--.1172S2; Wed, 10 Dec 2025 11:02:19 +0800 (CST) From: Haoxiang Li To: mchehab@kernel.org, lihaoxiang@isrc.iscas.ac.cn, hans.verkuil@cisco.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] media: cx23885: Add missing unmap in snd_cx23885_hw_params() Date: Wed, 10 Dec 2025 11:02:17 +0800 Message-Id: <20251210030217.53955-1-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: qwCowABXAGy64jhpXmgoAA--.1172S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtFyrKw4DCFykuw4UWF4rKrg_yoWDKrc_KF 9rZr98urWUCr1ayw4UtF1Iv348J3yDuF4kuFyxtFZIyr1rAFs09FZ0qr1rGr1kZrZxurZ5 C34UJF1kJrZ7XjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb48FF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6r1F6r1fM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr0_Gr 1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xII jxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr 1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkF7I0En4kS14v26r12 6r1DMxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI 0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y 0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxV W8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1l IxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7VUbhvttUUUU U== X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiBgwME2k4t7eyrgAAsY Content-Type: text/plain; charset="utf-8" In error path, add cx23885_alsa_dma_unmap() to release the resource acquired by cx23885_alsa_dma_map(). Fixes: 9529a4b0cf49 ("[media] cx23885: drop videobuf abuse in cx23885-alsa") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li --- drivers/media/pci/cx23885/cx23885-alsa.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/cx23885-alsa.c b/drivers/media/pci/c= x23885/cx23885-alsa.c index 25dc8d4dc5b7..717fc6c9ef21 100644 --- a/drivers/media/pci/cx23885/cx23885-alsa.c +++ b/drivers/media/pci/cx23885/cx23885-alsa.c @@ -392,8 +392,10 @@ static int snd_cx23885_hw_params(struct snd_pcm_substr= eam *substream, =20 ret =3D cx23885_risc_databuffer(chip->pci, &buf->risc, buf->sglist, chip->period_size, chip->num_periods, 1); - if (ret < 0) + if (ret < 0) { + cx23885_alsa_dma_unmap(chip); goto error; + } =20 /* Loop back to start of program */ buf->risc.jmp[0] =3D cpu_to_le32(RISC_JUMP|RISC_IRQ1|RISC_CNT_INC); --=20 2.25.1