From nobody Thu Dec 18 08:39:00 2025 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96F702EC0A7 for ; Tue, 9 Dec 2025 22:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765320034; cv=none; b=cF1X8f7O20r9tmb2p/n3kjGjvb8Mmm2uZBypmsEMV9ywJiAwXOookovThvRRY1MuXgT1+xpGIptrvaT9NJSdEIkplI4yR0rMYeeW6+d7r97lUB0vfWktE3Y8KLj/L9xwtGz5/es6VXa3KG6O1m71fljwHzUZDa0vqj+RgeINMJ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765320034; c=relaxed/simple; bh=tCh98JTKTb7XJKJ0j/3MlluR1scTujkw4X+uEScIUTo=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=gdABHD19FGTLYkZo6/F53QKtm8ecFUD/RVqU5XdPI7jypzJRaxWyzlhpAvaKWP39nuKS7XDksMACMOKZ6k9J99jBK4sXGoWIzcVMqrVfSVNKFALkaLYHbM0EwdN8J2SAvrHWvCVzZZVBCn7pcFpKDpYdrp1RyG316K7Eg/i9yxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=1B49VFT9; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="1B49VFT9" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-297f8a2ba9eso126190555ad.3 for ; Tue, 09 Dec 2025 14:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1765320032; x=1765924832; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=r7O48LXkjdqgnjge+x6j1USdfdM5LKXe6u1Y0sEV654=; b=1B49VFT9YA0AGxHZnccpZnNzt9Ynt/QYCqxYivRftjsVygbyd0LvKMA50aFfmH+aip pAtJUADx9O2JCTJu7iVBM9Mj80V/wDKBfDXoILapfo2l09GG+8uyb+svfhwcxyxrk+ZL FSe2ZWk7I5XaJxOAymVv7wD0L+W7rKZMlsBbKYodotlNdIwKvNgY910TKwtjc4rkhcll jY/8e9KU6Ugwq2NggMsCAMixFyp+9EjgVQNkUz5OhlCn22z12fsk+AZWsjyhgUOJphQn evUHriOn4ln9V3u6PlnnGlJDPlEqePtW/H8moF2Jx8b8COiB6vxaJxUfdIWdNltLVW9S yN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765320032; x=1765924832; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=r7O48LXkjdqgnjge+x6j1USdfdM5LKXe6u1Y0sEV654=; b=cny2wIWWJTA+MjFMy1bnaY9c9wwIWxS4Tt4cZGSyTW6TTPPV+cpAayKo/uaaYKpl7k ADwKwbR+YskHmmnO833gO9XZq8+7dmBzVW7Us+QYsYsYZBbnol5BxgVnY/tE7k+eLyuK XjNYUff4WPMZ4doCrDIID96e0rFN1+iabkxonT4REKxeZomAaOAs+traUbJsR1XrOIjd mzaT88qyi3Z92d/dNRWT5+Td899sbvOZJF5OA+qBjk4l2zMZD9hrqutBECZAnwXtpEDj vmsQ3CYvNuR1gxYG/p4WwXdSMG11Mbs0UoG9DsTte+RPINS0jM1vicmm+WnvSqzCW0gY 3Tcw== X-Forwarded-Encrypted: i=1; AJvYcCV0TeEMH9OHo4SHTyEkd0jH97aalxdBv/fuq9V/jAW+0nf6Gi6yZlNx60oySYXsQ/YW40B9qndsc4Va+Wg=@vger.kernel.org X-Gm-Message-State: AOJu0YxDnhELHI0222kVbu86ZMa65o60HyXmkjoQAuoV2lK5u62A8luD pFS8Psa+66LUmV8ScNWqM9xJR3/p49CV/ujR4Iz+5AIkllDwVdXQGD3ggObv5loCavsoIqBbZkd gSzLafIkBug== X-Google-Smtp-Source: AGHT+IFj4rqsfnPj3U/wPD6U+SDvCHeJsw7sYeBk6s+QvKgbGyD2On2jOkfICHVlusYJjqYFg+wML/xfAOAV X-Received: from dlbbk22.prod.google.com ([2002:a05:7022:4296:b0:11b:9777:3bd6]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:b9c:b0:119:e569:fb9b with SMTP id a92af1059eb24-11f29655a78mr189095c88.10.1765320031766; Tue, 09 Dec 2025 14:40:31 -0800 (PST) Date: Tue, 9 Dec 2025 14:40:24 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.223.gf5cc29aaa4-goog Message-ID: <20251209224024.2322124-1-irogers@google.com> Subject: [PATCH v1] tracing: Avoid possible signed 64-bit truncation From: Ian Rogers To: Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Ian Rogers Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 64-bit truncation to 32-bit can result in the sign of the truncated value changing. The cmp_mod_entry is used in bsearch and so the truncation could result in an invalid search order. This would only happen were the addresses more than 2GB apart and so unlikely, but let's fix the potentially broken compare anyway. Signed-off-by: Ian Rogers --- kernel/trace/trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d1e527cf2aae..e6a80cbe9326 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -6057,8 +6057,10 @@ static int cmp_mod_entry(const void *key, const void= *pivot) =20 if (addr >=3D ent[0].mod_addr && addr < ent[1].mod_addr) return 0; + else if (addr > ent->mod_addr) + return 1; else - return addr - ent->mod_addr; + return -1; } =20 /** --=20 2.52.0.223.gf5cc29aaa4-goog